[PATCH] arm: device.h: Add dma_mask to pdev_archdata structure

[PATCH] arm: device.h: Add dma_mask to pdev_archdata structure

[Fabio Estevam]

Fix the following build error when doing a 'make mx3_defconfig'

CC [M]  drivers/usb/host/fsl-mph-dr-of.o
drivers/usb/host/fsl-mph-dr-of.c: In function 'fsl_usb2_device_register':
drivers/usb/host/fsl-mph-dr-of.c:97: error: 'struct pdev_archdata' has no member named 'dma_mask'
make[3]: *** [drivers/usb/host/fsl-mph-dr-of.o] Error 1
make[2]: *** [drivers/usb/host] Error 2
make[1]: *** [drivers/usb] Error 2
make: *** [drivers] Error 2

Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
 arch/arm/include/asm/device.h |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/arch/arm/include/asm/device.h b/arch/arm/include/asm/device.h
index 7aa3680..6ec60f6 100644
--- a/arch/arm/include/asm/device.h
+++ b/arch/arm/include/asm/device.h
@@ -21,6 +21,7 @@ struct pdev_archdata {
 #ifdef CONFIG_ARCH_OMAP
 	struct omap_device *od;
 #endif
+	u64 dma_mask;
 };
 
 #endif
-- 
1.7.1

[PATCH] arm: device.h: Add dma_mask to pdev_archdata structure

[Russell King - ARM Linux]

On Wed, Nov 16, 2011 at 01:46:18AM -0200, Fabio Estevam wrote:
> Fix the following build error when doing a 'make mx3_defconfig'
> 
> CC [M]  drivers/usb/host/fsl-mph-dr-of.o
> drivers/usb/host/fsl-mph-dr-of.c: In function 'fsl_usb2_device_register':
> drivers/usb/host/fsl-mph-dr-of.c:97: error: 'struct pdev_archdata' has no member named 'dma_mask'
> make[3]: *** [drivers/usb/host/fsl-mph-dr-of.o] Error 1
> make[2]: *** [drivers/usb/host] Error 2
> make[1]: *** [drivers/usb] Error 2
> make: *** [drivers] Error 2

Why is this required for just MX3?  Why should we take the hit of adding
this (needlessly) for the other sub-architectures?  Why is MX3 doing this
differently?

[PATCH] arm: device.h: Add dma_mask to pdev_archdata structure

[Uwe Kleine-König]

On Wed, Nov 16, 2011 at 08:29:26AM +0000, Russell King - ARM Linux wrote:
> On Wed, Nov 16, 2011 at 01:46:18AM -0200, Fabio Estevam wrote:
> > Fix the following build error when doing a 'make mx3_defconfig'
> > 
> > CC [M]  drivers/usb/host/fsl-mph-dr-of.o
> > drivers/usb/host/fsl-mph-dr-of.c: In function 'fsl_usb2_device_register':
> > drivers/usb/host/fsl-mph-dr-of.c:97: error: 'struct pdev_archdata' has no member named 'dma_mask'
> > make[3]: *** [drivers/usb/host/fsl-mph-dr-of.o] Error 1
> > make[2]: *** [drivers/usb/host] Error 2
> > make[1]: *** [drivers/usb] Error 2
> > make: *** [drivers] Error 2
> 
> Why is this required for just MX3?  Why should we take the hit of adding
> this (needlessly) for the other sub-architectures?  Why is MX3 doing this
> differently?
fsl-mph-dr-of.c is a driver that works on ARM and POWERPC. The latter
has dma_mask in pdev_archdata and fsl-mph-dr-of.c uses it to hold the
value pointed to by pdev->dev.dma_mask. AFAIK a driver should consider
pdev->dev.dma_mask readonly, shouldn't it?

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-K?nig            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

[PATCH] arm: device.h: Add dma_mask to pdev_archdata structure

[Rob Herring]

On 11/16/2011 02:29 AM, Russell King - ARM Linux wrote:
> On Wed, Nov 16, 2011 at 01:46:18AM -0200, Fabio Estevam wrote:
>> Fix the following build error when doing a 'make mx3_defconfig'
>>
>> CC [M]  drivers/usb/host/fsl-mph-dr-of.o
>> drivers/usb/host/fsl-mph-dr-of.c: In function 'fsl_usb2_device_register':
>> drivers/usb/host/fsl-mph-dr-of.c:97: error: 'struct pdev_archdata' has no member named 'dma_mask'
>> make[3]: *** [drivers/usb/host/fsl-mph-dr-of.o] Error 1
>> make[2]: *** [drivers/usb/host] Error 2
>> make[1]: *** [drivers/usb] Error 2
>> make: *** [drivers] Error 2
> 
> Why is this required for just MX3?  Why should we take the hit of adding
> this (needlessly) for the other sub-architectures?  Why is MX3 doing this
> differently?

This or some way to populate a dma_mask value is needed for devicetree
based probing.

That being said, fsl-mph-dr-of.c directly accessing struct pdev_archdata
is not right either.

Rob

[PATCH] arm: device.h: Add dma_mask to pdev_archdata structure

[Dirk Behme]

On 16.11.2011 04:46, Fabio Estevam wrote:
> Fix the following build error when doing a 'make mx3_defconfig'
>
> CC [M]  drivers/usb/host/fsl-mph-dr-of.o
> drivers/usb/host/fsl-mph-dr-of.c: In function 'fsl_usb2_device_register':
> drivers/usb/host/fsl-mph-dr-of.c:97: error: 'struct pdev_archdata' has no member named 'dma_mask'
> make[3]: *** [drivers/usb/host/fsl-mph-dr-of.o] Error 1
> make[2]: *** [drivers/usb/host] Error 2
> make[1]: *** [drivers/usb] Error 2
> make: *** [drivers] Error 2
>
> Signed-off-by: Fabio Estevam<fabio.estevam@freescale.com>
> ---
>   arch/arm/include/asm/device.h |    1 +
>   1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/include/asm/device.h b/arch/arm/include/asm/device.h
> index 7aa3680..6ec60f6 100644
> --- a/arch/arm/include/asm/device.h
> +++ b/arch/arm/include/asm/device.h
> @@ -21,6 +21,7 @@ struct pdev_archdata {
>   #ifdef CONFIG_ARCH_OMAP
>   	struct omap_device *od;
>   #endif
> +	u64 dma_mask;
>   };
>
>   #endif

Will there  be a v2 of this patch fixing the review comments?

It seems the number of people hit by the issue this patch deals with 
increases ...

Many thanks

Dirk

[PATCH] arm: device.h: Add dma_mask to pdev_archdata structure

[Russell King - ARM Linux]

On Tue, Dec 20, 2011 at 08:13:32AM +0100, Dirk Behme wrote:
> On 16.11.2011 04:46, Fabio Estevam wrote:
>> Fix the following build error when doing a 'make mx3_defconfig'
>>
>> CC [M]  drivers/usb/host/fsl-mph-dr-of.o
>> drivers/usb/host/fsl-mph-dr-of.c: In function 'fsl_usb2_device_register':
>> drivers/usb/host/fsl-mph-dr-of.c:97: error: 'struct pdev_archdata' has no member named 'dma_mask'
>> make[3]: *** [drivers/usb/host/fsl-mph-dr-of.o] Error 1
>> make[2]: *** [drivers/usb/host] Error 2
>> make[1]: *** [drivers/usb] Error 2
>> make: *** [drivers] Error 2
>>
>> Signed-off-by: Fabio Estevam<fabio.estevam@freescale.com>
>> ---
>>   arch/arm/include/asm/device.h |    1 +
>>   1 files changed, 1 insertions(+), 0 deletions(-)
>>
>> diff --git a/arch/arm/include/asm/device.h b/arch/arm/include/asm/device.h
>> index 7aa3680..6ec60f6 100644
>> --- a/arch/arm/include/asm/device.h
>> +++ b/arch/arm/include/asm/device.h
>> @@ -21,6 +21,7 @@ struct pdev_archdata {
>>   #ifdef CONFIG_ARCH_OMAP
>>   	struct omap_device *od;
>>   #endif
>> +	u64 dma_mask;
>>   };
>>
>>   #endif
>
> Will there  be a v2 of this patch fixing the review comments?
>
> It seems the number of people hit by the issue this patch deals with  
> increases ...

How about fixing the driver?  Or how about fixing this problem properly
and sorting it out in the standard platform device model, rather than
asking every arch to add this to their platform device archdata?

[PATCH] arm: device.h: Add dma_mask to pdev_archdata structure

[Fabio Estevam]

Dirk,

On Tue, Dec 20, 2011 at 5:13 AM, Dirk Behme <dirk.behme@googlemail.com> wrote:

> Will there ?be a v2 of this patch fixing the review comments?
>
> It seems the number of people hit by the issue this patch deals with
> increases ...

I no longer see this issue on a recent kernel.

drivers/usb/host/fsl-mph-dr-of.c is not built for i.MX now.

If you still see this issue, let me know how to reproduce it.

Regards,

Fabio Estevam

[PATCH] arm: device.h: Add dma_mask to pdev_archdata structure

[Fabio Estevam]

On Wed, Dec 21, 2011 at 3:59 PM, Fabio Estevam <festevam@gmail.com> wrote:
> Dirk,
>
> On Tue, Dec 20, 2011 at 5:13 AM, Dirk Behme <dirk.behme@googlemail.com> wrote:
>
>> Will there ?be a v2 of this patch fixing the review comments?
>>
>> It seems the number of people hit by the issue this patch deals with
>> increases ...
>
> I no longer see this issue on a recent kernel.
>
> drivers/usb/host/fsl-mph-dr-of.c is not built for i.MX now.
>
> If you still see this issue, let me know how to reproduce it.

Ok, I managed to reproduce it and will submit a patch to the USB mailig list.

Regards,

Fabio Estevam