* [PATCH RESEND] bus: imx-weim: fix branch condition evaluates to a garbage value
@ 2023-03-06 6:05 ` Ivan Bornyakov
0 siblings, 0 replies; 14+ messages in thread
From: Ivan Bornyakov @ 2023-03-06 6:05 UTC (permalink / raw)
To: linux-imx
Cc: Ivan Bornyakov, shawnguo, s.hauer, kernel, festevam,
linux-arm-kernel, linux-kernel, stable
If bus type is other than imx50_weim_devtype and have no child devices,
variable 'ret' in function weim_parse_dt() will not be initialized, but
will be used as branch condition and return value. Fix this by
initializing 'ret' with 0.
This was discovered with help of clang-analyzer, but the situation is
quite possible in real life.
Signed-off-by: Ivan Bornyakov <i.bornyakov@metrotek.ru>
Cc: stable@vger.kernel.org
---
drivers/bus/imx-weim.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/bus/imx-weim.c b/drivers/bus/imx-weim.c
index 828c66bbaa67..55d917bd1f3f 100644
--- a/drivers/bus/imx-weim.c
+++ b/drivers/bus/imx-weim.c
@@ -204,8 +204,8 @@ static int weim_parse_dt(struct platform_device *pdev)
const struct of_device_id *of_id = of_match_device(weim_id_table,
&pdev->dev);
const struct imx_weim_devtype *devtype = of_id->data;
+ int ret = 0, have_child = 0;
struct device_node *child;
- int ret, have_child = 0;
struct weim_priv *priv;
void __iomem *base;
u32 reg;
--
2.39.2
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 14+ messages in thread
* Re: [PATCH RESEND] bus: imx-weim: fix branch condition evaluates to a garbage value
2023-03-06 6:05 ` Ivan Bornyakov
@ 2023-03-06 11:19 ` Fabio Estevam
-1 siblings, 0 replies; 14+ messages in thread
From: Fabio Estevam @ 2023-03-06 11:19 UTC (permalink / raw)
To: Ivan Bornyakov
Cc: linux-imx, shawnguo, s.hauer, kernel, linux-arm-kernel,
linux-kernel, stable
On Mon, Mar 6, 2023 at 3:05 AM Ivan Bornyakov <i.bornyakov@metrotek.ru> wrote:
>
> If bus type is other than imx50_weim_devtype and have no child devices,
> variable 'ret' in function weim_parse_dt() will not be initialized, but
> will be used as branch condition and return value. Fix this by
> initializing 'ret' with 0.
>
> This was discovered with help of clang-analyzer, but the situation is
> quite possible in real life.
>
> Signed-off-by: Ivan Bornyakov <i.bornyakov@metrotek.ru>
> Cc: stable@vger.kernel.org
Please add a Fixes tag here.
Reviewed-by: Fabio Estevam <festevam@gmail.com>
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH RESEND] bus: imx-weim: fix branch condition evaluates to a garbage value
@ 2023-03-06 11:19 ` Fabio Estevam
0 siblings, 0 replies; 14+ messages in thread
From: Fabio Estevam @ 2023-03-06 11:19 UTC (permalink / raw)
To: Ivan Bornyakov
Cc: linux-imx, shawnguo, s.hauer, kernel, linux-arm-kernel,
linux-kernel, stable
On Mon, Mar 6, 2023 at 3:05 AM Ivan Bornyakov <i.bornyakov@metrotek.ru> wrote:
>
> If bus type is other than imx50_weim_devtype and have no child devices,
> variable 'ret' in function weim_parse_dt() will not be initialized, but
> will be used as branch condition and return value. Fix this by
> initializing 'ret' with 0.
>
> This was discovered with help of clang-analyzer, but the situation is
> quite possible in real life.
>
> Signed-off-by: Ivan Bornyakov <i.bornyakov@metrotek.ru>
> Cc: stable@vger.kernel.org
Please add a Fixes tag here.
Reviewed-by: Fabio Estevam <festevam@gmail.com>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH RESEND] bus: imx-weim: fix branch condition evaluates to a garbage value
2023-03-06 6:05 ` Ivan Bornyakov
@ 2023-03-06 13:10 ` Ivan Bornyakov
-1 siblings, 0 replies; 14+ messages in thread
From: Ivan Bornyakov @ 2023-03-06 13:10 UTC (permalink / raw)
To: linux-imx
Cc: shawnguo, s.hauer, kernel, festevam, linux-arm-kernel,
linux-kernel, stable
On Mon, Mar 06, 2023 at 09:05:05AM +0300, Ivan Bornyakov wrote:
> If bus type is other than imx50_weim_devtype and have no child devices,
> variable 'ret' in function weim_parse_dt() will not be initialized, but
> will be used as branch condition and return value. Fix this by
> initializing 'ret' with 0.
>
> This was discovered with help of clang-analyzer, but the situation is
> quite possible in real life.
>
> Signed-off-by: Ivan Bornyakov <i.bornyakov@metrotek.ru>
> Cc: stable@vger.kernel.org
Fixes: 52c47b63412b ("bus: imx-weim: improve error handling upon child probe-failure")
Is it OK, or should I post v2 with "Fixes:" tag?
> ---
> drivers/bus/imx-weim.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/bus/imx-weim.c b/drivers/bus/imx-weim.c
> index 828c66bbaa67..55d917bd1f3f 100644
> --- a/drivers/bus/imx-weim.c
> +++ b/drivers/bus/imx-weim.c
> @@ -204,8 +204,8 @@ static int weim_parse_dt(struct platform_device *pdev)
> const struct of_device_id *of_id = of_match_device(weim_id_table,
> &pdev->dev);
> const struct imx_weim_devtype *devtype = of_id->data;
> + int ret = 0, have_child = 0;
> struct device_node *child;
> - int ret, have_child = 0;
> struct weim_priv *priv;
> void __iomem *base;
> u32 reg;
> --
> 2.39.2
>
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: [PATCH RESEND] bus: imx-weim: fix branch condition evaluates to a garbage value
@ 2023-03-06 13:10 ` Ivan Bornyakov
0 siblings, 0 replies; 14+ messages in thread
From: Ivan Bornyakov @ 2023-03-06 13:10 UTC (permalink / raw)
To: linux-imx
Cc: shawnguo, s.hauer, kernel, festevam, linux-arm-kernel,
linux-kernel, stable
On Mon, Mar 06, 2023 at 09:05:05AM +0300, Ivan Bornyakov wrote:
> If bus type is other than imx50_weim_devtype and have no child devices,
> variable 'ret' in function weim_parse_dt() will not be initialized, but
> will be used as branch condition and return value. Fix this by
> initializing 'ret' with 0.
>
> This was discovered with help of clang-analyzer, but the situation is
> quite possible in real life.
>
> Signed-off-by: Ivan Bornyakov <i.bornyakov@metrotek.ru>
> Cc: stable@vger.kernel.org
Fixes: 52c47b63412b ("bus: imx-weim: improve error handling upon child probe-failure")
Is it OK, or should I post v2 with "Fixes:" tag?
> ---
> drivers/bus/imx-weim.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/bus/imx-weim.c b/drivers/bus/imx-weim.c
> index 828c66bbaa67..55d917bd1f3f 100644
> --- a/drivers/bus/imx-weim.c
> +++ b/drivers/bus/imx-weim.c
> @@ -204,8 +204,8 @@ static int weim_parse_dt(struct platform_device *pdev)
> const struct of_device_id *of_id = of_match_device(weim_id_table,
> &pdev->dev);
> const struct imx_weim_devtype *devtype = of_id->data;
> + int ret = 0, have_child = 0;
> struct device_node *child;
> - int ret, have_child = 0;
> struct weim_priv *priv;
> void __iomem *base;
> u32 reg;
> --
> 2.39.2
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: [PATCH RESEND] bus: imx-weim: fix branch condition evaluates to a garbage value
2023-03-06 13:10 ` Ivan Bornyakov
@ 2023-03-06 13:12 ` Fabio Estevam
-1 siblings, 0 replies; 14+ messages in thread
From: Fabio Estevam @ 2023-03-06 13:12 UTC (permalink / raw)
To: Ivan Bornyakov
Cc: linux-imx, shawnguo, s.hauer, kernel, linux-arm-kernel,
linux-kernel, stable
On Mon, Mar 6, 2023 at 10:10 AM Ivan Bornyakov <i.bornyakov@metrotek.ru> wrote:
> Fixes: 52c47b63412b ("bus: imx-weim: improve error handling upon child probe-failure")
>
> Is it OK, or should I post v2 with "Fixes:" tag?
Please post a v2 with the Fixes tag and my Reviewed-by tag, thanks.
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: [PATCH RESEND] bus: imx-weim: fix branch condition evaluates to a garbage value
@ 2023-03-06 13:12 ` Fabio Estevam
0 siblings, 0 replies; 14+ messages in thread
From: Fabio Estevam @ 2023-03-06 13:12 UTC (permalink / raw)
To: Ivan Bornyakov
Cc: linux-imx, shawnguo, s.hauer, kernel, linux-arm-kernel,
linux-kernel, stable
On Mon, Mar 6, 2023 at 10:10 AM Ivan Bornyakov <i.bornyakov@metrotek.ru> wrote:
> Fixes: 52c47b63412b ("bus: imx-weim: improve error handling upon child probe-failure")
>
> Is it OK, or should I post v2 with "Fixes:" tag?
Please post a v2 with the Fixes tag and my Reviewed-by tag, thanks.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH v2] bus: imx-weim: fix branch condition evaluates to a garbage value
2023-03-06 6:05 ` Ivan Bornyakov
@ 2023-03-06 13:25 ` Ivan Bornyakov
-1 siblings, 0 replies; 14+ messages in thread
From: Ivan Bornyakov @ 2023-03-06 13:25 UTC (permalink / raw)
To: linux-imx
Cc: Ivan Bornyakov, shawnguo, s.hauer, kernel, festevam,
linux-arm-kernel, linux-kernel, stable
If bus type is other than imx50_weim_devtype and have no child devices,
variable 'ret' in function weim_parse_dt() will not be initialized, but
will be used as branch condition and return value. Fix this by
initializing 'ret' with 0.
This was discovered with help of clang-analyzer, but the situation is
quite possible in real life.
Fixes: 52c47b63412b ("bus: imx-weim: improve error handling upon child probe-failure")
Signed-off-by: Ivan Bornyakov <i.bornyakov@metrotek.ru>
Cc: stable@vger.kernel.org
Reviewed-by: Fabio Estevam <festevam@gmail.com>
---
drivers/bus/imx-weim.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
ChangeLog:
v1:
[https://lore.kernel.org/all/20230306060505.11657-1-i.bornyakov@metrotek.ru/]
v2:
* add "Fixes" tag
* add Fabio's "Reviewed-by" tag
diff --git a/drivers/bus/imx-weim.c b/drivers/bus/imx-weim.c
index 828c66bbaa67..55d917bd1f3f 100644
--- a/drivers/bus/imx-weim.c
+++ b/drivers/bus/imx-weim.c
@@ -204,8 +204,8 @@ static int weim_parse_dt(struct platform_device *pdev)
const struct of_device_id *of_id = of_match_device(weim_id_table,
&pdev->dev);
const struct imx_weim_devtype *devtype = of_id->data;
+ int ret = 0, have_child = 0;
struct device_node *child;
- int ret, have_child = 0;
struct weim_priv *priv;
void __iomem *base;
u32 reg;
--
2.39.2
^ permalink raw reply related [flat|nested] 14+ messages in thread* [PATCH v2] bus: imx-weim: fix branch condition evaluates to a garbage value
@ 2023-03-06 13:25 ` Ivan Bornyakov
0 siblings, 0 replies; 14+ messages in thread
From: Ivan Bornyakov @ 2023-03-06 13:25 UTC (permalink / raw)
To: linux-imx
Cc: Ivan Bornyakov, shawnguo, s.hauer, kernel, festevam,
linux-arm-kernel, linux-kernel, stable
If bus type is other than imx50_weim_devtype and have no child devices,
variable 'ret' in function weim_parse_dt() will not be initialized, but
will be used as branch condition and return value. Fix this by
initializing 'ret' with 0.
This was discovered with help of clang-analyzer, but the situation is
quite possible in real life.
Fixes: 52c47b63412b ("bus: imx-weim: improve error handling upon child probe-failure")
Signed-off-by: Ivan Bornyakov <i.bornyakov@metrotek.ru>
Cc: stable@vger.kernel.org
Reviewed-by: Fabio Estevam <festevam@gmail.com>
---
drivers/bus/imx-weim.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
ChangeLog:
v1:
[https://lore.kernel.org/all/20230306060505.11657-1-i.bornyakov@metrotek.ru/]
v2:
* add "Fixes" tag
* add Fabio's "Reviewed-by" tag
diff --git a/drivers/bus/imx-weim.c b/drivers/bus/imx-weim.c
index 828c66bbaa67..55d917bd1f3f 100644
--- a/drivers/bus/imx-weim.c
+++ b/drivers/bus/imx-weim.c
@@ -204,8 +204,8 @@ static int weim_parse_dt(struct platform_device *pdev)
const struct of_device_id *of_id = of_match_device(weim_id_table,
&pdev->dev);
const struct imx_weim_devtype *devtype = of_id->data;
+ int ret = 0, have_child = 0;
struct device_node *child;
- int ret, have_child = 0;
struct weim_priv *priv;
void __iomem *base;
u32 reg;
--
2.39.2
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 14+ messages in thread* Re: [PATCH v2] bus: imx-weim: fix branch condition evaluates to a garbage value
2023-03-06 13:25 ` Ivan Bornyakov
@ 2023-03-13 6:10 ` Ivan Bornyakov
-1 siblings, 0 replies; 14+ messages in thread
From: Ivan Bornyakov @ 2023-03-13 6:10 UTC (permalink / raw)
To: linux-imx
Cc: shawnguo, s.hauer, kernel, festevam, linux-arm-kernel,
linux-kernel, stable
On Mon, Mar 06, 2023 at 04:25:26PM +0300, Ivan Bornyakov wrote:
> If bus type is other than imx50_weim_devtype and have no child devices,
> variable 'ret' in function weim_parse_dt() will not be initialized, but
> will be used as branch condition and return value. Fix this by
> initializing 'ret' with 0.
>
> This was discovered with help of clang-analyzer, but the situation is
> quite possible in real life.
>
> Fixes: 52c47b63412b ("bus: imx-weim: improve error handling upon child probe-failure")
> Signed-off-by: Ivan Bornyakov <i.bornyakov@metrotek.ru>
> Cc: stable@vger.kernel.org
> Reviewed-by: Fabio Estevam <festevam@gmail.com>
> ---
> drivers/bus/imx-weim.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> ChangeLog:
> v1:
> [https://lore.kernel.org/all/20230306060505.11657-1-i.bornyakov@metrotek.ru/]
> v2:
> * add "Fixes" tag
> * add Fabio's "Reviewed-by" tag
>
> diff --git a/drivers/bus/imx-weim.c b/drivers/bus/imx-weim.c
> index 828c66bbaa67..55d917bd1f3f 100644
> --- a/drivers/bus/imx-weim.c
> +++ b/drivers/bus/imx-weim.c
> @@ -204,8 +204,8 @@ static int weim_parse_dt(struct platform_device *pdev)
> const struct of_device_id *of_id = of_match_device(weim_id_table,
> &pdev->dev);
> const struct imx_weim_devtype *devtype = of_id->data;
> + int ret = 0, have_child = 0;
> struct device_node *child;
> - int ret, have_child = 0;
> struct weim_priv *priv;
> void __iomem *base;
> u32 reg;
> --
> 2.39.2
>
Ping.
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: [PATCH v2] bus: imx-weim: fix branch condition evaluates to a garbage value
@ 2023-03-13 6:10 ` Ivan Bornyakov
0 siblings, 0 replies; 14+ messages in thread
From: Ivan Bornyakov @ 2023-03-13 6:10 UTC (permalink / raw)
To: linux-imx
Cc: shawnguo, s.hauer, kernel, festevam, linux-arm-kernel,
linux-kernel, stable
On Mon, Mar 06, 2023 at 04:25:26PM +0300, Ivan Bornyakov wrote:
> If bus type is other than imx50_weim_devtype and have no child devices,
> variable 'ret' in function weim_parse_dt() will not be initialized, but
> will be used as branch condition and return value. Fix this by
> initializing 'ret' with 0.
>
> This was discovered with help of clang-analyzer, but the situation is
> quite possible in real life.
>
> Fixes: 52c47b63412b ("bus: imx-weim: improve error handling upon child probe-failure")
> Signed-off-by: Ivan Bornyakov <i.bornyakov@metrotek.ru>
> Cc: stable@vger.kernel.org
> Reviewed-by: Fabio Estevam <festevam@gmail.com>
> ---
> drivers/bus/imx-weim.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> ChangeLog:
> v1:
> [https://lore.kernel.org/all/20230306060505.11657-1-i.bornyakov@metrotek.ru/]
> v2:
> * add "Fixes" tag
> * add Fabio's "Reviewed-by" tag
>
> diff --git a/drivers/bus/imx-weim.c b/drivers/bus/imx-weim.c
> index 828c66bbaa67..55d917bd1f3f 100644
> --- a/drivers/bus/imx-weim.c
> +++ b/drivers/bus/imx-weim.c
> @@ -204,8 +204,8 @@ static int weim_parse_dt(struct platform_device *pdev)
> const struct of_device_id *of_id = of_match_device(weim_id_table,
> &pdev->dev);
> const struct imx_weim_devtype *devtype = of_id->data;
> + int ret = 0, have_child = 0;
> struct device_node *child;
> - int ret, have_child = 0;
> struct weim_priv *priv;
> void __iomem *base;
> u32 reg;
> --
> 2.39.2
>
Ping.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v2] bus: imx-weim: fix branch condition evaluates to a garbage value
2023-03-06 13:25 ` Ivan Bornyakov
@ 2023-03-14 3:44 ` Shawn Guo
-1 siblings, 0 replies; 14+ messages in thread
From: Shawn Guo @ 2023-03-14 3:44 UTC (permalink / raw)
To: Ivan Bornyakov
Cc: linux-imx, s.hauer, kernel, festevam, linux-arm-kernel,
linux-kernel, stable
On Mon, Mar 06, 2023 at 04:25:26PM +0300, Ivan Bornyakov wrote:
> If bus type is other than imx50_weim_devtype and have no child devices,
> variable 'ret' in function weim_parse_dt() will not be initialized, but
> will be used as branch condition and return value. Fix this by
> initializing 'ret' with 0.
>
> This was discovered with help of clang-analyzer, but the situation is
> quite possible in real life.
>
> Fixes: 52c47b63412b ("bus: imx-weim: improve error handling upon child probe-failure")
> Signed-off-by: Ivan Bornyakov <i.bornyakov@metrotek.ru>
> Cc: stable@vger.kernel.org
> Reviewed-by: Fabio Estevam <festevam@gmail.com>
Ok, picked this version up instead.
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: [PATCH v2] bus: imx-weim: fix branch condition evaluates to a garbage value
@ 2023-03-14 3:44 ` Shawn Guo
0 siblings, 0 replies; 14+ messages in thread
From: Shawn Guo @ 2023-03-14 3:44 UTC (permalink / raw)
To: Ivan Bornyakov
Cc: linux-imx, s.hauer, kernel, festevam, linux-arm-kernel,
linux-kernel, stable
On Mon, Mar 06, 2023 at 04:25:26PM +0300, Ivan Bornyakov wrote:
> If bus type is other than imx50_weim_devtype and have no child devices,
> variable 'ret' in function weim_parse_dt() will not be initialized, but
> will be used as branch condition and return value. Fix this by
> initializing 'ret' with 0.
>
> This was discovered with help of clang-analyzer, but the situation is
> quite possible in real life.
>
> Fixes: 52c47b63412b ("bus: imx-weim: improve error handling upon child probe-failure")
> Signed-off-by: Ivan Bornyakov <i.bornyakov@metrotek.ru>
> Cc: stable@vger.kernel.org
> Reviewed-by: Fabio Estevam <festevam@gmail.com>
Ok, picked this version up instead.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 14+ messages in thread