All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ARM: dts: imx: Add missing LVDS decoder on M53Menlo
@ 2021-12-18 15:25 Marek Vasut
  2021-12-18 15:36 ` Fabio Estevam
  2022-01-26 12:19 ` Shawn Guo
  0 siblings, 2 replies; 6+ messages in thread
From: Marek Vasut @ 2021-12-18 15:25 UTC (permalink / raw)
  To: linux-arm-kernel; +Cc: Marek Vasut, Shawn Guo, Fabio Estevam, NXP Linux Team

The M53Menlo display unit uses an LVDS-to-DPI bridge, TI DS90CF364A.
Describe this bridge in DT, otherwise the DT incorrectly describes
DPI panel attached directly to LVDS source.

Fixes: 716be61d1869 ("ARM: dts: imx53: Add Menlosystems M53 board")
Signed-off-by: Marek Vasut <marex@denx.de>
Cc: Shawn Guo <shawnguo@kernel.org>
Cc: Fabio Estevam <festevam@gmail.com>
Cc: NXP Linux Team <linux-imx@nxp.com>
---
 arch/arm/boot/dts/imx53-m53menlo.dts | 27 +++++++++++++++++++++++++--
 1 file changed, 25 insertions(+), 2 deletions(-)

diff --git a/arch/arm/boot/dts/imx53-m53menlo.dts b/arch/arm/boot/dts/imx53-m53menlo.dts
index 4f88e96d81dd..a1eb36229ef8 100644
--- a/arch/arm/boot/dts/imx53-m53menlo.dts
+++ b/arch/arm/boot/dts/imx53-m53menlo.dts
@@ -53,6 +53,29 @@ eth {
 		};
 	};
 
+	lvds-decoder {
+		compatible = "ti,ds90cf364a", "lvds-decoder";
+
+		ports {
+			#address-cells = <1>;
+			#size-cells = <0>;
+
+			port@0 {
+				reg = <0>;
+				lvds_decoder_in: endpoint {
+					remote-endpoint = <&lvds0_out>;
+				};
+			};
+
+			port@1 {
+				reg = <1>;
+				lvds_decoder_out: endpoint {
+					remote-endpoint = <&panel_in>;
+				};
+			};
+		};
+	};
+
 	panel {
 		compatible = "edt,etm0700g0dh6";
 		pinctrl-0 = <&pinctrl_display_gpio>;
@@ -61,7 +84,7 @@ panel {
 
 		port {
 			panel_in: endpoint {
-				remote-endpoint = <&lvds0_out>;
+				remote-endpoint = <&lvds_decoder_out>;
 			};
 		};
 	};
@@ -450,7 +473,7 @@ port@2 {
 			reg = <2>;
 
 			lvds0_out: endpoint {
-				remote-endpoint = <&panel_in>;
+				remote-endpoint = <&lvds_decoder_in>;
 			};
 		};
 	};
-- 
2.33.0


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 6+ messages in thread
* Re: [PATCH] ARM: dts: imx: Add missing LVDS decoder on M53Menlo
  2021-12-18 15:25 [PATCH] ARM: dts: imx: Add missing LVDS decoder on M53Menlo Marek Vasut
@ 2021-12-18 15:36 ` Fabio Estevam
  2022-01-26 12:19 ` Shawn Guo
  1 sibling, 0 replies; 6+ messages in thread
From: Fabio Estevam @ 2021-12-18 15:36 UTC (permalink / raw)
  To: Marek Vasut
  Cc: moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
	Shawn Guo, NXP Linux Team

On Sat, Dec 18, 2021 at 12:25 PM Marek Vasut <marex@denx.de> wrote:
>
> The M53Menlo display unit uses an LVDS-to-DPI bridge, TI DS90CF364A.
> Describe this bridge in DT, otherwise the DT incorrectly describes
> DPI panel attached directly to LVDS source.
>
> Fixes: 716be61d1869 ("ARM: dts: imx53: Add Menlosystems M53 board")
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Shawn Guo <shawnguo@kernel.org>
> Cc: Fabio Estevam <festevam@gmail.com>
> Cc: NXP Linux Team <linux-imx@nxp.com>

Reviewed-by: Fabio Estevam <festevam@gmail.com>

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] ARM: dts: imx: Add missing LVDS decoder on M53Menlo
  2021-12-18 15:25 [PATCH] ARM: dts: imx: Add missing LVDS decoder on M53Menlo Marek Vasut
  2021-12-18 15:36 ` Fabio Estevam
@ 2022-01-26 12:19 ` Shawn Guo
  2022-01-26 12:39   ` Marek Vasut
  1 sibling, 1 reply; 6+ messages in thread
From: Shawn Guo @ 2022-01-26 12:19 UTC (permalink / raw)
  To: Marek Vasut; +Cc: linux-arm-kernel, Fabio Estevam, NXP Linux Team

On Sat, Dec 18, 2021 at 04:25:16PM +0100, Marek Vasut wrote:
> The M53Menlo display unit uses an LVDS-to-DPI bridge, TI DS90CF364A.
> Describe this bridge in DT, otherwise the DT incorrectly describes
> DPI panel attached directly to LVDS source.
> 
> Fixes: 716be61d1869 ("ARM: dts: imx53: Add Menlosystems M53 board")
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Shawn Guo <shawnguo@kernel.org>
> Cc: Fabio Estevam <festevam@gmail.com>
> Cc: NXP Linux Team <linux-imx@nxp.com>
> ---
>  arch/arm/boot/dts/imx53-m53menlo.dts | 27 +++++++++++++++++++++++++--
>  1 file changed, 25 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/imx53-m53menlo.dts b/arch/arm/boot/dts/imx53-m53menlo.dts
> index 4f88e96d81dd..a1eb36229ef8 100644
> --- a/arch/arm/boot/dts/imx53-m53menlo.dts
> +++ b/arch/arm/boot/dts/imx53-m53menlo.dts
> @@ -53,6 +53,29 @@ eth {
>  		};
>  	};
>  
> +	lvds-decoder {
> +		compatible = "ti,ds90cf364a", "lvds-decoder";

Is this "ti,ds90cf364a" documented anywhere?

> +
> +		ports {
> +			#address-cells = <1>;
> +			#size-cells = <0>;
> +
> +			port@0 {
> +				reg = <0>;

Please have a newline between property and child node.

Shawn

> +				lvds_decoder_in: endpoint {
> +					remote-endpoint = <&lvds0_out>;
> +				};
> +			};
> +
> +			port@1 {
> +				reg = <1>;
> +				lvds_decoder_out: endpoint {
> +					remote-endpoint = <&panel_in>;
> +				};
> +			};
> +		};
> +	};
> +
>  	panel {
>  		compatible = "edt,etm0700g0dh6";
>  		pinctrl-0 = <&pinctrl_display_gpio>;
> @@ -61,7 +84,7 @@ panel {
>  
>  		port {
>  			panel_in: endpoint {
> -				remote-endpoint = <&lvds0_out>;
> +				remote-endpoint = <&lvds_decoder_out>;
>  			};
>  		};
>  	};
> @@ -450,7 +473,7 @@ port@2 {
>  			reg = <2>;
>  
>  			lvds0_out: endpoint {
> -				remote-endpoint = <&panel_in>;
> +				remote-endpoint = <&lvds_decoder_in>;
>  			};
>  		};
>  	};
> -- 
> 2.33.0
> 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] ARM: dts: imx: Add missing LVDS decoder on M53Menlo
  2022-01-26 12:19 ` Shawn Guo
@ 2022-01-26 12:39   ` Marek Vasut
  2022-01-26 13:02     ` Shawn Guo
  0 siblings, 1 reply; 6+ messages in thread
From: Marek Vasut @ 2022-01-26 12:39 UTC (permalink / raw)
  To: Shawn Guo; +Cc: linux-arm-kernel, Fabio Estevam, NXP Linux Team

On 1/26/22 13:19, Shawn Guo wrote:
> On Sat, Dec 18, 2021 at 04:25:16PM +0100, Marek Vasut wrote:
>> The M53Menlo display unit uses an LVDS-to-DPI bridge, TI DS90CF364A.
>> Describe this bridge in DT, otherwise the DT incorrectly describes
>> DPI panel attached directly to LVDS source.
>>
>> Fixes: 716be61d1869 ("ARM: dts: imx53: Add Menlosystems M53 board")
>> Signed-off-by: Marek Vasut <marex@denx.de>
>> Cc: Shawn Guo <shawnguo@kernel.org>
>> Cc: Fabio Estevam <festevam@gmail.com>
>> Cc: NXP Linux Team <linux-imx@nxp.com>
>> ---
>>   arch/arm/boot/dts/imx53-m53menlo.dts | 27 +++++++++++++++++++++++++--
>>   1 file changed, 25 insertions(+), 2 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/imx53-m53menlo.dts b/arch/arm/boot/dts/imx53-m53menlo.dts
>> index 4f88e96d81dd..a1eb36229ef8 100644
>> --- a/arch/arm/boot/dts/imx53-m53menlo.dts
>> +++ b/arch/arm/boot/dts/imx53-m53menlo.dts
>> @@ -53,6 +53,29 @@ eth {
>>   		};
>>   	};
>>   
>> +	lvds-decoder {
>> +		compatible = "ti,ds90cf364a", "lvds-decoder";
> 
> Is this "ti,ds90cf364a" documented anywhere?

Here is a RB'd patch, currently waiting for someone from dri-devel to 
pick it:

https://patchwork.freedesktop.org/series/98203/

>> +
>> +		ports {
>> +			#address-cells = <1>;
>> +			#size-cells = <0>;
>> +
>> +			port@0 {
>> +				reg = <0>;
> 
> Please have a newline between property and child node.

Maybe you can fix this up when applying ?

Thanks

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] ARM: dts: imx: Add missing LVDS decoder on M53Menlo
  2022-01-26 12:39   ` Marek Vasut
@ 2022-01-26 13:02     ` Shawn Guo
  2022-01-26 13:35       ` Marek Vasut
  0 siblings, 1 reply; 6+ messages in thread
From: Shawn Guo @ 2022-01-26 13:02 UTC (permalink / raw)
  To: Marek Vasut; +Cc: linux-arm-kernel, Fabio Estevam, NXP Linux Team

On Wed, Jan 26, 2022 at 01:39:00PM +0100, Marek Vasut wrote:
> On 1/26/22 13:19, Shawn Guo wrote:
> > On Sat, Dec 18, 2021 at 04:25:16PM +0100, Marek Vasut wrote:
> > > The M53Menlo display unit uses an LVDS-to-DPI bridge, TI DS90CF364A.
> > > Describe this bridge in DT, otherwise the DT incorrectly describes
> > > DPI panel attached directly to LVDS source.
> > > 
> > > Fixes: 716be61d1869 ("ARM: dts: imx53: Add Menlosystems M53 board")
> > > Signed-off-by: Marek Vasut <marex@denx.de>
> > > Cc: Shawn Guo <shawnguo@kernel.org>
> > > Cc: Fabio Estevam <festevam@gmail.com>
> > > Cc: NXP Linux Team <linux-imx@nxp.com>
> > > ---
> > >   arch/arm/boot/dts/imx53-m53menlo.dts | 27 +++++++++++++++++++++++++--
> > >   1 file changed, 25 insertions(+), 2 deletions(-)
> > > 
> > > diff --git a/arch/arm/boot/dts/imx53-m53menlo.dts b/arch/arm/boot/dts/imx53-m53menlo.dts
> > > index 4f88e96d81dd..a1eb36229ef8 100644
> > > --- a/arch/arm/boot/dts/imx53-m53menlo.dts
> > > +++ b/arch/arm/boot/dts/imx53-m53menlo.dts
> > > @@ -53,6 +53,29 @@ eth {
> > >   		};
> > >   	};
> > > +	lvds-decoder {
> > > +		compatible = "ti,ds90cf364a", "lvds-decoder";
> > 
> > Is this "ti,ds90cf364a" documented anywhere?
> 
> Here is a RB'd patch, currently waiting for someone from dri-devel to pick
> it:
> 
> https://patchwork.freedesktop.org/series/98203/

I will have to wait till it lands.

Shawn

> 
> > > +
> > > +		ports {
> > > +			#address-cells = <1>;
> > > +			#size-cells = <0>;
> > > +
> > > +			port@0 {
> > > +				reg = <0>;
> > 
> > Please have a newline between property and child node.
> 
> Maybe you can fix this up when applying ?
> 
> Thanks

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] ARM: dts: imx: Add missing LVDS decoder on M53Menlo
  2022-01-26 13:02     ` Shawn Guo
@ 2022-01-26 13:35       ` Marek Vasut
  0 siblings, 0 replies; 6+ messages in thread
From: Marek Vasut @ 2022-01-26 13:35 UTC (permalink / raw)
  To: Shawn Guo; +Cc: linux-arm-kernel, Fabio Estevam, NXP Linux Team

On 1/26/22 14:02, Shawn Guo wrote:
> On Wed, Jan 26, 2022 at 01:39:00PM +0100, Marek Vasut wrote:
>> On 1/26/22 13:19, Shawn Guo wrote:
>>> On Sat, Dec 18, 2021 at 04:25:16PM +0100, Marek Vasut wrote:
>>>> The M53Menlo display unit uses an LVDS-to-DPI bridge, TI DS90CF364A.
>>>> Describe this bridge in DT, otherwise the DT incorrectly describes
>>>> DPI panel attached directly to LVDS source.
>>>>
>>>> Fixes: 716be61d1869 ("ARM: dts: imx53: Add Menlosystems M53 board")
>>>> Signed-off-by: Marek Vasut <marex@denx.de>
>>>> Cc: Shawn Guo <shawnguo@kernel.org>
>>>> Cc: Fabio Estevam <festevam@gmail.com>
>>>> Cc: NXP Linux Team <linux-imx@nxp.com>
>>>> ---
>>>>    arch/arm/boot/dts/imx53-m53menlo.dts | 27 +++++++++++++++++++++++++--
>>>>    1 file changed, 25 insertions(+), 2 deletions(-)
>>>>
>>>> diff --git a/arch/arm/boot/dts/imx53-m53menlo.dts b/arch/arm/boot/dts/imx53-m53menlo.dts
>>>> index 4f88e96d81dd..a1eb36229ef8 100644
>>>> --- a/arch/arm/boot/dts/imx53-m53menlo.dts
>>>> +++ b/arch/arm/boot/dts/imx53-m53menlo.dts
>>>> @@ -53,6 +53,29 @@ eth {
>>>>    		};
>>>>    	};
>>>> +	lvds-decoder {
>>>> +		compatible = "ti,ds90cf364a", "lvds-decoder";
>>>
>>> Is this "ti,ds90cf364a" documented anywhere?
>>
>> Here is a RB'd patch, currently waiting for someone from dri-devel to pick
>> it:
>>
>> https://patchwork.freedesktop.org/series/98203/
> 
> I will have to wait till it lands.

Of course.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-01-26 13:37 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-18 15:25 [PATCH] ARM: dts: imx: Add missing LVDS decoder on M53Menlo Marek Vasut
2021-12-18 15:36 ` Fabio Estevam
2022-01-26 12:19 ` Shawn Guo
2022-01-26 12:39   ` Marek Vasut
2022-01-26 13:02     ` Shawn Guo
2022-01-26 13:35       ` Marek Vasut

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.