* [PATCH] arm: dts: imx7ulp-evk: remove mux value from pad configuration
@ 2020-01-15 17:50 Jorge Ramirez-Ortiz
2020-01-16 2:22 ` Peng Fan
` (2 more replies)
0 siblings, 3 replies; 7+ messages in thread
From: Jorge Ramirez-Ortiz @ 2020-01-15 17:50 UTC (permalink / raw)
To: u-boot
The mux mode is embedded in the PAD definition and therefore there is
no need to repeat it in the PAD configuration value (more over since
this information will be masked out when the configuration value is
applied).
Signed-off-by: Jorge Ramirez-Ortiz <jorge@foundries.io>
---
arch/arm/dts/imx7ulp-evk.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/dts/imx7ulp-evk.dts b/arch/arm/dts/imx7ulp-evk.dts
index 08a682f314..8f6a935e24 100644
--- a/arch/arm/dts/imx7ulp-evk.dts
+++ b/arch/arm/dts/imx7ulp-evk.dts
@@ -156,7 +156,7 @@
pinctrl_backlight: backlight_grp {
fsl,pins = <
- IMX7ULP_PAD_PTF2__PTF2 0x20100
+ IMX7ULP_PAD_PTF2__PTF2 0x20000
>;
};
--
2.17.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH] arm: dts: imx7ulp-evk: remove mux value from pad configuration
2020-01-15 17:50 [PATCH] arm: dts: imx7ulp-evk: remove mux value from pad configuration Jorge Ramirez-Ortiz
@ 2020-01-16 2:22 ` Peng Fan
2020-01-16 7:40 ` Jorge
2020-01-17 11:50 ` Fabio Estevam
2020-01-20 20:18 ` sbabic at denx.de
2 siblings, 1 reply; 7+ messages in thread
From: Peng Fan @ 2020-01-16 2:22 UTC (permalink / raw)
To: u-boot
> Subject: [PATCH] arm: dts: imx7ulp-evk: remove mux value from pad
> configuration
>
> The mux mode is embedded in the PAD definition and therefore there is no
> need to repeat it in the PAD configuration value (more over since this
> information will be masked out when the configuration value is applied).
Has this been accepted by Shawn?
Thanks,
Peng.
>
> Signed-off-by: Jorge Ramirez-Ortiz <jorge@foundries.io>
> ---
> arch/arm/dts/imx7ulp-evk.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/dts/imx7ulp-evk.dts b/arch/arm/dts/imx7ulp-evk.dts
> index 08a682f314..8f6a935e24 100644
> --- a/arch/arm/dts/imx7ulp-evk.dts
> +++ b/arch/arm/dts/imx7ulp-evk.dts
> @@ -156,7 +156,7 @@
>
> pinctrl_backlight: backlight_grp {
> fsl,pins = <
> - IMX7ULP_PAD_PTF2__PTF2 0x20100
> + IMX7ULP_PAD_PTF2__PTF2 0x20000
> >;
> };
>
> --
> 2.17.1
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] arm: dts: imx7ulp-evk: remove mux value from pad configuration
2020-01-16 2:22 ` Peng Fan
@ 2020-01-16 7:40 ` Jorge
2020-01-17 11:51 ` Fabio Estevam
0 siblings, 1 reply; 7+ messages in thread
From: Jorge @ 2020-01-16 7:40 UTC (permalink / raw)
To: u-boot
On 16/01/20 02:22:35, Peng Fan wrote:
> > Subject: [PATCH] arm: dts: imx7ulp-evk: remove mux value from pad
> > configuration
> >
> > The mux mode is embedded in the PAD definition and therefore there is no
> > need to repeat it in the PAD configuration value (more over since this
> > information will be masked out when the configuration value is applied).
>
> Has this been accepted by Shawn?
added to DL now
>
> Thanks,
> Peng.
>
> >
> > Signed-off-by: Jorge Ramirez-Ortiz <jorge@foundries.io>
> > ---
> > arch/arm/dts/imx7ulp-evk.dts | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/arm/dts/imx7ulp-evk.dts b/arch/arm/dts/imx7ulp-evk.dts
> > index 08a682f314..8f6a935e24 100644
> > --- a/arch/arm/dts/imx7ulp-evk.dts
> > +++ b/arch/arm/dts/imx7ulp-evk.dts
> > @@ -156,7 +156,7 @@
> >
> > pinctrl_backlight: backlight_grp {
> > fsl,pins = <
> > - IMX7ULP_PAD_PTF2__PTF2 0x20100
> > + IMX7ULP_PAD_PTF2__PTF2 0x20000
> > >;
> > };
> >
> > --
> > 2.17.1
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] arm: dts: imx7ulp-evk: remove mux value from pad configuration
2020-01-15 17:50 [PATCH] arm: dts: imx7ulp-evk: remove mux value from pad configuration Jorge Ramirez-Ortiz
2020-01-16 2:22 ` Peng Fan
@ 2020-01-17 11:50 ` Fabio Estevam
2020-01-20 20:18 ` sbabic at denx.de
2 siblings, 0 replies; 7+ messages in thread
From: Fabio Estevam @ 2020-01-17 11:50 UTC (permalink / raw)
To: u-boot
On Wed, Jan 15, 2020 at 2:50 PM Jorge Ramirez-Ortiz <jorge@foundries.io> wrote:
>
> The mux mode is embedded in the PAD definition and therefore there is
> no need to repeat it in the PAD configuration value (more over since
> this information will be masked out when the configuration value is
> applied).
>
> Signed-off-by: Jorge Ramirez-Ortiz <jorge@foundries.io>
Reviewed-by: Fabio Estevam <festevam@gmail.com>
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] arm: dts: imx7ulp-evk: remove mux value from pad configuration
2020-01-16 7:40 ` Jorge
@ 2020-01-17 11:51 ` Fabio Estevam
2020-01-19 18:53 ` Jorge
0 siblings, 1 reply; 7+ messages in thread
From: Fabio Estevam @ 2020-01-17 11:51 UTC (permalink / raw)
To: u-boot
On Thu, Jan 16, 2020 at 4:40 AM Jorge Ramirez-Ortiz, Foundries
<jorge@foundries.io> wrote:
>
> On 16/01/20 02:22:35, Peng Fan wrote:
> > > Subject: [PATCH] arm: dts: imx7ulp-evk: remove mux value from pad
> > > configuration
> > >
> > > The mux mode is embedded in the PAD definition and therefore there is no
> > > need to repeat it in the PAD configuration value (more over since this
> > > information will be masked out when the configuration value is applied).
> >
> > Has this been accepted by Shawn?
>
> added to DL now
Mainline dts does not have backlight support, so this only affects U-Boot.
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] arm: dts: imx7ulp-evk: remove mux value from pad configuration
2020-01-17 11:51 ` Fabio Estevam
@ 2020-01-19 18:53 ` Jorge
0 siblings, 0 replies; 7+ messages in thread
From: Jorge @ 2020-01-19 18:53 UTC (permalink / raw)
To: u-boot
On 17/01/20 08:51:45, Fabio Estevam wrote:
> On Thu, Jan 16, 2020 at 4:40 AM Jorge Ramirez-Ortiz, Foundries
> <jorge@foundries.io> wrote:
> >
> > On 16/01/20 02:22:35, Peng Fan wrote:
> > > > Subject: [PATCH] arm: dts: imx7ulp-evk: remove mux value from pad
> > > > configuration
> > > >
> > > > The mux mode is embedded in the PAD definition and therefore there is no
> > > > need to repeat it in the PAD configuration value (more over since this
> > > > information will be masked out when the configuration value is applied).
> > >
> > > Has this been accepted by Shawn?
> >
> > added to DL now
>
> Mainline dts does not have backlight support, so this only affects U-Boot.
yes, the dts is only incorrect in uboot (ie, any of the mux values
that could be specified in the pad configuration field are just
ignored)
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] arm: dts: imx7ulp-evk: remove mux value from pad configuration
2020-01-15 17:50 [PATCH] arm: dts: imx7ulp-evk: remove mux value from pad configuration Jorge Ramirez-Ortiz
2020-01-16 2:22 ` Peng Fan
2020-01-17 11:50 ` Fabio Estevam
@ 2020-01-20 20:18 ` sbabic at denx.de
2 siblings, 0 replies; 7+ messages in thread
From: sbabic at denx.de @ 2020-01-20 20:18 UTC (permalink / raw)
To: u-boot
> The mux mode is embedded in the PAD definition and therefore there is
> no need to repeat it in the PAD configuration value (more over since
> this information will be masked out when the configuration value is
> applied).
> Signed-off-by: Jorge Ramirez-Ortiz <jorge@foundries.io>
> Reviewed-by: Fabio Estevam <festevam@gmail.com>
Applied to u-boot-imx, master, thanks !
Best regards,
Stefano Babic
--
=====================================================================
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2020-01-20 20:18 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-15 17:50 [PATCH] arm: dts: imx7ulp-evk: remove mux value from pad configuration Jorge Ramirez-Ortiz
2020-01-16 2:22 ` Peng Fan
2020-01-16 7:40 ` Jorge
2020-01-17 11:51 ` Fabio Estevam
2020-01-19 18:53 ` Jorge
2020-01-17 11:50 ` Fabio Estevam
2020-01-20 20:18 ` sbabic at denx.de
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.