* [PATCH V2 1/4] warp7: Fix the pmic_get() parameter in the DM case
@ 2020-01-29 21:05 Joris Offouga
2020-01-29 21:05 ` [PATCH V2 2/4] warp7: remove unused usb configs Joris Offouga
` (3 more replies)
0 siblings, 4 replies; 11+ messages in thread
From: Joris Offouga @ 2020-01-29 21:05 UTC (permalink / raw)
To: u-boot
When pmic_get() is used with DM the first parameter must be
the complete node name plus the unit address, so fix it
accordingly
Signed-off-by: Joris Offouga <offougajoris@gmail.com>
Reviewed-by: Fabio Estevam <festevam@gmail.com>
---
changes v1->v2:
add commit log
change commit message
add reviewed
board/warp7/warp7.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/board/warp7/warp7.c b/board/warp7/warp7.c
index 9efc62f2fb..1ebec93916 100644
--- a/board/warp7/warp7.c
+++ b/board/warp7/warp7.c
@@ -67,7 +67,7 @@ int power_init_board(void)
struct udevice *dev;
int ret, dev_id, rev_id;
- ret = pmic_get("pfuze3000", &dev);
+ ret = pmic_get("pfuze3000 at 8", &dev);
if (ret == -ENODEV)
return 0;
if (ret != 0)
--
2.20.1
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH V2 2/4] warp7: remove unused usb configs
2020-01-29 21:05 [PATCH V2 1/4] warp7: Fix the pmic_get() parameter in the DM case Joris Offouga
@ 2020-01-29 21:05 ` Joris Offouga
2020-01-29 22:50 ` Fabio Estevam
2020-02-10 9:07 ` sbabic at denx.de
2020-01-29 21:06 ` [PATCH V2 3/4] arm: dts: imx7s-warp7: Move u-boot specific node in u-boot.dtsi Joris Offouga
` (2 subsequent siblings)
3 siblings, 2 replies; 11+ messages in thread
From: Joris Offouga @ 2020-01-29 21:05 UTC (permalink / raw)
To: u-boot
With commit 6b503f9e6549("warp7: Switch to DM USB").
These configs are not necessary
Signed-off-by: Joris Offouga <offougajoris@gmail.com>
---
changes v1->v2:
add 12 digits for commit ID
fix typo in commit log
include/configs/warp7.h | 4 ----
1 file changed, 4 deletions(-)
diff --git a/include/configs/warp7.h b/include/configs/warp7.h
index da894ec0ca..39c00480bd 100644
--- a/include/configs/warp7.h
+++ b/include/configs/warp7.h
@@ -149,12 +149,8 @@
#define CONFIG_SYS_MMC_ENV_DEV 0
#define CONFIG_SYS_MMC_ENV_PART 0
-/* USB Configs */
-#define CONFIG_EHCI_HCD_INIT_AFTER_RESET
#define CONFIG_MXC_USB_PORTSC (PORT_PTS_UTMI | PORT_PTS_PTW)
-#define CONFIG_MXC_USB_FLAGS 0
-#define CONFIG_USB_MAX_CONTROLLER_COUNT 1 /* Only OTG1 port enabled */
#define CONFIG_IMX_THERMAL
--
2.20.1
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH V2 3/4] arm: dts: imx7s-warp7: Move u-boot specific node in u-boot.dtsi
2020-01-29 21:05 [PATCH V2 1/4] warp7: Fix the pmic_get() parameter in the DM case Joris Offouga
2020-01-29 21:05 ` [PATCH V2 2/4] warp7: remove unused usb configs Joris Offouga
@ 2020-01-29 21:06 ` Joris Offouga
2020-01-29 22:50 ` Fabio Estevam
2020-02-10 9:07 ` sbabic at denx.de
2020-01-29 21:06 ` [PATCH V2 4/4] mx7dsabre: Fix usbtog probe when use dfu or ums Joris Offouga
2020-02-10 9:08 ` [PATCH V2 1/4] warp7: Fix the pmic_get() parameter in the DM case sbabic at denx.de
3 siblings, 2 replies; 11+ messages in thread
From: Joris Offouga @ 2020-01-29 21:06 UTC (permalink / raw)
To: u-boot
These nodes are not in upstream kernel, so move these in u-boot.dtsi
Signed-off-by: Joris Offouga <offougajoris@gmail.com>
---
changes v1->v2:
fix stdoutpath in to stdout-path
add commit log
arch/arm/dts/imx7s-warp-u-boot.dtsi | 10 ++++++++++
arch/arm/dts/imx7s-warp.dts | 9 ---------
2 files changed, 10 insertions(+), 9 deletions(-)
create mode 100644 arch/arm/dts/imx7s-warp-u-boot.dtsi
diff --git a/arch/arm/dts/imx7s-warp-u-boot.dtsi b/arch/arm/dts/imx7s-warp-u-boot.dtsi
new file mode 100644
index 0000000000..6319840b1c
--- /dev/null
+++ b/arch/arm/dts/imx7s-warp-u-boot.dtsi
@@ -0,0 +1,10 @@
+/ {
+ aliases {
+ mmc0 = &usdhc3;
+ usb0 = &usbotg1;
+ };
+
+ chosen {
+ stdout-path = &uart1;
+ };
+};
diff --git a/arch/arm/dts/imx7s-warp.dts b/arch/arm/dts/imx7s-warp.dts
index db5ef67eb1..f7ba2c0a24 100644
--- a/arch/arm/dts/imx7s-warp.dts
+++ b/arch/arm/dts/imx7s-warp.dts
@@ -17,15 +17,6 @@
reg = <0x80000000 0x20000000>;
};
- aliases {
- mmc0 = &usdhc3;
- usb0 = &usbotg1;
- };
-
- chosen {
- stdout-path = &uart1;
- };
-
gpio-keys {
compatible = "gpio-keys";
pinctrl-0 = <&pinctrl_gpio>;
--
2.20.1
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH V2 4/4] mx7dsabre: Fix usbtog probe when use dfu or ums
2020-01-29 21:05 [PATCH V2 1/4] warp7: Fix the pmic_get() parameter in the DM case Joris Offouga
2020-01-29 21:05 ` [PATCH V2 2/4] warp7: remove unused usb configs Joris Offouga
2020-01-29 21:06 ` [PATCH V2 3/4] arm: dts: imx7s-warp7: Move u-boot specific node in u-boot.dtsi Joris Offouga
@ 2020-01-29 21:06 ` Joris Offouga
2020-01-29 22:51 ` Fabio Estevam
2020-02-10 9:06 ` sbabic at denx.de
2020-02-10 9:08 ` [PATCH V2 1/4] warp7: Fix the pmic_get() parameter in the DM case sbabic at denx.de
3 siblings, 2 replies; 11+ messages in thread
From: Joris Offouga @ 2020-01-29 21:06 UTC (permalink / raw)
To: u-boot
Before:
=> ums 0 mmc 0
UMS: LUN 0, dev 0, hwpart 0, sector 0x0, count 0x1dacc00
usb dr_mode not found
CTRL+C - Operation aborted
=> dfu 0 mmc 0
usb dr_mode not found
After :
=> ums 0 mmc 0
UMS: LUN 0, dev 0, hwpart 0, sector 0x0, count 0x1dacc00
=> dfu 0 mmc 0
Signed-off-by: Joris Offouga <offougajoris@gmail.com>
---
changes v1->v2:
none
arch/arm/dts/imx7d-sdb-u-boot.dtsi | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/arch/arm/dts/imx7d-sdb-u-boot.dtsi b/arch/arm/dts/imx7d-sdb-u-boot.dtsi
index 05dd74eee1..b78358fa13 100644
--- a/arch/arm/dts/imx7d-sdb-u-boot.dtsi
+++ b/arch/arm/dts/imx7d-sdb-u-boot.dtsi
@@ -1,3 +1,7 @@
&fec2 {
status = "disable";
};
+
+&usbotg1 {
+ dr_mode = "peripheral";
+};
--
2.20.1
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH V2 2/4] warp7: remove unused usb configs
2020-01-29 21:05 ` [PATCH V2 2/4] warp7: remove unused usb configs Joris Offouga
@ 2020-01-29 22:50 ` Fabio Estevam
2020-02-10 9:07 ` sbabic at denx.de
1 sibling, 0 replies; 11+ messages in thread
From: Fabio Estevam @ 2020-01-29 22:50 UTC (permalink / raw)
To: u-boot
On Wed, Jan 29, 2020 at 6:06 PM Joris Offouga <offougajoris@gmail.com> wrote:
>
> With commit 6b503f9e6549("warp7: Switch to DM USB").
> These configs are not necessary
>
> Signed-off-by: Joris Offouga <offougajoris@gmail.com>
Reviewed-by: Fabio Estevam <festevam@gmail.com>
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH V2 3/4] arm: dts: imx7s-warp7: Move u-boot specific node in u-boot.dtsi
2020-01-29 21:06 ` [PATCH V2 3/4] arm: dts: imx7s-warp7: Move u-boot specific node in u-boot.dtsi Joris Offouga
@ 2020-01-29 22:50 ` Fabio Estevam
2020-02-10 9:07 ` sbabic at denx.de
1 sibling, 0 replies; 11+ messages in thread
From: Fabio Estevam @ 2020-01-29 22:50 UTC (permalink / raw)
To: u-boot
On Wed, Jan 29, 2020 at 6:06 PM Joris Offouga <offougajoris@gmail.com> wrote:
>
> These nodes are not in upstream kernel, so move these in u-boot.dtsi
>
> Signed-off-by: Joris Offouga <offougajoris@gmail.com>
Reviewed-by: Fabio Estevam <festevam@gmail.com>
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH V2 4/4] mx7dsabre: Fix usbtog probe when use dfu or ums
2020-01-29 21:06 ` [PATCH V2 4/4] mx7dsabre: Fix usbtog probe when use dfu or ums Joris Offouga
@ 2020-01-29 22:51 ` Fabio Estevam
2020-02-10 9:06 ` sbabic at denx.de
1 sibling, 0 replies; 11+ messages in thread
From: Fabio Estevam @ 2020-01-29 22:51 UTC (permalink / raw)
To: u-boot
On Wed, Jan 29, 2020 at 6:06 PM Joris Offouga <offougajoris@gmail.com> wrote:
>
> Before:
> => ums 0 mmc 0
> UMS: LUN 0, dev 0, hwpart 0, sector 0x0, count 0x1dacc00
> usb dr_mode not found
> CTRL+C - Operation aborted
> => dfu 0 mmc 0
> usb dr_mode not found
>
> After :
> => ums 0 mmc 0
> UMS: LUN 0, dev 0, hwpart 0, sector 0x0, count 0x1dacc00
> => dfu 0 mmc 0
>
> Signed-off-by: Joris Offouga <offougajoris@gmail.com>
Reviewed-by: Fabio Estevam <festevam@gmail.com>
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH V2 4/4] mx7dsabre: Fix usbtog probe when use dfu or ums
2020-01-29 21:06 ` [PATCH V2 4/4] mx7dsabre: Fix usbtog probe when use dfu or ums Joris Offouga
2020-01-29 22:51 ` Fabio Estevam
@ 2020-02-10 9:06 ` sbabic at denx.de
1 sibling, 0 replies; 11+ messages in thread
From: sbabic at denx.de @ 2020-02-10 9:06 UTC (permalink / raw)
To: u-boot
> Before:
> => ums 0 mmc 0
> UMS: LUN 0, dev 0, hwpart 0, sector 0x0, count 0x1dacc00
> usb dr_mode not found
> CTRL+C - Operation aborted
> => dfu 0 mmc 0
> usb dr_mode not found
> After :
> => ums 0 mmc 0
> UMS: LUN 0, dev 0, hwpart 0, sector 0x0, count 0x1dacc00
> => dfu 0 mmc 0
> Signed-off-by: Joris Offouga <offougajoris@gmail.com>
> Reviewed-by: Fabio Estevam <festevam@gmail.com>
Applied to u-boot-imx, master, thanks !
Best regards,
Stefano Babic
--
=====================================================================
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH V2 2/4] warp7: remove unused usb configs
2020-01-29 21:05 ` [PATCH V2 2/4] warp7: remove unused usb configs Joris Offouga
2020-01-29 22:50 ` Fabio Estevam
@ 2020-02-10 9:07 ` sbabic at denx.de
1 sibling, 0 replies; 11+ messages in thread
From: sbabic at denx.de @ 2020-02-10 9:07 UTC (permalink / raw)
To: u-boot
> With commit 6b503f9e6549("warp7: Switch to DM USB").
> These configs are not necessary
> Signed-off-by: Joris Offouga <offougajoris@gmail.com>
> Reviewed-by: Fabio Estevam <festevam@gmail.com>
Applied to u-boot-imx, master, thanks !
Best regards,
Stefano Babic
--
=====================================================================
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH V2 3/4] arm: dts: imx7s-warp7: Move u-boot specific node in u-boot.dtsi
2020-01-29 21:06 ` [PATCH V2 3/4] arm: dts: imx7s-warp7: Move u-boot specific node in u-boot.dtsi Joris Offouga
2020-01-29 22:50 ` Fabio Estevam
@ 2020-02-10 9:07 ` sbabic at denx.de
1 sibling, 0 replies; 11+ messages in thread
From: sbabic at denx.de @ 2020-02-10 9:07 UTC (permalink / raw)
To: u-boot
> These nodes are not in upstream kernel, so move these in u-boot.dtsi
> Signed-off-by: Joris Offouga <offougajoris@gmail.com>
> Reviewed-by: Fabio Estevam <festevam@gmail.com>
Applied to u-boot-imx, master, thanks !
Best regards,
Stefano Babic
--
=====================================================================
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH V2 1/4] warp7: Fix the pmic_get() parameter in the DM case
2020-01-29 21:05 [PATCH V2 1/4] warp7: Fix the pmic_get() parameter in the DM case Joris Offouga
` (2 preceding siblings ...)
2020-01-29 21:06 ` [PATCH V2 4/4] mx7dsabre: Fix usbtog probe when use dfu or ums Joris Offouga
@ 2020-02-10 9:08 ` sbabic at denx.de
3 siblings, 0 replies; 11+ messages in thread
From: sbabic at denx.de @ 2020-02-10 9:08 UTC (permalink / raw)
To: u-boot
> When pmic_get() is used with DM the first parameter must be
> the complete node name plus the unit address, so fix it
> accordingly
> Signed-off-by: Joris Offouga <offougajoris@gmail.com>
> Reviewed-by: Fabio Estevam <festevam@gmail.com>
Applied to u-boot-imx, master, thanks !
Best regards,
Stefano Babic
--
=====================================================================
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2020-02-10 9:08 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-29 21:05 [PATCH V2 1/4] warp7: Fix the pmic_get() parameter in the DM case Joris Offouga
2020-01-29 21:05 ` [PATCH V2 2/4] warp7: remove unused usb configs Joris Offouga
2020-01-29 22:50 ` Fabio Estevam
2020-02-10 9:07 ` sbabic at denx.de
2020-01-29 21:06 ` [PATCH V2 3/4] arm: dts: imx7s-warp7: Move u-boot specific node in u-boot.dtsi Joris Offouga
2020-01-29 22:50 ` Fabio Estevam
2020-02-10 9:07 ` sbabic at denx.de
2020-01-29 21:06 ` [PATCH V2 4/4] mx7dsabre: Fix usbtog probe when use dfu or ums Joris Offouga
2020-01-29 22:51 ` Fabio Estevam
2020-02-10 9:06 ` sbabic at denx.de
2020-02-10 9:08 ` [PATCH V2 1/4] warp7: Fix the pmic_get() parameter in the DM case sbabic at denx.de
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.