All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH RESEND] drm/msm/adreno: Do not print error on "qcom, gpu-pwrlevels" absence
@ 2019-10-15 13:40 Fabio Estevam
       [not found] ` <20191015134012.15165-1-festevam-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
  0 siblings, 1 reply; 12+ messages in thread
From: Fabio Estevam @ 2019-10-15 13:40 UTC (permalink / raw)
  To: robdclark-Re5JQEeQqe8AvxtiuMwx3w
  Cc: jonathan-eSc4qw6YbEQ, sean-p7yTbzM4H96eqtR555YLDQ,
	dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
	jcrouse-sgV2jX0FEOL9JmXXK+q4OQ, Fabio Estevam,
	freedreno-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
	cphealy-Re5JQEeQqe8AvxtiuMwx3w

Booting the adreno driver on a imx53 board leads to the following
error message:

adreno 30000000.gpu: [drm:adreno_gpu_init] *ERROR* Could not find the GPU powerlevels

As the "qcom,gpu-pwrlevels" property is optional and never present on
i.MX5, turn the message into debug level instead.

Signed-off-by: Fabio Estevam <festevam@gmail.com>
---

 drivers/gpu/drm/msm/adreno/adreno_gpu.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/msm/adreno/adreno_gpu.c b/drivers/gpu/drm/msm/adreno/adreno_gpu.c
index 0783e4b5486a..5d7bdb4c83cc 100644
--- a/drivers/gpu/drm/msm/adreno/adreno_gpu.c
+++ b/drivers/gpu/drm/msm/adreno/adreno_gpu.c
@@ -826,7 +826,7 @@ static int adreno_get_legacy_pwrlevels(struct device *dev)
 
 	node = of_get_compatible_child(dev->of_node, "qcom,gpu-pwrlevels");
 	if (!node) {
-		DRM_DEV_ERROR(dev, "Could not find the GPU powerlevels\n");
+		DRM_DEV_DEBUG(dev, "Could not find the GPU powerlevels\n");
 		return -ENXIO;
 	}
 
-- 
2.17.1

_______________________________________________
Freedreno mailing list
Freedreno@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/freedreno

^ permalink raw reply related	[flat|nested] 12+ messages in thread
* Re: [PATCH RESEND] drm/msm/adreno: Do not print error on "qcom, gpu-pwrlevels" absence
       [not found] ` <20191015134012.15165-1-festevam-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
@ 2019-10-15 14:19   ` Jeffrey Hugo
       [not found]     ` <CAOCk7NpoGA8VmTXSk96VxVtGU2yFs0+n8wyBeQkvwR8HZSOCRQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
  0 siblings, 1 reply; 12+ messages in thread
From: Jeffrey Hugo @ 2019-10-15 14:19 UTC (permalink / raw)
  To: Fabio Estevam
  Cc: Jonathan Marek, Sean Paul, Jordan Crouse,
	open list:DRM PANEL DRIVERS, Rob Clark, freedreno,
	cphealy-Re5JQEeQqe8AvxtiuMwx3w

On Tue, Oct 15, 2019 at 7:40 AM Fabio Estevam <festevam@gmail.com> wrote:
>
> Booting the adreno driver on a imx53 board leads to the following
> error message:
>
> adreno 30000000.gpu: [drm:adreno_gpu_init] *ERROR* Could not find the GPU powerlevels
>
> As the "qcom,gpu-pwrlevels" property is optional and never present on
> i.MX5, turn the message into debug level instead.
>
> Signed-off-by: Fabio Estevam <festevam@gmail.com>

Seems reasonable.  Reviewed-by: Jeffrey Hugo <jeffrey.l.hugo@gmail.com>

> ---
>
>  drivers/gpu/drm/msm/adreno/adreno_gpu.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/msm/adreno/adreno_gpu.c b/drivers/gpu/drm/msm/adreno/adreno_gpu.c
> index 0783e4b5486a..5d7bdb4c83cc 100644
> --- a/drivers/gpu/drm/msm/adreno/adreno_gpu.c
> +++ b/drivers/gpu/drm/msm/adreno/adreno_gpu.c
> @@ -826,7 +826,7 @@ static int adreno_get_legacy_pwrlevels(struct device *dev)
>
>         node = of_get_compatible_child(dev->of_node, "qcom,gpu-pwrlevels");
>         if (!node) {
> -               DRM_DEV_ERROR(dev, "Could not find the GPU powerlevels\n");
> +               DRM_DEV_DEBUG(dev, "Could not find the GPU powerlevels\n");
>                 return -ENXIO;
>         }
>
> --
> 2.17.1
>
> _______________________________________________
> Freedreno mailing list
> Freedreno@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/freedreno
_______________________________________________
Freedreno mailing list
Freedreno@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/freedreno

^ permalink raw reply	[flat|nested] 12+ messages in thread
* Re: [PATCH RESEND] drm/msm/adreno: Do not print error on "qcom, gpu-pwrlevels" absence
@ 2019-10-31 22:03         ` Fabio Estevam
  0 siblings, 0 replies; 12+ messages in thread
From: Fabio Estevam @ 2019-10-31 22:03 UTC (permalink / raw)
  To: Jeffrey Hugo, Rob Clark
  Cc: Jonathan Marek, Sean Paul, open list:DRM PANEL DRIVERS,
	Jordan Crouse, freedreno, Chris Healy

Hi Rob,

On Tue, Oct 15, 2019 at 11:19 AM Jeffrey Hugo <jeffrey.l.hugo@gmail.com> wrote:
>
> On Tue, Oct 15, 2019 at 7:40 AM Fabio Estevam <festevam@gmail.com> wrote:
> >
> > Booting the adreno driver on a imx53 board leads to the following
> > error message:
> >
> > adreno 30000000.gpu: [drm:adreno_gpu_init] *ERROR* Could not find the GPU powerlevels
> >
> > As the "qcom,gpu-pwrlevels" property is optional and never present on
> > i.MX5, turn the message into debug level instead.
> >
> > Signed-off-by: Fabio Estevam <festevam@gmail.com>
>
> Seems reasonable.  Reviewed-by: Jeffrey Hugo <jeffrey.l.hugo@gmail.com>

Any comments, please?

Just wanted to get rid of this misleading error message on i.MX5.

Thanks
_______________________________________________
Freedreno mailing list
Freedreno@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/freedreno

^ permalink raw reply	[flat|nested] 12+ messages in thread
* Re: [Freedreno] [PATCH RESEND] drm/msm/adreno: Do not print error on "qcom, gpu-pwrlevels" absence
@ 2019-10-31 22:03         ` Fabio Estevam
  0 siblings, 0 replies; 12+ messages in thread
From: Fabio Estevam @ 2019-10-31 22:03 UTC (permalink / raw)
  To: Jeffrey Hugo, Rob Clark
  Cc: Jonathan Marek, Sean Paul, open list:DRM PANEL DRIVERS,
	freedreno, Chris Healy

Hi Rob,

On Tue, Oct 15, 2019 at 11:19 AM Jeffrey Hugo <jeffrey.l.hugo@gmail.com> wrote:
>
> On Tue, Oct 15, 2019 at 7:40 AM Fabio Estevam <festevam@gmail.com> wrote:
> >
> > Booting the adreno driver on a imx53 board leads to the following
> > error message:
> >
> > adreno 30000000.gpu: [drm:adreno_gpu_init] *ERROR* Could not find the GPU powerlevels
> >
> > As the "qcom,gpu-pwrlevels" property is optional and never present on
> > i.MX5, turn the message into debug level instead.
> >
> > Signed-off-by: Fabio Estevam <festevam@gmail.com>
>
> Seems reasonable.  Reviewed-by: Jeffrey Hugo <jeffrey.l.hugo@gmail.com>

Any comments, please?

Just wanted to get rid of this misleading error message on i.MX5.

Thanks
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 12+ messages in thread
* Re: [Freedreno] [PATCH RESEND] drm/msm/adreno: Do not print error on "qcom, gpu-pwrlevels" absence
  2019-10-31 22:03         ` [Freedreno] " Fabio Estevam
  (?)
@ 2019-11-01 14:52         ` Jordan Crouse
       [not found]           ` <20191101145209.GA16446-p/X+hYOWT4canIX5fXjzESPyLMyjRtWwAL8bYrjMMd8@public.gmane.org>
  -1 siblings, 1 reply; 12+ messages in thread
From: Jordan Crouse @ 2019-11-01 14:52 UTC (permalink / raw)
  To: Fabio Estevam
  Cc: Jonathan Marek, Jeffrey Hugo, Sean Paul,
	open list:DRM PANEL DRIVERS, freedreno, Chris Healy

On Thu, Oct 31, 2019 at 07:03:59PM -0300, Fabio Estevam wrote:
> Hi Rob,
> 
> On Tue, Oct 15, 2019 at 11:19 AM Jeffrey Hugo <jeffrey.l.hugo@gmail.com> wrote:
> >
> > On Tue, Oct 15, 2019 at 7:40 AM Fabio Estevam <festevam@gmail.com> wrote:
> > >
> > > Booting the adreno driver on a imx53 board leads to the following
> > > error message:
> > >
> > > adreno 30000000.gpu: [drm:adreno_gpu_init] *ERROR* Could not find the GPU powerlevels
> > >
> > > As the "qcom,gpu-pwrlevels" property is optional and never present on
> > > i.MX5, turn the message into debug level instead.
> > >
> > > Signed-off-by: Fabio Estevam <festevam@gmail.com>
> >
> > Seems reasonable.  Reviewed-by: Jeffrey Hugo <jeffrey.l.hugo@gmail.com>
> 
> Any comments, please?
> 
> Just wanted to get rid of this misleading error message on i.MX5.

I'm good with this. This really should only be around for
compatibility with downstream device tree files which should mean nothing for
I.MX5.

Jordan

-- 
The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 12+ messages in thread
* Re: [PATCH RESEND] drm/msm/adreno: Do not print error on "qcom, gpu-pwrlevels" absence
@ 2019-11-12 16:40               ` Fabio Estevam
  0 siblings, 0 replies; 12+ messages in thread
From: Fabio Estevam @ 2019-11-12 16:40 UTC (permalink / raw)
  To: Fabio Estevam, Jeffrey Hugo, Rob Clark, Jonathan Marek,
	Sean Paul, open list:DRM PANEL DRIVERS, freedreno, Chris Healy

Hi Jordan,

On Fri, Nov 1, 2019 at 11:52 AM Jordan Crouse <jcrouse@codeaurora.org> wrote:

> I'm good with this. This really should only be around for
> compatibility with downstream device tree files which should mean nothing for
> I.MX5.

May I resend it with your Reviewed-by tag?

Thanks
_______________________________________________
Freedreno mailing list
Freedreno@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/freedreno

^ permalink raw reply	[flat|nested] 12+ messages in thread
* Re: [Freedreno] [PATCH RESEND] drm/msm/adreno: Do not print error on "qcom, gpu-pwrlevels" absence
@ 2019-11-12 16:40               ` Fabio Estevam
  0 siblings, 0 replies; 12+ messages in thread
From: Fabio Estevam @ 2019-11-12 16:40 UTC (permalink / raw)
  To: Fabio Estevam, Jeffrey Hugo, Rob Clark, Jonathan Marek,
	Sean Paul, open list:DRM PANEL DRIVERS, freedreno, Chris Healy

Hi Jordan,

On Fri, Nov 1, 2019 at 11:52 AM Jordan Crouse <jcrouse@codeaurora.org> wrote:

> I'm good with this. This really should only be around for
> compatibility with downstream device tree files which should mean nothing for
> I.MX5.

May I resend it with your Reviewed-by tag?

Thanks
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 12+ messages in thread
* Re: [PATCH RESEND] drm/msm/adreno: Do not print error on "qcom, gpu-pwrlevels" absence
@ 2019-11-12 16:52                   ` Jordan Crouse
  0 siblings, 0 replies; 12+ messages in thread
From: Jordan Crouse @ 2019-11-12 16:52 UTC (permalink / raw)
  To: Fabio Estevam
  Cc: Jonathan Marek, Jeffrey Hugo, Sean Paul,
	open list:DRM PANEL DRIVERS, Rob Clark, freedreno, Chris Healy

On Tue, Nov 12, 2019 at 01:40:22PM -0300, Fabio Estevam wrote:
> Hi Jordan,
> 
> On Fri, Nov 1, 2019 at 11:52 AM Jordan Crouse <jcrouse@codeaurora.org> wrote:
> 
> > I'm good with this. This really should only be around for
> > compatibility with downstream device tree files which should mean nothing for
> > I.MX5.
> 
> May I resend it with your Reviewed-by tag?

Of course.

Jordan
-- 
The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
_______________________________________________
Freedreno mailing list
Freedreno@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/freedreno

^ permalink raw reply	[flat|nested] 12+ messages in thread
* Re: [Freedreno] [PATCH RESEND] drm/msm/adreno: Do not print error on "qcom, gpu-pwrlevels" absence
@ 2019-11-12 16:52                   ` Jordan Crouse
  0 siblings, 0 replies; 12+ messages in thread
From: Jordan Crouse @ 2019-11-12 16:52 UTC (permalink / raw)
  To: Fabio Estevam
  Cc: Jonathan Marek, Jeffrey Hugo, Sean Paul,
	open list:DRM PANEL DRIVERS, freedreno, Chris Healy

On Tue, Nov 12, 2019 at 01:40:22PM -0300, Fabio Estevam wrote:
> Hi Jordan,
> 
> On Fri, Nov 1, 2019 at 11:52 AM Jordan Crouse <jcrouse@codeaurora.org> wrote:
> 
> > I'm good with this. This really should only be around for
> > compatibility with downstream device tree files which should mean nothing for
> > I.MX5.
> 
> May I resend it with your Reviewed-by tag?

Of course.

Jordan
-- 
The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 12+ messages in thread
* Re: [PATCH RESEND] drm/msm/adreno: Do not print error on "qcom,gpu-pwrlevels" absence
  2019-12-10 23:11 Fabio Estevam
@ 2019-12-18 14:15 ` Fabio Estevam
  0 siblings, 0 replies; 12+ messages in thread
From: Fabio Estevam @ 2019-12-18 14:15 UTC (permalink / raw)
  To: Rob Clark
  Cc: Jonathan Marek, Jeffrey Hugo, David Airlie,
	open list:DRM DRIVER FOR MSM ADRENO GPU, DRI mailing list,
	Sean Paul

Hi Rob,

On Tue, Dec 10, 2019 at 8:12 PM Fabio Estevam <festevam@gmail.com> wrote:
>
> Booting the adreno driver on a imx53 board leads to the following
> error message:
>
> adreno 30000000.gpu: [drm:adreno_gpu_init] *ERROR* Could not find the GPU powerlevels
>
> As the "qcom,gpu-pwrlevels" property is optional and never present on
> i.MX5, turn the message into debug level instead.
>
> Signed-off-by: Fabio Estevam <festevam@gmail.com>
> Reviewed-by: Jeffrey Hugo <jeffrey.l.hugo@gmail.com>
> Reviewed-by: Jordan Crouse <jcrouse@codeaurora.org>
> ---
> Trying once again :-)
>
>  drivers/gpu/drm/msm/adreno/adreno_gpu.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/msm/adreno/adreno_gpu.c b/drivers/gpu/drm/msm/adreno/adreno_gpu.c
> index 0783e4b5486a..5d7bdb4c83cc 100644
> --- a/drivers/gpu/drm/msm/adreno/adreno_gpu.c
> +++ b/drivers/gpu/drm/msm/adreno/adreno_gpu.c
> @@ -826,7 +826,7 @@ static int adreno_get_legacy_pwrlevels(struct device *dev)
>
>         node = of_get_compatible_child(dev->of_node, "qcom,gpu-pwrlevels");
>         if (!node) {
> -               DRM_DEV_ERROR(dev, "Could not find the GPU powerlevels\n");
> +               DRM_DEV_DEBUG(dev, "Could not find the GPU powerlevels\n");

A gentle ping...
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 12+ messages in thread
* [PATCH RESEND] drm/msm/adreno: Do not print error on "qcom, gpu-pwrlevels" absence
@ 2019-12-10 23:11 Fabio Estevam
  2019-12-18 14:15 ` [PATCH RESEND] drm/msm/adreno: Do not print error on "qcom,gpu-pwrlevels" absence Fabio Estevam
  0 siblings, 1 reply; 12+ messages in thread
From: Fabio Estevam @ 2019-12-10 23:11 UTC (permalink / raw)
  To: robdclark; +Cc: jonathan, jeffrey.l.hugo, airlied, freedreno, dri-devel, sean

Booting the adreno driver on a imx53 board leads to the following
error message:

adreno 30000000.gpu: [drm:adreno_gpu_init] *ERROR* Could not find the GPU powerlevels

As the "qcom,gpu-pwrlevels" property is optional and never present on
i.MX5, turn the message into debug level instead.

Signed-off-by: Fabio Estevam <festevam@gmail.com>
Reviewed-by: Jeffrey Hugo <jeffrey.l.hugo@gmail.com>
Reviewed-by: Jordan Crouse <jcrouse@codeaurora.org>
---
Trying once again :-)

 drivers/gpu/drm/msm/adreno/adreno_gpu.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/msm/adreno/adreno_gpu.c b/drivers/gpu/drm/msm/adreno/adreno_gpu.c
index 0783e4b5486a..5d7bdb4c83cc 100644
--- a/drivers/gpu/drm/msm/adreno/adreno_gpu.c
+++ b/drivers/gpu/drm/msm/adreno/adreno_gpu.c
@@ -826,7 +826,7 @@ static int adreno_get_legacy_pwrlevels(struct device *dev)
 
 	node = of_get_compatible_child(dev->of_node, "qcom,gpu-pwrlevels");
 	if (!node) {
-		DRM_DEV_ERROR(dev, "Could not find the GPU powerlevels\n");
+		DRM_DEV_DEBUG(dev, "Could not find the GPU powerlevels\n");
 		return -ENXIO;
 	}
 
-- 
2.17.1

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply related	[flat|nested] 12+ messages in thread
* [PATCH RESEND] drm/msm/adreno: Do not print error on "qcom, gpu-pwrlevels" absence
@ 2019-11-12 21:59 Fabio Estevam
  0 siblings, 0 replies; 12+ messages in thread
From: Fabio Estevam @ 2019-11-12 21:59 UTC (permalink / raw)
  To: robdclark; +Cc: jonathan, jeffrey.l.hugo, dri-devel, sean, cphealy

Booting the adreno driver on a imx53 board leads to the following
error message:

adreno 30000000.gpu: [drm:adreno_gpu_init] *ERROR* Could not find the GPU powerlevels

As the "qcom,gpu-pwrlevels" property is optional and never present on
i.MX5, turn the message into debug level instead.

Signed-off-by: Fabio Estevam <festevam@gmail.com>
Reviewed-by: Jeffrey Hugo <jeffrey.l.hugo@gmail.com>
Reviewed-by: Jordan Crouse <jcrouse@codeaurora.org>
---
 drivers/gpu/drm/msm/adreno/adreno_gpu.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/msm/adreno/adreno_gpu.c b/drivers/gpu/drm/msm/adreno/adreno_gpu.c
index 0783e4b5486a..5d7bdb4c83cc 100644
--- a/drivers/gpu/drm/msm/adreno/adreno_gpu.c
+++ b/drivers/gpu/drm/msm/adreno/adreno_gpu.c
@@ -826,7 +826,7 @@ static int adreno_get_legacy_pwrlevels(struct device *dev)
 
 	node = of_get_compatible_child(dev->of_node, "qcom,gpu-pwrlevels");
 	if (!node) {
-		DRM_DEV_ERROR(dev, "Could not find the GPU powerlevels\n");
+		DRM_DEV_DEBUG(dev, "Could not find the GPU powerlevels\n");
 		return -ENXIO;
 	}
 
-- 
2.17.1

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply related	[flat|nested] 12+ messages in thread
end of thread, other threads:[~2019-12-18 14:15 UTC | newest]

Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-15 13:40 [PATCH RESEND] drm/msm/adreno: Do not print error on "qcom, gpu-pwrlevels" absence Fabio Estevam
     [not found] ` <20191015134012.15165-1-festevam-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2019-10-15 14:19   ` Jeffrey Hugo
     [not found]     ` <CAOCk7NpoGA8VmTXSk96VxVtGU2yFs0+n8wyBeQkvwR8HZSOCRQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2019-10-31 22:03       ` Fabio Estevam
2019-10-31 22:03         ` [Freedreno] " Fabio Estevam
2019-11-01 14:52         ` Jordan Crouse
     [not found]           ` <20191101145209.GA16446-p/X+hYOWT4canIX5fXjzESPyLMyjRtWwAL8bYrjMMd8@public.gmane.org>
2019-11-12 16:40             ` Fabio Estevam
2019-11-12 16:40               ` [Freedreno] " Fabio Estevam
     [not found]               ` <CAOMZO5ADoav=-6ZMn-C=7UA0Fz96BVyitSYeAsn+kxf8HBzZ2g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2019-11-12 16:52                 ` Jordan Crouse
2019-11-12 16:52                   ` [Freedreno] " Jordan Crouse
2019-11-12 21:59 Fabio Estevam
2019-12-10 23:11 Fabio Estevam
2019-12-18 14:15 ` [PATCH RESEND] drm/msm/adreno: Do not print error on "qcom,gpu-pwrlevels" absence Fabio Estevam

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.