All of lore.kernel.org
 help / color / mirror / Atom feed
From: Fabio Estevam <festevam@gmail.com>
To: Philipp Zabel <p.zabel@pengutronix.de>
Cc: gregkh@linuxfoundation.org, shawn.guo@linaro.org,
	kernel@pengutronix.de, linux-kernel@vger.kernel.org,
	Fabio Estevam <fabio.estevam@freescale.com>
Subject: Re: [PATCH 5/5] imx-drm: ipu-dp: Adjust the maximum number of flows
Date: Fri, 28 Jun 2013 11:09:33 -0300	[thread overview]
Message-ID: <CAOMZO5As90NNdDoYSmCmXq5UB5j2YgdgTnjMbyqz7X0hT5e=uQ@mail.gmail.com> (raw)
In-Reply-To: <1372427593.4257.7.camel@pizza.hi.pengutronix.de>

Hi Philipp,

On Fri, Jun 28, 2013 at 10:53 AM, Philipp Zabel <p.zabel@pengutronix.de> wrote:

>
> If (flow == IPUV3_NUM_FLOWS << 1), this will continue and try to access
> &priv->flow[3] below, which is invalid. How about
>
> +       if ((flow >> 1) >= IPUV3_NUM_FLOWS)
>
> instead?

Yes, agreed.

Thanks,

Fabio Estevam

  reply	other threads:[~2013-06-28 14:09 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-28  3:32 [PATCH 1/5] imx-drm: imx-drm-core: Export imx_drm_encoder_get_mux_id Fabio Estevam
2013-06-28  3:32 ` [PATCH 2/5] imx-drm: ipu-dp: Check the return value of devm_kzalloc() Fabio Estevam
2013-06-28  3:32 ` [PATCH 3/5] imx-drm: ipu-dp: Remove unneeded braces Fabio Estevam
2013-06-28  3:32 ` [PATCH 4/5] imx-drm: ipu-dp: Introduce IPUV3_NUM_FLOWS Fabio Estevam
2013-06-28  3:32 ` [PATCH 5/5] imx-drm: ipu-dp: Adjust the maximum number of flows Fabio Estevam
2013-06-28  7:30   ` Uwe Kleine-König
2013-06-28 13:25     ` Fabio Estevam
2013-06-28 13:53   ` Philipp Zabel
2013-06-28 14:09     ` Fabio Estevam [this message]
2013-06-28  7:29 ` [PATCH 1/5] imx-drm: imx-drm-core: Export imx_drm_encoder_get_mux_id Uwe Kleine-König
2013-06-28 14:43   ` Fabio Estevam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAOMZO5As90NNdDoYSmCmXq5UB5j2YgdgTnjMbyqz7X0hT5e=uQ@mail.gmail.com' \
    --to=festevam@gmail.com \
    --cc=fabio.estevam@freescale.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=kernel@pengutronix.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=p.zabel@pengutronix.de \
    --cc=shawn.guo@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.