All of lore.kernel.org
 help / color / mirror / Atom feed
From: Fabio Estevam <festevam@gmail.com>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: gregkh@linuxfoundation.org, shawn.guo@linaro.org,
	kernel@pengutronix.de, linux-kernel@vger.kernel.org,
	Fabio Estevam <fabio.estevam@freescale.com>
Subject: Re: [PATCH 1/5] imx-drm: imx-drm-core: Export imx_drm_encoder_get_mux_id
Date: Fri, 28 Jun 2013 11:43:59 -0300	[thread overview]
Message-ID: <CAOMZO5AtbfsrXnNyXKwyfqPn48bsuimk_D6gddXchzGcCfD-RA@mail.gmail.com> (raw)
In-Reply-To: <20130628072950.GI27010@pengutronix.de>

Hi Uwe,

On Fri, Jun 28, 2013 at 4:29 AM, Uwe Kleine-König
<u.kleine-koenig@pengutronix.de> wrote:
> On Fri, Jun 28, 2013 at 12:32:01AM -0300, Fabio Estevam wrote:
>> From: Fabio Estevam <fabio.estevam@freescale.com>
>>
>> When building imx_v6_v7_defconfig with imx-drm drivers selected as modules, we
>> get the following build error:
>>
>> ERROR: "imx_drm_encoder_get_mux_id" [drivers/staging/imx-drm/imx-ldb.ko] undefined!
> So imx-ldb.c needs a symbol from imx-drm-core.c right? The alternative
> to exporting this symbol for a single user(?) is to link these two files
> into a single module. Does this make sense? If yes, that would IMHO be
> the better fix.

The Makefile for these files is:

imxdrm-objs := imx-drm-core.o imx-fb.o

obj-$(CONFIG_DRM_IMX) += imxdrm.o

obj-$(CONFIG_DRM_IMX_PARALLEL_DISPLAY) += parallel-display.o
obj-$(CONFIG_DRM_IMX_TVE) += imx-tve.o
obj-$(CONFIG_DRM_IMX_LDB) += imx-ldb.o
obj-$(CONFIG_DRM_IMX_FB_HELPER) += imx-fbdev.o
obj-$(CONFIG_DRM_IMX_IPUV3_CORE) += ipu-v3/
obj-$(CONFIG_DRM_IMX_IPUV3)	+= ipuv3-crtc.o

so imx-drm-core is always built and imx-ldb is only built when
CONFIG_DRM_IMX_LDB is selected.

In this case, we should keep the two modules separate and fix this
error using the export.

Regards,

Fabio Estevam

      reply	other threads:[~2013-06-28 14:44 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-28  3:32 [PATCH 1/5] imx-drm: imx-drm-core: Export imx_drm_encoder_get_mux_id Fabio Estevam
2013-06-28  3:32 ` [PATCH 2/5] imx-drm: ipu-dp: Check the return value of devm_kzalloc() Fabio Estevam
2013-06-28  3:32 ` [PATCH 3/5] imx-drm: ipu-dp: Remove unneeded braces Fabio Estevam
2013-06-28  3:32 ` [PATCH 4/5] imx-drm: ipu-dp: Introduce IPUV3_NUM_FLOWS Fabio Estevam
2013-06-28  3:32 ` [PATCH 5/5] imx-drm: ipu-dp: Adjust the maximum number of flows Fabio Estevam
2013-06-28  7:30   ` Uwe Kleine-König
2013-06-28 13:25     ` Fabio Estevam
2013-06-28 13:53   ` Philipp Zabel
2013-06-28 14:09     ` Fabio Estevam
2013-06-28  7:29 ` [PATCH 1/5] imx-drm: imx-drm-core: Export imx_drm_encoder_get_mux_id Uwe Kleine-König
2013-06-28 14:43   ` Fabio Estevam [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAOMZO5AtbfsrXnNyXKwyfqPn48bsuimk_D6gddXchzGcCfD-RA@mail.gmail.com \
    --to=festevam@gmail.com \
    --cc=fabio.estevam@freescale.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=kernel@pengutronix.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=shawn.guo@linaro.org \
    --cc=u.kleine-koenig@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.