* [PATCH 1/5] ARM: dts: imx7-colibri: use OF graph to describe the display
@ 2017-03-29 23:21 ` Stefan Agner
0 siblings, 0 replies; 16+ messages in thread
From: Stefan Agner @ 2017-03-29 23:21 UTC (permalink / raw)
To: linux-arm-kernel
To make use of the new eLCDIF DRM driver OF graph description is
required. Describe the display using OF graph nodes.
Signed-off-by: Stefan Agner <stefan@agner.ch>
---
arch/arm/boot/dts/imx7-colibri-eval-v3.dtsi | 38 +++++++++++------------------
1 file changed, 14 insertions(+), 24 deletions(-)
diff --git a/arch/arm/boot/dts/imx7-colibri-eval-v3.dtsi b/arch/arm/boot/dts/imx7-colibri-eval-v3.dtsi
index 373ee19196a6..7a98a45a0d95 100644
--- a/arch/arm/boot/dts/imx7-colibri-eval-v3.dtsi
+++ b/arch/arm/boot/dts/imx7-colibri-eval-v3.dtsi
@@ -44,6 +44,17 @@
chosen {
stdout-path = "serial0:115200n8";
};
+
+ panel: panel {
+ compatible = "edt,et057090dhu";
+ backlight = <&bl>;
+
+ port {
+ panel_in: endpoint {
+ remote-endpoint = <&lcdif_out>;
+ };
+ };
+ };
};
&bl {
@@ -75,32 +86,11 @@
};
&lcdif {
- display = <&display0>;
status = "okay";
- display0: lcd-display {
- bits-per-pixel = <16>;
- bus-width = <18>;
-
- display-timings {
- native-mode = <&timing_vga>;
-
- /* Standard VGA timing */
- timing_vga: 640x480 {
- clock-frequency = <25175000>;
- hactive = <640>;
- vactive = <480>;
- hback-porch = <40>;
- hfront-porch = <24>;
- vback-porch = <32>;
- vfront-porch = <11>;
- hsync-len = <96>;
- vsync-len = <2>;
- de-active = <1>;
- hsync-active = <0>;
- vsync-active = <0>;
- pixelclk-active = <0>;
- };
+ port {
+ lcdif_out: endpoint {
+ remote-endpoint = <&panel_in>;
};
};
};
--
2.12.1
^ permalink raw reply related [flat|nested] 16+ messages in thread* [PATCH 2/5] ARM: dts: imx7-colibri: fix PMIC voltages
2017-03-29 23:21 ` Stefan Agner
@ 2017-03-29 23:21 ` Stefan Agner
-1 siblings, 0 replies; 16+ messages in thread
From: Stefan Agner @ 2017-03-29 23:21 UTC (permalink / raw)
To: shawnguo, kernel
Cc: fabio.estevam, robh+dt, mark.rutland, linux-arm-kernel,
devicetree, linux-kernel, Stefan Agner
Fix wrong voltage of PWR_EN_+V3.3 rail. The error had no noticeable
effect since no consumer explicitly requested a specific voltage.
Also use round voltages as it is common in other device trees.
Signed-off-by: Stefan Agner <stefan@agner.ch>
---
arch/arm/boot/dts/imx7-colibri.dtsi | 32 ++++++++++++++++----------------
1 file changed, 16 insertions(+), 16 deletions(-)
diff --git a/arch/arm/boot/dts/imx7-colibri.dtsi b/arch/arm/boot/dts/imx7-colibri.dtsi
index a171545478be..47eab920666f 100644
--- a/arch/arm/boot/dts/imx7-colibri.dtsi
+++ b/arch/arm/boot/dts/imx7-colibri.dtsi
@@ -151,29 +151,29 @@
regulators {
reg_DCDC1: DCDC1 { /* V1.0_SOC */
- regulator-min-microvolt = <975000>;
- regulator-max-microvolt = <1125000>;
+ regulator-min-microvolt = <1000000>;
+ regulator-max-microvolt = <1100000>;
regulator-boot-on;
regulator-always-on;
};
reg_DCDC2: DCDC2 { /* V1.1_ARM */
- regulator-min-microvolt = <975000>;
- regulator-max-microvolt = <1125000>;
+ regulator-min-microvolt = <975000>;
+ regulator-max-microvolt = <1100000>;
regulator-boot-on;
regulator-always-on;
};
reg_DCDC3: DCDC3 { /* V1.8 */
- regulator-min-microvolt = <1775000>;
- regulator-max-microvolt = <1825000>;
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <1800000>;
regulator-boot-on;
regulator-always-on;
};
reg_DCDC4: DCDC4 { /* V1.35_DRAM */
- regulator-min-microvolt = <1325000>;
- regulator-max-microvolt = <1375000>;
+ regulator-min-microvolt = <1350000>;
+ regulator-max-microvolt = <1350000>;
regulator-boot-on;
regulator-always-on;
};
@@ -185,29 +185,29 @@
};
reg_LDO2: LDO2 { /* +V1.8_SD */
- regulator-min-microvolt = <1775000>;
- regulator-max-microvolt = <3325000>;
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <3300000>;
regulator-boot-on;
regulator-always-on;
};
reg_LDO3: LDO3 { /* PWR_EN_+V3.3_LPSR */
- regulator-min-microvolt = <3275000>;
- regulator-max-microvolt = <3325000>;
+ regulator-min-microvolt = <3300000>;
+ regulator-max-microvolt = <3300000>;
regulator-boot-on;
regulator-always-on;
};
reg_LDO4: LDO4 { /* V1.8_LPSR */
- regulator-min-microvolt = <1775000>;
- regulator-max-microvolt = <1825000>;
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <1800000>;
regulator-boot-on;
regulator-always-on;
};
reg_LDO5: LDO5 { /* PWR_EN_+V3.3 */
- regulator-min-microvolt = <1775000>;
- regulator-max-microvolt = <1825000>;
+ regulator-min-microvolt = <3300000>;
+ regulator-max-microvolt = <3300000>;
regulator-boot-on;
regulator-always-on;
};
--
2.12.1
^ permalink raw reply related [flat|nested] 16+ messages in thread* [PATCH 2/5] ARM: dts: imx7-colibri: fix PMIC voltages
@ 2017-03-29 23:21 ` Stefan Agner
0 siblings, 0 replies; 16+ messages in thread
From: Stefan Agner @ 2017-03-29 23:21 UTC (permalink / raw)
To: linux-arm-kernel
Fix wrong voltage of PWR_EN_+V3.3 rail. The error had no noticeable
effect since no consumer explicitly requested a specific voltage.
Also use round voltages as it is common in other device trees.
Signed-off-by: Stefan Agner <stefan@agner.ch>
---
arch/arm/boot/dts/imx7-colibri.dtsi | 32 ++++++++++++++++----------------
1 file changed, 16 insertions(+), 16 deletions(-)
diff --git a/arch/arm/boot/dts/imx7-colibri.dtsi b/arch/arm/boot/dts/imx7-colibri.dtsi
index a171545478be..47eab920666f 100644
--- a/arch/arm/boot/dts/imx7-colibri.dtsi
+++ b/arch/arm/boot/dts/imx7-colibri.dtsi
@@ -151,29 +151,29 @@
regulators {
reg_DCDC1: DCDC1 { /* V1.0_SOC */
- regulator-min-microvolt = <975000>;
- regulator-max-microvolt = <1125000>;
+ regulator-min-microvolt = <1000000>;
+ regulator-max-microvolt = <1100000>;
regulator-boot-on;
regulator-always-on;
};
reg_DCDC2: DCDC2 { /* V1.1_ARM */
- regulator-min-microvolt = <975000>;
- regulator-max-microvolt = <1125000>;
+ regulator-min-microvolt = <975000>;
+ regulator-max-microvolt = <1100000>;
regulator-boot-on;
regulator-always-on;
};
reg_DCDC3: DCDC3 { /* V1.8 */
- regulator-min-microvolt = <1775000>;
- regulator-max-microvolt = <1825000>;
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <1800000>;
regulator-boot-on;
regulator-always-on;
};
reg_DCDC4: DCDC4 { /* V1.35_DRAM */
- regulator-min-microvolt = <1325000>;
- regulator-max-microvolt = <1375000>;
+ regulator-min-microvolt = <1350000>;
+ regulator-max-microvolt = <1350000>;
regulator-boot-on;
regulator-always-on;
};
@@ -185,29 +185,29 @@
};
reg_LDO2: LDO2 { /* +V1.8_SD */
- regulator-min-microvolt = <1775000>;
- regulator-max-microvolt = <3325000>;
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <3300000>;
regulator-boot-on;
regulator-always-on;
};
reg_LDO3: LDO3 { /* PWR_EN_+V3.3_LPSR */
- regulator-min-microvolt = <3275000>;
- regulator-max-microvolt = <3325000>;
+ regulator-min-microvolt = <3300000>;
+ regulator-max-microvolt = <3300000>;
regulator-boot-on;
regulator-always-on;
};
reg_LDO4: LDO4 { /* V1.8_LPSR */
- regulator-min-microvolt = <1775000>;
- regulator-max-microvolt = <1825000>;
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <1800000>;
regulator-boot-on;
regulator-always-on;
};
reg_LDO5: LDO5 { /* PWR_EN_+V3.3 */
- regulator-min-microvolt = <1775000>;
- regulator-max-microvolt = <1825000>;
+ regulator-min-microvolt = <3300000>;
+ regulator-max-microvolt = <3300000>;
regulator-boot-on;
regulator-always-on;
};
--
2.12.1
^ permalink raw reply related [flat|nested] 16+ messages in thread
* [PATCH 3/5] ARM: dts: imx7-colibri: allow to disable Ethernet rail
2017-03-29 23:21 ` Stefan Agner
@ 2017-03-29 23:21 ` Stefan Agner
-1 siblings, 0 replies; 16+ messages in thread
From: Stefan Agner @ 2017-03-29 23:21 UTC (permalink / raw)
To: shawnguo, kernel
Cc: fabio.estevam, robh+dt, mark.rutland, linux-arm-kernel,
devicetree, linux-kernel, Stefan Agner
The regulator-always-on property on the Ethernet rail prevents Linux
from disabling the rail when Ethernet is shut down (suspend or simply
link down). With this change the regulator framework will disable the
rail when the Ethernet PHY is not used, saving power especially on
carrier board not using Ethernet.
Signed-off-by: Stefan Agner <stefan@agner.ch>
---
arch/arm/boot/dts/imx7-colibri.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/imx7-colibri.dtsi b/arch/arm/boot/dts/imx7-colibri.dtsi
index 47eab920666f..cbcab937b905 100644
--- a/arch/arm/boot/dts/imx7-colibri.dtsi
+++ b/arch/arm/boot/dts/imx7-colibri.dtsi
@@ -181,7 +181,7 @@
reg_LDO1: LDO1 { /* PWR_EN_+V3.3_ETH */
regulator-min-microvolt = <1800000>;
regulator-max-microvolt = <3300000>;
- regulator-always-on;
+ regulator-boot-on;
};
reg_LDO2: LDO2 { /* +V1.8_SD */
--
2.12.1
^ permalink raw reply related [flat|nested] 16+ messages in thread* [PATCH 3/5] ARM: dts: imx7-colibri: allow to disable Ethernet rail
@ 2017-03-29 23:21 ` Stefan Agner
0 siblings, 0 replies; 16+ messages in thread
From: Stefan Agner @ 2017-03-29 23:21 UTC (permalink / raw)
To: linux-arm-kernel
The regulator-always-on property on the Ethernet rail prevents Linux
from disabling the rail when Ethernet is shut down (suspend or simply
link down). With this change the regulator framework will disable the
rail when the Ethernet PHY is not used, saving power especially on
carrier board not using Ethernet.
Signed-off-by: Stefan Agner <stefan@agner.ch>
---
arch/arm/boot/dts/imx7-colibri.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/imx7-colibri.dtsi b/arch/arm/boot/dts/imx7-colibri.dtsi
index 47eab920666f..cbcab937b905 100644
--- a/arch/arm/boot/dts/imx7-colibri.dtsi
+++ b/arch/arm/boot/dts/imx7-colibri.dtsi
@@ -181,7 +181,7 @@
reg_LDO1: LDO1 { /* PWR_EN_+V3.3_ETH */
regulator-min-microvolt = <1800000>;
regulator-max-microvolt = <3300000>;
- regulator-always-on;
+ regulator-boot-on;
};
reg_LDO2: LDO2 { /* +V1.8_SD */
--
2.12.1
^ permalink raw reply related [flat|nested] 16+ messages in thread
* [PATCH 4/5] ARM: dts: imx7-colibri: remove 1.8V fixed regulator
2017-03-29 23:21 ` Stefan Agner
@ 2017-03-29 23:21 ` Stefan Agner
-1 siblings, 0 replies; 16+ messages in thread
From: Stefan Agner @ 2017-03-29 23:21 UTC (permalink / raw)
To: shawnguo, kernel
Cc: fabio.estevam, robh+dt, mark.rutland, linux-arm-kernel,
devicetree, linux-kernel, Stefan Agner
The ADC is directly supplied by the PMIC 1.8V rail, remove the
superfluous fixed regulator.
Signed-off-by: Stefan Agner <stefan@agner.ch>
---
arch/arm/boot/dts/imx7-colibri.dtsi | 11 ++---------
1 file changed, 2 insertions(+), 9 deletions(-)
diff --git a/arch/arm/boot/dts/imx7-colibri.dtsi b/arch/arm/boot/dts/imx7-colibri.dtsi
index cbcab937b905..2d87489f9105 100644
--- a/arch/arm/boot/dts/imx7-colibri.dtsi
+++ b/arch/arm/boot/dts/imx7-colibri.dtsi
@@ -60,13 +60,6 @@
regulator-max-microvolt = <3300000>;
};
- reg_vref_1v8: regulator-vref-1v8 {
- compatible = "regulator-fixed";
- regulator-name = "vref-1v8";
- regulator-min-microvolt = <1800000>;
- regulator-max-microvolt = <1800000>;
- };
-
sound {
compatible = "simple-audio-card";
simple-audio-card,name = "imx7-sgtl5000";
@@ -85,11 +78,11 @@
};
&adc1 {
- vref-supply = <®_vref_1v8>;
+ vref-supply = <®_DCDC3>;
};
&adc2 {
- vref-supply = <®_vref_1v8>;
+ vref-supply = <®_DCDC3>;
};
&cpu0 {
--
2.12.1
^ permalink raw reply related [flat|nested] 16+ messages in thread* [PATCH 4/5] ARM: dts: imx7-colibri: remove 1.8V fixed regulator
@ 2017-03-29 23:21 ` Stefan Agner
0 siblings, 0 replies; 16+ messages in thread
From: Stefan Agner @ 2017-03-29 23:21 UTC (permalink / raw)
To: linux-arm-kernel
The ADC is directly supplied by the PMIC 1.8V rail, remove the
superfluous fixed regulator.
Signed-off-by: Stefan Agner <stefan@agner.ch>
---
arch/arm/boot/dts/imx7-colibri.dtsi | 11 ++---------
1 file changed, 2 insertions(+), 9 deletions(-)
diff --git a/arch/arm/boot/dts/imx7-colibri.dtsi b/arch/arm/boot/dts/imx7-colibri.dtsi
index cbcab937b905..2d87489f9105 100644
--- a/arch/arm/boot/dts/imx7-colibri.dtsi
+++ b/arch/arm/boot/dts/imx7-colibri.dtsi
@@ -60,13 +60,6 @@
regulator-max-microvolt = <3300000>;
};
- reg_vref_1v8: regulator-vref-1v8 {
- compatible = "regulator-fixed";
- regulator-name = "vref-1v8";
- regulator-min-microvolt = <1800000>;
- regulator-max-microvolt = <1800000>;
- };
-
sound {
compatible = "simple-audio-card";
simple-audio-card,name = "imx7-sgtl5000";
@@ -85,11 +78,11 @@
};
&adc1 {
- vref-supply = <®_vref_1v8>;
+ vref-supply = <®_DCDC3>;
};
&adc2 {
- vref-supply = <®_vref_1v8>;
+ vref-supply = <®_DCDC3>;
};
&cpu0 {
--
2.12.1
^ permalink raw reply related [flat|nested] 16+ messages in thread
* [PATCH 5/5] ARM: dts: imx7-colibri: add Carrier Board 3.3V/5V regulators
2017-03-29 23:21 ` Stefan Agner
@ 2017-03-29 23:21 ` Stefan Agner
-1 siblings, 0 replies; 16+ messages in thread
From: Stefan Agner @ 2017-03-29 23:21 UTC (permalink / raw)
To: shawnguo, kernel
Cc: fabio.estevam, robh+dt, mark.rutland, linux-arm-kernel,
devicetree, linux-kernel, Stefan Agner
Model the Carrier Board power distribution by adding a fixed 3.3V
and 5V regulator. The 3.3V regulator is connected to the backlight
as well as the display supply. The 5V regulator is used to supply
USB VBUS.
Signed-off-by: Stefan Agner <stefan@agner.ch>
---
arch/arm/boot/dts/imx7-colibri-eval-v3.dtsi | 17 +++++++++++++++++
arch/arm/boot/dts/imx7d-colibri-eval-v3.dts | 1 +
2 files changed, 18 insertions(+)
diff --git a/arch/arm/boot/dts/imx7-colibri-eval-v3.dtsi b/arch/arm/boot/dts/imx7-colibri-eval-v3.dtsi
index 7a98a45a0d95..18bebd6d8d47 100644
--- a/arch/arm/boot/dts/imx7-colibri-eval-v3.dtsi
+++ b/arch/arm/boot/dts/imx7-colibri-eval-v3.dtsi
@@ -48,6 +48,7 @@
panel: panel {
compatible = "edt,et057090dhu";
backlight = <&bl>;
+ power-supply = <®_3v3>;
port {
panel_in: endpoint {
@@ -55,11 +56,27 @@
};
};
};
+
+ reg_3v3: regulator-3v3 {
+ compatible = "regulator-fixed";
+ regulator-name = "3.3V";
+ regulator-min-microvolt = <3300000>;
+ regulator-max-microvolt = <3300000>;
+ };
+
+ reg_5v0: regulator-5v0 {
+ compatible = "regulator-fixed";
+ regulator-name = "5V";
+ regulator-min-microvolt = <5000000>;
+ regulator-max-microvolt = <5000000>;
+ };
};
&bl {
brightness-levels = <0 4 8 16 32 64 128 255>;
default-brightness-level = <6>;
+ power-supply = <®_3v3>;
+
status = "okay";
};
diff --git a/arch/arm/boot/dts/imx7d-colibri-eval-v3.dts b/arch/arm/boot/dts/imx7d-colibri-eval-v3.dts
index bd01d2cc642d..a608a14d8c85 100644
--- a/arch/arm/boot/dts/imx7d-colibri-eval-v3.dts
+++ b/arch/arm/boot/dts/imx7d-colibri-eval-v3.dts
@@ -57,6 +57,7 @@
regulator-min-microvolt = <5000000>;
regulator-max-microvolt = <5000000>;
gpio = <&gpio4 7 GPIO_ACTIVE_LOW>;
+ vin-supply = <®_5v0>;
};
};
--
2.12.1
^ permalink raw reply related [flat|nested] 16+ messages in thread* [PATCH 5/5] ARM: dts: imx7-colibri: add Carrier Board 3.3V/5V regulators
@ 2017-03-29 23:21 ` Stefan Agner
0 siblings, 0 replies; 16+ messages in thread
From: Stefan Agner @ 2017-03-29 23:21 UTC (permalink / raw)
To: linux-arm-kernel
Model the Carrier Board power distribution by adding a fixed 3.3V
and 5V regulator. The 3.3V regulator is connected to the backlight
as well as the display supply. The 5V regulator is used to supply
USB VBUS.
Signed-off-by: Stefan Agner <stefan@agner.ch>
---
arch/arm/boot/dts/imx7-colibri-eval-v3.dtsi | 17 +++++++++++++++++
arch/arm/boot/dts/imx7d-colibri-eval-v3.dts | 1 +
2 files changed, 18 insertions(+)
diff --git a/arch/arm/boot/dts/imx7-colibri-eval-v3.dtsi b/arch/arm/boot/dts/imx7-colibri-eval-v3.dtsi
index 7a98a45a0d95..18bebd6d8d47 100644
--- a/arch/arm/boot/dts/imx7-colibri-eval-v3.dtsi
+++ b/arch/arm/boot/dts/imx7-colibri-eval-v3.dtsi
@@ -48,6 +48,7 @@
panel: panel {
compatible = "edt,et057090dhu";
backlight = <&bl>;
+ power-supply = <®_3v3>;
port {
panel_in: endpoint {
@@ -55,11 +56,27 @@
};
};
};
+
+ reg_3v3: regulator-3v3 {
+ compatible = "regulator-fixed";
+ regulator-name = "3.3V";
+ regulator-min-microvolt = <3300000>;
+ regulator-max-microvolt = <3300000>;
+ };
+
+ reg_5v0: regulator-5v0 {
+ compatible = "regulator-fixed";
+ regulator-name = "5V";
+ regulator-min-microvolt = <5000000>;
+ regulator-max-microvolt = <5000000>;
+ };
};
&bl {
brightness-levels = <0 4 8 16 32 64 128 255>;
default-brightness-level = <6>;
+ power-supply = <®_3v3>;
+
status = "okay";
};
diff --git a/arch/arm/boot/dts/imx7d-colibri-eval-v3.dts b/arch/arm/boot/dts/imx7d-colibri-eval-v3.dts
index bd01d2cc642d..a608a14d8c85 100644
--- a/arch/arm/boot/dts/imx7d-colibri-eval-v3.dts
+++ b/arch/arm/boot/dts/imx7d-colibri-eval-v3.dts
@@ -57,6 +57,7 @@
regulator-min-microvolt = <5000000>;
regulator-max-microvolt = <5000000>;
gpio = <&gpio4 7 GPIO_ACTIVE_LOW>;
+ vin-supply = <®_5v0>;
};
};
--
2.12.1
^ permalink raw reply related [flat|nested] 16+ messages in thread
* Re: [PATCH 1/5] ARM: dts: imx7-colibri: use OF graph to describe the display
2017-03-29 23:21 ` Stefan Agner
@ 2017-03-30 13:16 ` Shawn Guo
-1 siblings, 0 replies; 16+ messages in thread
From: Shawn Guo @ 2017-03-30 13:16 UTC (permalink / raw)
To: Stefan Agner
Cc: kernel, fabio.estevam, robh+dt, mark.rutland, linux-arm-kernel,
devicetree, linux-kernel
On Wed, Mar 29, 2017 at 04:21:09PM -0700, Stefan Agner wrote:
> To make use of the new eLCDIF DRM driver OF graph description is
> required. Describe the display using OF graph nodes.
>
> Signed-off-by: Stefan Agner <stefan@agner.ch>
Applied all, thanks.
^ permalink raw reply [flat|nested] 16+ messages in thread
* [PATCH 1/5] ARM: dts: imx7-colibri: use OF graph to describe the display
@ 2017-03-30 13:16 ` Shawn Guo
0 siblings, 0 replies; 16+ messages in thread
From: Shawn Guo @ 2017-03-30 13:16 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, Mar 29, 2017 at 04:21:09PM -0700, Stefan Agner wrote:
> To make use of the new eLCDIF DRM driver OF graph description is
> required. Describe the display using OF graph nodes.
>
> Signed-off-by: Stefan Agner <stefan@agner.ch>
Applied all, thanks.
^ permalink raw reply [flat|nested] 16+ messages in thread
* [PATCH 1/5] ARM: dts: imx7-colibri: use OF graph to describe the display
2017-03-29 23:21 ` Stefan Agner
` (5 preceding siblings ...)
(?)
@ 2017-05-05 11:48 ` Fabio Estevam
2017-05-05 13:18 ` Fabio Estevam
-1 siblings, 1 reply; 16+ messages in thread
From: Fabio Estevam @ 2017-05-05 11:48 UTC (permalink / raw)
To: linux-arm-kernel
Hi Stefan,
On Wed, Mar 29, 2017 at 8:21 PM, Stefan Agner <stefan@agner.ch> wrote:
> To make use of the new eLCDIF DRM driver OF graph description is
> required. Describe the display using OF graph nodes.
>
> Signed-off-by: Stefan Agner <stefan@agner.ch>
Could you please confirm that drm/mxsfb is working fine on 4.11 on your board?
I am converting mx6sx sdb to use drm/mxsfb and I noticed that when
board boots I get garbage on the display.
If I do a blank/unblank then things are displayed correctly.
Thanks
^ permalink raw reply [flat|nested] 16+ messages in thread* [PATCH 1/5] ARM: dts: imx7-colibri: use OF graph to describe the display
2017-05-05 11:48 ` Fabio Estevam
@ 2017-05-05 13:18 ` Fabio Estevam
2017-05-05 23:52 ` Stefan Agner
0 siblings, 1 reply; 16+ messages in thread
From: Fabio Estevam @ 2017-05-05 13:18 UTC (permalink / raw)
To: linux-arm-kernel
On Fri, May 5, 2017 at 8:48 AM, Fabio Estevam <festevam@gmail.com> wrote:
> Could you please confirm that drm/mxsfb is working fine on 4.11 on your board?
>
> I am converting mx6sx sdb to use drm/mxsfb and I noticed that when
> board boots I get garbage on the display.
>
> If I do a blank/unblank then things are displayed correctly.
Ok, I managed to fix the drm/mxsfb driver.
Will submit a patch shortly.
^ permalink raw reply [flat|nested] 16+ messages in thread
* [PATCH 1/5] ARM: dts: imx7-colibri: use OF graph to describe the display
2017-05-05 13:18 ` Fabio Estevam
@ 2017-05-05 23:52 ` Stefan Agner
2017-05-06 0:15 ` Marek Vasut
0 siblings, 1 reply; 16+ messages in thread
From: Stefan Agner @ 2017-05-05 23:52 UTC (permalink / raw)
To: linux-arm-kernel
On 2017-05-05 06:18, Fabio Estevam wrote:
> On Fri, May 5, 2017 at 8:48 AM, Fabio Estevam <festevam@gmail.com> wrote:
>
>> Could you please confirm that drm/mxsfb is working fine on 4.11 on your board?
>>
>> I am converting mx6sx sdb to use drm/mxsfb and I noticed that when
>> board boots I get garbage on the display.
>>
>> If I do a blank/unblank then things are displayed correctly.
>
> Ok, I managed to fix the drm/mxsfb driver.
>
> Will submit a patch shortly.
FWIW, it works, on i.MX 7 here, but I also have a U-Boot which
initialized eLCDIF first.
Will check your patch and without U-Boot eLCDIF support.
--
Stefan
^ permalink raw reply [flat|nested] 16+ messages in thread
* [PATCH 1/5] ARM: dts: imx7-colibri: use OF graph to describe the display
2017-05-05 23:52 ` Stefan Agner
@ 2017-05-06 0:15 ` Marek Vasut
0 siblings, 0 replies; 16+ messages in thread
From: Marek Vasut @ 2017-05-06 0:15 UTC (permalink / raw)
To: linux-arm-kernel
On 05/06/2017 01:52 AM, Stefan Agner wrote:
> On 2017-05-05 06:18, Fabio Estevam wrote:
>> On Fri, May 5, 2017 at 8:48 AM, Fabio Estevam <festevam@gmail.com> wrote:
>>
>>> Could you please confirm that drm/mxsfb is working fine on 4.11 on your board?
>>>
>>> I am converting mx6sx sdb to use drm/mxsfb and I noticed that when
>>> board boots I get garbage on the display.
>>>
>>> If I do a blank/unblank then things are displayed correctly.
>>
>> Ok, I managed to fix the drm/mxsfb driver.
>>
>> Will submit a patch shortly.
>
> FWIW, it works, on i.MX 7 here, but I also have a U-Boot which
> initialized eLCDIF first.
>
> Will check your patch and without U-Boot eLCDIF support.
Same thing here, I had U-Boot which inited the eLCDIF too and disabling
that triggered this issue on MX6SX as well. Then again, the original
patch I sent Fabio fixed it for me too:
diff --git a/drivers/gpu/drm/mxsfb/mxsfb_crtc.c
b/drivers/gpu/drm/mxsfb/mxsfb_crtc.c
index 6d701d2c362d..f02d23d55995 100644
--- a/drivers/gpu/drm/mxsfb/mxsfb_crtc.c
+++ b/drivers/gpu/drm/mxsfb/mxsfb_crtc.c
@@ -84,6 +84,8 @@ static int mxsfb_set_pixel_fmt(struct
mxsfb_drm_private *mxsfb)
writel(ctrl1, mxsfb->base + LCDC_CTRL1);
writel(ctrl, mxsfb->base + LCDC_CTRL);
+ writel(ctrl1, mxsfb->base + LCDC_CTRL1);
+ writel(ctrl, mxsfb->base + LCDC_CTRL);
return 0;
}
--
Best regards,
Marek Vasut
^ permalink raw reply related [flat|nested] 16+ messages in thread