[PATCH 1/2] ARM: dts: imx23-sansa: Remove 'enable-active-low' property

[PATCH 1/2] ARM: dts: imx23-sansa: Remove 'enable-active-low' property

[Fabio Estevam]

Property 'enable-active-low' does not exist. Only 'enable-active-high' is
valid, and when this property is absent the gpio regulator will act as
active low by default.

So remove the unexisting 'enable-active-low' property. 

While at it, in order to make the gpio regulator description clearer pass
the GPIO_ACTIVE_LOW flag.

Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
---
 arch/arm/boot/dts/imx23-sansa.dts | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/arch/arm/boot/dts/imx23-sansa.dts b/arch/arm/boot/dts/imx23-sansa.dts
index 4ec32f4..221fd55 100644
--- a/arch/arm/boot/dts/imx23-sansa.dts
+++ b/arch/arm/boot/dts/imx23-sansa.dts
@@ -42,6 +42,7 @@
  */
 
 /dts-v1/;
+#include <dt-bindings/gpio/gpio.h>
 #include "imx23.dtsi"
 
 / {
@@ -149,9 +150,8 @@
 		regulator-name = "vdd-touchpad0";
 		regulator-min-microvolt = <3300000>;
 		regulator-max-microvolt = <3300000>;
-		gpio = <&gpio0 26 0>;
+		gpio = <&gpio0 26 GPIO_ACTIVE_LOW>;
 		regulator-always-on;
-		enable-active-low;
 	};
 
 	reg_vdd_tuner: regulator-vdd-tuner0 {
@@ -159,9 +159,8 @@
 		regulator-name = "vdd-tuner0";
 		regulator-min-microvolt = <3300000>;
 		regulator-max-microvolt = <3300000>;
-		gpio = <&gpio0 29 0>;
+		gpio = <&gpio0 29 GPIO_ACTIVE_LOW>;
 		regulator-always-on;
-		enable-active-low;
 	};
 
 	backlight {
-- 
2.7.4

[PATCH 2/2] ARM: dts: tx6: Remove 'enable-active-low' property

[Fabio Estevam]

Property 'enable-active-low' does not exist. Only 'enable-active-high' is
valid, and when this property is absent the gpio regulator will act as
active low by default.

So remove the unexisting 'enable-active-low' property. 

While at it in order to make the gpio regulator description clearer pass
the GPIO_ACTIVE_LOW flag.

Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
---
 arch/arm/boot/dts/imx6qdl-tx6.dtsi  | 3 +--
 arch/arm/boot/dts/imx6ul-tx6ul.dtsi | 3 +--
 2 files changed, 2 insertions(+), 4 deletions(-)

diff --git a/arch/arm/boot/dts/imx6qdl-tx6.dtsi b/arch/arm/boot/dts/imx6qdl-tx6.dtsi
index 1691714..a146fe7 100644
--- a/arch/arm/boot/dts/imx6qdl-tx6.dtsi
+++ b/arch/arm/boot/dts/imx6qdl-tx6.dtsi
@@ -133,8 +133,7 @@
 		regulator-max-microvolt = <3300000>;
 		pinctrl-names = "default";
 		pinctrl-0 = <&pinctrl_flexcan_xcvr>;
-		gpio = <&gpio4 21 GPIO_ACTIVE_HIGH>;
-		enable-active-low;
+		gpio = <&gpio4 21 GPIO_ACTIVE_LOW>;
 	};
 
 	reg_lcd0_pwr: regulator-lcd0-pwr {
diff --git a/arch/arm/boot/dts/imx6ul-tx6ul.dtsi b/arch/arm/boot/dts/imx6ul-tx6ul.dtsi
index c784a0b..4ccc9e9 100644
--- a/arch/arm/boot/dts/imx6ul-tx6ul.dtsi
+++ b/arch/arm/boot/dts/imx6ul-tx6ul.dtsi
@@ -173,8 +173,7 @@
 		regulator-max-microvolt = <3300000>;
 		pinctrl-names = "default";
 		pinctrl-0 = <&pinctrl_flexcan_xcvr>;
-		gpio = <&gpio3 5 GPIO_ACTIVE_HIGH>;
-		enable-active-low;
+		gpio = <&gpio3 5 GPIO_ACTIVE_LOW>;
 	};
 
 	reg_lcd_pwr: regulator-lcdpwr {
-- 
2.7.4

[PATCH 1/2] ARM: dts: imx23-sansa: Remove 'enable-active-low' property

[Stefan Wahren]

Hi Fabio,

> Fabio Estevam <fabio.estevam@nxp.com> hat am 17. Mai 2017 um 18:43 geschrieben:
> 
> 
> Property 'enable-active-low' does not exist. Only 'enable-active-high' is
> valid, and when this property is absent the gpio regulator will act as
> active low by default.
> 
> So remove the unexisting 'enable-active-low' property. 
> 
> While at it, in order to make the gpio regulator description clearer pass
> the GPIO_ACTIVE_LOW flag.
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
> ---
>  arch/arm/boot/dts/imx23-sansa.dts | 7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/imx23-sansa.dts b/arch/arm/boot/dts/imx23-sansa.dts
> index 4ec32f4..221fd55 100644
> --- a/arch/arm/boot/dts/imx23-sansa.dts
> +++ b/arch/arm/boot/dts/imx23-sansa.dts
> @@ -42,6 +42,7 @@
>   */
>  
>  /dts-v1/;
> +#include <dt-bindings/gpio/gpio.h>
>  #include "imx23.dtsi"
>  
>  / {
> @@ -149,9 +150,8 @@
>  		regulator-name = "vdd-touchpad0";
>  		regulator-min-microvolt = <3300000>;
>  		regulator-max-microvolt = <3300000>;
> -		gpio = <&gpio0 26 0>;
> +		gpio = <&gpio0 26 GPIO_ACTIVE_LOW>;

GPIO_ACTIVE_LOW = 1, GPIO_ACTIVE_HIGH = 0

So this doesn't look save to me.

Stefan

>  		regulator-always-on;
> -		enable-active-low;
>  	};
>  
>  	reg_vdd_tuner: regulator-vdd-tuner0 {
> @@ -159,9 +159,8 @@
>  		regulator-name = "vdd-tuner0";
>  		regulator-min-microvolt = <3300000>;
>  		regulator-max-microvolt = <3300000>;
> -		gpio = <&gpio0 29 0>;
> +		gpio = <&gpio0 29 GPIO_ACTIVE_LOW>;
>  		regulator-always-on;
> -		enable-active-low;
>  	};
>  
>  	backlight {
> -- 
> 2.7.4
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

[PATCH 1/2] ARM: dts: imx23-sansa: Remove 'enable-active-low' property

[Fabio Estevam]

Hi Stefan,

On Wed, May 17, 2017 at 1:59 PM, Stefan Wahren <stefan.wahren@i2se.com> wrote:

> GPIO_ACTIVE_LOW = 1, GPIO_ACTIVE_HIGH = 0

Correct.

> So this doesn't look save to me.

gpio regulator driver does not look for the gpio flag field, so this
change is safe.

That's the reason there is a property called 'enable-active-high'.

When 'enable-active-high' is passed the gpio regulator is active high.
If the property is absent then it is active low.

This is explained in
Documentation/devicetree/bindings/regulator/fixed-regulator.txt

Passing GPIO_ACTIVE_LOW describes the gpio regulator correctly in this case.

[PATCH 1/2] ARM: dts: imx23-sansa: Remove 'enable-active-low' property

[Stefan Wahren]

> Fabio Estevam <festevam@gmail.com> hat am 17. Mai 2017 um 19:06 geschrieben:
> 
> 
> Hi Stefan,
> 
> On Wed, May 17, 2017 at 1:59 PM, Stefan Wahren <stefan.wahren@i2se.com> wrote:
> 
> > GPIO_ACTIVE_LOW = 1, GPIO_ACTIVE_HIGH = 0
> 
> Correct.
> 
> > So this doesn't look save to me.
> 
> gpio regulator driver does not look for the gpio flag field, so this
> change is safe.
> 
> That's the reason there is a property called 'enable-active-high'.
> 
> When 'enable-active-high' is passed the gpio regulator is active high.
> If the property is absent then it is active low.
> 
> This is explained in
> Documentation/devicetree/bindings/regulator/fixed-regulator.txt
> 
> Passing GPIO_ACTIVE_LOW describes the gpio regulator correctly in this case.
> 

Thanks for this explanation, this wasn't clear to me from the subject / commit log.

[PATCH 1/2] ARM: dts: imx23-sansa: Remove 'enable-active-low' property

[Fabio Estevam]

Hi Stefan,

On Wed, May 17, 2017 at 2:52 PM, Stefan Wahren <stefan.wahren@i2se.com> wrote:

> Thanks for this explanation, this wasn't clear to me from the subject / commit log.

I have sent a v2, where I try to make this clear. Thanks for your feedback.

[PATCH 1/2] ARM: dts: imx23-sansa: Remove 'enable-active-low' property

[Stefan Wahren]

Am 24.05.2017 um 13:55 schrieb Fabio Estevam:
> Hi Stefan,
>
> On Wed, May 17, 2017 at 2:52 PM, Stefan Wahren <stefan.wahren@i2se.com> wrote:
>
>> Thanks for this explanation, this wasn't clear to me from the subject / commit log.
> I have sent a v2, where I try to make this clear. Thanks for your feedback.
>

Looks good to me. Unfortunately i don't a board to test it.

Stefan