[PATCH 1/4] imx25pdk: Add wic option to not update fstab

[PATCH 1/4] imx25pdk: Add wic option to not update fstab

[Fabio Berton]

Signed-off-by: Fabio Berton <fabio.berton@ossystems.com.br>
---
 conf/machine/imx25pdk.conf | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/conf/machine/imx25pdk.conf b/conf/machine/imx25pdk.conf
index e22d9f4e..bd7ae0ee 100644
--- a/conf/machine/imx25pdk.conf
+++ b/conf/machine/imx25pdk.conf
@@ -18,6 +18,10 @@ SERIAL_CONSOLE = "115200 ttymxc0"
 MACHINE_FEATURES = "usbgadget usbhost vfat alsa touchscreen"
 
 WKS_FILE = "imx-uboot.wks"
+
+# Do not update fstab file when using wic images
+WIC_CREATE_EXTRA_ARGS_append = " --no-fstab-update"
+
 MACHINE_ESSENTIAL_EXTRA_RDEPENDS += " \
     kernel-image \
     kernel-devicetree \
-- 
2.14.2

[PATCH 2/4] imx6qdlsabreauto: Add wic option to not update fstab

[Fabio Berton]

Signed-off-by: Fabio Berton <fabio.berton@ossystems.com.br>
---
 conf/machine/imx6qdlsabreauto.conf | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/conf/machine/imx6qdlsabreauto.conf b/conf/machine/imx6qdlsabreauto.conf
index fabd4cd0..79aca7cb 100644
--- a/conf/machine/imx6qdlsabreauto.conf
+++ b/conf/machine/imx6qdlsabreauto.conf
@@ -38,6 +38,9 @@ UBOOT_SUFFIX = "img"
 SPL_BINARY = "SPL"
 WKS_FILE = "imx-uboot-spl-bootpart.wks"
 
+# Do not update fstab file when using wic images
+WIC_CREATE_EXTRA_ARGS_append = " --no-fstab-update"
+
 SERIAL_CONSOLE = "115200 ttymxc3"
 
 MACHINE_FIRMWARE_append_mx6 = " linux-firmware-ath6k"
-- 
2.14.2

[PATCH 3/4] imx6qdlsabresd: Add wic option to not update fstab

[Fabio Berton]

Signed-off-by: Fabio Berton <fabio.berton@ossystems.com.br>
---
 conf/machine/imx6qdlsabresd.conf | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/conf/machine/imx6qdlsabresd.conf b/conf/machine/imx6qdlsabresd.conf
index 7cde5059..fc281bd6 100644
--- a/conf/machine/imx6qdlsabresd.conf
+++ b/conf/machine/imx6qdlsabresd.conf
@@ -38,6 +38,9 @@ UBOOT_SUFFIX = "img"
 SPL_BINARY = "SPL"
 WKS_FILE = "imx-uboot-spl-bootpart.wks"
 
+# Do not update fstab file when using wic images
+WIC_CREATE_EXTRA_ARGS_append = " --no-fstab-update"
+
 SERIAL_CONSOLE = "115200 ttymxc0"
 
 MACHINE_FIRMWARE_append_mx6 = " linux-firmware-ath6k"
-- 
2.14.2

[PATCH 4/4] imx6ulevk: Add wic option to not update fstab

[Fabio Berton]

Signed-off-by: Fabio Berton <fabio.berton@ossystems.com.br>
---
 conf/machine/imx6ulevk.conf | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/conf/machine/imx6ulevk.conf b/conf/machine/imx6ulevk.conf
index 14f83828..d3c40e69 100644
--- a/conf/machine/imx6ulevk.conf
+++ b/conf/machine/imx6ulevk.conf
@@ -25,3 +25,6 @@ UBOOT_CONFIG[emmc] = "mx6ul_14x14_evk_emmc_config,sdcard"
 UBOOT_CONFIG[qspi1] = "mx6ul_14x14_evk_qspi1_config"
 UBOOT_CONFIG[mfgtool] = "mx6ul_14x14_evk_config"
 WKS_FILE = "imx-uboot-spl-bootpart.wks"
+
+# Do not update fstab file when using wic images
+WIC_CREATE_EXTRA_ARGS_append = " --no-fstab-update"
-- 
2.14.2

Re: [PATCH 1/4] imx25pdk: Add wic option to not update fstab

[Theodore A. Roth]

On Tue, Feb 27, 2018 at 1:40 PM, Fabio Berton
<fabio.berton@ossystems.com.br> wrote:
> Signed-off-by: Fabio Berton <fabio.berton@ossystems.com.br>
> ---
>  conf/machine/imx25pdk.conf | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/conf/machine/imx25pdk.conf b/conf/machine/imx25pdk.conf
> index e22d9f4e..bd7ae0ee 100644
> --- a/conf/machine/imx25pdk.conf
> +++ b/conf/machine/imx25pdk.conf
> @@ -18,6 +18,10 @@ SERIAL_CONSOLE = "115200 ttymxc0"
>  MACHINE_FEATURES = "usbgadget usbhost vfat alsa touchscreen"
>
>  WKS_FILE = "imx-uboot.wks"
> +
> +# Do not update fstab file when using wic images
> +WIC_CREATE_EXTRA_ARGS_append = " --no-fstab-update"
> +
>  MACHINE_ESSENTIAL_EXTRA_RDEPENDS += " \
>      kernel-image \
>      kernel-devicetree \
> --
> 2.14.2
>
> --

Fabio,

Should this sort of patch also be applied to the
'conf/machine/include/imx-base.inc' in meta-freescale? I got bit by
this a couple of weeks ago on an 'imx7dsabresd' machine build using
systemd which would not boot and I did not see anything in your patch
set that touched on that.

Thanks.

Ted Roth

Re: [PATCH 1/4] imx25pdk: Add wic option to not update fstab

[Fabio Estevam]

Hi Fabio,

On Tue, Feb 27, 2018 at 5:40 PM, Fabio Berton
<fabio.berton@ossystems.com.br> wrote:
> Signed-off-by: Fabio Berton <fabio.berton@ossystems.com.br>

Please add a commit log explaining why this patch is needed.

Re: [PATCH 1/4] imx25pdk: Add wic option to not update fstab

[Fabio Berton]

[-- Attachment #1: Type: text/plain, Size: 1353 bytes --]

Hi Theodore,

I'll look to add this to imx-base.inc

Thanks!

On Wed, Feb 28, 2018 at 9:04 AM, Theodore A. Roth <troth@openavr.org> wrote:

> On Tue, Feb 27, 2018 at 1:40 PM, Fabio Berton
> <fabio.berton@ossystems.com.br> wrote:
> > Signed-off-by: Fabio Berton <fabio.berton@ossystems.com.br>
> > ---
> >  conf/machine/imx25pdk.conf | 4 ++++
> >  1 file changed, 4 insertions(+)
> >
> > diff --git a/conf/machine/imx25pdk.conf b/conf/machine/imx25pdk.conf
> > index e22d9f4e..bd7ae0ee 100644
> > --- a/conf/machine/imx25pdk.conf
> > +++ b/conf/machine/imx25pdk.conf
> > @@ -18,6 +18,10 @@ SERIAL_CONSOLE = "115200 ttymxc0"
> >  MACHINE_FEATURES = "usbgadget usbhost vfat alsa touchscreen"
> >
> >  WKS_FILE = "imx-uboot.wks"
> > +
> > +# Do not update fstab file when using wic images
> > +WIC_CREATE_EXTRA_ARGS_append = " --no-fstab-update"
> > +
> >  MACHINE_ESSENTIAL_EXTRA_RDEPENDS += " \
> >      kernel-image \
> >      kernel-devicetree \
> > --
> > 2.14.2
> >
> > --
>
> Fabio,
>
> Should this sort of patch also be applied to the
> 'conf/machine/include/imx-base.inc' in meta-freescale? I got bit by
> this a couple of weeks ago on an 'imx7dsabresd' machine build using
> systemd which would not boot and I did not see anything in your patch
> set that touched on that.
>
> Thanks.
>
> Ted Roth
>

[-- Attachment #2: Type: text/html, Size: 2493 bytes --]

Re: [PATCH 1/4] imx25pdk: Add wic option to not update fstab

[Fabio Berton]

[-- Attachment #1: Type: text/plain, Size: 379 bytes --]

Hi Fabio!

Ok, I'll explain in commit log.

Thanks!

On Wed, Feb 28, 2018 at 9:26 AM, Fabio Estevam <festevam@gmail.com> wrote:

> Hi Fabio,
>
> On Tue, Feb 27, 2018 at 5:40 PM, Fabio Berton
> <fabio.berton@ossystems.com.br> wrote:
> > Signed-off-by: Fabio Berton <fabio.berton@ossystems.com.br>
>
> Please add a commit log explaining why this patch is needed.
>

[-- Attachment #2: Type: text/html, Size: 1279 bytes --]