* [U-Boot] [PATCH] tools/imximage: fix reported DCD information for MX7ULP
@ 2019-11-28 10:33 Jorge Ramirez-Ortiz
2019-12-02 9:44 ` Jorge
2019-12-02 13:42 ` Fabio Estevam
0 siblings, 2 replies; 5+ messages in thread
From: Jorge Ramirez-Ortiz @ 2019-11-28 10:33 UTC (permalink / raw)
To: u-boot
On the MX7ULP, OCRAM for DCD is at 0x2f010000
Signed-off-by: Jorge Ramirez-Ortiz <jorge@foundries.io>
---
tools/imximage.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/tools/imximage.c b/tools/imximage.c
index d7c0b6e883..762a06d468 100644
--- a/tools/imximage.c
+++ b/tools/imximage.c
@@ -11,6 +11,7 @@
#include "imagetool.h"
#include <image.h>
#include "imximage.h"
+#include <generated/autoconf.h>
#define UNDEFINED 0xFFFFFFFF
@@ -524,8 +525,13 @@ static void print_hdr_v2(struct imx_header *imx_hdr)
printf("HAB Blocks: 0x%08x 0x%08x 0x%08x\n",
(uint32_t)fhdr_v2->self, 0,
(uint32_t)(fhdr_v2->csf - fhdr_v2->self));
+#ifndef CONFIG_MX7ULP
printf("DCD Blocks: 0x00910000 0x%08x 0x%08x\n",
offs, be16_to_cpu(dcdlen));
+#else
+ printf("DCD Blocks: 0x2f010000 0x%08x 0x%08x\n",
+ offs, be16_to_cpu(dcdlen));
+#endif
}
} else {
imx_header_v2_t *next_hdr_v2;
--
2.17.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* [U-Boot] [PATCH] tools/imximage: fix reported DCD information for MX7ULP
2019-11-28 10:33 [U-Boot] [PATCH] tools/imximage: fix reported DCD information for MX7ULP Jorge Ramirez-Ortiz
@ 2019-12-02 9:44 ` Jorge
2019-12-02 13:42 ` Fabio Estevam
1 sibling, 0 replies; 5+ messages in thread
From: Jorge @ 2019-12-02 9:44 UTC (permalink / raw)
To: u-boot
On 28/11/19 11:33:21, Jorge Ramirez-Ortiz wrote:
> On the MX7ULP, OCRAM for DCD is at 0x2f010000
any comments?
do notice that this is not trivial debug information: this is required
for security puposes so images can then be signed and booted via
SDP. Dumping the wrong information here is important stuff.
>
> Signed-off-by: Jorge Ramirez-Ortiz <jorge@foundries.io>
> ---
> tools/imximage.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/tools/imximage.c b/tools/imximage.c
> index d7c0b6e883..762a06d468 100644
> --- a/tools/imximage.c
> +++ b/tools/imximage.c
> @@ -11,6 +11,7 @@
> #include "imagetool.h"
> #include <image.h>
> #include "imximage.h"
> +#include <generated/autoconf.h>
>
> #define UNDEFINED 0xFFFFFFFF
>
> @@ -524,8 +525,13 @@ static void print_hdr_v2(struct imx_header *imx_hdr)
> printf("HAB Blocks: 0x%08x 0x%08x 0x%08x\n",
> (uint32_t)fhdr_v2->self, 0,
> (uint32_t)(fhdr_v2->csf - fhdr_v2->self));
> +#ifndef CONFIG_MX7ULP
> printf("DCD Blocks: 0x00910000 0x%08x 0x%08x\n",
> offs, be16_to_cpu(dcdlen));
> +#else
> + printf("DCD Blocks: 0x2f010000 0x%08x 0x%08x\n",
> + offs, be16_to_cpu(dcdlen));
> +#endif
> }
> } else {
> imx_header_v2_t *next_hdr_v2;
> --
> 2.17.1
>
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> https://lists.denx.de/listinfo/u-boot
^ permalink raw reply [flat|nested] 5+ messages in thread* [U-Boot] [PATCH] tools/imximage: fix reported DCD information for MX7ULP
2019-11-28 10:33 [U-Boot] [PATCH] tools/imximage: fix reported DCD information for MX7ULP Jorge Ramirez-Ortiz
2019-12-02 9:44 ` Jorge
@ 2019-12-02 13:42 ` Fabio Estevam
2019-12-03 14:07 ` Jorge
1 sibling, 1 reply; 5+ messages in thread
From: Fabio Estevam @ 2019-12-02 13:42 UTC (permalink / raw)
To: u-boot
Hi Jorge,
Adding Breno.
On Thu, Nov 28, 2019 at 7:33 AM Jorge Ramirez-Ortiz <jorge@foundries.io> wrote:
>
> On the MX7ULP, OCRAM for DCD is at 0x2f010000
>
> Signed-off-by: Jorge Ramirez-Ortiz <jorge@foundries.io>
> ---
> tools/imximage.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/tools/imximage.c b/tools/imximage.c
> index d7c0b6e883..762a06d468 100644
> --- a/tools/imximage.c
> +++ b/tools/imximage.c
> @@ -11,6 +11,7 @@
> #include "imagetool.h"
> #include <image.h>
> #include "imximage.h"
> +#include <generated/autoconf.h>
>
> #define UNDEFINED 0xFFFFFFFF
>
> @@ -524,8 +525,13 @@ static void print_hdr_v2(struct imx_header *imx_hdr)
> printf("HAB Blocks: 0x%08x 0x%08x 0x%08x\n",
> (uint32_t)fhdr_v2->self, 0,
> (uint32_t)(fhdr_v2->csf - fhdr_v2->self));
> +#ifndef CONFIG_MX7ULP
> printf("DCD Blocks: 0x00910000 0x%08x 0x%08x\n",
> offs, be16_to_cpu(dcdlen));
> +#else
> + printf("DCD Blocks: 0x2f010000 0x%08x 0x%08x\n",
> + offs, be16_to_cpu(dcdlen));
> +#endif
Can we make the DCD OCRAM a variable passed via Kconfig and selected
by SoC type?
This way we don't need to keep changing this for future SoCs.
What do you think?
^ permalink raw reply [flat|nested] 5+ messages in thread* [PATCH] tools/imximage: fix reported DCD information for MX7ULP
2019-12-02 13:42 ` Fabio Estevam
@ 2019-12-03 14:07 ` Jorge
2019-12-03 16:32 ` Fabio Estevam
0 siblings, 1 reply; 5+ messages in thread
From: Jorge @ 2019-12-03 14:07 UTC (permalink / raw)
To: u-boot
On 02/12/19 10:42:13, Fabio Estevam wrote:
> Hi Jorge,
>
> Adding Breno.
>
> On Thu, Nov 28, 2019 at 7:33 AM Jorge Ramirez-Ortiz <jorge@foundries.io> wrote:
> >
> > On the MX7ULP, OCRAM for DCD is at 0x2f010000
> >
> > Signed-off-by: Jorge Ramirez-Ortiz <jorge@foundries.io>
> > ---
> > tools/imximage.c | 6 ++++++
> > 1 file changed, 6 insertions(+)
> >
> > diff --git a/tools/imximage.c b/tools/imximage.c
> > index d7c0b6e883..762a06d468 100644
> > --- a/tools/imximage.c
> > +++ b/tools/imximage.c
> > @@ -11,6 +11,7 @@
> > #include "imagetool.h"
> > #include <image.h>
> > #include "imximage.h"
> > +#include <generated/autoconf.h>
> >
> > #define UNDEFINED 0xFFFFFFFF
> >
> > @@ -524,8 +525,13 @@ static void print_hdr_v2(struct imx_header *imx_hdr)
> > printf("HAB Blocks: 0x%08x 0x%08x 0x%08x\n",
> > (uint32_t)fhdr_v2->self, 0,
> > (uint32_t)(fhdr_v2->csf - fhdr_v2->self));
> > +#ifndef CONFIG_MX7ULP
> > printf("DCD Blocks: 0x00910000 0x%08x 0x%08x\n",
> > offs, be16_to_cpu(dcdlen));
> > +#else
> > + printf("DCD Blocks: 0x2f010000 0x%08x 0x%08x\n",
> > + offs, be16_to_cpu(dcdlen));
> > +#endif
>
> Can we make the DCD OCRAM a variable passed via Kconfig and selected
> by SoC type?
>
> This way we don't need to keep changing this for future SoCs.
>
> What do you think?
sure that would work. given that the default 0x00910000 is valid on
most of the cases - well all but the mx7ulp - we could apply this default and only change to the
Kconfig value if defined.
should we go for that?
^ permalink raw reply [flat|nested] 5+ messages in thread* [PATCH] tools/imximage: fix reported DCD information for MX7ULP
2019-12-03 14:07 ` Jorge
@ 2019-12-03 16:32 ` Fabio Estevam
0 siblings, 0 replies; 5+ messages in thread
From: Fabio Estevam @ 2019-12-03 16:32 UTC (permalink / raw)
To: u-boot
Hi Jorge,
On Tue, Dec 3, 2019 at 11:07 AM Jorge Ramirez-Ortiz, Foundries
<jorge@foundries.io> wrote:
> sure that would work. given that the default 0x00910000 is valid on
> most of the cases - well all but the mx7ulp - we could apply this default and only change to the
> Kconfig value if defined.
>
> should we go for that?
Yes, that would be fine.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-12-03 16:32 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-28 10:33 [U-Boot] [PATCH] tools/imximage: fix reported DCD information for MX7ULP Jorge Ramirez-Ortiz
2019-12-02 9:44 ` Jorge
2019-12-02 13:42 ` Fabio Estevam
2019-12-03 14:07 ` Jorge
2019-12-03 16:32 ` Fabio Estevam
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.