All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] serial: imx: Fix DCD reading
@ 2016-09-26 13:55 ` Sascha Hauer
  0 siblings, 0 replies; 20+ messages in thread
From: Sascha Hauer @ 2016-09-26 13:55 UTC (permalink / raw)
  To: linux-kernel
  Cc: linux-serial, linux-arm-kernel, kernel, Greg Kroah-Hartman, Sascha Hauer

The USR2_DCDIN bit is tested for in register usr1. As the name
suggests the usr2 register should be used instead. This fixes
reading the Carrier detect status.

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
---
 drivers/tty/serial/imx.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/tty/serial/imx.c b/drivers/tty/serial/imx.c
index 0df2b1c..615c027 100644
--- a/drivers/tty/serial/imx.c
+++ b/drivers/tty/serial/imx.c
@@ -740,12 +740,13 @@ static unsigned int imx_get_hwmctrl(struct imx_port *sport)
 {
 	unsigned int tmp = TIOCM_DSR;
 	unsigned usr1 = readl(sport->port.membase + USR1);
+	unsigned usr2 = readl(sport->port.membase + USR2);
 
 	if (usr1 & USR1_RTSS)
 		tmp |= TIOCM_CTS;
 
 	/* in DCE mode DCDIN is always 0 */
-	if (!(usr1 & USR2_DCDIN))
+	if (!(usr2 & USR2_DCDIN))
 		tmp |= TIOCM_CAR;
 
 	if (sport->dte_mode)
-- 
2.9.3

^ permalink raw reply related	[flat|nested] 20+ messages in thread
* [PATCH] serial: imx: Fix DCD reading
@ 2016-09-26 13:55 ` Sascha Hauer
  0 siblings, 0 replies; 20+ messages in thread
From: Sascha Hauer @ 2016-09-26 13:55 UTC (permalink / raw)
  To: linux-kernel
  Cc: linux-serial, linux-arm-kernel, kernel, Greg Kroah-Hartman, Sascha Hauer

The USR2_DCDIN bit is tested for in register usr1. As the name
suggests the usr2 register should be used instead. This fixes
reading the Carrier detect status.

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
---
 drivers/tty/serial/imx.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/tty/serial/imx.c b/drivers/tty/serial/imx.c
index 0df2b1c..615c027 100644
--- a/drivers/tty/serial/imx.c
+++ b/drivers/tty/serial/imx.c
@@ -740,12 +740,13 @@ static unsigned int imx_get_hwmctrl(struct imx_port *sport)
 {
 	unsigned int tmp = TIOCM_DSR;
 	unsigned usr1 = readl(sport->port.membase + USR1);
+	unsigned usr2 = readl(sport->port.membase + USR2);
 
 	if (usr1 & USR1_RTSS)
 		tmp |= TIOCM_CTS;
 
 	/* in DCE mode DCDIN is always 0 */
-	if (!(usr1 & USR2_DCDIN))
+	if (!(usr2 & USR2_DCDIN))
 		tmp |= TIOCM_CAR;
 
 	if (sport->dte_mode)
-- 
2.9.3

^ permalink raw reply related	[flat|nested] 20+ messages in thread
* [PATCH] serial: imx: Fix DCD reading
@ 2016-09-26 13:55 ` Sascha Hauer
  0 siblings, 0 replies; 20+ messages in thread
From: Sascha Hauer @ 2016-09-26 13:55 UTC (permalink / raw)
  To: linux-arm-kernel

The USR2_DCDIN bit is tested for in register usr1. As the name
suggests the usr2 register should be used instead. This fixes
reading the Carrier detect status.

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
---
 drivers/tty/serial/imx.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/tty/serial/imx.c b/drivers/tty/serial/imx.c
index 0df2b1c..615c027 100644
--- a/drivers/tty/serial/imx.c
+++ b/drivers/tty/serial/imx.c
@@ -740,12 +740,13 @@ static unsigned int imx_get_hwmctrl(struct imx_port *sport)
 {
 	unsigned int tmp = TIOCM_DSR;
 	unsigned usr1 = readl(sport->port.membase + USR1);
+	unsigned usr2 = readl(sport->port.membase + USR2);
 
 	if (usr1 & USR1_RTSS)
 		tmp |= TIOCM_CTS;
 
 	/* in DCE mode DCDIN is always 0 */
-	if (!(usr1 & USR2_DCDIN))
+	if (!(usr2 & USR2_DCDIN))
 		tmp |= TIOCM_CAR;
 
 	if (sport->dte_mode)
-- 
2.9.3

^ permalink raw reply related	[flat|nested] 20+ messages in thread
* Re: [PATCH] serial: imx: Fix DCD reading
  2016-09-26 13:55 ` Sascha Hauer
  (?)
@ 2016-09-26 14:08   ` Fabio Estevam
  -1 siblings, 0 replies; 20+ messages in thread
From: Fabio Estevam @ 2016-09-26 14:08 UTC (permalink / raw)
  To: Sascha Hauer
  Cc: linux-kernel, linux-serial, linux-arm-kernel, Sascha Hauer,
	Greg Kroah-Hartman

Hi Sascha,

On Mon, Sep 26, 2016 at 10:55 AM, Sascha Hauer <s.hauer@pengutronix.de> wrote:
> The USR2_DCDIN bit is tested for in register usr1. As the name
> suggests the usr2 register should be used instead. This fixes
> reading the Carrier detect status.
>
> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

Good catch:

Reviewed-by: Fabio Estevam <fabio.estevam@nxp.com>

Shouldn't this have stable on Cc?

^ permalink raw reply	[flat|nested] 20+ messages in thread
* Re: [PATCH] serial: imx: Fix DCD reading
@ 2016-09-26 14:08   ` Fabio Estevam
  0 siblings, 0 replies; 20+ messages in thread
From: Fabio Estevam @ 2016-09-26 14:08 UTC (permalink / raw)
  To: Sascha Hauer
  Cc: linux-kernel, linux-serial, linux-arm-kernel, Sascha Hauer,
	Greg Kroah-Hartman

Hi Sascha,

On Mon, Sep 26, 2016 at 10:55 AM, Sascha Hauer <s.hauer@pengutronix.de> wrote:
> The USR2_DCDIN bit is tested for in register usr1. As the name
> suggests the usr2 register should be used instead. This fixes
> reading the Carrier detect status.
>
> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

Good catch:

Reviewed-by: Fabio Estevam <fabio.estevam@nxp.com>

Shouldn't this have stable on Cc?

^ permalink raw reply	[flat|nested] 20+ messages in thread
* [PATCH] serial: imx: Fix DCD reading
@ 2016-09-26 14:08   ` Fabio Estevam
  0 siblings, 0 replies; 20+ messages in thread
From: Fabio Estevam @ 2016-09-26 14:08 UTC (permalink / raw)
  To: linux-arm-kernel

Hi Sascha,

On Mon, Sep 26, 2016 at 10:55 AM, Sascha Hauer <s.hauer@pengutronix.de> wrote:
> The USR2_DCDIN bit is tested for in register usr1. As the name
> suggests the usr2 register should be used instead. This fixes
> reading the Carrier detect status.
>
> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

Good catch:

Reviewed-by: Fabio Estevam <fabio.estevam@nxp.com>

Shouldn't this have stable on Cc?

^ permalink raw reply	[flat|nested] 20+ messages in thread
* Re: [PATCH] serial: imx: Fix DCD reading
  2016-09-26 13:55 ` Sascha Hauer
@ 2016-09-26 14:09   ` Uwe Kleine-König
  -1 siblings, 0 replies; 20+ messages in thread
From: Uwe Kleine-König @ 2016-09-26 14:09 UTC (permalink / raw)
  To: Sascha Hauer
  Cc: linux-kernel, kernel, Greg Kroah-Hartman, linux-arm-kernel, linux-serial

Hallo,

On Mon, Sep 26, 2016 at 03:55:31PM +0200, Sascha Hauer wrote:
> The USR2_DCDIN bit is tested for in register usr1. As the name
> suggests the usr2 register should be used instead. This fixes
> reading the Carrier detect status.
> 
> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
Fixes: 90ebc4838666 ("serial: imx: repair and complete handshaking")
Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>

Thanks
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

^ permalink raw reply	[flat|nested] 20+ messages in thread
* [PATCH] serial: imx: Fix DCD reading
@ 2016-09-26 14:09   ` Uwe Kleine-König
  0 siblings, 0 replies; 20+ messages in thread
From: Uwe Kleine-König @ 2016-09-26 14:09 UTC (permalink / raw)
  To: linux-arm-kernel

Hallo,

On Mon, Sep 26, 2016 at 03:55:31PM +0200, Sascha Hauer wrote:
> The USR2_DCDIN bit is tested for in register usr1. As the name
> suggests the usr2 register should be used instead. This fixes
> reading the Carrier detect status.
> 
> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
Fixes: 90ebc4838666 ("serial: imx: repair and complete handshaking")
Acked-by: Uwe Kleine-K?nig <u.kleine-koenig@pengutronix.de>

Thanks
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-K?nig            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

^ permalink raw reply	[flat|nested] 20+ messages in thread
* Re: [PATCH] serial: imx: Fix DCD reading
  2016-09-26 14:09   ` Uwe Kleine-König
  (?)
@ 2016-09-26 14:13     ` Fabio Estevam
  -1 siblings, 0 replies; 20+ messages in thread
From: Fabio Estevam @ 2016-09-26 14:13 UTC (permalink / raw)
  To: Uwe Kleine-König
  Cc: Sascha Hauer, linux-kernel, Sascha Hauer, Greg Kroah-Hartman,
	linux-arm-kernel, linux-serial

On Mon, Sep 26, 2016 at 11:09 AM, Uwe Kleine-König
<u.kleine-koenig@pengutronix.de> wrote:
> Hallo,
>
> On Mon, Sep 26, 2016 at 03:55:31PM +0200, Sascha Hauer wrote:
>> The USR2_DCDIN bit is tested for in register usr1. As the name
>> suggests the usr2 register should be used instead. This fixes
>> reading the Carrier detect status.
>>
>> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
> Fixes: 90ebc4838666 ("serial: imx: repair and complete handshaking")
> Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>

Great, so it affects 4.5+ kernels and should probably have:

Cc: <stable@vger.kernel.org> # 4.5+

^ permalink raw reply	[flat|nested] 20+ messages in thread
* Re: [PATCH] serial: imx: Fix DCD reading
@ 2016-09-26 14:13     ` Fabio Estevam
  0 siblings, 0 replies; 20+ messages in thread
From: Fabio Estevam @ 2016-09-26 14:13 UTC (permalink / raw)
  To: Uwe Kleine-König
  Cc: Sascha Hauer, linux-kernel, Sascha Hauer, Greg Kroah-Hartman,
	linux-arm-kernel, linux-serial

On Mon, Sep 26, 2016 at 11:09 AM, Uwe Kleine-König
<u.kleine-koenig@pengutronix.de> wrote:
> Hallo,
>
> On Mon, Sep 26, 2016 at 03:55:31PM +0200, Sascha Hauer wrote:
>> The USR2_DCDIN bit is tested for in register usr1. As the name
>> suggests the usr2 register should be used instead. This fixes
>> reading the Carrier detect status.
>>
>> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
> Fixes: 90ebc4838666 ("serial: imx: repair and complete handshaking")
> Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>

Great, so it affects 4.5+ kernels and should probably have:

Cc: <stable@vger.kernel.org> # 4.5+

^ permalink raw reply	[flat|nested] 20+ messages in thread
* [PATCH] serial: imx: Fix DCD reading
@ 2016-09-26 14:13     ` Fabio Estevam
  0 siblings, 0 replies; 20+ messages in thread
From: Fabio Estevam @ 2016-09-26 14:13 UTC (permalink / raw)
  To: linux-arm-kernel

On Mon, Sep 26, 2016 at 11:09 AM, Uwe Kleine-K?nig
<u.kleine-koenig@pengutronix.de> wrote:
> Hallo,
>
> On Mon, Sep 26, 2016 at 03:55:31PM +0200, Sascha Hauer wrote:
>> The USR2_DCDIN bit is tested for in register usr1. As the name
>> suggests the usr2 register should be used instead. This fixes
>> reading the Carrier detect status.
>>
>> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
> Fixes: 90ebc4838666 ("serial: imx: repair and complete handshaking")
> Acked-by: Uwe Kleine-K?nig <u.kleine-koenig@pengutronix.de>

Great, so it affects 4.5+ kernels and should probably have:

Cc: <stable@vger.kernel.org> # 4.5+

^ permalink raw reply	[flat|nested] 20+ messages in thread
* Re: [PATCH] serial: imx: Fix DCD reading
  2016-09-26 14:13     ` Fabio Estevam
  (?)
@ 2016-09-26 14:25       ` Uwe Kleine-König
  -1 siblings, 0 replies; 20+ messages in thread
From: Uwe Kleine-König @ 2016-09-26 14:25 UTC (permalink / raw)
  To: Fabio Estevam
  Cc: Sascha Hauer, linux-kernel, Sascha Hauer, Greg Kroah-Hartman,
	linux-arm-kernel, linux-serial

Hello Fabio,

On Mon, Sep 26, 2016 at 11:13:37AM -0300, Fabio Estevam wrote:
> On Mon, Sep 26, 2016 at 11:09 AM, Uwe Kleine-König
> <u.kleine-koenig@pengutronix.de> wrote:
> > On Mon, Sep 26, 2016 at 03:55:31PM +0200, Sascha Hauer wrote:
> >> The USR2_DCDIN bit is tested for in register usr1. As the name
> >> suggests the usr2 register should be used instead. This fixes
> >> reading the Carrier detect status.
> >>
> >> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
> > Fixes: 90ebc4838666 ("serial: imx: repair and complete handshaking")
> > Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> 
> Great, so it affects 4.5+ kernels and should probably have:
> 
> Cc: <stable@vger.kernel.org> # 4.5+

This is usually not necessary if there is a Fixes: line.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

^ permalink raw reply	[flat|nested] 20+ messages in thread
* Re: [PATCH] serial: imx: Fix DCD reading
@ 2016-09-26 14:25       ` Uwe Kleine-König
  0 siblings, 0 replies; 20+ messages in thread
From: Uwe Kleine-König @ 2016-09-26 14:25 UTC (permalink / raw)
  To: Fabio Estevam
  Cc: Sascha Hauer, linux-kernel, Sascha Hauer, Greg Kroah-Hartman,
	linux-arm-kernel, linux-serial

Hello Fabio,

On Mon, Sep 26, 2016 at 11:13:37AM -0300, Fabio Estevam wrote:
> On Mon, Sep 26, 2016 at 11:09 AM, Uwe Kleine-König
> <u.kleine-koenig@pengutronix.de> wrote:
> > On Mon, Sep 26, 2016 at 03:55:31PM +0200, Sascha Hauer wrote:
> >> The USR2_DCDIN bit is tested for in register usr1. As the name
> >> suggests the usr2 register should be used instead. This fixes
> >> reading the Carrier detect status.
> >>
> >> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
> > Fixes: 90ebc4838666 ("serial: imx: repair and complete handshaking")
> > Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> 
> Great, so it affects 4.5+ kernels and should probably have:
> 
> Cc: <stable@vger.kernel.org> # 4.5+

This is usually not necessary if there is a Fixes: line.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

^ permalink raw reply	[flat|nested] 20+ messages in thread
* [PATCH] serial: imx: Fix DCD reading
@ 2016-09-26 14:25       ` Uwe Kleine-König
  0 siblings, 0 replies; 20+ messages in thread
From: Uwe Kleine-König @ 2016-09-26 14:25 UTC (permalink / raw)
  To: linux-arm-kernel

Hello Fabio,

On Mon, Sep 26, 2016 at 11:13:37AM -0300, Fabio Estevam wrote:
> On Mon, Sep 26, 2016 at 11:09 AM, Uwe Kleine-K?nig
> <u.kleine-koenig@pengutronix.de> wrote:
> > On Mon, Sep 26, 2016 at 03:55:31PM +0200, Sascha Hauer wrote:
> >> The USR2_DCDIN bit is tested for in register usr1. As the name
> >> suggests the usr2 register should be used instead. This fixes
> >> reading the Carrier detect status.
> >>
> >> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
> > Fixes: 90ebc4838666 ("serial: imx: repair and complete handshaking")
> > Acked-by: Uwe Kleine-K?nig <u.kleine-koenig@pengutronix.de>
> 
> Great, so it affects 4.5+ kernels and should probably have:
> 
> Cc: <stable@vger.kernel.org> # 4.5+

This is usually not necessary if there is a Fixes: line.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-K?nig            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

^ permalink raw reply	[flat|nested] 20+ messages in thread
* Re: [PATCH] serial: imx: Fix DCD reading
  2016-09-26 14:25       ` Uwe Kleine-König
  (?)
@ 2016-09-26 14:28         ` Fabio Estevam
  -1 siblings, 0 replies; 20+ messages in thread
From: Fabio Estevam @ 2016-09-26 14:28 UTC (permalink / raw)
  To: Uwe Kleine-König
  Cc: Sascha Hauer, linux-kernel, Sascha Hauer, Greg Kroah-Hartman,
	linux-arm-kernel, linux-serial

Hi Uwe,

On Mon, Sep 26, 2016 at 11:25 AM, Uwe Kleine-König
<u.kleine-koenig@pengutronix.de> wrote:

>> Great, so it affects 4.5+ kernels and should probably have:
>>
>> Cc: <stable@vger.kernel.org> # 4.5+
>
> This is usually not necessary if there is a Fixes: line.

I thought Greg prefers the explicit Cc: stable line as documented in
Documentation/stable_kernel_rules.txt.

Greg?

^ permalink raw reply	[flat|nested] 20+ messages in thread
* Re: [PATCH] serial: imx: Fix DCD reading
@ 2016-09-26 14:28         ` Fabio Estevam
  0 siblings, 0 replies; 20+ messages in thread
From: Fabio Estevam @ 2016-09-26 14:28 UTC (permalink / raw)
  To: Uwe Kleine-König
  Cc: Sascha Hauer, linux-kernel, Sascha Hauer, Greg Kroah-Hartman,
	linux-arm-kernel, linux-serial

Hi Uwe,

On Mon, Sep 26, 2016 at 11:25 AM, Uwe Kleine-König
<u.kleine-koenig@pengutronix.de> wrote:

>> Great, so it affects 4.5+ kernels and should probably have:
>>
>> Cc: <stable@vger.kernel.org> # 4.5+
>
> This is usually not necessary if there is a Fixes: line.

I thought Greg prefers the explicit Cc: stable line as documented in
Documentation/stable_kernel_rules.txt.

Greg?

^ permalink raw reply	[flat|nested] 20+ messages in thread
* [PATCH] serial: imx: Fix DCD reading
@ 2016-09-26 14:28         ` Fabio Estevam
  0 siblings, 0 replies; 20+ messages in thread
From: Fabio Estevam @ 2016-09-26 14:28 UTC (permalink / raw)
  To: linux-arm-kernel

Hi Uwe,

On Mon, Sep 26, 2016 at 11:25 AM, Uwe Kleine-K?nig
<u.kleine-koenig@pengutronix.de> wrote:

>> Great, so it affects 4.5+ kernels and should probably have:
>>
>> Cc: <stable@vger.kernel.org> # 4.5+
>
> This is usually not necessary if there is a Fixes: line.

I thought Greg prefers the explicit Cc: stable line as documented in
Documentation/stable_kernel_rules.txt.

Greg?

^ permalink raw reply	[flat|nested] 20+ messages in thread
* Re: [PATCH] serial: imx: Fix DCD reading
  2016-09-26 14:28         ` Fabio Estevam
  (?)
@ 2016-09-26 15:08           ` Fabio Estevam
  -1 siblings, 0 replies; 20+ messages in thread
From: Fabio Estevam @ 2016-09-26 15:08 UTC (permalink / raw)
  To: Uwe Kleine-König
  Cc: Sascha Hauer, linux-kernel, Sascha Hauer, Greg Kroah-Hartman,
	linux-arm-kernel, linux-serial

On Mon, Sep 26, 2016 at 11:28 AM, Fabio Estevam <festevam@gmail.com> wrote:
> Hi Uwe,
>
> On Mon, Sep 26, 2016 at 11:25 AM, Uwe Kleine-König
> <u.kleine-koenig@pengutronix.de> wrote:
>
>>> Great, so it affects 4.5+ kernels and should probably have:
>>>
>>> Cc: <stable@vger.kernel.org> # 4.5+
>>
>> This is usually not necessary if there is a Fixes: line.
>
> I thought Greg prefers the explicit Cc: stable line as documented in
> Documentation/stable_kernel_rules.txt.
>
> Greg?

Ok, in this previous discussion Greg stated that he prefers Cc: stable
to be present:
http://www.spinics.net/lists/linux-gpio/msg10659.html

^ permalink raw reply	[flat|nested] 20+ messages in thread
* Re: [PATCH] serial: imx: Fix DCD reading
@ 2016-09-26 15:08           ` Fabio Estevam
  0 siblings, 0 replies; 20+ messages in thread
From: Fabio Estevam @ 2016-09-26 15:08 UTC (permalink / raw)
  To: Uwe Kleine-König
  Cc: Sascha Hauer, linux-kernel, Sascha Hauer, Greg Kroah-Hartman,
	linux-arm-kernel, linux-serial

On Mon, Sep 26, 2016 at 11:28 AM, Fabio Estevam <festevam@gmail.com> wrote:
> Hi Uwe,
>
> On Mon, Sep 26, 2016 at 11:25 AM, Uwe Kleine-König
> <u.kleine-koenig@pengutronix.de> wrote:
>
>>> Great, so it affects 4.5+ kernels and should probably have:
>>>
>>> Cc: <stable@vger.kernel.org> # 4.5+
>>
>> This is usually not necessary if there is a Fixes: line.
>
> I thought Greg prefers the explicit Cc: stable line as documented in
> Documentation/stable_kernel_rules.txt.
>
> Greg?

Ok, in this previous discussion Greg stated that he prefers Cc: stable
to be present:
http://www.spinics.net/lists/linux-gpio/msg10659.html

^ permalink raw reply	[flat|nested] 20+ messages in thread
* [PATCH] serial: imx: Fix DCD reading
@ 2016-09-26 15:08           ` Fabio Estevam
  0 siblings, 0 replies; 20+ messages in thread
From: Fabio Estevam @ 2016-09-26 15:08 UTC (permalink / raw)
  To: linux-arm-kernel

On Mon, Sep 26, 2016 at 11:28 AM, Fabio Estevam <festevam@gmail.com> wrote:
> Hi Uwe,
>
> On Mon, Sep 26, 2016 at 11:25 AM, Uwe Kleine-K?nig
> <u.kleine-koenig@pengutronix.de> wrote:
>
>>> Great, so it affects 4.5+ kernels and should probably have:
>>>
>>> Cc: <stable@vger.kernel.org> # 4.5+
>>
>> This is usually not necessary if there is a Fixes: line.
>
> I thought Greg prefers the explicit Cc: stable line as documented in
> Documentation/stable_kernel_rules.txt.
>
> Greg?

Ok, in this previous discussion Greg stated that he prefers Cc: stable
to be present:
http://www.spinics.net/lists/linux-gpio/msg10659.html

^ permalink raw reply	[flat|nested] 20+ messages in thread
end of thread, other threads:[~2016-09-26 15:08 UTC | newest]

Thread overview: 20+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-09-26 13:55 [PATCH] serial: imx: Fix DCD reading Sascha Hauer
2016-09-26 13:55 ` Sascha Hauer
2016-09-26 13:55 ` Sascha Hauer
2016-09-26 14:08 ` Fabio Estevam
2016-09-26 14:08   ` Fabio Estevam
2016-09-26 14:08   ` Fabio Estevam
2016-09-26 14:09 ` Uwe Kleine-König
2016-09-26 14:09   ` Uwe Kleine-König
2016-09-26 14:13   ` Fabio Estevam
2016-09-26 14:13     ` Fabio Estevam
2016-09-26 14:13     ` Fabio Estevam
2016-09-26 14:25     ` Uwe Kleine-König
2016-09-26 14:25       ` Uwe Kleine-König
2016-09-26 14:25       ` Uwe Kleine-König
2016-09-26 14:28       ` Fabio Estevam
2016-09-26 14:28         ` Fabio Estevam
2016-09-26 14:28         ` Fabio Estevam
2016-09-26 15:08         ` Fabio Estevam
2016-09-26 15:08           ` Fabio Estevam
2016-09-26 15:08           ` Fabio Estevam

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.