[Buildroot] [PATCH v2 0/2] Xorg: enable Etnaviv support

[Buildroot] [PATCH v2 0/2] Xorg: enable Etnaviv support

[Evgeniy Didin]

From: Evgeniy Didin <didin@synopsys.com>

This patch series enables Etnaviv support in Xorg.

Signed-off-by: Evgeniy Didin <didin@synopsys.com>
Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Cc: Alexey Brodkin <abrodkin@synopsys.com>
Cc: arc-buildroot at synopsys.com

Evgeniy Didin (2):
  libdrm-armada: new package
  xf86-video-armada: new package

 DEVELOPERS                                         |  2 ++
 package/Config.in                                  |  1 +
 package/libdrm-armada/Config.in                    |  8 +++++
 package/libdrm-armada/libdrm-armada.hash           |  5 +++
 package/libdrm-armada/libdrm-armada.mk             | 22 +++++++++++++
 package/x11r7/Config.in                            |  1 +
 package/x11r7/xdriver_xf86-video-armada/Config.in  | 11 +++++++
 .../xdriver_xf86-video-armada.hash                 |  6 ++++
 .../xdriver_xf86-video-armada.mk                   | 37 ++++++++++++++++++++++
 9 files changed, 93 insertions(+)
 create mode 100644 package/libdrm-armada/Config.in
 create mode 100644 package/libdrm-armada/libdrm-armada.hash
 create mode 100644 package/libdrm-armada/libdrm-armada.mk
 create mode 100644 package/x11r7/xdriver_xf86-video-armada/Config.in
 create mode 100644 package/x11r7/xdriver_xf86-video-armada/xdriver_xf86-video-armada.hash
 create mode 100644 package/x11r7/xdriver_xf86-video-armada/xdriver_xf86-video-armada.mk

-- 
2.11.0

[Buildroot] [PATCH v2 1/2] libdrm-armada: new package

[Evgeniy Didin]

From: Evgeniy Didin <didin@synopsys.com>

libdrm-armada is an Etnaviv libdrm buffer object management module.
It is used with xf86-driver-video-armada, which is Xorg driver for Etnaviv.

Signed-off-by: Evgeniy Didin <didin@synopsys.com>
Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Cc: Alexey Brodkin <abrodkin@synopsys.com>
Cc: arc-buildroot at synopsys.com
---
Changes since v1:
-Add entry in DEVELOPERS
-Some clean-up was made
-Add license file
-Add dependency for threads in toolchain
-Use full Git hash

 DEVELOPERS                               |  1 +
 package/Config.in                        |  1 +
 package/libdrm-armada/Config.in          |  8 ++++++++
 package/libdrm-armada/libdrm-armada.hash |  5 +++++
 package/libdrm-armada/libdrm-armada.mk   | 22 ++++++++++++++++++++++
 5 files changed, 37 insertions(+)
 create mode 100644 package/libdrm-armada/Config.in
 create mode 100644 package/libdrm-armada/libdrm-armada.hash
 create mode 100644 package/libdrm-armada/libdrm-armada.mk

diff --git a/DEVELOPERS b/DEVELOPERS
index fe989c0775..f38ce61966 100644
--- a/DEVELOPERS
+++ b/DEVELOPERS
@@ -153,6 +153,7 @@ F:	package/wf111/
 
 N:	ARC Maintainers <arc-buildroot@synopsys.com>
 F:	arch/Config.in.arc
+F:	package/libdrm-armada
 
 N:	Ariel D'Alessandro <ariel@vanguardiasur.com.ar>
 F:	package/axfsutils/
diff --git a/package/Config.in b/package/Config.in
index bd39a374f0..4e7a15fb49 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -1116,6 +1116,7 @@ menu "Graphics"
 	source "package/libdmtx/Config.in"
 	source "package/libdri2/Config.in"
 	source "package/libdrm/Config.in"
+	source "package/libdrm-armada/Config.in"
 	source "package/libepoxy/Config.in"
 	source "package/libexif/Config.in"
 	source "package/libfm/Config.in"
diff --git a/package/libdrm-armada/Config.in b/package/libdrm-armada/Config.in
new file mode 100644
index 0000000000..a78ed44040
--- /dev/null
+++ b/package/libdrm-armada/Config.in
@@ -0,0 +1,8 @@
+config BR2_PACKAGE_LIBDRM_ARMADA
+	bool "libdrm-armada"
+	depends on BR2_TOOLCHAIN_HAS_THREADS
+	select BR2_PACKAGE_LIBDRM
+	help
+	  Etnaviv libdrm buffer object management module
+
+	  http://git.arm.linux.org.uk/cgit/libdrm-armada.git/
diff --git a/package/libdrm-armada/libdrm-armada.hash b/package/libdrm-armada/libdrm-armada.hash
new file mode 100644
index 0000000000..7b36147312
--- /dev/null
+++ b/package/libdrm-armada/libdrm-armada.hash
@@ -0,0 +1,5 @@
+# Locally calculated
+sha256  d9a6184276aa9defe70f6eb215656096a4d3c669f2ceae98e8348a60d749c549  libdrm-armada-6b461c163b0bd02c76b65d94cc2fb3767167bda8.tar.gz
+
+# Hash for license file:
+sha256  cf445db5adf2d878b83f7bbd60948a22303f8cf606a83b85fbaf20d9e16a3861  libdrm_lists.h
diff --git a/package/libdrm-armada/libdrm-armada.mk b/package/libdrm-armada/libdrm-armada.mk
new file mode 100644
index 0000000000..c01fa69e0f
--- /dev/null
+++ b/package/libdrm-armada/libdrm-armada.mk
@@ -0,0 +1,22 @@
+################################################################################
+#
+# libdrm-armada
+#
+################################################################################
+
+LIBDRM_ARMADA_VERSION = 6b461c163b0bd02c76b65d94cc2fb3767167bda8
+LIBDRM_ARMADA_SITE = http://git.arm.linux.org.uk/cgit/libdrm-armada.git
+LIBDRM_ARMADA_SITE_METHOD = git
+LIBDRM_ARMADA_DEPENDENCIES = libdrm
+LIBDRM_ARMADA_INSTALL_STAGING = YES
+LIBDRM_ARMADA_AUTORECONF = YES
+LIBDRM_ARMADA_LICENSE_FILES = libdrm_lists.h
+
+# Needed for autoreconf to work properly
+define LIBDRM_ARMADA_FIXUP_M4_DIR
+        mkdir $(@D)/m4
+endef
+
+LIBDRM_ARMADA_POST_PATCH_HOOKS += LIBDRM_ARMADA_FIXUP_M4_DIR
+
+$(eval $(autotools-package))
-- 
2.11.0

[Buildroot] [PATCH v2 2/2] xf86-video-armada: new package

[Evgeniy Didin]

From: Evgeniy Didin <didin@synopsys.com>

xf86-video-armada is a Xorg driver for Etnaviv GPU.

Signed-off-by: Evgeniy Didin <didin@synopsys.com>
Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Cc: Alexey Brodkin <abrodkin@synopsys.com>
Cc: arc-buildroot at synopsys.com
---
Changes since v1:
-Add entry in DEVELOPERS
-Some clean-up was made
-Add license file
-Use full Git hash

 DEVELOPERS                                         |  1 +
 package/x11r7/Config.in                            |  1 +
 package/x11r7/xdriver_xf86-video-armada/Config.in  | 11 +++++++
 .../xdriver_xf86-video-armada.hash                 |  6 ++++
 .../xdriver_xf86-video-armada.mk                   | 37 ++++++++++++++++++++++
 5 files changed, 56 insertions(+)
 create mode 100644 package/x11r7/xdriver_xf86-video-armada/Config.in
 create mode 100644 package/x11r7/xdriver_xf86-video-armada/xdriver_xf86-video-armada.hash
 create mode 100644 package/x11r7/xdriver_xf86-video-armada/xdriver_xf86-video-armada.mk

diff --git a/DEVELOPERS b/DEVELOPERS
index f38ce61966..da41a28793 100644
--- a/DEVELOPERS
+++ b/DEVELOPERS
@@ -154,6 +154,7 @@ F:	package/wf111/
 N:	ARC Maintainers <arc-buildroot@synopsys.com>
 F:	arch/Config.in.arc
 F:	package/libdrm-armada
+F:	package/x11r7/xdriver_xf86-video-armada
 
 N:	Ariel D'Alessandro <ariel@vanguardiasur.com.ar>
 F:	package/axfsutils/
diff --git a/package/x11r7/Config.in b/package/x11r7/Config.in
index ddceaa407f..e791419083 100644
--- a/package/x11r7/Config.in
+++ b/package/x11r7/Config.in
@@ -157,6 +157,7 @@ if BR2_PACKAGE_XORG7
 		source package/x11r7/xdriver_xf86-input-vmmouse/Config.in
 		source package/x11r7/xdriver_xf86-video-amdgpu/Config.in
 		source package/x11r7/xdriver_xf86-video-ark/Config.in
+		source package/x11r7/xdriver_xf86-video-armada/Config.in
 		source package/x11r7/xdriver_xf86-video-ast/Config.in
 		source package/x11r7/xdriver_xf86-video-ati/Config.in
 		source package/x11r7/xdriver_xf86-video-cirrus/Config.in
diff --git a/package/x11r7/xdriver_xf86-video-armada/Config.in b/package/x11r7/xdriver_xf86-video-armada/Config.in
new file mode 100644
index 0000000000..ade8a75643
--- /dev/null
+++ b/package/x11r7/xdriver_xf86-video-armada/Config.in
@@ -0,0 +1,11 @@
+config BR2_PACKAGE_XDRIVER_XF86_VIDEO_ARMADA
+	bool "xf86-video-armada"
+	depends on BR2_PACKAGE_MESA3D
+	select BR2_PACKAGE_LIBDRM_ARMADA
+	help
+	 Xorg driver for Etnaviv GPU.
+
+	 http://git.arm.linux.org.uk/cgit/xf86-video-armada.git
+
+comment "xf86-video-armada needs mesa3d"
+        depends on !BR2_PACKAGE_MESA3D
diff --git a/package/x11r7/xdriver_xf86-video-armada/xdriver_xf86-video-armada.hash b/package/x11r7/xdriver_xf86-video-armada/xdriver_xf86-video-armada.hash
new file mode 100644
index 0000000000..7fa0f525ed
--- /dev/null
+++ b/package/x11r7/xdriver_xf86-video-armada/xdriver_xf86-video-armada.hash
@@ -0,0 +1,6 @@
+# Locally calculated
+sha256	5df615507ca6579ffba6df8a2aea6f6b542aa3985598efae836f335f9752cb39	xdriver_xf86-video-armada-04748ff4fb30370086cc97b9487a32951c5600ba.tar.gz
+
+# Hashes for license files:
+sha256  57ed74a42ee9ea913ae81c5bac498340ade4ef1e70e9007f39b2da3de952e597	README
+sha256  9d8facadc083641f71b8bcf9f078bd53f27aba3545b170f100c38f07cf3a42a2	etna_viv/LICENSE
diff --git a/package/x11r7/xdriver_xf86-video-armada/xdriver_xf86-video-armada.mk b/package/x11r7/xdriver_xf86-video-armada/xdriver_xf86-video-armada.mk
new file mode 100644
index 0000000000..7cac256241
--- /dev/null
+++ b/package/x11r7/xdriver_xf86-video-armada/xdriver_xf86-video-armada.mk
@@ -0,0 +1,37 @@
+################################################################################
+#
+# xdriver_xf86-video-armada
+#
+################################################################################
+
+XDRIVER_XF86_VIDEO_ARMADA_VERSION = 04748ff4fb30370086cc97b9487a32951c5600ba
+XDRIVER_XF86_VIDEO_ARMADA_SITE = http://git.arm.linux.org.uk/cgit/xf86-video-armada.git
+XDRIVER_XF86_VIDEO_ARMADA_SITE_METHOD = git
+XDRIVER_XF86_VIDEO_ARMADA_AUTORECONF = YES
+XDRIVER_XF86_VIDEO_ARMADA_DEPENDENCIES = \
+	libdrm-armada \
+	xserver_xorg-server
+
+XDRIVER_XF86_VIDEO_ARMADA_LICENSE_FILES= README etna_viv/LICENSE
+XDRIVER_XF86_VIDEO_ARMADA_LICENSE = BSD
+
+#Need etna_viv source files for driver
+define XDRIVER_XF86_VIDEO_ARMADA_ETNASRC
+	git clone https://github.com/laanwj/etna_viv.git $(@D)/etna_viv
+        mkdir $(@D)/m4
+endef
+
+XDRIVER_XF86_VIDEO_ARMADA_POST_PATCH_HOOKS += XDRIVER_XF86_VIDEO_ARMADA_ETNASRC
+
+define XDRIVER_XF86_VIDEO_ARMADA_INSTALL_CONF_FILE
+        $(INSTALL) -m 0644 -D $(@D)/conf/xorg-sample.conf $(TARGET_DIR)/etc/X11/xorg.conf
+endef
+
+XDRIVER_XF86_VIDEO_ARMADA_POST_INSTALL_TARGET_HOOKS += XDRIVER_XF86_VIDEO_ARMADA_INSTALL_CONF_FILE
+
+
+XDRIVER_XF86_VIDEO_ARMADA_CONF_OPTS = \
+  --prefix=/usr --disable-vivante --disable-etnaviv \
+  --with-etnaviv-source=$(@D)/etna_viv
+
+$(eval $(autotools-package))
-- 
2.11.0

[Buildroot] [PATCH v2 0/2] Xorg: enable Etnaviv support

[Fabio Estevam]

Hi Evgeniy,

On Fri, Feb 2, 2018 at 12:55 PM, Evgeniy Didin
<Evgeniy.Didin@synopsys.com> wrote:
> From: Evgeniy Didin <didin@synopsys.com>
>
> This patch series enables Etnaviv support in Xorg.
>
> Signed-off-by: Evgeniy Didin <didin@synopsys.com>
> Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> Cc: Alexey Brodkin <abrodkin@synopsys.com>
> Cc: arc-buildroot at synopsys.com
>
> Evgeniy Didin (2):
>   libdrm-armada: new package
>   xf86-video-armada: new package

Thanks for this series.

I would be interested in testing it.

From your previous version, it looks like you also used a imx6 wandboard.

Could you please share the defconfig changes you did in wandboard and
also the command lines you used to launch X11?

Thanks

[Buildroot] [arc-buildroot] Re: [PATCH v2 0/2] Xorg: enable Etnaviv support

[Evgeniy Didin]

Hello Fabio,

> Thanks for this series.
> 
> I would be interested in testing it.
> 
> From your previous version, it looks like you also used a imx6
> wandboard.

Exactly so.

> Could you please share the defconfig changes you did in wandboard and
> also the command lines you used to launch X11?

Sure, in attachment I placed defconfig which I used to run glmark app.
on Wandboard.

Commands:
$ X &
$ export DISPLAY=:0
$ glmark2-es2??

-Evgeniy
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: wandboard_test_defconfig
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20180206/253da0cd/attachment.ksh>

[Buildroot] [arc-buildroot] Re: [PATCH v2 0/2] Xorg: enable Etnaviv support

[Fabio Estevam]

Hi Evgeniy,

On Tue, Feb 6, 2018 at 9:06 AM, Evgeniy Didin
<Evgeniy.Didin@synopsys.com> wrote:

> Sure, in attachment I placed defconfig which I used to run glmark app.
> on Wandboard.
>
> Commands:
> $ X &
> $ export DISPLAY=:0
> $ glmark2-es2

Thanks! It works fine.

I have a minor comment in one of your patches. Will reply there.

Thanks for your good work!

[Buildroot] [PATCH v2 1/2] libdrm-armada: new package

[Fabio Estevam]

On Fri, Feb 2, 2018 at 12:55 PM, Evgeniy Didin
<Evgeniy.Didin@synopsys.com> wrote:
> From: Evgeniy Didin <didin@synopsys.com>
>
> libdrm-armada is an Etnaviv libdrm buffer object management module.
> It is used with xf86-driver-video-armada, which is Xorg driver for Etnaviv.
>
> Signed-off-by: Evgeniy Didin <didin@synopsys.com>
> Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> Cc: Alexey Brodkin <abrodkin@synopsys.com>
> Cc: arc-buildroot at synopsys.com

Tested-by: Fabio Estevam <festevam@gmail.com>

[Buildroot] [PATCH v2 2/2] xf86-video-armada: new package

[Fabio Estevam]

Hi Evgeniy,

On Fri, Feb 2, 2018 at 12:55 PM, Evgeniy Didin
<Evgeniy.Didin@synopsys.com> wrote:

> +++ b/package/x11r7/xdriver_xf86-video-armada/xdriver_xf86-video-armada.hash
> @@ -0,0 +1,6 @@
> +# Locally calculated
> +sha256 5df615507ca6579ffba6df8a2aea6f6b542aa3985598efae836f335f9752cb39        xdriver_xf86-video-armada-04748ff4fb30370086cc97b9487a32951c5600ba.tar.gz

I had to manually change the sha256 to
5df615507ca6579ffba6df8a2aea6f6b542aa3985598efae836f335f9752cb39 in
order to fix the mismatch error.

With this fixed:

Tested-by: Fabio Estevam <festevam@gmail.com>

[Buildroot] [PATCH v2 2/2] xf86-video-armada: new package

[Thomas Petazzoni]

Hello,

On Tue, 6 Feb 2018 14:25:46 -0200, Fabio Estevam wrote:
> Hi Evgeniy,
> 
> On Fri, Feb 2, 2018 at 12:55 PM, Evgeniy Didin
> <Evgeniy.Didin@synopsys.com> wrote:
> 
> > +++ b/package/x11r7/xdriver_xf86-video-armada/xdriver_xf86-video-armada.hash
> > @@ -0,0 +1,6 @@
> > +# Locally calculated
> > +sha256 5df615507ca6579ffba6df8a2aea6f6b542aa3985598efae836f335f9752cb39        xdriver_xf86-video-armada-04748ff4fb30370086cc97b9487a32951c5600ba.tar.gz  
> 
> I had to manually change the sha256 to
> 5df615507ca6579ffba6df8a2aea6f6b542aa3985598efae836f335f9752cb39 in
> order to fix the mismatch error.
> 
> With this fixed:
> 
> Tested-by: Fabio Estevam <festevam@gmail.com>

Which version of tar are you using? Which version of tar is Evgeniy
using?

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
http://bootlin.com

[Buildroot] [PATCH v2 2/2] xf86-video-armada: new package

[Fabio Estevam]

Hi Thomas,

On Tue, Feb 6, 2018 at 6:02 PM, Thomas Petazzoni
<thomas.petazzoni@bootlin.com> wrote:

> Which version of tar are you using? Which version of tar is Evgeniy
> using?

I tested this series against master, which uses tar-1.29 version.

Thanks

[Buildroot] [PATCH v2 2/2] xf86-video-armada: new package

[Baruch Siach]

Hi Fabio,

On Tue, Feb 06, 2018 at 11:30:00PM -0200, Fabio Estevam wrote:
> On Tue, Feb 6, 2018 at 6:02 PM, Thomas Petazzoni
> <thomas.petazzoni@bootlin.com> wrote:
> 
> > Which version of tar are you using? Which version of tar is Evgeniy
> > using?
> 
> I tested this series against master, which uses tar-1.29 version.

Thomas asks about your host installed tar version. Buildroot builds its own 
host-tar only when the host is missing a suitable tar.

This is related to the issue discovered with tar version 1.30 that generates 
slightly different archives.

  http://lists.busybox.net/pipermail/buildroot/2018-January/211222.html

This has also been discussed in the last developers meeting (first item):

  https://annuel2.framapad.org/p/BuildrootFosdem2018

baruch

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -

[Buildroot] [PATCH v2 2/2] xf86-video-armada: new package

[Fabio Estevam]

Hi Baruch,

On Wed, Feb 7, 2018 at 3:40 AM, Baruch Siach <baruch@tkos.co.il> wrote:

> Thomas asks about your host installed tar version. Buildroot builds its own
> host-tar only when the host is missing a suitable tar.

Thanks for the clarification!

The host PC also uses tar 1.29 version:

~$ tar --version
tar (GNU tar) 1.29

Thanks

[Buildroot] [PATCH v2 2/2] xf86-video-armada: new package

[Evgeniy Didin]

Hi Thomas,

> > Which version of tar are you using? Which version of tar is Evgeniy
> > using?

The host PC I use has tar 1.26 version:

$ tar --version
tar (GNU tar) 1.26

-Evgeniy

[Buildroot] [PATCH v2 2/2] xf86-video-armada: new package

[Arnout Vandecappelle]

On 06-02-18 17:25, Fabio Estevam wrote:
> Hi Evgeniy,
> 
> On Fri, Feb 2, 2018 at 12:55 PM, Evgeniy Didin
> <Evgeniy.Didin@synopsys.com> wrote:
> 
>> +++ b/package/x11r7/xdriver_xf86-video-armada/xdriver_xf86-video-armada.hash
>> @@ -0,0 +1,6 @@
>> +# Locally calculated
>> +sha256 5df615507ca6579ffba6df8a2aea6f6b542aa3985598efae836f335f9752cb39        xdriver_xf86-video-armada-04748ff4fb30370086cc97b9487a32951c5600ba.tar.gz
> 
> I had to manually change the sha256 to
> 5df615507ca6579ffba6df8a2aea6f6b542aa3985598efae836f335f9752cb39 in
> order to fix the mismatch error.

 My cmp-foo may be off, but that is what is in the hash file, no?

 Regards,
 Arnout

> 
> With this fixed:
> 
> Tested-by: Fabio Estevam <festevam@gmail.com>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
> 

-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF

[Buildroot] [PATCH v2 2/2] xf86-video-armada: new package

[Fabio Estevam]

Hi Arnout,

On Wed, Feb 7, 2018 at 9:19 PM, Arnout Vandecappelle <arnout@mind.be> wrote:

>  My cmp-foo may be off, but that is what is in the hash file, no?

Sorry, I typed the sha256 incorrectly.

What I meant  to say is that I had to change it to:

# Locally calculated
sha256 6fdde0a589ae51f918a515506d425ae288116b0fc8b845e10d6fbeff75469028
xdriver_xf86-video-armada-04748ff4fb30370086cc97b9487a32951c5600ba.tar.gz

[Buildroot] [PATCH v2 1/2] libdrm-armada: new package

[Thomas Petazzoni]

Hello,

On Fri,  2 Feb 2018 17:55:25 +0300, Evgeniy Didin wrote:
> From: Evgeniy Didin <didin@synopsys.com>
> 
> libdrm-armada is an Etnaviv libdrm buffer object management module.
> It is used with xf86-driver-video-armada, which is Xorg driver for Etnaviv.
> 
> Signed-off-by: Evgeniy Didin <didin@synopsys.com>
> Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> Cc: Alexey Brodkin <abrodkin@synopsys.com>
> Cc: arc-buildroot at synopsys.com

Thanks for this contribution. On the first iteration, Fabio asked the
question of whether this package was really needed.

Do you know why this isn't in upstream libdrm ? Will these additional
features always be part of a separate libdrm-package project/package,
or is it planned to have them merged in libdrm at some point ?

Indeed, the fact that libdrm already has support for etnaviv makes the
thing a bit strange.

Could you comment on this ?

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
http://bootlin.com

[Buildroot] [PATCH v2 2/2] xf86-video-armada: new package

[Thomas Petazzoni]

Hello Evgeniy,

On Fri,  2 Feb 2018 17:55:26 +0300, Evgeniy Didin wrote:


> diff --git a/package/x11r7/xdriver_xf86-video-armada/Config.in b/package/x11r7/xdriver_xf86-video-armada/Config.in
> new file mode 100644
> index 0000000000..ade8a75643
> --- /dev/null
> +++ b/package/x11r7/xdriver_xf86-video-armada/Config.in
> @@ -0,0 +1,11 @@
> +config BR2_PACKAGE_XDRIVER_XF86_VIDEO_ARMADA
> +	bool "xf86-video-armada"
> +	depends on BR2_PACKAGE_MESA3D

It would be nice to add a comment about this dependency here, because
your package doesn't itself depend on mesa3d. I assume it's because you
need GLX support in the X.org server, but it would be nice to make this
explicit.


> +XDRIVER_XF86_VIDEO_ARMADA_VERSION = 04748ff4fb30370086cc97b9487a32951c5600ba
> +XDRIVER_XF86_VIDEO_ARMADA_SITE = http://git.arm.linux.org.uk/cgit/xf86-video-armada.git
> +XDRIVER_XF86_VIDEO_ARMADA_SITE_METHOD = git
> +XDRIVER_XF86_VIDEO_ARMADA_AUTORECONF = YES
> +XDRIVER_XF86_VIDEO_ARMADA_DEPENDENCIES = \
> +	libdrm-armada \
> +	xserver_xorg-server
> +
> +XDRIVER_XF86_VIDEO_ARMADA_LICENSE_FILES= README etna_viv/LICENSE

Space before =, and please put the LICENSE_FILES variable after the
LICENSE variable.

> +XDRIVER_XF86_VIDEO_ARMADA_LICENSE = BSD

BSD is not a license. See https://spdx.org/licenses/ for a list of
license codes.

> +#Need etna_viv source files for driver
> +define XDRIVER_XF86_VIDEO_ARMADA_ETNASRC
> +	git clone https://github.com/laanwj/etna_viv.git $(@D)/etna_viv

This is not acceptable, as it completely works around the Buildroot
download infrastructure, preventing offline builds. Why do we need
this ? Why isn't the upstream version of etnaviv sufficient ?

If it's really needed, a separate package will have to be created.

> +        mkdir $(@D)/m4
> +endef
> +
> +XDRIVER_XF86_VIDEO_ARMADA_POST_PATCH_HOOKS += XDRIVER_XF86_VIDEO_ARMADA_ETNASRC
> +
> +define XDRIVER_XF86_VIDEO_ARMADA_INSTALL_CONF_FILE
> +        $(INSTALL) -m 0644 -D $(@D)/conf/xorg-sample.conf $(TARGET_DIR)/etc/X11/xorg.conf
> +endef
> +
> +XDRIVER_XF86_VIDEO_ARMADA_POST_INSTALL_TARGET_HOOKS += XDRIVER_XF86_VIDEO_ARMADA_INSTALL_CONF_FILE
> +
> +
> +XDRIVER_XF86_VIDEO_ARMADA_CONF_OPTS = \
> +  --prefix=/usr --disable-vivante --disable-etnaviv \

--prefix=/usr is already passed by the autotools-package
infrastructure. Why do you disable vivante and etnaviv ?

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
http://bootlin.com