* [PATCH 0/2] ARM: dts: imx: Add Engicam 1.5 MX6 support
@ 2018-07-20 10:16 ` Jacopo Mondi
0 siblings, 0 replies; 10+ messages in thread
From: Jacopo Mondi @ 2018-07-20 10:16 UTC (permalink / raw)
To: shawnguo, s.hauer, kernel, fabio.estevam, linux-imx, robh+dt,
mark.rutland, linux, jagan
Cc: devicetree, Jacopo Mondi, linux-arm-kernel
Hello,
the 'EDIMM Starter Kit 1.5 MIPI Evaluation" board, whose support has been
introduced by commit:
commit 3fe08835773121870b1de7d0cac9a4ade796661e ("ARM: dts: imx6q: Add Engicam
i.CoreM6 1.5 Quad/Dual MIPI starter kit support")
is actually based on 1.5 version of the "i.Core 1.5 MX6" CPU module which
differs from the original "i.Core MX6" for a few details, including the one that
has sparkled this activity: the ethernet PHY interface clock provider.
Instead of fixing the PHY clock provider in the imx6q-icore-mipi.dts file, I
preferred adding a new .dtsi for the 1.5 version of the module, to gather
differences between version in a single place. Then I've referenced the new one
in the dts file.
As a result, the ethernet interface is now working on the EDIMM 1.5 MIPI
evaluation kit.
Thanks
j
Jacopo Mondi (2):
ARM: dts: imx6qdl: Add Engicam i.Core 1.5 MX6
ARM: dts: imx6q-icore-mipi: Use 1.5 version of i.Core MX6
arch/arm/boot/dts/imx6q-icore-mipi.dts | 4 ++--
arch/arm/boot/dts/imx6qdl-icore-1.5.dtsi | 34 ++++++++++++++++++++++++++++++++
2 files changed, 36 insertions(+), 2 deletions(-)
create mode 100644 arch/arm/boot/dts/imx6qdl-icore-1.5.dtsi
--
2.7.4
^ permalink raw reply [flat|nested] 10+ messages in thread* [PATCH 0/2] ARM: dts: imx: Add Engicam 1.5 MX6 support
@ 2018-07-20 10:16 ` Jacopo Mondi
0 siblings, 0 replies; 10+ messages in thread
From: Jacopo Mondi @ 2018-07-20 10:16 UTC (permalink / raw)
To: linux-arm-kernel
Hello,
the 'EDIMM Starter Kit 1.5 MIPI Evaluation" board, whose support has been
introduced by commit:
commit 3fe08835773121870b1de7d0cac9a4ade796661e ("ARM: dts: imx6q: Add Engicam
i.CoreM6 1.5 Quad/Dual MIPI starter kit support")
is actually based on 1.5 version of the "i.Core 1.5 MX6" CPU module which
differs from the original "i.Core MX6" for a few details, including the one that
has sparkled this activity: the ethernet PHY interface clock provider.
Instead of fixing the PHY clock provider in the imx6q-icore-mipi.dts file, I
preferred adding a new .dtsi for the 1.5 version of the module, to gather
differences between version in a single place. Then I've referenced the new one
in the dts file.
As a result, the ethernet interface is now working on the EDIMM 1.5 MIPI
evaluation kit.
Thanks
j
Jacopo Mondi (2):
ARM: dts: imx6qdl: Add Engicam i.Core 1.5 MX6
ARM: dts: imx6q-icore-mipi: Use 1.5 version of i.Core MX6
arch/arm/boot/dts/imx6q-icore-mipi.dts | 4 ++--
arch/arm/boot/dts/imx6qdl-icore-1.5.dtsi | 34 ++++++++++++++++++++++++++++++++
2 files changed, 36 insertions(+), 2 deletions(-)
create mode 100644 arch/arm/boot/dts/imx6qdl-icore-1.5.dtsi
--
2.7.4
^ permalink raw reply [flat|nested] 10+ messages in thread* [PATCH 1/2] ARM: dts: imx6qdl: Add Engicam i.Core 1.5 MX6
2018-07-20 10:16 ` Jacopo Mondi
@ 2018-07-20 10:16 ` Jacopo Mondi
-1 siblings, 0 replies; 10+ messages in thread
From: Jacopo Mondi @ 2018-07-20 10:16 UTC (permalink / raw)
To: shawnguo, s.hauer, kernel, fabio.estevam, linux-imx, robh+dt,
mark.rutland, linux, jagan
Cc: devicetree, Jacopo Mondi, linux-arm-kernel
The 1.5 version of Engicam's i.Core MX6 CPU module features a different clock
provider for the ethernet's PHY interface. Adjust the FEC ptp clock to
reference CLK_ENET_REF clock source, and set SION bit of
MX6QDL_PAD_GPIO_16__ENET_REF_CLK to adjust the input path of that pin.
The newly introduced imx6ql-icore-1.5.dtsi allows to collect in a single
place differences between version '1.0' and '1.5' of the module.
Signed-off-by: Jacopo Mondi <jacopo@jmondi.org>
---
arch/arm/boot/dts/imx6qdl-icore-1.5.dtsi | 34 ++++++++++++++++++++++++++++++++
1 file changed, 34 insertions(+)
create mode 100644 arch/arm/boot/dts/imx6qdl-icore-1.5.dtsi
diff --git a/arch/arm/boot/dts/imx6qdl-icore-1.5.dtsi b/arch/arm/boot/dts/imx6qdl-icore-1.5.dtsi
new file mode 100644
index 0000000..d91d46b
--- /dev/null
+++ b/arch/arm/boot/dts/imx6qdl-icore-1.5.dtsi
@@ -0,0 +1,34 @@
+// SPDX-License-Identifier: GPL-2.0+
+/*
+ * Copyright (C) 2018 Jacopo Mondi <jacopo@jmondi.org>
+ */
+
+#include "imx6qdl-icore.dtsi"
+
+&iomuxc {
+ pinctrl_enet: enetgrp {
+ fsl,pins = <
+ MX6QDL_PAD_ENET_CRS_DV__ENET_RX_EN 0x1b0b0
+ MX6QDL_PAD_GPIO_16__ENET_REF_CLK 0x4001b0b0
+ MX6QDL_PAD_ENET_TX_EN__ENET_TX_EN 0x1b0b0
+ MX6QDL_PAD_ENET_RXD1__ENET_RX_DATA1 0x1b0b0
+ MX6QDL_PAD_ENET_RXD0__ENET_RX_DATA0 0x1b0b0
+ MX6QDL_PAD_ENET_TXD1__ENET_TX_DATA1 0x1b0b0
+ MX6QDL_PAD_ENET_TXD0__ENET_TX_DATA0 0x1b0b0
+ MX6QDL_PAD_ENET_MDC__ENET_MDC 0x1b0b0
+ MX6QDL_PAD_ENET_MDIO__ENET_MDIO 0x1b0b0
+ MX6QDL_PAD_GPIO_17__GPIO7_IO12 0x1b0b0
+ >;
+ };
+};
+
+&fec {
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_enet>;
+ phy-reset-gpios = <&gpio7 12 GPIO_ACTIVE_LOW>;
+ clocks = <&clks IMX6QDL_CLK_ENET>,
+ <&clks IMX6QDL_CLK_ENET>,
+ <&clks IMX6QDL_CLK_ENET_REF>;
+ phy-mode = "rmii";
+ status = "okay";
+};
--
2.7.4
^ permalink raw reply related [flat|nested] 10+ messages in thread* [PATCH 1/2] ARM: dts: imx6qdl: Add Engicam i.Core 1.5 MX6
@ 2018-07-20 10:16 ` Jacopo Mondi
0 siblings, 0 replies; 10+ messages in thread
From: Jacopo Mondi @ 2018-07-20 10:16 UTC (permalink / raw)
To: linux-arm-kernel
The 1.5 version of Engicam's i.Core MX6 CPU module features a different clock
provider for the ethernet's PHY interface. Adjust the FEC ptp clock to
reference CLK_ENET_REF clock source, and set SION bit of
MX6QDL_PAD_GPIO_16__ENET_REF_CLK to adjust the input path of that pin.
The newly introduced imx6ql-icore-1.5.dtsi allows to collect in a single
place differences between version '1.0' and '1.5' of the module.
Signed-off-by: Jacopo Mondi <jacopo@jmondi.org>
---
arch/arm/boot/dts/imx6qdl-icore-1.5.dtsi | 34 ++++++++++++++++++++++++++++++++
1 file changed, 34 insertions(+)
create mode 100644 arch/arm/boot/dts/imx6qdl-icore-1.5.dtsi
diff --git a/arch/arm/boot/dts/imx6qdl-icore-1.5.dtsi b/arch/arm/boot/dts/imx6qdl-icore-1.5.dtsi
new file mode 100644
index 0000000..d91d46b
--- /dev/null
+++ b/arch/arm/boot/dts/imx6qdl-icore-1.5.dtsi
@@ -0,0 +1,34 @@
+// SPDX-License-Identifier: GPL-2.0+
+/*
+ * Copyright (C) 2018 Jacopo Mondi <jacopo@jmondi.org>
+ */
+
+#include "imx6qdl-icore.dtsi"
+
+&iomuxc {
+ pinctrl_enet: enetgrp {
+ fsl,pins = <
+ MX6QDL_PAD_ENET_CRS_DV__ENET_RX_EN 0x1b0b0
+ MX6QDL_PAD_GPIO_16__ENET_REF_CLK 0x4001b0b0
+ MX6QDL_PAD_ENET_TX_EN__ENET_TX_EN 0x1b0b0
+ MX6QDL_PAD_ENET_RXD1__ENET_RX_DATA1 0x1b0b0
+ MX6QDL_PAD_ENET_RXD0__ENET_RX_DATA0 0x1b0b0
+ MX6QDL_PAD_ENET_TXD1__ENET_TX_DATA1 0x1b0b0
+ MX6QDL_PAD_ENET_TXD0__ENET_TX_DATA0 0x1b0b0
+ MX6QDL_PAD_ENET_MDC__ENET_MDC 0x1b0b0
+ MX6QDL_PAD_ENET_MDIO__ENET_MDIO 0x1b0b0
+ MX6QDL_PAD_GPIO_17__GPIO7_IO12 0x1b0b0
+ >;
+ };
+};
+
+&fec {
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_enet>;
+ phy-reset-gpios = <&gpio7 12 GPIO_ACTIVE_LOW>;
+ clocks = <&clks IMX6QDL_CLK_ENET>,
+ <&clks IMX6QDL_CLK_ENET>,
+ <&clks IMX6QDL_CLK_ENET_REF>;
+ phy-mode = "rmii";
+ status = "okay";
+};
--
2.7.4
^ permalink raw reply related [flat|nested] 10+ messages in thread* Re: [PATCH 1/2] ARM: dts: imx6qdl: Add Engicam i.Core 1.5 MX6
2018-07-20 10:16 ` Jacopo Mondi
@ 2018-07-20 19:07 ` Fabio Estevam
-1 siblings, 0 replies; 10+ messages in thread
From: Fabio Estevam @ 2018-07-20 19:07 UTC (permalink / raw)
To: Jacopo Mondi
Cc: Mark Rutland,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
Sascha Hauer, Russell King - ARM Linux, Rob Herring,
NXP Linux Team, Sascha Hauer, Fabio Estevam, Shawn Guo,
moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
Jagan Teki
On Fri, Jul 20, 2018 at 7:16 AM, Jacopo Mondi <jacopo@jmondi.org> wrote:
> The 1.5 version of Engicam's i.Core MX6 CPU module features a different clock
> provider for the ethernet's PHY interface. Adjust the FEC ptp clock to
> reference CLK_ENET_REF clock source, and set SION bit of
> MX6QDL_PAD_GPIO_16__ENET_REF_CLK to adjust the input path of that pin.
>
> The newly introduced imx6ql-icore-1.5.dtsi allows to collect in a single
> place differences between version '1.0' and '1.5' of the module.
>
> Signed-off-by: Jacopo Mondi <jacopo@jmondi.org>
Reviewed-by: Fabio Estevam <fabio.estevam@nxp.com>
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH 1/2] ARM: dts: imx6qdl: Add Engicam i.Core 1.5 MX6
@ 2018-07-20 19:07 ` Fabio Estevam
0 siblings, 0 replies; 10+ messages in thread
From: Fabio Estevam @ 2018-07-20 19:07 UTC (permalink / raw)
To: linux-arm-kernel
On Fri, Jul 20, 2018 at 7:16 AM, Jacopo Mondi <jacopo@jmondi.org> wrote:
> The 1.5 version of Engicam's i.Core MX6 CPU module features a different clock
> provider for the ethernet's PHY interface. Adjust the FEC ptp clock to
> reference CLK_ENET_REF clock source, and set SION bit of
> MX6QDL_PAD_GPIO_16__ENET_REF_CLK to adjust the input path of that pin.
>
> The newly introduced imx6ql-icore-1.5.dtsi allows to collect in a single
> place differences between version '1.0' and '1.5' of the module.
>
> Signed-off-by: Jacopo Mondi <jacopo@jmondi.org>
Reviewed-by: Fabio Estevam <fabio.estevam@nxp.com>
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH 2/2] ARM: dts: imx6q-icore-mipi: Use 1.5 version of i.Core MX6
2018-07-20 10:16 ` Jacopo Mondi
@ 2018-07-20 10:16 ` Jacopo Mondi
-1 siblings, 0 replies; 10+ messages in thread
From: Jacopo Mondi @ 2018-07-20 10:16 UTC (permalink / raw)
To: shawnguo, s.hauer, kernel, fabio.estevam, linux-imx, robh+dt,
mark.rutland, linux, jagan
Cc: devicetree, Jacopo Mondi, linux-arm-kernel
The "EDIMM STARTER KIT i.Core 1.5 MIPI Evaluation" is based on the 1.5 version
of the i.Core MX6 cpu module. The 1.5 version differs from the original one for
a few details, including the ethernet PHY interface clock provider.
With this commit, the ethernet interface works properly:
SMSC LAN8710/LAN8720 2188000.ethernet-1:00: attached PHY driver
While before using the 1.5 version, ethernet failed to startup do to un-clocked
PHY interface:
fec 2188000.ethernet eth0: could not attach to PHY
Fixes: commit 3fe088357731 ("ARM: dts: imx6q: Add Engicam i.CoreM6 1.5 Quad/Dual MIPI starter kit support")
Signed-off-by: Jacopo Mondi <jacopo@jmondi.org>
---
arch/arm/boot/dts/imx6q-icore-mipi.dts | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/boot/dts/imx6q-icore-mipi.dts b/arch/arm/boot/dts/imx6q-icore-mipi.dts
index 95b2efd..1f15882 100644
--- a/arch/arm/boot/dts/imx6q-icore-mipi.dts
+++ b/arch/arm/boot/dts/imx6q-icore-mipi.dts
@@ -8,10 +8,10 @@
/dts-v1/;
#include "imx6q.dtsi"
-#include "imx6qdl-icore.dtsi"
+#include "imx6qdl-icore-1.5.dtsi"
/ {
- model = "Engicam i.CoreM6 Quad/Dual MIPI Starter Kit";
+ model = "Engicam i.CoreM6 1.5 Quad/Dual MIPI Starter Kit";
compatible = "engicam,imx6-icore", "fsl,imx6q";
};
--
2.7.4
^ permalink raw reply related [flat|nested] 10+ messages in thread* [PATCH 2/2] ARM: dts: imx6q-icore-mipi: Use 1.5 version of i.Core MX6
@ 2018-07-20 10:16 ` Jacopo Mondi
0 siblings, 0 replies; 10+ messages in thread
From: Jacopo Mondi @ 2018-07-20 10:16 UTC (permalink / raw)
To: linux-arm-kernel
The "EDIMM STARTER KIT i.Core 1.5 MIPI Evaluation" is based on the 1.5 version
of the i.Core MX6 cpu module. The 1.5 version differs from the original one for
a few details, including the ethernet PHY interface clock provider.
With this commit, the ethernet interface works properly:
SMSC LAN8710/LAN8720 2188000.ethernet-1:00: attached PHY driver
While before using the 1.5 version, ethernet failed to startup do to un-clocked
PHY interface:
fec 2188000.ethernet eth0: could not attach to PHY
Fixes: commit 3fe088357731 ("ARM: dts: imx6q: Add Engicam i.CoreM6 1.5 Quad/Dual MIPI starter kit support")
Signed-off-by: Jacopo Mondi <jacopo@jmondi.org>
---
arch/arm/boot/dts/imx6q-icore-mipi.dts | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/boot/dts/imx6q-icore-mipi.dts b/arch/arm/boot/dts/imx6q-icore-mipi.dts
index 95b2efd..1f15882 100644
--- a/arch/arm/boot/dts/imx6q-icore-mipi.dts
+++ b/arch/arm/boot/dts/imx6q-icore-mipi.dts
@@ -8,10 +8,10 @@
/dts-v1/;
#include "imx6q.dtsi"
-#include "imx6qdl-icore.dtsi"
+#include "imx6qdl-icore-1.5.dtsi"
/ {
- model = "Engicam i.CoreM6 Quad/Dual MIPI Starter Kit";
+ model = "Engicam i.CoreM6 1.5 Quad/Dual MIPI Starter Kit";
compatible = "engicam,imx6-icore", "fsl,imx6q";
};
--
2.7.4
^ permalink raw reply related [flat|nested] 10+ messages in thread* Re: [PATCH 2/2] ARM: dts: imx6q-icore-mipi: Use 1.5 version of i.Core MX6
2018-07-20 10:16 ` Jacopo Mondi
@ 2018-07-20 19:10 ` Fabio Estevam
-1 siblings, 0 replies; 10+ messages in thread
From: Fabio Estevam @ 2018-07-20 19:10 UTC (permalink / raw)
To: Jacopo Mondi
Cc: Mark Rutland,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
Sascha Hauer, Russell King - ARM Linux, Rob Herring,
NXP Linux Team, Sascha Hauer, Fabio Estevam, Shawn Guo,
moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
Jagan Teki
On Fri, Jul 20, 2018 at 7:16 AM, Jacopo Mondi <jacopo@jmondi.org> wrote:
> The "EDIMM STARTER KIT i.Core 1.5 MIPI Evaluation" is based on the 1.5 version
> of the i.Core MX6 cpu module. The 1.5 version differs from the original one for
> a few details, including the ethernet PHY interface clock provider.
>
> With this commit, the ethernet interface works properly:
> SMSC LAN8710/LAN8720 2188000.ethernet-1:00: attached PHY driver
>
> While before using the 1.5 version, ethernet failed to startup do to un-clocked
> PHY interface:
> fec 2188000.ethernet eth0: could not attach to PHY
>
> Fixes: commit 3fe088357731 ("ARM: dts: imx6q: Add Engicam i.CoreM6 1.5 Quad/Dual MIPI starter kit support")
Nit: the "commit" word should be removed from the Fixes line.
>
Also, no need to add a blank line after the Fixes tag.
Reviewed-by: Fabio Estevam <fabio.estevam@nxp.com>
> Signed-off-by: Jacopo Mondi <jacopo@jmondi.org>
^ permalink raw reply [flat|nested] 10+ messages in thread* [PATCH 2/2] ARM: dts: imx6q-icore-mipi: Use 1.5 version of i.Core MX6
@ 2018-07-20 19:10 ` Fabio Estevam
0 siblings, 0 replies; 10+ messages in thread
From: Fabio Estevam @ 2018-07-20 19:10 UTC (permalink / raw)
To: linux-arm-kernel
On Fri, Jul 20, 2018 at 7:16 AM, Jacopo Mondi <jacopo@jmondi.org> wrote:
> The "EDIMM STARTER KIT i.Core 1.5 MIPI Evaluation" is based on the 1.5 version
> of the i.Core MX6 cpu module. The 1.5 version differs from the original one for
> a few details, including the ethernet PHY interface clock provider.
>
> With this commit, the ethernet interface works properly:
> SMSC LAN8710/LAN8720 2188000.ethernet-1:00: attached PHY driver
>
> While before using the 1.5 version, ethernet failed to startup do to un-clocked
> PHY interface:
> fec 2188000.ethernet eth0: could not attach to PHY
>
> Fixes: commit 3fe088357731 ("ARM: dts: imx6q: Add Engicam i.CoreM6 1.5 Quad/Dual MIPI starter kit support")
Nit: the "commit" word should be removed from the Fixes line.
>
Also, no need to add a blank line after the Fixes tag.
Reviewed-by: Fabio Estevam <fabio.estevam@nxp.com>
> Signed-off-by: Jacopo Mondi <jacopo@jmondi.org>
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2018-07-20 19:10 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-07-20 10:16 [PATCH 0/2] ARM: dts: imx: Add Engicam 1.5 MX6 support Jacopo Mondi
2018-07-20 10:16 ` Jacopo Mondi
2018-07-20 10:16 ` [PATCH 1/2] ARM: dts: imx6qdl: Add Engicam i.Core 1.5 MX6 Jacopo Mondi
2018-07-20 10:16 ` Jacopo Mondi
2018-07-20 19:07 ` Fabio Estevam
2018-07-20 19:07 ` Fabio Estevam
2018-07-20 10:16 ` [PATCH 2/2] ARM: dts: imx6q-icore-mipi: Use 1.5 version of i.Core MX6 Jacopo Mondi
2018-07-20 10:16 ` Jacopo Mondi
2018-07-20 19:10 ` Fabio Estevam
2018-07-20 19:10 ` Fabio Estevam
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.