All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/1] ARM: dts: imx6ul: add spdif node
@ 2021-05-31 10:01 Jörg Krause
  2021-05-31 21:32 ` Fabio Estevam
  2021-06-12  7:21 ` Shawn Guo
  0 siblings, 2 replies; 4+ messages in thread
From: Jörg Krause @ 2021-05-31 10:01 UTC (permalink / raw)
  To: linux-arm-kernel
  Cc: Fabio Estevam, Shawn Guo, Sascha Hauer, NXP Linux Team, Jörg Krause

The i.MX6UL has a SPDIF located at start address 0x02004000 in the
AIPS-1 memory region [1].

SPDIF is also available on i.MX6ULL [2], so imx6ull.dtsi is fine.

[1] i.MX 6UltraLite Applications Processor Reference Manual, Rev. 2,
    03/2017, Table-2-2 AIPS-1 memory map, p. 158
[2] i.MX 6ULL Applications Processor Reference Manual, Rev. 1,
    11/2017, Table-2-2 AIPS-1 memory map, p. 178

Signed-off-by: Jörg Krause <joerg.krause@embedded.rocks>
---
 arch/arm/boot/dts/imx6ul.dtsi | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)

diff --git a/arch/arm/boot/dts/imx6ul.dtsi b/arch/arm/boot/dts/imx6ul.dtsi
index afeec01f6522..f9c867e97b9a 100644
--- a/arch/arm/boot/dts/imx6ul.dtsi
+++ b/arch/arm/boot/dts/imx6ul.dtsi
@@ -210,6 +210,30 @@ spba-bus@2000000 {
 				reg = <0x02000000 0x40000>;
 				ranges;
 
+				spdif: spdif@2004000 {
+					compatible = "fsl,imx6ul-spdif", "fsl,imx35-spdif";
+					reg = <0x02004000 0x4000>;
+					interrupts = <GIC_SPI 52 IRQ_TYPE_LEVEL_HIGH>;
+					dmas = <&sdma 41 18 0>, <&sdma 42 18 0>;
+					dma-names = "rx", "tx";
+					clocks = <&clks IMX6UL_CLK_SPDIF_GCLK>,
+						 <&clks IMX6UL_CLK_OSC>,
+						 <&clks IMX6UL_CLK_SPDIF>,
+						 <&clks IMX6UL_CLK_DUMMY>,
+						 <&clks IMX6UL_CLK_DUMMY>,
+						 <&clks IMX6UL_CLK_DUMMY>,
+						 <&clks IMX6UL_CLK_IPG>,
+						 <&clks IMX6UL_CLK_DUMMY>,
+						 <&clks IMX6UL_CLK_DUMMY>,
+						 <&clks IMX6UL_CLK_SPBA>;
+					clock-names = "core", "rxtx0",
+						      "rxtx1", "rxtx2",
+						      "rxtx3", "rxtx4",
+						      "rxtx5", "rxtx6",
+						      "rxtx7", "spba";
+					status = "disabled";
+				};
+
 				ecspi1: spi@2008000 {
 					#address-cells = <1>;
 					#size-cells = <0>;
-- 
2.31.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH 1/1] ARM: dts: imx6ul: add spdif node
  2021-05-31 10:01 [PATCH 1/1] ARM: dts: imx6ul: add spdif node Jörg Krause
@ 2021-05-31 21:32 ` Fabio Estevam
  2021-06-03  8:23   ` Jörg Krause
  2021-06-12  7:21 ` Shawn Guo
  1 sibling, 1 reply; 4+ messages in thread
From: Fabio Estevam @ 2021-05-31 21:32 UTC (permalink / raw)
  To: Jörg Krause
  Cc: moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
	Shawn Guo, Sascha Hauer, NXP Linux Team

Hi Jörg,

On Mon, May 31, 2021 at 7:01 AM Jörg Krause <joerg.krause@embedded.rocks> wrote:
>
> The i.MX6UL has a SPDIF located at start address 0x02004000 in the
> AIPS-1 memory region [1].
>
> SPDIF is also available on i.MX6ULL [2], so imx6ull.dtsi is fine.
>
> [1] i.MX 6UltraLite Applications Processor Reference Manual, Rev. 2,
>     03/2017, Table-2-2 AIPS-1 memory map, p. 158
> [2] i.MX 6ULL Applications Processor Reference Manual, Rev. 1,
>     11/2017, Table-2-2 AIPS-1 memory map, p. 178
>
> Signed-off-by: Jörg Krause <joerg.krause@embedded.rocks>

The patch looks good.

Did you have a chance to test this on your hardware?

Thanks

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH 1/1] ARM: dts: imx6ul: add spdif node
  2021-05-31 21:32 ` Fabio Estevam
@ 2021-06-03  8:23   ` Jörg Krause
  0 siblings, 0 replies; 4+ messages in thread
From: Jörg Krause @ 2021-06-03  8:23 UTC (permalink / raw)
  To: Fabio Estevam
  Cc: moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
	Shawn Guo, Sascha Hauer, NXP Linux Team

Hi Fabio,

yes, I am running it on a custom i.MX6ULL board:

```
imx-spdif sound-spdif: snd-soc-dummy-dai <-> 2004000.spdif mapping ok
```

Best regards
Jörg Krause

On Mon, 2021-05-31 at 18:32 -0300, Fabio Estevam wrote:
> Hi Jörg,
> 
> On Mon, May 31, 2021 at 7:01 AM Jörg Krause <joerg.krause@embedded.rocks> wrote:
> > 
> > The i.MX6UL has a SPDIF located at start address 0x02004000 in the
> > AIPS-1 memory region [1].
> > 
> > SPDIF is also available on i.MX6ULL [2], so imx6ull.dtsi is fine.
> > 
> > [1] i.MX 6UltraLite Applications Processor Reference Manual, Rev. 2,
> >     03/2017, Table-2-2 AIPS-1 memory map, p. 158
> > [2] i.MX 6ULL Applications Processor Reference Manual, Rev. 1,
> >     11/2017, Table-2-2 AIPS-1 memory map, p. 178
> > 
> > Signed-off-by: Jörg Krause <joerg.krause@embedded.rocks>
> 
> The patch looks good.
> 
> Did you have a chance to test this on your hardware?
> 
> Thanks


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH 1/1] ARM: dts: imx6ul: add spdif node
  2021-05-31 10:01 [PATCH 1/1] ARM: dts: imx6ul: add spdif node Jörg Krause
  2021-05-31 21:32 ` Fabio Estevam
@ 2021-06-12  7:21 ` Shawn Guo
  1 sibling, 0 replies; 4+ messages in thread
From: Shawn Guo @ 2021-06-12  7:21 UTC (permalink / raw)
  To: Jörg Krause
  Cc: linux-arm-kernel, Fabio Estevam, Sascha Hauer, NXP Linux Team

On Mon, May 31, 2021 at 10:01:08AM +0000, Jörg Krause wrote:
> The i.MX6UL has a SPDIF located at start address 0x02004000 in the
> AIPS-1 memory region [1].
> 
> SPDIF is also available on i.MX6ULL [2], so imx6ull.dtsi is fine.
> 
> [1] i.MX 6UltraLite Applications Processor Reference Manual, Rev. 2,
>     03/2017, Table-2-2 AIPS-1 memory map, p. 158
> [2] i.MX 6ULL Applications Processor Reference Manual, Rev. 1,
>     11/2017, Table-2-2 AIPS-1 memory map, p. 178
> 
> Signed-off-by: Jörg Krause <joerg.krause@embedded.rocks>
> ---
>  arch/arm/boot/dts/imx6ul.dtsi | 24 ++++++++++++++++++++++++
>  1 file changed, 24 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/imx6ul.dtsi b/arch/arm/boot/dts/imx6ul.dtsi
> index afeec01f6522..f9c867e97b9a 100644
> --- a/arch/arm/boot/dts/imx6ul.dtsi
> +++ b/arch/arm/boot/dts/imx6ul.dtsi
> @@ -210,6 +210,30 @@ spba-bus@2000000 {
>  				reg = <0x02000000 0x40000>;
>  				ranges;
>  
> +				spdif: spdif@2004000 {
> +					compatible = "fsl,imx6ul-spdif", "fsl,imx35-spdif";

New compatible needs to be documented.

Shawn

> +					reg = <0x02004000 0x4000>;
> +					interrupts = <GIC_SPI 52 IRQ_TYPE_LEVEL_HIGH>;
> +					dmas = <&sdma 41 18 0>, <&sdma 42 18 0>;
> +					dma-names = "rx", "tx";
> +					clocks = <&clks IMX6UL_CLK_SPDIF_GCLK>,
> +						 <&clks IMX6UL_CLK_OSC>,
> +						 <&clks IMX6UL_CLK_SPDIF>,
> +						 <&clks IMX6UL_CLK_DUMMY>,
> +						 <&clks IMX6UL_CLK_DUMMY>,
> +						 <&clks IMX6UL_CLK_DUMMY>,
> +						 <&clks IMX6UL_CLK_IPG>,
> +						 <&clks IMX6UL_CLK_DUMMY>,
> +						 <&clks IMX6UL_CLK_DUMMY>,
> +						 <&clks IMX6UL_CLK_SPBA>;
> +					clock-names = "core", "rxtx0",
> +						      "rxtx1", "rxtx2",
> +						      "rxtx3", "rxtx4",
> +						      "rxtx5", "rxtx6",
> +						      "rxtx7", "spba";
> +					status = "disabled";
> +				};
> +
>  				ecspi1: spi@2008000 {
>  					#address-cells = <1>;
>  					#size-cells = <0>;
> -- 
> 2.31.1
> 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2021-06-12  7:22 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-31 10:01 [PATCH 1/1] ARM: dts: imx6ul: add spdif node Jörg Krause
2021-05-31 21:32 ` Fabio Estevam
2021-06-03  8:23   ` Jörg Krause
2021-06-12  7:21 ` Shawn Guo

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.