All of lore.kernel.org
 help / color / mirror / Atom feed
From: Fabio Estevam <festevam@gmail.com>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
	"Magnus Lilja" <lilja.magnus@gmail.com>
Cc: Vladimir Zapolskiy <vz@mleia.com>,
	Shawn Guo <shawnguo@kernel.org>, Wim Van Sebroeck <wim@iguana.be>,
	Guenter Roeck <linux@roeck-us.net>,
	Fabio Estevam <fabio.estevam@nxp.com>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	linux-watchdog@vger.kernel.org,
	Sascha Hauer <kernel@pengutronix.de>
Subject: Re: [PATCH 1/3] watchdog: imx2: Only i.MX35 and later have a WMCR register
Date: Mon, 16 Jan 2017 11:34:05 -0200	[thread overview]
Message-ID: <CAOMZO5BH+B5dxNGC-2bNZe-PCqcmOXd=xenmd-pfLKncDp--gg@mail.gmail.com> (raw)
In-Reply-To: <20170109095039.11979-2-u.kleine-koenig@pengutronix.de>

Hi Magnus,

On Mon, Jan 9, 2017 at 7:50 AM, Uwe Kleine-König
<u.kleine-koenig@pengutronix.de> wrote:
> Commit 5fe65ce7ccbb ("watchdog: imx2_wdt: Disable power down counter on
> boot") introduced a write to the WMCR register that doesn't exist on
> i.MX21, i.MX27 and i.MX31 and so makes the SoC hang during probe.
>
> So teach the driver to differentiate between these two types. Note that
> this effectively undoes commit 5fe65ce7ccbb for machines using dt until
> their dtb is updated accordingly. This is critical iff the bootloader
> doesn't disable the power down counter and the #WDOG signal actually
> does something to the machine.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>

Is it possible for you to try this series and let us know if it fixes
the mx31 watchdog issue?

Thanks

WARNING: multiple messages have this Message-ID (diff)
From: festevam@gmail.com (Fabio Estevam)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/3] watchdog: imx2: Only i.MX35 and later have a WMCR register
Date: Mon, 16 Jan 2017 11:34:05 -0200	[thread overview]
Message-ID: <CAOMZO5BH+B5dxNGC-2bNZe-PCqcmOXd=xenmd-pfLKncDp--gg@mail.gmail.com> (raw)
In-Reply-To: <20170109095039.11979-2-u.kleine-koenig@pengutronix.de>

Hi Magnus,

On Mon, Jan 9, 2017 at 7:50 AM, Uwe Kleine-K?nig
<u.kleine-koenig@pengutronix.de> wrote:
> Commit 5fe65ce7ccbb ("watchdog: imx2_wdt: Disable power down counter on
> boot") introduced a write to the WMCR register that doesn't exist on
> i.MX21, i.MX27 and i.MX31 and so makes the SoC hang during probe.
>
> So teach the driver to differentiate between these two types. Note that
> this effectively undoes commit 5fe65ce7ccbb for machines using dt until
> their dtb is updated accordingly. This is critical iff the bootloader
> doesn't disable the power down counter and the #WDOG signal actually
> does something to the machine.
>
> Signed-off-by: Uwe Kleine-K?nig <u.kleine-koenig@pengutronix.de>

Is it possible for you to try this series and let us know if it fixes
the mx31 watchdog issue?

Thanks

  reply	other threads:[~2017-01-16 13:34 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-09  9:50 [PATCH 0/3] watchdog: imx2: handle WMCR only being available on i.MX35 and later Uwe Kleine-König
2017-01-09  9:50 ` Uwe Kleine-König
2017-01-09  9:50 ` [PATCH 1/3] watchdog: imx2: Only i.MX35 and later have a WMCR register Uwe Kleine-König
2017-01-09  9:50   ` Uwe Kleine-König
2017-01-16 13:34   ` Fabio Estevam [this message]
2017-01-16 13:34     ` Fabio Estevam
2017-01-16 18:34   ` Fabio Estevam
2017-01-16 18:34     ` Fabio Estevam
2017-01-09  9:50 ` [PATCH 2/3] dts: teach newer i.MX machines to have the i.MX35 type watchdog Uwe Kleine-König
2017-01-09  9:50   ` Uwe Kleine-König
2017-01-16 18:35   ` Fabio Estevam
2017-01-16 18:35     ` Fabio Estevam
2017-01-16 20:43     ` Uwe Kleine-König
2017-01-16 20:43       ` Uwe Kleine-König
2017-01-16 21:48       ` Vladimir Zapolskiy
2017-01-16 21:48         ` Vladimir Zapolskiy
2017-01-17  8:10         ` Uwe Kleine-König
2017-01-17  8:10           ` Uwe Kleine-König
2017-01-09  9:50 ` [PATCH 3/3] watchdog: imx2: add compatibility for new " Uwe Kleine-König
2017-01-09  9:50   ` Uwe Kleine-König
2017-01-16 18:36   ` Fabio Estevam
2017-01-16 18:36     ` Fabio Estevam
2017-01-09 10:55 ` [PATCH 0/3] watchdog: imx2: handle WMCR only being available on i.MX35 and later Vladimir Zapolskiy
2017-01-09 10:55   ` Vladimir Zapolskiy
2017-01-09 11:04   ` Uwe Kleine-König
2017-01-09 11:04     ` Uwe Kleine-König
2017-01-09 17:19 ` Guenter Roeck
2017-01-09 17:19   ` Guenter Roeck
2017-01-09 20:06   ` Uwe Kleine-König
2017-01-09 20:06     ` Uwe Kleine-König
2017-01-16 17:27 ` Magnus Lilja
2017-01-16 17:27   ` Magnus Lilja

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAOMZO5BH+B5dxNGC-2bNZe-PCqcmOXd=xenmd-pfLKncDp--gg@mail.gmail.com' \
    --to=festevam@gmail.com \
    --cc=fabio.estevam@nxp.com \
    --cc=kernel@pengutronix.de \
    --cc=lilja.magnus@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-watchdog@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=shawnguo@kernel.org \
    --cc=u.kleine-koenig@pengutronix.de \
    --cc=vz@mleia.com \
    --cc=wim@iguana.be \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.