* [PATCH] ARM: dts: imx6qdl-dhcom-pdk2: Include missing headers
@ 2021-12-31 0:12 Marek Vasut
2021-12-31 0:14 ` Fabio Estevam
2022-01-28 7:23 ` Shawn Guo
0 siblings, 2 replies; 3+ messages in thread
From: Marek Vasut @ 2021-12-31 0:12 UTC (permalink / raw)
To: linux-arm-kernel
Cc: Marek Vasut, Christoph Niedermaier, Fabio Estevam,
NXP Linux Team, Shawn Guo, kernel
Include missing headers, since this DT source uses symbolic names defined
in those headers. If an external DT includes this dtsi without including
the headers as well, the DT becomes unbuildable.
Three headers are included:
dt-bindings/gpio/gpio.h -- because this DT contains GPIO_ACTIVE_HIGH
dt-bindings/input/input.h -- because this DT contains KEY_A
dt-bindings/pwm/pwm.h -- because this DT contains PWM_POLARITY_INVERTED
Signed-off-by: Marek Vasut <marex@denx.de>
Cc: Christoph Niedermaier <cniedermaier@dh-electronics.com>
Cc: Fabio Estevam <festevam@gmail.com>
Cc: NXP Linux Team <linux-imx@nxp.com>
Cc: Shawn Guo <shawnguo@kernel.org>
Cc: kernel@dh-electronics.com
---
arch/arm/boot/dts/imx6qdl-dhcom-pdk2.dtsi | 3 +++
1 file changed, 3 insertions(+)
diff --git a/arch/arm/boot/dts/imx6qdl-dhcom-pdk2.dtsi b/arch/arm/boot/dts/imx6qdl-dhcom-pdk2.dtsi
index dc89b554e694e..fe72650295a5b 100644
--- a/arch/arm/boot/dts/imx6qdl-dhcom-pdk2.dtsi
+++ b/arch/arm/boot/dts/imx6qdl-dhcom-pdk2.dtsi
@@ -4,7 +4,10 @@
* Copyright (C) 2018 Marek Vasut <marex@denx.de>
*/
+#include <dt-bindings/gpio/gpio.h>
+#include <dt-bindings/input/input.h>
#include <dt-bindings/leds/common.h>
+#include <dt-bindings/pwm/pwm.h>
/ {
chosen {
--
2.34.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ARM: dts: imx6qdl-dhcom-pdk2: Include missing headers
2021-12-31 0:12 [PATCH] ARM: dts: imx6qdl-dhcom-pdk2: Include missing headers Marek Vasut
@ 2021-12-31 0:14 ` Fabio Estevam
2022-01-28 7:23 ` Shawn Guo
1 sibling, 0 replies; 3+ messages in thread
From: Fabio Estevam @ 2021-12-31 0:14 UTC (permalink / raw)
To: Marek Vasut
Cc: moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
Christoph Niedermaier, NXP Linux Team, Shawn Guo, kernel
Hi Marek,
On Thu, Dec 30, 2021 at 9:12 PM Marek Vasut <marex@denx.de> wrote:
>
> Include missing headers, since this DT source uses symbolic names defined
> in those headers. If an external DT includes this dtsi without including
> the headers as well, the DT becomes unbuildable.
>
> Three headers are included:
> dt-bindings/gpio/gpio.h -- because this DT contains GPIO_ACTIVE_HIGH
> dt-bindings/input/input.h -- because this DT contains KEY_A
> dt-bindings/pwm/pwm.h -- because this DT contains PWM_POLARITY_INVERTED
This makes sense:
Reviewed-by: Fabio Estevam <festevam@gmail.com>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ARM: dts: imx6qdl-dhcom-pdk2: Include missing headers
2021-12-31 0:12 [PATCH] ARM: dts: imx6qdl-dhcom-pdk2: Include missing headers Marek Vasut
2021-12-31 0:14 ` Fabio Estevam
@ 2022-01-28 7:23 ` Shawn Guo
1 sibling, 0 replies; 3+ messages in thread
From: Shawn Guo @ 2022-01-28 7:23 UTC (permalink / raw)
To: Marek Vasut
Cc: linux-arm-kernel, Christoph Niedermaier, Fabio Estevam,
NXP Linux Team, kernel
On Fri, Dec 31, 2021 at 01:12:14AM +0100, Marek Vasut wrote:
> Include missing headers, since this DT source uses symbolic names defined
> in those headers. If an external DT includes this dtsi without including
> the headers as well, the DT becomes unbuildable.
>
> Three headers are included:
> dt-bindings/gpio/gpio.h -- because this DT contains GPIO_ACTIVE_HIGH
> dt-bindings/input/input.h -- because this DT contains KEY_A
> dt-bindings/pwm/pwm.h -- because this DT contains PWM_POLARITY_INVERTED
>
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Christoph Niedermaier <cniedermaier@dh-electronics.com>
> Cc: Fabio Estevam <festevam@gmail.com>
> Cc: NXP Linux Team <linux-imx@nxp.com>
> Cc: Shawn Guo <shawnguo@kernel.org>
> Cc: kernel@dh-electronics.com
Applied, thanks!
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-01-28 7:25 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-31 0:12 [PATCH] ARM: dts: imx6qdl-dhcom-pdk2: Include missing headers Marek Vasut
2021-12-31 0:14 ` Fabio Estevam
2022-01-28 7:23 ` Shawn Guo
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.