[U-Boot] Between 2015.10 and 2016.01, SPI flash changed erase size, and saveenv stopped working

[U-Boot] Between 2015.10 and 2016.01, SPI flash changed erase size, and saveenv stopped working

[Pavel Machek]

Hi!

On board with Altera Cyclone 5:

=> version

U-Boot 2016.01-05658-g81689ec (May 29 2016 - 22:25:45 +0200)
arm-linux-gnueabi-gcc (GCC) 4.8.2
GNU ld (GNU Binutils) 2.24
Saving Environment to SPI Flash...
spi_flash_std_probe: slave=0bf367d0, cs=0
SF: Detected N25Q512 with page size 256 Bytes, erase size 64 KiB,
total 64 MiB
offset 0x40000 is protected and cannot be erased

...

=> version

U-Boot 2015.10-04078-g3b6d086 (May 29 2016 - 22:33:36 +0200)
arm-linux-gnueabi-gcc (GCC) 4.8.2
GNU ld (GNU Binutils) 2.24
SF: Detected N25Q512 with page size 256 Bytes, erase size 4 KiB, total
64 MiB


Does anyone else see the problem? Any ideas?

Best regards,
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

[U-Boot] Between 2015.10 and 2016.01, SPI flash changed erase size, and saveenv stopped working

[Stefan Roese]

Hi Pavel,

On 29.05.2016 22:40, Pavel Machek wrote:
> Hi!
>
> On board with Altera Cyclone 5:
>
> => version
>
> U-Boot 2016.01-05658-g81689ec (May 29 2016 - 22:25:45 +0200)
> arm-linux-gnueabi-gcc (GCC) 4.8.2
> GNU ld (GNU Binutils) 2.24
> Saving Environment to SPI Flash...
> spi_flash_std_probe: slave=0bf367d0, cs=0
> SF: Detected N25Q512 with page size 256 Bytes, erase size 64 KiB,
> total 64 MiB
> offset 0x40000 is protected and cannot be erased
>
> ...
>
> => version
>
> U-Boot 2015.10-04078-g3b6d086 (May 29 2016 - 22:33:36 +0200)
> arm-linux-gnueabi-gcc (GCC) 4.8.2
> GNU ld (GNU Binutils) 2.24
> SF: Detected N25Q512 with page size 256 Bytes, erase size 4 KiB, total
> 64 MiB
>
>
> Does anyone else see the problem? Any ideas?

I think you have run into the S-bit / cache issue with version
the 2016 U-Boot version. This was fixed with these patches:

mtd: cqspi: Simplify indirect write code
mtd: cqspi: Simplify indirect read code

Please use the v2016.05 release.

Thanks,
Stefan

[U-Boot] Between 2015.10 and 2016.01, SPI flash changed erase size, and saveenv stopped working

[Pavel Machek]

On Mon 2016-05-30 05:21:28, Stefan Roese wrote:
> Hi Pavel,
> 
> On 29.05.2016 22:40, Pavel Machek wrote:
> >Hi!
> >
> >On board with Altera Cyclone 5:
> >
> >=> version
> >
> >U-Boot 2016.01-05658-g81689ec (May 29 2016 - 22:25:45 +0200)
> >arm-linux-gnueabi-gcc (GCC) 4.8.2
> >GNU ld (GNU Binutils) 2.24
> >Saving Environment to SPI Flash...
> >spi_flash_std_probe: slave=0bf367d0, cs=0
> >SF: Detected N25Q512 with page size 256 Bytes, erase size 64 KiB,
> >total 64 MiB
> >offset 0x40000 is protected and cannot be erased
> >
> >...
> >
> >=> version
> >
> >U-Boot 2015.10-04078-g3b6d086 (May 29 2016 - 22:33:36 +0200)
> >arm-linux-gnueabi-gcc (GCC) 4.8.2
> >GNU ld (GNU Binutils) 2.24
> >SF: Detected N25Q512 with page size 256 Bytes, erase size 4 KiB, total
> >64 MiB
> >
> >
> >Does anyone else see the problem? Any ideas?
> 
> I think you have run into the S-bit / cache issue with version
> the 2016 U-Boot version. This was fixed with these patches:
> 
> mtd: cqspi: Simplify indirect write code
> mtd: cqspi: Simplify indirect read code
> 
> Please use the v2016.05 release.

Sorry if I was unclear, but it is also broken in v2016.03, v2016.05
and v2016.07. I hoped narowing down range where it broke would help.

Best regards,
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

[U-Boot] Between 2015.10 and 2016.01, SPI flash changed erase size, and saveenv stopped working

[Pavel Machek]

On Mon 2016-05-30 05:21:28, Stefan Roese wrote:
> Hi Pavel,
> 
> On 29.05.2016 22:40, Pavel Machek wrote:
> >Hi!
> >
> >On board with Altera Cyclone 5:
> >
> >=> version
> >
> >U-Boot 2016.01-05658-g81689ec (May 29 2016 - 22:25:45 +0200)
> >arm-linux-gnueabi-gcc (GCC) 4.8.2
> >GNU ld (GNU Binutils) 2.24
> >Saving Environment to SPI Flash...
> >spi_flash_std_probe: slave=0bf367d0, cs=0
> >SF: Detected N25Q512 with page size 256 Bytes, erase size 64 KiB,
> >total 64 MiB
> >offset 0x40000 is protected and cannot be erased
> >
> >...
> >
> >=> version
> >
> >U-Boot 2015.10-04078-g3b6d086 (May 29 2016 - 22:33:36 +0200)
> >arm-linux-gnueabi-gcc (GCC) 4.8.2
> >GNU ld (GNU Binutils) 2.24
> >SF: Detected N25Q512 with page size 256 Bytes, erase size 4 KiB, total
> >64 MiB
> >
> >
> >Does anyone else see the problem? Any ideas?

Commit c3c016cf75360c2a0d0a065b64b438aaf7720576 is a part of the problem:

offset 0x40000 is protected and cannot be erased
=> sf help
No SPI flash selected. Please run `sf probe'
=> sf probe
...
SF: Detected N25Q512 with page size 256 Bytes, erase size 4 KiB, total
64 MiB
cadence_spi_set_speed: speed=1000000
=> sf protect unlock 0x40000 0x20000
cadence_spi_xfer: len=1 [bytes]
cadence_spi_xfer: len=1 [bytes]
=> saveenv
Saving Environment to SPI Flash...

Best regards,
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

[U-Boot] Between 2015.10 and 2016.01, SPI flash changed erase size, and saveenv stopped working

[Pavel Machek]

Hi!

> Commit c3c016cf75360c2a0d0a065b64b438aaf7720576 is a part of the problem:
> 
> offset 0x40000 is protected and cannot be erased
> => sf help
> No SPI flash selected. Please run `sf probe'
> => sf probe
> ...
> SF: Detected N25Q512 with page size 256 Bytes, erase size 4 KiB, total
> 64 MiB
> cadence_spi_set_speed: speed=1000000
> => sf protect unlock 0x40000 0x20000
> cadence_spi_xfer: len=1 [bytes]
> cadence_spi_xfer: len=1 [bytes]
> => saveenv
> Saving Environment to SPI Flash...

Disabling flash locking like this seems to do the trick:

diff --git a/drivers/mtd/spi/spi_flash.c b/drivers/mtd/spi/spi_flash.c
index 907067b..b75e66a 100644
--- a/drivers/mtd/spi/spi_flash.c
+++ b/drivers/mtd/spi/spi_flash.c
@@ -1131,14 +1131,16 @@ int spi_flash_scan(struct spi_flash *flash)
 
 	/* lock hooks are flash specific - assign them based on idcode0 */
 	switch (idcode[0]) {
+#if 0
 #if defined(CONFIG_SPI_FLASH_STMICRO) || defined(CONFIG_SPI_FLASH_SST)
 	case SPI_FLASH_CFI_MFR_STMICRO:
 	case SPI_FLASH_CFI_MFR_SST:
 		flash->flash_lock = stm_lock;
 		flash->flash_unlock = stm_unlock;
 		flash->flash_is_locked = stm_is_locked;
-#endif
 		break;
+#endif
+#endif
 	default:
 		debug("SF: Lock ops not supported for %02x flash\n", idcode[0]);
 	}

and if someone is watching, the #endif should be moved. switch (...) {
break;  } is strange kind of C.

Best regards,
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

[U-Boot] Between 2015.10 and 2016.01, SPI flash changed erase size, and saveenv stopped working

[Fabio Estevam]

On Mon, May 30, 2016 at 5:33 AM, Pavel Machek <pavel@denx.de> wrote:

> Commit c3c016cf75360c2a0d0a065b64b438aaf7720576 is a part of the problem:
>
> offset 0x40000 is protected and cannot be erased
> => sf help
> No SPI flash selected. Please run `sf probe'
> => sf probe
> ...
> SF: Detected N25Q512 with page size 256 Bytes, erase size 4 KiB, total
> 64 MiB
> cadence_spi_set_speed: speed=1000000
> => sf protect unlock 0x40000 0x20000
> cadence_spi_xfer: len=1 [bytes]
> cadence_spi_xfer: len=1 [bytes]
> => saveenv
> Saving Environment to SPI Flash...

Does this quick hack help? I am wondering if yous SPI flash power up
with the SR field protected:

--- a/drivers/mtd/spi/spi_flash.c
+++ b/drivers/mtd/spi/spi_flash.c
@@ -1021,11 +1021,7 @@ int spi_flash_scan(struct spi_flash *flash)
                return -EPROTONOSUPPORT;
        }

-       /* Flash powers up read-only, so clear BP# bits */
-       if (idcode[0] == SPI_FLASH_CFI_MFR_ATMEL ||
-           idcode[0] == SPI_FLASH_CFI_MFR_MACRONIX ||
-           idcode[0] == SPI_FLASH_CFI_MFR_SST)
-               write_sr(flash, 0);
+       write_sr(flash, 0);

        /* Assign spi data */
        flash->name = params->name;

[U-Boot] Between 2015.10 and 2016.01, SPI flash changed erase size, and saveenv stopped working

[Pavel Machek]

On Mon 2016-05-30 10:43:39, Fabio Estevam wrote:
> On Mon, May 30, 2016 at 5:33 AM, Pavel Machek <pavel@denx.de> wrote:
> 
> > Commit c3c016cf75360c2a0d0a065b64b438aaf7720576 is a part of the problem:
> >
> > offset 0x40000 is protected and cannot be erased
> > => sf help
> > No SPI flash selected. Please run `sf probe'
> > => sf probe
> > ...
> > SF: Detected N25Q512 with page size 256 Bytes, erase size 4 KiB, total
> > 64 MiB
> > cadence_spi_set_speed: speed=1000000
> > => sf protect unlock 0x40000 0x20000
> > cadence_spi_xfer: len=1 [bytes]
> > cadence_spi_xfer: len=1 [bytes]
> > => saveenv
> > Saving Environment to SPI Flash...
> 
> Does this quick hack help? I am wondering if yous SPI flash power up
> with the SR field protected:

Yes, it helps. Thanks! I can now write to the enviornment.

But it still does not look like locking is working quite correctly:

Best regards,
								Pavel

=> sf protect lock 0xe0000 0x10000
=> saveenv
Saving Environment to SPI Flash...
read_ops: at e1000, len f000
read: 61440 remains
read: 28672 remains
Erasing SPI flash...SF: erase 20  e  0  0 (e0000)
SF: erase 20  e 10  0 (e1000)
SF: erase 20  e 20  0 (e2000)
SF: erase 20  e 30  0 (e3000)
SF: erase 20  e 40  0 (e4000)
SF: erase 20  e 50  0 (e5000)
SF: erase 20  e 60  0 (e6000)
SF: erase 20  e 70  0 (e7000)
SF: erase 20  e 80  0 (e8000)
SF: erase 20  e 90  0 (e9000)
SF: erase 20  e a0  0 (ea000)
SF: erase 20  e b0  0 (eb000)
SF: erase 20  e c0  0 (ec000)
SF: erase 20  e d0  0 (ed000)
SF: erase 20  e e0  0 (ee000)
SF: erase 20  e f0  0 (ef000)
Writing to SPI flash...SF: 0x0bf4dd50 => cmd = { 0x02 0x0e0000 }
chunk_len = 256
SF: 0x0bf4de50 => cmd = { 0x02 0x0e0100 } chunk_len = 256
SF: 0x0bf4df50 => cmd = { 0x02 0x0e0200 } chunk_len = 256
SF: 0x0bf4e050 => cmd = { 0x02 0x0e0300 } chunk_len = 256
SF: 0x0bf4e150 => cmd = { 0x02 0x0e0400 } chunk_len = 256
SF: 0x0bf4e250 => cmd = { 0x02 0x0e0500 } chunk_len = 256


> --- a/drivers/mtd/spi/spi_flash.c
> +++ b/drivers/mtd/spi/spi_flash.c
> @@ -1021,11 +1021,7 @@ int spi_flash_scan(struct spi_flash *flash)
>                 return -EPROTONOSUPPORT;
>         }
> 
> -       /* Flash powers up read-only, so clear BP# bits */
> -       if (idcode[0] == SPI_FLASH_CFI_MFR_ATMEL ||
> -           idcode[0] == SPI_FLASH_CFI_MFR_MACRONIX ||
> -           idcode[0] == SPI_FLASH_CFI_MFR_SST)
> -               write_sr(flash, 0);
> +       write_sr(flash, 0);
> 
>         /* Assign spi data */
>         flash->name = params->name;

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

[U-Boot] Between 2015.10 and 2016.01, SPI flash changed erase size, and saveenv stopped working

[Fabio Estevam]

On Mon, May 30, 2016 at 5:25 PM, Pavel Machek <pavel@denx.de> wrote:

> Yes, it helps. Thanks! I can now write to the enviornment.

Ok, good. What happens if you revert the hack and boot a fresh 2016.05 U-boot?

Are you able to write/save to the env?

I want to understand if your flash always come up with the SR bits
protected or not.

[U-Boot] socfpga 2016.07-rc0: have to disable parts of flash probing and limit read size to get SPL to work

[Pavel Machek]

Hi!

There's one more "funny" thing I see with SPI: SPL fails to boot if I
let it do full probing, or if I allow it to do reads in big chunks
(that may be explained by watchdog, I'll investigate it some more).

This makes SPL work for me, but I guess I'd like to understand why.

Ideas welcome.

Best regards,
								Pavel

--- a/drivers/mtd/spi/spi_flash.c
+++ b/drivers/mtd/spi/spi_flash.c
@@ -515,6 +520,7 @@ int spi_flash_cmd_read_ops(struct spi_flash *flash, u32 offset,
 #endif
 		remain_len = ((SPI_FLASH_16MB_BOUN << flash->shift) *
 				(bank_sel + 1)) - offset;
+		remain_len = 32768;
 		if (len < remain_len)
 			read_len = len;
 		else
@@ -1176,23 +1178,28 @@ int spi_flash_scan(struct spi_flash *flash)
 	/* Now erase size becomes valid sector size */
 	flash->sector_size = flash->erase_size;
 
+#ifndef CONFIG_SPL_BUILD
 	/* Look for the fastest read cmd */
 	cmd = fls(params->e_rd_cmd & spi->mode_rx);
 	if (cmd) {
 		cmd = spi_read_cmds_array[cmd - 1];
 		flash->read_cmd = cmd;
 	} else {
+#endif
 		/* Go for default supported read cmd */
 		flash->read_cmd = CMD_READ_ARRAY_FAST;
+#ifndef CONFIG_SPL_BUILD		
 	}
-
 	/* Not require to look for fastest only two write cmds yet */
 	if (params->flags & WR_QPP && spi->mode & SPI_TX_QUAD)
 		flash->write_cmd = CMD_QUAD_PAGE_PROGRAM;
 	else
+#endif
 		/* Go for default supported write cmd */
 		flash->write_cmd = CMD_PAGE_PROGRAM;
 
+	/* Why are we even probing writes? SPL should not write anywhere... */
+
 	/* Set the quad enable bit - only for quad commands */
 	if ((flash->read_cmd == CMD_READ_QUAD_OUTPUT_FAST) ||
 	    (flash->read_cmd == CMD_READ_QUAD_IO_FAST) ||




-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

[U-Boot] Between 2015.10 and 2016.01, SPI flash changed erase size, and saveenv stopped working

[Pavel Machek]

On Mon 2016-05-30 10:43:39, Fabio Estevam wrote:
> On Mon, May 30, 2016 at 5:33 AM, Pavel Machek <pavel@denx.de> wrote:
> 
> > Commit c3c016cf75360c2a0d0a065b64b438aaf7720576 is a part of the problem:
> >
> > offset 0x40000 is protected and cannot be erased
> > => sf help
> > No SPI flash selected. Please run `sf probe'
> > => sf probe
> > ...
> > SF: Detected N25Q512 with page size 256 Bytes, erase size 4 KiB, total
> > 64 MiB
> > cadence_spi_set_speed: speed=1000000
> > => sf protect unlock 0x40000 0x20000
> > cadence_spi_xfer: len=1 [bytes]
> > cadence_spi_xfer: len=1 [bytes]
> > => saveenv
> > Saving Environment to SPI Flash...
> 
> Does this quick hack help? I am wondering if yous SPI flash power up
> with the SR field protected:

This may be stupid but... is it possible that changes made by
write_sr() persist over powerdown?

Best regards,
									Pavel

> --- a/drivers/mtd/spi/spi_flash.c
> +++ b/drivers/mtd/spi/spi_flash.c
> @@ -1021,11 +1021,7 @@ int spi_flash_scan(struct spi_flash *flash)
>                 return -EPROTONOSUPPORT;
>         }
> 
> -       /* Flash powers up read-only, so clear BP# bits */
> -       if (idcode[0] == SPI_FLASH_CFI_MFR_ATMEL ||
> -           idcode[0] == SPI_FLASH_CFI_MFR_MACRONIX ||
> -           idcode[0] == SPI_FLASH_CFI_MFR_SST)
> -               write_sr(flash, 0);
> +       write_sr(flash, 0);
> 
>         /* Assign spi data */
>         flash->name = params->name;

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

[U-Boot] Between 2015.10 and 2016.01, SPI flash changed erase size, and saveenv stopped working

[Fabio Estevam]

On Thu, Jun 2, 2016 at 10:41 AM, Pavel Machek <pavel@denx.de> wrote:

>> Does this quick hack help? I am wondering if yous SPI flash power up
>> with the SR field protected:
>
> This may be stupid but... is it possible that changes made by
> write_sr() persist over powerdown?

Yes, they do.