* [PATCH 0/3] ARM: imx25: print silicon revision, support 1.2
@ 2022-06-02 8:03 ` Martin Kaiser
0 siblings, 0 replies; 54+ messages in thread
From: Martin Kaiser @ 2022-06-02 8:03 UTC (permalink / raw)
To: Shawn Guo, Pengutronix Kernel Team, Fabio Estevam
Cc: linux-arm-kernel, linux-clk, linux-kernel, Martin Kaiser
Resurrect the unused function to print the imx25 silicon revision at
startup. Add support for revision 1.2.
Martin Kaiser (3):
ARM: imx25: support silicon revision 1.2
clk: imx25: print silicon revision during init
clk: imx25: make __mx25_clocks_init return void
arch/arm/mach-imx/cpu-imx25.c | 2 ++
drivers/clk/imx/clk-imx25.c | 5 +++--
include/soc/imx/revision.h | 1 +
3 files changed, 6 insertions(+), 2 deletions(-)
--
2.30.2
^ permalink raw reply [flat|nested] 54+ messages in thread
* [PATCH 0/3] ARM: imx25: print silicon revision, support 1.2
@ 2022-06-02 8:03 ` Martin Kaiser
0 siblings, 0 replies; 54+ messages in thread
From: Martin Kaiser @ 2022-06-02 8:03 UTC (permalink / raw)
To: Shawn Guo, Pengutronix Kernel Team, Fabio Estevam
Cc: linux-arm-kernel, linux-clk, linux-kernel, Martin Kaiser
Resurrect the unused function to print the imx25 silicon revision at
startup. Add support for revision 1.2.
Martin Kaiser (3):
ARM: imx25: support silicon revision 1.2
clk: imx25: print silicon revision during init
clk: imx25: make __mx25_clocks_init return void
arch/arm/mach-imx/cpu-imx25.c | 2 ++
drivers/clk/imx/clk-imx25.c | 5 +++--
include/soc/imx/revision.h | 1 +
3 files changed, 6 insertions(+), 2 deletions(-)
--
2.30.2
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 54+ messages in thread
* [PATCH 1/3] ARM: imx25: support silicon revision 1.2
2022-06-02 8:03 ` Martin Kaiser
@ 2022-06-02 8:03 ` Martin Kaiser
-1 siblings, 0 replies; 54+ messages in thread
From: Martin Kaiser @ 2022-06-02 8:03 UTC (permalink / raw)
To: Shawn Guo, Pengutronix Kernel Team, Fabio Estevam
Cc: linux-arm-kernel, linux-clk, linux-kernel, Martin Kaiser
Update the mx25_read_cpu_rev function to recognize silicon revision 1.2
for imx25 chipsets.
Silicon revision 1.2 is mentioned in the errata document at
https://www.nxp.com/docs/en/errata/IMX25CE.pdf. The imx25 chips on my
test boards show revision 1.2 as well.
Signed-off-by: Martin Kaiser <martin@kaiser.cx>
---
arch/arm/mach-imx/cpu-imx25.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/arm/mach-imx/cpu-imx25.c b/arch/arm/mach-imx/cpu-imx25.c
index b2e1963f473d..3e63445cde06 100644
--- a/arch/arm/mach-imx/cpu-imx25.c
+++ b/arch/arm/mach-imx/cpu-imx25.c
@@ -32,6 +32,8 @@ static int mx25_read_cpu_rev(void)
return IMX_CHIP_REVISION_1_0;
case 0x01:
return IMX_CHIP_REVISION_1_1;
+ case 0x02:
+ return IMX_CHIP_REVISION_1_2;
default:
return IMX_CHIP_REVISION_UNKNOWN;
}
--
2.30.2
^ permalink raw reply related [flat|nested] 54+ messages in thread
* [PATCH 1/3] ARM: imx25: support silicon revision 1.2
@ 2022-06-02 8:03 ` Martin Kaiser
0 siblings, 0 replies; 54+ messages in thread
From: Martin Kaiser @ 2022-06-02 8:03 UTC (permalink / raw)
To: Shawn Guo, Pengutronix Kernel Team, Fabio Estevam
Cc: linux-arm-kernel, linux-clk, linux-kernel, Martin Kaiser
Update the mx25_read_cpu_rev function to recognize silicon revision 1.2
for imx25 chipsets.
Silicon revision 1.2 is mentioned in the errata document at
https://www.nxp.com/docs/en/errata/IMX25CE.pdf. The imx25 chips on my
test boards show revision 1.2 as well.
Signed-off-by: Martin Kaiser <martin@kaiser.cx>
---
arch/arm/mach-imx/cpu-imx25.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/arm/mach-imx/cpu-imx25.c b/arch/arm/mach-imx/cpu-imx25.c
index b2e1963f473d..3e63445cde06 100644
--- a/arch/arm/mach-imx/cpu-imx25.c
+++ b/arch/arm/mach-imx/cpu-imx25.c
@@ -32,6 +32,8 @@ static int mx25_read_cpu_rev(void)
return IMX_CHIP_REVISION_1_0;
case 0x01:
return IMX_CHIP_REVISION_1_1;
+ case 0x02:
+ return IMX_CHIP_REVISION_1_2;
default:
return IMX_CHIP_REVISION_UNKNOWN;
}
--
2.30.2
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 54+ messages in thread
* [PATCH 2/3] clk: imx25: print silicon revision during init
2022-06-02 8:03 ` Martin Kaiser
@ 2022-06-02 8:03 ` Martin Kaiser
-1 siblings, 0 replies; 54+ messages in thread
From: Martin Kaiser @ 2022-06-02 8:03 UTC (permalink / raw)
To: Shawn Guo, Pengutronix Kernel Team, Fabio Estevam
Cc: linux-arm-kernel, linux-clk, linux-kernel, Martin Kaiser
Print the imx25 silicon revision when the clocks are initialised.
Use the same mechanism as for imx27, i.e. call mx25_revision.
This function is unused at the moment.
Signed-off-by: Martin Kaiser <martin@kaiser.cx>
---
drivers/clk/imx/clk-imx25.c | 3 +++
include/soc/imx/revision.h | 1 +
2 files changed, 4 insertions(+)
diff --git a/drivers/clk/imx/clk-imx25.c b/drivers/clk/imx/clk-imx25.c
index 66192fe0a898..263409fca1eb 100644
--- a/drivers/clk/imx/clk-imx25.c
+++ b/drivers/clk/imx/clk-imx25.c
@@ -13,6 +13,7 @@
#include <linux/of.h>
#include <linux/of_address.h>
#include <linux/of_irq.h>
+#include <soc/imx/revision.h>
#include "clk.h"
@@ -220,6 +221,8 @@ static int __init __mx25_clocks_init(void __iomem *ccm_base)
imx_register_uart_clocks(6);
+ imx_print_silicon_rev("i.MX25", mx25_revision());
+
return 0;
}
diff --git a/include/soc/imx/revision.h b/include/soc/imx/revision.h
index b2a55dafaf0a..b122d2fc8881 100644
--- a/include/soc/imx/revision.h
+++ b/include/soc/imx/revision.h
@@ -22,6 +22,7 @@
#define IMX_CHIP_REVISION_3_3 0x33
#define IMX_CHIP_REVISION_UNKNOWN 0xff
+int mx25_revision(void);
int mx27_revision(void);
int mx31_revision(void);
int mx35_revision(void);
--
2.30.2
^ permalink raw reply related [flat|nested] 54+ messages in thread
* [PATCH 2/3] clk: imx25: print silicon revision during init
@ 2022-06-02 8:03 ` Martin Kaiser
0 siblings, 0 replies; 54+ messages in thread
From: Martin Kaiser @ 2022-06-02 8:03 UTC (permalink / raw)
To: Shawn Guo, Pengutronix Kernel Team, Fabio Estevam
Cc: linux-arm-kernel, linux-clk, linux-kernel, Martin Kaiser
Print the imx25 silicon revision when the clocks are initialised.
Use the same mechanism as for imx27, i.e. call mx25_revision.
This function is unused at the moment.
Signed-off-by: Martin Kaiser <martin@kaiser.cx>
---
drivers/clk/imx/clk-imx25.c | 3 +++
include/soc/imx/revision.h | 1 +
2 files changed, 4 insertions(+)
diff --git a/drivers/clk/imx/clk-imx25.c b/drivers/clk/imx/clk-imx25.c
index 66192fe0a898..263409fca1eb 100644
--- a/drivers/clk/imx/clk-imx25.c
+++ b/drivers/clk/imx/clk-imx25.c
@@ -13,6 +13,7 @@
#include <linux/of.h>
#include <linux/of_address.h>
#include <linux/of_irq.h>
+#include <soc/imx/revision.h>
#include "clk.h"
@@ -220,6 +221,8 @@ static int __init __mx25_clocks_init(void __iomem *ccm_base)
imx_register_uart_clocks(6);
+ imx_print_silicon_rev("i.MX25", mx25_revision());
+
return 0;
}
diff --git a/include/soc/imx/revision.h b/include/soc/imx/revision.h
index b2a55dafaf0a..b122d2fc8881 100644
--- a/include/soc/imx/revision.h
+++ b/include/soc/imx/revision.h
@@ -22,6 +22,7 @@
#define IMX_CHIP_REVISION_3_3 0x33
#define IMX_CHIP_REVISION_UNKNOWN 0xff
+int mx25_revision(void);
int mx27_revision(void);
int mx31_revision(void);
int mx35_revision(void);
--
2.30.2
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 54+ messages in thread
* [PATCH 3/3] clk: imx25: make __mx25_clocks_init return void
2022-06-02 8:03 ` Martin Kaiser
@ 2022-06-02 8:03 ` Martin Kaiser
-1 siblings, 0 replies; 54+ messages in thread
From: Martin Kaiser @ 2022-06-02 8:03 UTC (permalink / raw)
To: Shawn Guo, Pengutronix Kernel Team, Fabio Estevam
Cc: linux-arm-kernel, linux-clk, linux-kernel, Martin Kaiser
The __mx25_clocks_init function always returns 0 and its only
caller does not check the return value. Let's remove it.
Signed-off-by: Martin Kaiser <martin@kaiser.cx>
---
drivers/clk/imx/clk-imx25.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/clk/imx/clk-imx25.c b/drivers/clk/imx/clk-imx25.c
index 263409fca1eb..72b30dd7f05f 100644
--- a/drivers/clk/imx/clk-imx25.c
+++ b/drivers/clk/imx/clk-imx25.c
@@ -74,7 +74,7 @@ enum mx25_clks {
static struct clk *clk[clk_max];
-static int __init __mx25_clocks_init(void __iomem *ccm_base)
+static void __init __mx25_clocks_init(void __iomem *ccm_base)
{
BUG_ON(!ccm_base);
@@ -222,8 +222,6 @@ static int __init __mx25_clocks_init(void __iomem *ccm_base)
imx_register_uart_clocks(6);
imx_print_silicon_rev("i.MX25", mx25_revision());
-
- return 0;
}
static void __init mx25_clocks_init_dt(struct device_node *np)
--
2.30.2
^ permalink raw reply related [flat|nested] 54+ messages in thread
* [PATCH 3/3] clk: imx25: make __mx25_clocks_init return void
@ 2022-06-02 8:03 ` Martin Kaiser
0 siblings, 0 replies; 54+ messages in thread
From: Martin Kaiser @ 2022-06-02 8:03 UTC (permalink / raw)
To: Shawn Guo, Pengutronix Kernel Team, Fabio Estevam
Cc: linux-arm-kernel, linux-clk, linux-kernel, Martin Kaiser
The __mx25_clocks_init function always returns 0 and its only
caller does not check the return value. Let's remove it.
Signed-off-by: Martin Kaiser <martin@kaiser.cx>
---
drivers/clk/imx/clk-imx25.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/clk/imx/clk-imx25.c b/drivers/clk/imx/clk-imx25.c
index 263409fca1eb..72b30dd7f05f 100644
--- a/drivers/clk/imx/clk-imx25.c
+++ b/drivers/clk/imx/clk-imx25.c
@@ -74,7 +74,7 @@ enum mx25_clks {
static struct clk *clk[clk_max];
-static int __init __mx25_clocks_init(void __iomem *ccm_base)
+static void __init __mx25_clocks_init(void __iomem *ccm_base)
{
BUG_ON(!ccm_base);
@@ -222,8 +222,6 @@ static int __init __mx25_clocks_init(void __iomem *ccm_base)
imx_register_uart_clocks(6);
imx_print_silicon_rev("i.MX25", mx25_revision());
-
- return 0;
}
static void __init mx25_clocks_init_dt(struct device_node *np)
--
2.30.2
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 54+ messages in thread
* Re: [PATCH 1/3] ARM: imx25: support silicon revision 1.2
2022-06-02 8:03 ` Martin Kaiser
@ 2022-06-19 3:40 ` Shawn Guo
-1 siblings, 0 replies; 54+ messages in thread
From: Shawn Guo @ 2022-06-19 3:40 UTC (permalink / raw)
To: Martin Kaiser
Cc: Pengutronix Kernel Team, Fabio Estevam, linux-arm-kernel,
linux-clk, linux-kernel
On Thu, Jun 02, 2022 at 10:03:42AM +0200, Martin Kaiser wrote:
> Update the mx25_read_cpu_rev function to recognize silicon revision 1.2
> for imx25 chipsets.
>
> Silicon revision 1.2 is mentioned in the errata document at
> https://www.nxp.com/docs/en/errata/IMX25CE.pdf. The imx25 chips on my
> test boards show revision 1.2 as well.
>
> Signed-off-by: Martin Kaiser <martin@kaiser.cx>
Applied this one, thanks!
^ permalink raw reply [flat|nested] 54+ messages in thread
* Re: [PATCH 1/3] ARM: imx25: support silicon revision 1.2
@ 2022-06-19 3:40 ` Shawn Guo
0 siblings, 0 replies; 54+ messages in thread
From: Shawn Guo @ 2022-06-19 3:40 UTC (permalink / raw)
To: Martin Kaiser
Cc: Pengutronix Kernel Team, Fabio Estevam, linux-arm-kernel,
linux-clk, linux-kernel
On Thu, Jun 02, 2022 at 10:03:42AM +0200, Martin Kaiser wrote:
> Update the mx25_read_cpu_rev function to recognize silicon revision 1.2
> for imx25 chipsets.
>
> Silicon revision 1.2 is mentioned in the errata document at
> https://www.nxp.com/docs/en/errata/IMX25CE.pdf. The imx25 chips on my
> test boards show revision 1.2 as well.
>
> Signed-off-by: Martin Kaiser <martin@kaiser.cx>
Applied this one, thanks!
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 54+ messages in thread
* [PATCH v2 0/2] ARM: imx25: print silicon revision at startup
2022-06-02 8:03 ` Martin Kaiser
@ 2022-06-23 7:51 ` Martin Kaiser
-1 siblings, 0 replies; 54+ messages in thread
From: Martin Kaiser @ 2022-06-23 7:51 UTC (permalink / raw)
To: Abel Vesa, Stephen Boyd
Cc: Shawn Guo, Pengutronix Kernel Team, Fabio Estevam,
linux-arm-kernel, linux-clk, linux-kernel, Martin Kaiser
Resurrect the unused function to print the imx25 silicon revision at
startup.
changes in v2:
- drop the patch about silicon revision 1.2. It has already been merged
by Shawn Guo.
- send the changeset to the clk maintainers
Martin Kaiser (2):
clk: imx25: print silicon revision during init
clk: imx25: make __mx25_clocks_init return void
drivers/clk/imx/clk-imx25.c | 5 +++--
include/soc/imx/revision.h | 1 +
2 files changed, 4 insertions(+), 2 deletions(-)
--
2.30.2
^ permalink raw reply [flat|nested] 54+ messages in thread
* [PATCH v2 0/2] ARM: imx25: print silicon revision at startup
@ 2022-06-23 7:51 ` Martin Kaiser
0 siblings, 0 replies; 54+ messages in thread
From: Martin Kaiser @ 2022-06-23 7:51 UTC (permalink / raw)
To: Abel Vesa, Stephen Boyd
Cc: Shawn Guo, Pengutronix Kernel Team, Fabio Estevam,
linux-arm-kernel, linux-clk, linux-kernel, Martin Kaiser
Resurrect the unused function to print the imx25 silicon revision at
startup.
changes in v2:
- drop the patch about silicon revision 1.2. It has already been merged
by Shawn Guo.
- send the changeset to the clk maintainers
Martin Kaiser (2):
clk: imx25: print silicon revision during init
clk: imx25: make __mx25_clocks_init return void
drivers/clk/imx/clk-imx25.c | 5 +++--
include/soc/imx/revision.h | 1 +
2 files changed, 4 insertions(+), 2 deletions(-)
--
2.30.2
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 54+ messages in thread
* [PATCH v2 1/2] clk: imx25: print silicon revision during init
2022-06-23 7:51 ` Martin Kaiser
@ 2022-06-23 7:51 ` Martin Kaiser
-1 siblings, 0 replies; 54+ messages in thread
From: Martin Kaiser @ 2022-06-23 7:51 UTC (permalink / raw)
To: Abel Vesa, Stephen Boyd
Cc: Shawn Guo, Pengutronix Kernel Team, Fabio Estevam,
linux-arm-kernel, linux-clk, linux-kernel, Martin Kaiser
Print the imx25 silicon revision when the clocks are initialised.
Use the same mechanism as for imx27, i.e. call mx25_revision.
This function is unused at the moment.
Signed-off-by: Martin Kaiser <martin@kaiser.cx>
---
changes in v2:
- send the patch to the clk maintainers
drivers/clk/imx/clk-imx25.c | 3 +++
include/soc/imx/revision.h | 1 +
2 files changed, 4 insertions(+)
diff --git a/drivers/clk/imx/clk-imx25.c b/drivers/clk/imx/clk-imx25.c
index 66192fe0a898..263409fca1eb 100644
--- a/drivers/clk/imx/clk-imx25.c
+++ b/drivers/clk/imx/clk-imx25.c
@@ -13,6 +13,7 @@
#include <linux/of.h>
#include <linux/of_address.h>
#include <linux/of_irq.h>
+#include <soc/imx/revision.h>
#include "clk.h"
@@ -220,6 +221,8 @@ static int __init __mx25_clocks_init(void __iomem *ccm_base)
imx_register_uart_clocks(6);
+ imx_print_silicon_rev("i.MX25", mx25_revision());
+
return 0;
}
diff --git a/include/soc/imx/revision.h b/include/soc/imx/revision.h
index b2a55dafaf0a..b122d2fc8881 100644
--- a/include/soc/imx/revision.h
+++ b/include/soc/imx/revision.h
@@ -22,6 +22,7 @@
#define IMX_CHIP_REVISION_3_3 0x33
#define IMX_CHIP_REVISION_UNKNOWN 0xff
+int mx25_revision(void);
int mx27_revision(void);
int mx31_revision(void);
int mx35_revision(void);
--
2.30.2
^ permalink raw reply related [flat|nested] 54+ messages in thread
* [PATCH v2 1/2] clk: imx25: print silicon revision during init
@ 2022-06-23 7:51 ` Martin Kaiser
0 siblings, 0 replies; 54+ messages in thread
From: Martin Kaiser @ 2022-06-23 7:51 UTC (permalink / raw)
To: Abel Vesa, Stephen Boyd
Cc: Shawn Guo, Pengutronix Kernel Team, Fabio Estevam,
linux-arm-kernel, linux-clk, linux-kernel, Martin Kaiser
Print the imx25 silicon revision when the clocks are initialised.
Use the same mechanism as for imx27, i.e. call mx25_revision.
This function is unused at the moment.
Signed-off-by: Martin Kaiser <martin@kaiser.cx>
---
changes in v2:
- send the patch to the clk maintainers
drivers/clk/imx/clk-imx25.c | 3 +++
include/soc/imx/revision.h | 1 +
2 files changed, 4 insertions(+)
diff --git a/drivers/clk/imx/clk-imx25.c b/drivers/clk/imx/clk-imx25.c
index 66192fe0a898..263409fca1eb 100644
--- a/drivers/clk/imx/clk-imx25.c
+++ b/drivers/clk/imx/clk-imx25.c
@@ -13,6 +13,7 @@
#include <linux/of.h>
#include <linux/of_address.h>
#include <linux/of_irq.h>
+#include <soc/imx/revision.h>
#include "clk.h"
@@ -220,6 +221,8 @@ static int __init __mx25_clocks_init(void __iomem *ccm_base)
imx_register_uart_clocks(6);
+ imx_print_silicon_rev("i.MX25", mx25_revision());
+
return 0;
}
diff --git a/include/soc/imx/revision.h b/include/soc/imx/revision.h
index b2a55dafaf0a..b122d2fc8881 100644
--- a/include/soc/imx/revision.h
+++ b/include/soc/imx/revision.h
@@ -22,6 +22,7 @@
#define IMX_CHIP_REVISION_3_3 0x33
#define IMX_CHIP_REVISION_UNKNOWN 0xff
+int mx25_revision(void);
int mx27_revision(void);
int mx31_revision(void);
int mx35_revision(void);
--
2.30.2
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 54+ messages in thread
* [PATCH v2 2/2] clk: imx25: make __mx25_clocks_init return void
2022-06-23 7:51 ` Martin Kaiser
@ 2022-06-23 7:51 ` Martin Kaiser
-1 siblings, 0 replies; 54+ messages in thread
From: Martin Kaiser @ 2022-06-23 7:51 UTC (permalink / raw)
To: Abel Vesa, Stephen Boyd
Cc: Shawn Guo, Pengutronix Kernel Team, Fabio Estevam,
linux-arm-kernel, linux-clk, linux-kernel, Martin Kaiser
The __mx25_clocks_init function always returns 0 and its only
caller does not check the return value. Let's remove it.
Signed-off-by: Martin Kaiser <martin@kaiser.cx>
---
changes in v2:
- send the patch to the clk maintainers
drivers/clk/imx/clk-imx25.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/clk/imx/clk-imx25.c b/drivers/clk/imx/clk-imx25.c
index 263409fca1eb..72b30dd7f05f 100644
--- a/drivers/clk/imx/clk-imx25.c
+++ b/drivers/clk/imx/clk-imx25.c
@@ -74,7 +74,7 @@ enum mx25_clks {
static struct clk *clk[clk_max];
-static int __init __mx25_clocks_init(void __iomem *ccm_base)
+static void __init __mx25_clocks_init(void __iomem *ccm_base)
{
BUG_ON(!ccm_base);
@@ -222,8 +222,6 @@ static int __init __mx25_clocks_init(void __iomem *ccm_base)
imx_register_uart_clocks(6);
imx_print_silicon_rev("i.MX25", mx25_revision());
-
- return 0;
}
static void __init mx25_clocks_init_dt(struct device_node *np)
--
2.30.2
^ permalink raw reply related [flat|nested] 54+ messages in thread
* [PATCH v2 2/2] clk: imx25: make __mx25_clocks_init return void
@ 2022-06-23 7:51 ` Martin Kaiser
0 siblings, 0 replies; 54+ messages in thread
From: Martin Kaiser @ 2022-06-23 7:51 UTC (permalink / raw)
To: Abel Vesa, Stephen Boyd
Cc: Shawn Guo, Pengutronix Kernel Team, Fabio Estevam,
linux-arm-kernel, linux-clk, linux-kernel, Martin Kaiser
The __mx25_clocks_init function always returns 0 and its only
caller does not check the return value. Let's remove it.
Signed-off-by: Martin Kaiser <martin@kaiser.cx>
---
changes in v2:
- send the patch to the clk maintainers
drivers/clk/imx/clk-imx25.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/clk/imx/clk-imx25.c b/drivers/clk/imx/clk-imx25.c
index 263409fca1eb..72b30dd7f05f 100644
--- a/drivers/clk/imx/clk-imx25.c
+++ b/drivers/clk/imx/clk-imx25.c
@@ -74,7 +74,7 @@ enum mx25_clks {
static struct clk *clk[clk_max];
-static int __init __mx25_clocks_init(void __iomem *ccm_base)
+static void __init __mx25_clocks_init(void __iomem *ccm_base)
{
BUG_ON(!ccm_base);
@@ -222,8 +222,6 @@ static int __init __mx25_clocks_init(void __iomem *ccm_base)
imx_register_uart_clocks(6);
imx_print_silicon_rev("i.MX25", mx25_revision());
-
- return 0;
}
static void __init mx25_clocks_init_dt(struct device_node *np)
--
2.30.2
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 54+ messages in thread
* [PATCH v3 0/2] ARM: imx25: print silicon revision at startup
2022-06-02 8:03 ` Martin Kaiser
@ 2022-07-24 17:47 ` Martin Kaiser
-1 siblings, 0 replies; 54+ messages in thread
From: Martin Kaiser @ 2022-07-24 17:47 UTC (permalink / raw)
To: Abel Vesa, Stephen Boyd
Cc: Shawn Guo, Pengutronix Kernel Team, Fabio Estevam,
linux-arm-kernel, linux-clk, linux-kernel, Martin Kaiser
Resurrect the unused function to print the imx25 silicon revision at
startup.
It's been a month since I sent v2. I'm resending the series, hoping to
get a response this time. Thanks in advance.
changes in v3:
- rebase against today's linux-next
changes in v2:
- drop the patch about silicon revision 1.2. It has already been merged
by Shawn Guo.
- send the changeset to the clk maintainers
Martin Kaiser (2):
clk: imx25: print silicon revision during init
clk: imx25: make __mx25_clocks_init return void
drivers/clk/imx/clk-imx25.c | 5 +++--
include/soc/imx/revision.h | 1 +
2 files changed, 4 insertions(+), 2 deletions(-)
--
2.30.2
^ permalink raw reply [flat|nested] 54+ messages in thread
* [PATCH v3 0/2] ARM: imx25: print silicon revision at startup
@ 2022-07-24 17:47 ` Martin Kaiser
0 siblings, 0 replies; 54+ messages in thread
From: Martin Kaiser @ 2022-07-24 17:47 UTC (permalink / raw)
To: Abel Vesa, Stephen Boyd
Cc: Shawn Guo, Pengutronix Kernel Team, Fabio Estevam,
linux-arm-kernel, linux-clk, linux-kernel, Martin Kaiser
Resurrect the unused function to print the imx25 silicon revision at
startup.
It's been a month since I sent v2. I'm resending the series, hoping to
get a response this time. Thanks in advance.
changes in v3:
- rebase against today's linux-next
changes in v2:
- drop the patch about silicon revision 1.2. It has already been merged
by Shawn Guo.
- send the changeset to the clk maintainers
Martin Kaiser (2):
clk: imx25: print silicon revision during init
clk: imx25: make __mx25_clocks_init return void
drivers/clk/imx/clk-imx25.c | 5 +++--
include/soc/imx/revision.h | 1 +
2 files changed, 4 insertions(+), 2 deletions(-)
--
2.30.2
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 54+ messages in thread
* [PATCH v3 1/2] clk: imx25: print silicon revision during init
2022-07-24 17:47 ` Martin Kaiser
@ 2022-07-24 17:47 ` Martin Kaiser
-1 siblings, 0 replies; 54+ messages in thread
From: Martin Kaiser @ 2022-07-24 17:47 UTC (permalink / raw)
To: Abel Vesa, Stephen Boyd
Cc: Shawn Guo, Pengutronix Kernel Team, Fabio Estevam,
linux-arm-kernel, linux-clk, linux-kernel, Martin Kaiser
Print the imx25 silicon revision when the clocks are initialised.
Use the same mechanism as for imx27, i.e. call mx25_revision.
This function is unused at the moment.
Signed-off-by: Martin Kaiser <martin@kaiser.cx>
---
changes in v3:
- rebase against today's linux-next
changes in v2:
- send the patch to the clk maintainers
drivers/clk/imx/clk-imx25.c | 3 +++
include/soc/imx/revision.h | 1 +
2 files changed, 4 insertions(+)
diff --git a/drivers/clk/imx/clk-imx25.c b/drivers/clk/imx/clk-imx25.c
index 66192fe0a898..263409fca1eb 100644
--- a/drivers/clk/imx/clk-imx25.c
+++ b/drivers/clk/imx/clk-imx25.c
@@ -13,6 +13,7 @@
#include <linux/of.h>
#include <linux/of_address.h>
#include <linux/of_irq.h>
+#include <soc/imx/revision.h>
#include "clk.h"
@@ -220,6 +221,8 @@ static int __init __mx25_clocks_init(void __iomem *ccm_base)
imx_register_uart_clocks(6);
+ imx_print_silicon_rev("i.MX25", mx25_revision());
+
return 0;
}
diff --git a/include/soc/imx/revision.h b/include/soc/imx/revision.h
index b2a55dafaf0a..b122d2fc8881 100644
--- a/include/soc/imx/revision.h
+++ b/include/soc/imx/revision.h
@@ -22,6 +22,7 @@
#define IMX_CHIP_REVISION_3_3 0x33
#define IMX_CHIP_REVISION_UNKNOWN 0xff
+int mx25_revision(void);
int mx27_revision(void);
int mx31_revision(void);
int mx35_revision(void);
--
2.30.2
^ permalink raw reply related [flat|nested] 54+ messages in thread
* [PATCH v3 1/2] clk: imx25: print silicon revision during init
@ 2022-07-24 17:47 ` Martin Kaiser
0 siblings, 0 replies; 54+ messages in thread
From: Martin Kaiser @ 2022-07-24 17:47 UTC (permalink / raw)
To: Abel Vesa, Stephen Boyd
Cc: Shawn Guo, Pengutronix Kernel Team, Fabio Estevam,
linux-arm-kernel, linux-clk, linux-kernel, Martin Kaiser
Print the imx25 silicon revision when the clocks are initialised.
Use the same mechanism as for imx27, i.e. call mx25_revision.
This function is unused at the moment.
Signed-off-by: Martin Kaiser <martin@kaiser.cx>
---
changes in v3:
- rebase against today's linux-next
changes in v2:
- send the patch to the clk maintainers
drivers/clk/imx/clk-imx25.c | 3 +++
include/soc/imx/revision.h | 1 +
2 files changed, 4 insertions(+)
diff --git a/drivers/clk/imx/clk-imx25.c b/drivers/clk/imx/clk-imx25.c
index 66192fe0a898..263409fca1eb 100644
--- a/drivers/clk/imx/clk-imx25.c
+++ b/drivers/clk/imx/clk-imx25.c
@@ -13,6 +13,7 @@
#include <linux/of.h>
#include <linux/of_address.h>
#include <linux/of_irq.h>
+#include <soc/imx/revision.h>
#include "clk.h"
@@ -220,6 +221,8 @@ static int __init __mx25_clocks_init(void __iomem *ccm_base)
imx_register_uart_clocks(6);
+ imx_print_silicon_rev("i.MX25", mx25_revision());
+
return 0;
}
diff --git a/include/soc/imx/revision.h b/include/soc/imx/revision.h
index b2a55dafaf0a..b122d2fc8881 100644
--- a/include/soc/imx/revision.h
+++ b/include/soc/imx/revision.h
@@ -22,6 +22,7 @@
#define IMX_CHIP_REVISION_3_3 0x33
#define IMX_CHIP_REVISION_UNKNOWN 0xff
+int mx25_revision(void);
int mx27_revision(void);
int mx31_revision(void);
int mx35_revision(void);
--
2.30.2
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 54+ messages in thread
* [PATCH v3 2/2] clk: imx25: make __mx25_clocks_init return void
2022-07-24 17:47 ` Martin Kaiser
@ 2022-07-24 17:47 ` Martin Kaiser
-1 siblings, 0 replies; 54+ messages in thread
From: Martin Kaiser @ 2022-07-24 17:47 UTC (permalink / raw)
To: Abel Vesa, Stephen Boyd
Cc: Shawn Guo, Pengutronix Kernel Team, Fabio Estevam,
linux-arm-kernel, linux-clk, linux-kernel, Martin Kaiser
The __mx25_clocks_init function always returns 0 and its only
caller does not check the return value. Let's remove it.
Signed-off-by: Martin Kaiser <martin@kaiser.cx>
---
changes in v3:
- rebase against today's linux-next
changes in v2:
- send the patch to the clk maintainers
drivers/clk/imx/clk-imx25.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/clk/imx/clk-imx25.c b/drivers/clk/imx/clk-imx25.c
index 263409fca1eb..72b30dd7f05f 100644
--- a/drivers/clk/imx/clk-imx25.c
+++ b/drivers/clk/imx/clk-imx25.c
@@ -74,7 +74,7 @@ enum mx25_clks {
static struct clk *clk[clk_max];
-static int __init __mx25_clocks_init(void __iomem *ccm_base)
+static void __init __mx25_clocks_init(void __iomem *ccm_base)
{
BUG_ON(!ccm_base);
@@ -222,8 +222,6 @@ static int __init __mx25_clocks_init(void __iomem *ccm_base)
imx_register_uart_clocks(6);
imx_print_silicon_rev("i.MX25", mx25_revision());
-
- return 0;
}
static void __init mx25_clocks_init_dt(struct device_node *np)
--
2.30.2
^ permalink raw reply related [flat|nested] 54+ messages in thread
* [PATCH v3 2/2] clk: imx25: make __mx25_clocks_init return void
@ 2022-07-24 17:47 ` Martin Kaiser
0 siblings, 0 replies; 54+ messages in thread
From: Martin Kaiser @ 2022-07-24 17:47 UTC (permalink / raw)
To: Abel Vesa, Stephen Boyd
Cc: Shawn Guo, Pengutronix Kernel Team, Fabio Estevam,
linux-arm-kernel, linux-clk, linux-kernel, Martin Kaiser
The __mx25_clocks_init function always returns 0 and its only
caller does not check the return value. Let's remove it.
Signed-off-by: Martin Kaiser <martin@kaiser.cx>
---
changes in v3:
- rebase against today's linux-next
changes in v2:
- send the patch to the clk maintainers
drivers/clk/imx/clk-imx25.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/clk/imx/clk-imx25.c b/drivers/clk/imx/clk-imx25.c
index 263409fca1eb..72b30dd7f05f 100644
--- a/drivers/clk/imx/clk-imx25.c
+++ b/drivers/clk/imx/clk-imx25.c
@@ -74,7 +74,7 @@ enum mx25_clks {
static struct clk *clk[clk_max];
-static int __init __mx25_clocks_init(void __iomem *ccm_base)
+static void __init __mx25_clocks_init(void __iomem *ccm_base)
{
BUG_ON(!ccm_base);
@@ -222,8 +222,6 @@ static int __init __mx25_clocks_init(void __iomem *ccm_base)
imx_register_uart_clocks(6);
imx_print_silicon_rev("i.MX25", mx25_revision());
-
- return 0;
}
static void __init mx25_clocks_init_dt(struct device_node *np)
--
2.30.2
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 54+ messages in thread
* Re: [PATCH v3 1/2] clk: imx25: print silicon revision during init
2022-07-24 17:47 ` Martin Kaiser
@ 2022-07-25 10:53 ` Fabio Estevam
-1 siblings, 0 replies; 54+ messages in thread
From: Fabio Estevam @ 2022-07-25 10:53 UTC (permalink / raw)
To: Martin Kaiser
Cc: Abel Vesa, Stephen Boyd, Shawn Guo, Pengutronix Kernel Team,
moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
linux-clk, linux-kernel
Hi Martin,
On Sun, Jul 24, 2022 at 2:48 PM Martin Kaiser <martin@kaiser.cx> wrote:
>
> Print the imx25 silicon revision when the clocks are initialised.
>
> Use the same mechanism as for imx27, i.e. call mx25_revision.
> This function is unused at the moment.
>
> Signed-off-by: Martin Kaiser <martin@kaiser.cx>
Reviewed-by: Fabio Estevam <festevam@gmail.com>
^ permalink raw reply [flat|nested] 54+ messages in thread
* Re: [PATCH v3 1/2] clk: imx25: print silicon revision during init
@ 2022-07-25 10:53 ` Fabio Estevam
0 siblings, 0 replies; 54+ messages in thread
From: Fabio Estevam @ 2022-07-25 10:53 UTC (permalink / raw)
To: Martin Kaiser
Cc: Abel Vesa, Stephen Boyd, Shawn Guo, Pengutronix Kernel Team,
moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
linux-clk, linux-kernel
Hi Martin,
On Sun, Jul 24, 2022 at 2:48 PM Martin Kaiser <martin@kaiser.cx> wrote:
>
> Print the imx25 silicon revision when the clocks are initialised.
>
> Use the same mechanism as for imx27, i.e. call mx25_revision.
> This function is unused at the moment.
>
> Signed-off-by: Martin Kaiser <martin@kaiser.cx>
Reviewed-by: Fabio Estevam <festevam@gmail.com>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 54+ messages in thread
* Re: [PATCH v3 2/2] clk: imx25: make __mx25_clocks_init return void
2022-07-24 17:47 ` Martin Kaiser
@ 2022-07-25 10:54 ` Fabio Estevam
-1 siblings, 0 replies; 54+ messages in thread
From: Fabio Estevam @ 2022-07-25 10:54 UTC (permalink / raw)
To: Martin Kaiser
Cc: Abel Vesa, Stephen Boyd, Shawn Guo, Pengutronix Kernel Team,
moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
linux-clk, linux-kernel
On Sun, Jul 24, 2022 at 2:48 PM Martin Kaiser <martin@kaiser.cx> wrote:
>
> The __mx25_clocks_init function always returns 0 and its only
> caller does not check the return value. Let's remove it.
>
> Signed-off-by: Martin Kaiser <martin@kaiser.cx>
Reviewed-by: Fabio Estevam <festevam@gmail.com>
^ permalink raw reply [flat|nested] 54+ messages in thread
* Re: [PATCH v3 2/2] clk: imx25: make __mx25_clocks_init return void
@ 2022-07-25 10:54 ` Fabio Estevam
0 siblings, 0 replies; 54+ messages in thread
From: Fabio Estevam @ 2022-07-25 10:54 UTC (permalink / raw)
To: Martin Kaiser
Cc: Abel Vesa, Stephen Boyd, Shawn Guo, Pengutronix Kernel Team,
moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
linux-clk, linux-kernel
On Sun, Jul 24, 2022 at 2:48 PM Martin Kaiser <martin@kaiser.cx> wrote:
>
> The __mx25_clocks_init function always returns 0 and its only
> caller does not check the return value. Let's remove it.
>
> Signed-off-by: Martin Kaiser <martin@kaiser.cx>
Reviewed-by: Fabio Estevam <festevam@gmail.com>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 54+ messages in thread
* [PATCH v4 0/2] ARM: imx25: print silicon revision at startup
2022-06-02 8:03 ` Martin Kaiser
@ 2022-08-15 19:07 ` Martin Kaiser
-1 siblings, 0 replies; 54+ messages in thread
From: Martin Kaiser @ 2022-08-15 19:07 UTC (permalink / raw)
To: Abel Vesa, Stephen Boyd
Cc: Shawn Guo, Pengutronix Kernel Team, Fabio Estevam,
linux-arm-kernel, linux-clk, linux-kernel, Martin Kaiser
Resurrect the unused function to print the imx25 silicon revision at
startup.
Now that 6.0-rc1 is out, I hope that the clk maintainers have a moment
to review this simple patch set ;-)
changes in v4:
- rebase against today's linux-next
- add Fabio's Reviewed-by tags
changes in v3:
- rebase against today's linux-next
changes in v2:
- drop the patch about silicon revision 1.2. It has already been merged
by Shawn Guo.
- send the changeset to the clk maintainers
Martin Kaiser (2):
clk: imx25: print silicon revision during init
clk: imx25: make __mx25_clocks_init return void
drivers/clk/imx/clk-imx25.c | 5 +++--
include/soc/imx/revision.h | 1 +
2 files changed, 4 insertions(+), 2 deletions(-)
--
2.30.2
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 54+ messages in thread
* [PATCH v4 0/2] ARM: imx25: print silicon revision at startup
@ 2022-08-15 19:07 ` Martin Kaiser
0 siblings, 0 replies; 54+ messages in thread
From: Martin Kaiser @ 2022-08-15 19:07 UTC (permalink / raw)
To: Abel Vesa, Stephen Boyd
Cc: Shawn Guo, Pengutronix Kernel Team, Fabio Estevam,
linux-arm-kernel, linux-clk, linux-kernel, Martin Kaiser
Resurrect the unused function to print the imx25 silicon revision at
startup.
Now that 6.0-rc1 is out, I hope that the clk maintainers have a moment
to review this simple patch set ;-)
changes in v4:
- rebase against today's linux-next
- add Fabio's Reviewed-by tags
changes in v3:
- rebase against today's linux-next
changes in v2:
- drop the patch about silicon revision 1.2. It has already been merged
by Shawn Guo.
- send the changeset to the clk maintainers
Martin Kaiser (2):
clk: imx25: print silicon revision during init
clk: imx25: make __mx25_clocks_init return void
drivers/clk/imx/clk-imx25.c | 5 +++--
include/soc/imx/revision.h | 1 +
2 files changed, 4 insertions(+), 2 deletions(-)
--
2.30.2
^ permalink raw reply [flat|nested] 54+ messages in thread
* [PATCH v4 1/2] clk: imx25: print silicon revision during init
2022-08-15 19:07 ` Martin Kaiser
@ 2022-08-15 19:07 ` Martin Kaiser
-1 siblings, 0 replies; 54+ messages in thread
From: Martin Kaiser @ 2022-08-15 19:07 UTC (permalink / raw)
To: Abel Vesa, Stephen Boyd
Cc: Shawn Guo, Pengutronix Kernel Team, Fabio Estevam,
linux-arm-kernel, linux-clk, linux-kernel, Martin Kaiser
Print the imx25 silicon revision when the clocks are initialised.
Use the same mechanism as for imx27, i.e. call mx25_revision.
This function is unused at the moment.
Signed-off-by: Martin Kaiser <martin@kaiser.cx>
Reviewed-by: Fabio Estevam <festevam@gmail.com>
---
changes in v4:
- rebase against today's linux-next
- add Fabio's Reviewed-by tag
changes in v3:
- rebase against today's linux-next
changes in v2:
- send the patch to the clk maintainers
drivers/clk/imx/clk-imx25.c | 3 +++
include/soc/imx/revision.h | 1 +
2 files changed, 4 insertions(+)
diff --git a/drivers/clk/imx/clk-imx25.c b/drivers/clk/imx/clk-imx25.c
index 66192fe0a898..263409fca1eb 100644
--- a/drivers/clk/imx/clk-imx25.c
+++ b/drivers/clk/imx/clk-imx25.c
@@ -13,6 +13,7 @@
#include <linux/of.h>
#include <linux/of_address.h>
#include <linux/of_irq.h>
+#include <soc/imx/revision.h>
#include "clk.h"
@@ -220,6 +221,8 @@ static int __init __mx25_clocks_init(void __iomem *ccm_base)
imx_register_uart_clocks(6);
+ imx_print_silicon_rev("i.MX25", mx25_revision());
+
return 0;
}
diff --git a/include/soc/imx/revision.h b/include/soc/imx/revision.h
index b2a55dafaf0a..b122d2fc8881 100644
--- a/include/soc/imx/revision.h
+++ b/include/soc/imx/revision.h
@@ -22,6 +22,7 @@
#define IMX_CHIP_REVISION_3_3 0x33
#define IMX_CHIP_REVISION_UNKNOWN 0xff
+int mx25_revision(void);
int mx27_revision(void);
int mx31_revision(void);
int mx35_revision(void);
--
2.30.2
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 54+ messages in thread
* [PATCH v4 1/2] clk: imx25: print silicon revision during init
@ 2022-08-15 19:07 ` Martin Kaiser
0 siblings, 0 replies; 54+ messages in thread
From: Martin Kaiser @ 2022-08-15 19:07 UTC (permalink / raw)
To: Abel Vesa, Stephen Boyd
Cc: Shawn Guo, Pengutronix Kernel Team, Fabio Estevam,
linux-arm-kernel, linux-clk, linux-kernel, Martin Kaiser
Print the imx25 silicon revision when the clocks are initialised.
Use the same mechanism as for imx27, i.e. call mx25_revision.
This function is unused at the moment.
Signed-off-by: Martin Kaiser <martin@kaiser.cx>
Reviewed-by: Fabio Estevam <festevam@gmail.com>
---
changes in v4:
- rebase against today's linux-next
- add Fabio's Reviewed-by tag
changes in v3:
- rebase against today's linux-next
changes in v2:
- send the patch to the clk maintainers
drivers/clk/imx/clk-imx25.c | 3 +++
include/soc/imx/revision.h | 1 +
2 files changed, 4 insertions(+)
diff --git a/drivers/clk/imx/clk-imx25.c b/drivers/clk/imx/clk-imx25.c
index 66192fe0a898..263409fca1eb 100644
--- a/drivers/clk/imx/clk-imx25.c
+++ b/drivers/clk/imx/clk-imx25.c
@@ -13,6 +13,7 @@
#include <linux/of.h>
#include <linux/of_address.h>
#include <linux/of_irq.h>
+#include <soc/imx/revision.h>
#include "clk.h"
@@ -220,6 +221,8 @@ static int __init __mx25_clocks_init(void __iomem *ccm_base)
imx_register_uart_clocks(6);
+ imx_print_silicon_rev("i.MX25", mx25_revision());
+
return 0;
}
diff --git a/include/soc/imx/revision.h b/include/soc/imx/revision.h
index b2a55dafaf0a..b122d2fc8881 100644
--- a/include/soc/imx/revision.h
+++ b/include/soc/imx/revision.h
@@ -22,6 +22,7 @@
#define IMX_CHIP_REVISION_3_3 0x33
#define IMX_CHIP_REVISION_UNKNOWN 0xff
+int mx25_revision(void);
int mx27_revision(void);
int mx31_revision(void);
int mx35_revision(void);
--
2.30.2
^ permalink raw reply related [flat|nested] 54+ messages in thread
* [PATCH v4 2/2] clk: imx25: make __mx25_clocks_init return void
2022-08-15 19:07 ` Martin Kaiser
@ 2022-08-15 19:07 ` Martin Kaiser
-1 siblings, 0 replies; 54+ messages in thread
From: Martin Kaiser @ 2022-08-15 19:07 UTC (permalink / raw)
To: Abel Vesa, Stephen Boyd
Cc: Shawn Guo, Pengutronix Kernel Team, Fabio Estevam,
linux-arm-kernel, linux-clk, linux-kernel, Martin Kaiser
The __mx25_clocks_init function always returns 0 and its only
caller does not check the return value. Let's remove it.
Signed-off-by: Martin Kaiser <martin@kaiser.cx>
Reviewed-by: Fabio Estevam <festevam@gmail.com>
---
changes in v4:
- rebase against today's linux-next
- add Fabio's Reviewed-by tag
changes in v3:
- rebase against today's linux-next
changes in v2:
- send the patch to the clk maintainers
drivers/clk/imx/clk-imx25.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/clk/imx/clk-imx25.c b/drivers/clk/imx/clk-imx25.c
index 263409fca1eb..72b30dd7f05f 100644
--- a/drivers/clk/imx/clk-imx25.c
+++ b/drivers/clk/imx/clk-imx25.c
@@ -74,7 +74,7 @@ enum mx25_clks {
static struct clk *clk[clk_max];
-static int __init __mx25_clocks_init(void __iomem *ccm_base)
+static void __init __mx25_clocks_init(void __iomem *ccm_base)
{
BUG_ON(!ccm_base);
@@ -222,8 +222,6 @@ static int __init __mx25_clocks_init(void __iomem *ccm_base)
imx_register_uart_clocks(6);
imx_print_silicon_rev("i.MX25", mx25_revision());
-
- return 0;
}
static void __init mx25_clocks_init_dt(struct device_node *np)
--
2.30.2
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 54+ messages in thread
* [PATCH v4 2/2] clk: imx25: make __mx25_clocks_init return void
@ 2022-08-15 19:07 ` Martin Kaiser
0 siblings, 0 replies; 54+ messages in thread
From: Martin Kaiser @ 2022-08-15 19:07 UTC (permalink / raw)
To: Abel Vesa, Stephen Boyd
Cc: Shawn Guo, Pengutronix Kernel Team, Fabio Estevam,
linux-arm-kernel, linux-clk, linux-kernel, Martin Kaiser
The __mx25_clocks_init function always returns 0 and its only
caller does not check the return value. Let's remove it.
Signed-off-by: Martin Kaiser <martin@kaiser.cx>
Reviewed-by: Fabio Estevam <festevam@gmail.com>
---
changes in v4:
- rebase against today's linux-next
- add Fabio's Reviewed-by tag
changes in v3:
- rebase against today's linux-next
changes in v2:
- send the patch to the clk maintainers
drivers/clk/imx/clk-imx25.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/clk/imx/clk-imx25.c b/drivers/clk/imx/clk-imx25.c
index 263409fca1eb..72b30dd7f05f 100644
--- a/drivers/clk/imx/clk-imx25.c
+++ b/drivers/clk/imx/clk-imx25.c
@@ -74,7 +74,7 @@ enum mx25_clks {
static struct clk *clk[clk_max];
-static int __init __mx25_clocks_init(void __iomem *ccm_base)
+static void __init __mx25_clocks_init(void __iomem *ccm_base)
{
BUG_ON(!ccm_base);
@@ -222,8 +222,6 @@ static int __init __mx25_clocks_init(void __iomem *ccm_base)
imx_register_uart_clocks(6);
imx_print_silicon_rev("i.MX25", mx25_revision());
-
- return 0;
}
static void __init mx25_clocks_init_dt(struct device_node *np)
--
2.30.2
^ permalink raw reply related [flat|nested] 54+ messages in thread
* [PATCH v5 0/2] ARM: imx25: print silicon revision at startup
2022-08-15 19:07 ` Martin Kaiser
@ 2023-05-17 15:39 ` Martin Kaiser
-1 siblings, 0 replies; 54+ messages in thread
From: Martin Kaiser @ 2023-05-17 15:39 UTC (permalink / raw)
To: Abel Vesa, Stephen Boyd
Cc: Shawn Guo, Pengutronix Kernel Team, Fabio Estevam, Arnd Bergmann,
linux-arm-kernel, linux-clk, linux-kernel, Martin Kaiser
Resurrect the unused function to print the imx25 silicon revision at
startup.
This patchset has been mentioned in a discussion today. Let's bring it to the
attention of the clk maintainers again.
Thanks & best regards,
Martin
changes in v5:
- rebase against today's linux-next
changes in v4:
- rebase against today's linux-next
- add Fabio's Reviewed-by tags
changes in v3:
- rebase against today's linux-next
changes in v2:
- drop the patch about silicon revision 1.2. It has already been merged
by Shawn Guo.
- send the changeset to the clk maintainers
Martin Kaiser (2):
clk: imx25: print silicon revision during init
clk: imx25: make __mx25_clocks_init return void
drivers/clk/imx/clk-imx25.c | 5 +++--
include/soc/imx/revision.h | 1 +
2 files changed, 4 insertions(+), 2 deletions(-)
--
2.30.2
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 54+ messages in thread
* [PATCH v5 0/2] ARM: imx25: print silicon revision at startup
@ 2023-05-17 15:39 ` Martin Kaiser
0 siblings, 0 replies; 54+ messages in thread
From: Martin Kaiser @ 2023-05-17 15:39 UTC (permalink / raw)
To: Abel Vesa, Stephen Boyd
Cc: Shawn Guo, Pengutronix Kernel Team, Fabio Estevam, Arnd Bergmann,
linux-arm-kernel, linux-clk, linux-kernel, Martin Kaiser
Resurrect the unused function to print the imx25 silicon revision at
startup.
This patchset has been mentioned in a discussion today. Let's bring it to the
attention of the clk maintainers again.
Thanks & best regards,
Martin
changes in v5:
- rebase against today's linux-next
changes in v4:
- rebase against today's linux-next
- add Fabio's Reviewed-by tags
changes in v3:
- rebase against today's linux-next
changes in v2:
- drop the patch about silicon revision 1.2. It has already been merged
by Shawn Guo.
- send the changeset to the clk maintainers
Martin Kaiser (2):
clk: imx25: print silicon revision during init
clk: imx25: make __mx25_clocks_init return void
drivers/clk/imx/clk-imx25.c | 5 +++--
include/soc/imx/revision.h | 1 +
2 files changed, 4 insertions(+), 2 deletions(-)
--
2.30.2
^ permalink raw reply [flat|nested] 54+ messages in thread
* [PATCH v5 1/2] clk: imx25: print silicon revision during init
2023-05-17 15:39 ` Martin Kaiser
@ 2023-05-17 15:39 ` Martin Kaiser
-1 siblings, 0 replies; 54+ messages in thread
From: Martin Kaiser @ 2023-05-17 15:39 UTC (permalink / raw)
To: Abel Vesa, Stephen Boyd
Cc: Shawn Guo, Pengutronix Kernel Team, Fabio Estevam, Arnd Bergmann,
linux-arm-kernel, linux-clk, linux-kernel, Martin Kaiser
Print the imx25 silicon revision when the clocks are initialised.
Use the same mechanism as for imx27, i.e. call mx25_revision.
This function is unused at the moment.
Signed-off-by: Martin Kaiser <martin@kaiser.cx>
Reviewed-by: Fabio Estevam <festevam@gmail.com>
---
changes in v5:
- rebase against today's linux-next
changes in v4:
- rebase against today's linux-next
- add Fabio's Reviewed-by tag
changes in v3:
- rebase against today's linux-next
changes in v2:
- send the patch to the clk maintainers
drivers/clk/imx/clk-imx25.c | 3 +++
include/soc/imx/revision.h | 1 +
2 files changed, 4 insertions(+)
diff --git a/drivers/clk/imx/clk-imx25.c b/drivers/clk/imx/clk-imx25.c
index cc013b343e62..bee3da2e21e1 100644
--- a/drivers/clk/imx/clk-imx25.c
+++ b/drivers/clk/imx/clk-imx25.c
@@ -13,6 +13,7 @@
#include <linux/of.h>
#include <linux/of_address.h>
#include <linux/of_irq.h>
+#include <soc/imx/revision.h>
#include "clk.h"
@@ -220,6 +221,8 @@ static int __init __mx25_clocks_init(void __iomem *ccm_base)
imx_register_uart_clocks();
+ imx_print_silicon_rev("i.MX25", mx25_revision());
+
return 0;
}
diff --git a/include/soc/imx/revision.h b/include/soc/imx/revision.h
index b2a55dafaf0a..b122d2fc8881 100644
--- a/include/soc/imx/revision.h
+++ b/include/soc/imx/revision.h
@@ -22,6 +22,7 @@
#define IMX_CHIP_REVISION_3_3 0x33
#define IMX_CHIP_REVISION_UNKNOWN 0xff
+int mx25_revision(void);
int mx27_revision(void);
int mx31_revision(void);
int mx35_revision(void);
--
2.30.2
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 54+ messages in thread
* [PATCH v5 1/2] clk: imx25: print silicon revision during init
@ 2023-05-17 15:39 ` Martin Kaiser
0 siblings, 0 replies; 54+ messages in thread
From: Martin Kaiser @ 2023-05-17 15:39 UTC (permalink / raw)
To: Abel Vesa, Stephen Boyd
Cc: Shawn Guo, Pengutronix Kernel Team, Fabio Estevam, Arnd Bergmann,
linux-arm-kernel, linux-clk, linux-kernel, Martin Kaiser
Print the imx25 silicon revision when the clocks are initialised.
Use the same mechanism as for imx27, i.e. call mx25_revision.
This function is unused at the moment.
Signed-off-by: Martin Kaiser <martin@kaiser.cx>
Reviewed-by: Fabio Estevam <festevam@gmail.com>
---
changes in v5:
- rebase against today's linux-next
changes in v4:
- rebase against today's linux-next
- add Fabio's Reviewed-by tag
changes in v3:
- rebase against today's linux-next
changes in v2:
- send the patch to the clk maintainers
drivers/clk/imx/clk-imx25.c | 3 +++
include/soc/imx/revision.h | 1 +
2 files changed, 4 insertions(+)
diff --git a/drivers/clk/imx/clk-imx25.c b/drivers/clk/imx/clk-imx25.c
index cc013b343e62..bee3da2e21e1 100644
--- a/drivers/clk/imx/clk-imx25.c
+++ b/drivers/clk/imx/clk-imx25.c
@@ -13,6 +13,7 @@
#include <linux/of.h>
#include <linux/of_address.h>
#include <linux/of_irq.h>
+#include <soc/imx/revision.h>
#include "clk.h"
@@ -220,6 +221,8 @@ static int __init __mx25_clocks_init(void __iomem *ccm_base)
imx_register_uart_clocks();
+ imx_print_silicon_rev("i.MX25", mx25_revision());
+
return 0;
}
diff --git a/include/soc/imx/revision.h b/include/soc/imx/revision.h
index b2a55dafaf0a..b122d2fc8881 100644
--- a/include/soc/imx/revision.h
+++ b/include/soc/imx/revision.h
@@ -22,6 +22,7 @@
#define IMX_CHIP_REVISION_3_3 0x33
#define IMX_CHIP_REVISION_UNKNOWN 0xff
+int mx25_revision(void);
int mx27_revision(void);
int mx31_revision(void);
int mx35_revision(void);
--
2.30.2
^ permalink raw reply related [flat|nested] 54+ messages in thread
* [PATCH v5 2/2] clk: imx25: make __mx25_clocks_init return void
2023-05-17 15:39 ` Martin Kaiser
@ 2023-05-17 15:39 ` Martin Kaiser
-1 siblings, 0 replies; 54+ messages in thread
From: Martin Kaiser @ 2023-05-17 15:39 UTC (permalink / raw)
To: Abel Vesa, Stephen Boyd
Cc: Shawn Guo, Pengutronix Kernel Team, Fabio Estevam, Arnd Bergmann,
linux-arm-kernel, linux-clk, linux-kernel, Martin Kaiser
The __mx25_clocks_init function always returns 0 and its only
caller does not check the return value. Let's remove it.
Signed-off-by: Martin Kaiser <martin@kaiser.cx>
Reviewed-by: Fabio Estevam <festevam@gmail.com>
---
changes in v5:
- rebase against today's linux-next
changes in v4:
- rebase against today's linux-next
- add Fabio's Reviewed-by tag
changes in v3:
- rebase against today's linux-next
changes in v2:
- send the patch to the clk maintainers
drivers/clk/imx/clk-imx25.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/clk/imx/clk-imx25.c b/drivers/clk/imx/clk-imx25.c
index bee3da2e21e1..c566be848c2d 100644
--- a/drivers/clk/imx/clk-imx25.c
+++ b/drivers/clk/imx/clk-imx25.c
@@ -74,7 +74,7 @@ enum mx25_clks {
static struct clk *clk[clk_max];
-static int __init __mx25_clocks_init(void __iomem *ccm_base)
+static void __init __mx25_clocks_init(void __iomem *ccm_base)
{
BUG_ON(!ccm_base);
@@ -222,8 +222,6 @@ static int __init __mx25_clocks_init(void __iomem *ccm_base)
imx_register_uart_clocks();
imx_print_silicon_rev("i.MX25", mx25_revision());
-
- return 0;
}
static void __init mx25_clocks_init_dt(struct device_node *np)
--
2.30.2
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 54+ messages in thread
* [PATCH v5 2/2] clk: imx25: make __mx25_clocks_init return void
@ 2023-05-17 15:39 ` Martin Kaiser
0 siblings, 0 replies; 54+ messages in thread
From: Martin Kaiser @ 2023-05-17 15:39 UTC (permalink / raw)
To: Abel Vesa, Stephen Boyd
Cc: Shawn Guo, Pengutronix Kernel Team, Fabio Estevam, Arnd Bergmann,
linux-arm-kernel, linux-clk, linux-kernel, Martin Kaiser
The __mx25_clocks_init function always returns 0 and its only
caller does not check the return value. Let's remove it.
Signed-off-by: Martin Kaiser <martin@kaiser.cx>
Reviewed-by: Fabio Estevam <festevam@gmail.com>
---
changes in v5:
- rebase against today's linux-next
changes in v4:
- rebase against today's linux-next
- add Fabio's Reviewed-by tag
changes in v3:
- rebase against today's linux-next
changes in v2:
- send the patch to the clk maintainers
drivers/clk/imx/clk-imx25.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/clk/imx/clk-imx25.c b/drivers/clk/imx/clk-imx25.c
index bee3da2e21e1..c566be848c2d 100644
--- a/drivers/clk/imx/clk-imx25.c
+++ b/drivers/clk/imx/clk-imx25.c
@@ -74,7 +74,7 @@ enum mx25_clks {
static struct clk *clk[clk_max];
-static int __init __mx25_clocks_init(void __iomem *ccm_base)
+static void __init __mx25_clocks_init(void __iomem *ccm_base)
{
BUG_ON(!ccm_base);
@@ -222,8 +222,6 @@ static int __init __mx25_clocks_init(void __iomem *ccm_base)
imx_register_uart_clocks();
imx_print_silicon_rev("i.MX25", mx25_revision());
-
- return 0;
}
static void __init mx25_clocks_init_dt(struct device_node *np)
--
2.30.2
^ permalink raw reply related [flat|nested] 54+ messages in thread
* Re: [PATCH v5 0/2] ARM: imx25: print silicon revision at startup
2023-05-17 15:39 ` Martin Kaiser
@ 2023-05-17 18:21 ` Arnd Bergmann
-1 siblings, 0 replies; 54+ messages in thread
From: Arnd Bergmann @ 2023-05-17 18:21 UTC (permalink / raw)
To: Martin Kaiser, Abel Vesa, Stephen Boyd
Cc: Shawn Guo, Pengutronix Kernel Team, Fabio Estevam,
linux-arm-kernel, linux-clk, linux-kernel
On Wed, May 17, 2023, at 17:39, Martin Kaiser wrote:
> Resurrect the unused function to print the imx25 silicon revision at
> startup.
>
> This patchset has been mentioned in a discussion today. Let's bring it to the
> attention of the clk maintainers again.
Looks good to me, and fixes the warning about the function having
no prototype, so
Acked-by: Arnd Bergmann <arnd@arndb.de>
^ permalink raw reply [flat|nested] 54+ messages in thread
* Re: [PATCH v5 0/2] ARM: imx25: print silicon revision at startup
@ 2023-05-17 18:21 ` Arnd Bergmann
0 siblings, 0 replies; 54+ messages in thread
From: Arnd Bergmann @ 2023-05-17 18:21 UTC (permalink / raw)
To: Martin Kaiser, Abel Vesa, Stephen Boyd
Cc: Shawn Guo, Pengutronix Kernel Team, Fabio Estevam,
linux-arm-kernel, linux-clk, linux-kernel
On Wed, May 17, 2023, at 17:39, Martin Kaiser wrote:
> Resurrect the unused function to print the imx25 silicon revision at
> startup.
>
> This patchset has been mentioned in a discussion today. Let's bring it to the
> attention of the clk maintainers again.
Looks good to me, and fixes the warning about the function having
no prototype, so
Acked-by: Arnd Bergmann <arnd@arndb.de>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 54+ messages in thread
* [PATCH v6 0/2] ARM: imx25: print silicon revision at startup
2022-06-02 8:03 ` Martin Kaiser
@ 2023-07-30 16:39 ` Martin Kaiser
-1 siblings, 0 replies; 54+ messages in thread
From: Martin Kaiser @ 2023-07-30 16:39 UTC (permalink / raw)
To: Abel Vesa, Stephen Boyd
Cc: Shawn Guo, Fabio Estevam, Arnd Bergmann, linux-arm-kernel,
linux-clk, linux-kernel, Martin Kaiser
Resurrect the unused function to print the imx25 silicon revision at
startup.
This patch set is blocking Arnd's work on enabling -Werror=missing-prototypes.
I'd really appreciate a response from the clk maintainers if these (trivial)
patches are ok.
Thanks,
Martin
changes in v6:
- rebase against today's linux-next
- add Acked-by from Arnd
changes in v5:
- rebase against today's linux-next
changes in v4:
- rebase against today's linux-next
- add Fabio's Reviewed-by tags
changes in v3:
- rebase against today's linux-next
changes in v2:
- drop the patch about silicon revision 1.2. It has already been merged
by Shawn Guo.
- send the changeset to the clk maintainers
Martin Kaiser (2):
clk: imx25: print silicon revision during init
clk: imx25: make __mx25_clocks_init return void
drivers/clk/imx/clk-imx25.c | 5 +++--
include/soc/imx/revision.h | 1 +
2 files changed, 4 insertions(+), 2 deletions(-)
--
2.39.2
^ permalink raw reply [flat|nested] 54+ messages in thread
* [PATCH v6 0/2] ARM: imx25: print silicon revision at startup
@ 2023-07-30 16:39 ` Martin Kaiser
0 siblings, 0 replies; 54+ messages in thread
From: Martin Kaiser @ 2023-07-30 16:39 UTC (permalink / raw)
To: Abel Vesa, Stephen Boyd
Cc: Shawn Guo, Fabio Estevam, Arnd Bergmann, linux-arm-kernel,
linux-clk, linux-kernel, Martin Kaiser
Resurrect the unused function to print the imx25 silicon revision at
startup.
This patch set is blocking Arnd's work on enabling -Werror=missing-prototypes.
I'd really appreciate a response from the clk maintainers if these (trivial)
patches are ok.
Thanks,
Martin
changes in v6:
- rebase against today's linux-next
- add Acked-by from Arnd
changes in v5:
- rebase against today's linux-next
changes in v4:
- rebase against today's linux-next
- add Fabio's Reviewed-by tags
changes in v3:
- rebase against today's linux-next
changes in v2:
- drop the patch about silicon revision 1.2. It has already been merged
by Shawn Guo.
- send the changeset to the clk maintainers
Martin Kaiser (2):
clk: imx25: print silicon revision during init
clk: imx25: make __mx25_clocks_init return void
drivers/clk/imx/clk-imx25.c | 5 +++--
include/soc/imx/revision.h | 1 +
2 files changed, 4 insertions(+), 2 deletions(-)
--
2.39.2
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 54+ messages in thread
* [PATCH v6 1/2] clk: imx25: print silicon revision during init
2023-07-30 16:39 ` Martin Kaiser
@ 2023-07-30 16:39 ` Martin Kaiser
-1 siblings, 0 replies; 54+ messages in thread
From: Martin Kaiser @ 2023-07-30 16:39 UTC (permalink / raw)
To: Abel Vesa, Stephen Boyd
Cc: Shawn Guo, Fabio Estevam, Arnd Bergmann, linux-arm-kernel,
linux-clk, linux-kernel, Martin Kaiser
Print the imx25 silicon revision when the clocks are initialised.
Use the same mechanism as for imx27, i.e. call mx25_revision.
This function is unused at the moment.
Signed-off-by: Martin Kaiser <martin@kaiser.cx>
Reviewed-by: Fabio Estevam <festevam@gmail.com>
Acked-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/clk/imx/clk-imx25.c | 3 +++
include/soc/imx/revision.h | 1 +
2 files changed, 4 insertions(+)
diff --git a/drivers/clk/imx/clk-imx25.c b/drivers/clk/imx/clk-imx25.c
index cc013b343e62..bee3da2e21e1 100644
--- a/drivers/clk/imx/clk-imx25.c
+++ b/drivers/clk/imx/clk-imx25.c
@@ -13,6 +13,7 @@
#include <linux/of.h>
#include <linux/of_address.h>
#include <linux/of_irq.h>
+#include <soc/imx/revision.h>
#include "clk.h"
@@ -220,6 +221,8 @@ static int __init __mx25_clocks_init(void __iomem *ccm_base)
imx_register_uart_clocks();
+ imx_print_silicon_rev("i.MX25", mx25_revision());
+
return 0;
}
diff --git a/include/soc/imx/revision.h b/include/soc/imx/revision.h
index b2a55dafaf0a..b122d2fc8881 100644
--- a/include/soc/imx/revision.h
+++ b/include/soc/imx/revision.h
@@ -22,6 +22,7 @@
#define IMX_CHIP_REVISION_3_3 0x33
#define IMX_CHIP_REVISION_UNKNOWN 0xff
+int mx25_revision(void);
int mx27_revision(void);
int mx31_revision(void);
int mx35_revision(void);
--
2.39.2
^ permalink raw reply related [flat|nested] 54+ messages in thread
* [PATCH v6 1/2] clk: imx25: print silicon revision during init
@ 2023-07-30 16:39 ` Martin Kaiser
0 siblings, 0 replies; 54+ messages in thread
From: Martin Kaiser @ 2023-07-30 16:39 UTC (permalink / raw)
To: Abel Vesa, Stephen Boyd
Cc: Shawn Guo, Fabio Estevam, Arnd Bergmann, linux-arm-kernel,
linux-clk, linux-kernel, Martin Kaiser
Print the imx25 silicon revision when the clocks are initialised.
Use the same mechanism as for imx27, i.e. call mx25_revision.
This function is unused at the moment.
Signed-off-by: Martin Kaiser <martin@kaiser.cx>
Reviewed-by: Fabio Estevam <festevam@gmail.com>
Acked-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/clk/imx/clk-imx25.c | 3 +++
include/soc/imx/revision.h | 1 +
2 files changed, 4 insertions(+)
diff --git a/drivers/clk/imx/clk-imx25.c b/drivers/clk/imx/clk-imx25.c
index cc013b343e62..bee3da2e21e1 100644
--- a/drivers/clk/imx/clk-imx25.c
+++ b/drivers/clk/imx/clk-imx25.c
@@ -13,6 +13,7 @@
#include <linux/of.h>
#include <linux/of_address.h>
#include <linux/of_irq.h>
+#include <soc/imx/revision.h>
#include "clk.h"
@@ -220,6 +221,8 @@ static int __init __mx25_clocks_init(void __iomem *ccm_base)
imx_register_uart_clocks();
+ imx_print_silicon_rev("i.MX25", mx25_revision());
+
return 0;
}
diff --git a/include/soc/imx/revision.h b/include/soc/imx/revision.h
index b2a55dafaf0a..b122d2fc8881 100644
--- a/include/soc/imx/revision.h
+++ b/include/soc/imx/revision.h
@@ -22,6 +22,7 @@
#define IMX_CHIP_REVISION_3_3 0x33
#define IMX_CHIP_REVISION_UNKNOWN 0xff
+int mx25_revision(void);
int mx27_revision(void);
int mx31_revision(void);
int mx35_revision(void);
--
2.39.2
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 54+ messages in thread
* [PATCH v6 2/2] clk: imx25: make __mx25_clocks_init return void
2023-07-30 16:39 ` Martin Kaiser
@ 2023-07-30 16:39 ` Martin Kaiser
-1 siblings, 0 replies; 54+ messages in thread
From: Martin Kaiser @ 2023-07-30 16:39 UTC (permalink / raw)
To: Abel Vesa, Stephen Boyd
Cc: Shawn Guo, Fabio Estevam, Arnd Bergmann, linux-arm-kernel,
linux-clk, linux-kernel, Martin Kaiser
The __mx25_clocks_init function always returns 0 and its only
caller does not check the return value. Let's remove it.
Signed-off-by: Martin Kaiser <martin@kaiser.cx>
Reviewed-by: Fabio Estevam <festevam@gmail.com>
Acked-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/clk/imx/clk-imx25.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/clk/imx/clk-imx25.c b/drivers/clk/imx/clk-imx25.c
index bee3da2e21e1..c566be848c2d 100644
--- a/drivers/clk/imx/clk-imx25.c
+++ b/drivers/clk/imx/clk-imx25.c
@@ -74,7 +74,7 @@ enum mx25_clks {
static struct clk *clk[clk_max];
-static int __init __mx25_clocks_init(void __iomem *ccm_base)
+static void __init __mx25_clocks_init(void __iomem *ccm_base)
{
BUG_ON(!ccm_base);
@@ -222,8 +222,6 @@ static int __init __mx25_clocks_init(void __iomem *ccm_base)
imx_register_uart_clocks();
imx_print_silicon_rev("i.MX25", mx25_revision());
-
- return 0;
}
static void __init mx25_clocks_init_dt(struct device_node *np)
--
2.39.2
^ permalink raw reply related [flat|nested] 54+ messages in thread
* [PATCH v6 2/2] clk: imx25: make __mx25_clocks_init return void
@ 2023-07-30 16:39 ` Martin Kaiser
0 siblings, 0 replies; 54+ messages in thread
From: Martin Kaiser @ 2023-07-30 16:39 UTC (permalink / raw)
To: Abel Vesa, Stephen Boyd
Cc: Shawn Guo, Fabio Estevam, Arnd Bergmann, linux-arm-kernel,
linux-clk, linux-kernel, Martin Kaiser
The __mx25_clocks_init function always returns 0 and its only
caller does not check the return value. Let's remove it.
Signed-off-by: Martin Kaiser <martin@kaiser.cx>
Reviewed-by: Fabio Estevam <festevam@gmail.com>
Acked-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/clk/imx/clk-imx25.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/clk/imx/clk-imx25.c b/drivers/clk/imx/clk-imx25.c
index bee3da2e21e1..c566be848c2d 100644
--- a/drivers/clk/imx/clk-imx25.c
+++ b/drivers/clk/imx/clk-imx25.c
@@ -74,7 +74,7 @@ enum mx25_clks {
static struct clk *clk[clk_max];
-static int __init __mx25_clocks_init(void __iomem *ccm_base)
+static void __init __mx25_clocks_init(void __iomem *ccm_base)
{
BUG_ON(!ccm_base);
@@ -222,8 +222,6 @@ static int __init __mx25_clocks_init(void __iomem *ccm_base)
imx_register_uart_clocks();
imx_print_silicon_rev("i.MX25", mx25_revision());
-
- return 0;
}
static void __init mx25_clocks_init_dt(struct device_node *np)
--
2.39.2
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 54+ messages in thread
* Re: [PATCH v6 0/2] ARM: imx25: print silicon revision at startup
2023-07-30 16:39 ` Martin Kaiser
@ 2023-08-01 19:13 ` Stephen Boyd
-1 siblings, 0 replies; 54+ messages in thread
From: Stephen Boyd @ 2023-08-01 19:13 UTC (permalink / raw)
To: Abel Vesa, Martin Kaiser
Cc: Shawn Guo, Fabio Estevam, Arnd Bergmann, linux-arm-kernel,
linux-clk, linux-kernel, Martin Kaiser
Quoting Martin Kaiser (2023-07-30 09:39:26)
> Resurrect the unused function to print the imx25 silicon revision at
> startup.
>
> This patch set is blocking Arnd's work on enabling -Werror=missing-prototypes.
>
> I'd really appreciate a response from the clk maintainers if these (trivial)
> patches are ok.
You need to Cc linux-imx@nxp.com on imx clk patches. I think Abel has
some filter that looks for linux-clk@vger and linux-imx.
Also, please don't send series replies to previous rounds. It buries the
patches deep in my MUA and my scripts don't work well to apply patches
when they're sent like that.
I presume that Abel will pick the patches up? Or do you want to land
them through Arnd's tree? Either way feel free to add my acked-by
Acked-by: Stephen Boyd <sboyd@kernel.org>
^ permalink raw reply [flat|nested] 54+ messages in thread
* Re: [PATCH v6 0/2] ARM: imx25: print silicon revision at startup
@ 2023-08-01 19:13 ` Stephen Boyd
0 siblings, 0 replies; 54+ messages in thread
From: Stephen Boyd @ 2023-08-01 19:13 UTC (permalink / raw)
To: Abel Vesa, Martin Kaiser
Cc: Shawn Guo, Fabio Estevam, Arnd Bergmann, linux-arm-kernel,
linux-clk, linux-kernel, Martin Kaiser
Quoting Martin Kaiser (2023-07-30 09:39:26)
> Resurrect the unused function to print the imx25 silicon revision at
> startup.
>
> This patch set is blocking Arnd's work on enabling -Werror=missing-prototypes.
>
> I'd really appreciate a response from the clk maintainers if these (trivial)
> patches are ok.
You need to Cc linux-imx@nxp.com on imx clk patches. I think Abel has
some filter that looks for linux-clk@vger and linux-imx.
Also, please don't send series replies to previous rounds. It buries the
patches deep in my MUA and my scripts don't work well to apply patches
when they're sent like that.
I presume that Abel will pick the patches up? Or do you want to land
them through Arnd's tree? Either way feel free to add my acked-by
Acked-by: Stephen Boyd <sboyd@kernel.org>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 54+ messages in thread
* Re: [PATCH v6 0/2] ARM: imx25: print silicon revision at startup
2023-08-01 19:13 ` Stephen Boyd
@ 2023-08-02 18:38 ` Martin Kaiser
-1 siblings, 0 replies; 54+ messages in thread
From: Martin Kaiser @ 2023-08-02 18:38 UTC (permalink / raw)
To: Stephen Boyd, Arnd Bergmann
Cc: Abel Vesa, Shawn Guo, Fabio Estevam, linux-arm-kernel, linux-clk,
linux-kernel
Stephen Boyd (sboyd@kernel.org) wrote:
> You need to Cc linux-imx@nxp.com on imx clk patches. I think Abel has
> some filter that looks for linux-clk@vger and linux-imx.
> Also, please don't send series replies to previous rounds. It buries the
> patches deep in my MUA and my scripts don't work well to apply patches
> when they're sent like that.
> I presume that Abel will pick the patches up? Or do you want to land
> them through Arnd's tree? Either way feel free to add my acked-by
> Acked-by: Stephen Boyd <sboyd@kernel.org>
Thanks for responding, Stephen.
Ok, understood. I'll resend with Cc linux-imx@nxp.com and without the
reply to previous versions.
Arnd, are you ok with taking these patches through your tree as
suggested by Stephen?
Thanks,
Martin
^ permalink raw reply [flat|nested] 54+ messages in thread
* Re: [PATCH v6 0/2] ARM: imx25: print silicon revision at startup
@ 2023-08-02 18:38 ` Martin Kaiser
0 siblings, 0 replies; 54+ messages in thread
From: Martin Kaiser @ 2023-08-02 18:38 UTC (permalink / raw)
To: Stephen Boyd, Arnd Bergmann
Cc: Abel Vesa, Shawn Guo, Fabio Estevam, linux-arm-kernel, linux-clk,
linux-kernel
Stephen Boyd (sboyd@kernel.org) wrote:
> You need to Cc linux-imx@nxp.com on imx clk patches. I think Abel has
> some filter that looks for linux-clk@vger and linux-imx.
> Also, please don't send series replies to previous rounds. It buries the
> patches deep in my MUA and my scripts don't work well to apply patches
> when they're sent like that.
> I presume that Abel will pick the patches up? Or do you want to land
> them through Arnd's tree? Either way feel free to add my acked-by
> Acked-by: Stephen Boyd <sboyd@kernel.org>
Thanks for responding, Stephen.
Ok, understood. I'll resend with Cc linux-imx@nxp.com and without the
reply to previous versions.
Arnd, are you ok with taking these patches through your tree as
suggested by Stephen?
Thanks,
Martin
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 54+ messages in thread
* Re: [PATCH v6 0/2] ARM: imx25: print silicon revision at startup
2023-08-02 18:38 ` Martin Kaiser
@ 2023-08-06 3:23 ` Shawn Guo
-1 siblings, 0 replies; 54+ messages in thread
From: Shawn Guo @ 2023-08-06 3:23 UTC (permalink / raw)
To: Martin Kaiser
Cc: Stephen Boyd, Arnd Bergmann, Abel Vesa, Fabio Estevam,
linux-arm-kernel, linux-clk, linux-kernel
On Wed, Aug 02, 2023 at 08:38:49PM +0200, Martin Kaiser wrote:
> Stephen Boyd (sboyd@kernel.org) wrote:
>
> > You need to Cc linux-imx@nxp.com on imx clk patches. I think Abel has
> > some filter that looks for linux-clk@vger and linux-imx.
>
> > Also, please don't send series replies to previous rounds. It buries the
> > patches deep in my MUA and my scripts don't work well to apply patches
> > when they're sent like that.
>
> > I presume that Abel will pick the patches up? Or do you want to land
> > them through Arnd's tree? Either way feel free to add my acked-by
>
> > Acked-by: Stephen Boyd <sboyd@kernel.org>
>
> Thanks for responding, Stephen.
>
> Ok, understood. I'll resend with Cc linux-imx@nxp.com and without the
> reply to previous versions.
>
> Arnd, are you ok with taking these patches through your tree as
> suggested by Stephen?
I prefer to have Abel apply the patches through clk tree rather than
arm-soc tree, unless there is a good reason for them to go via the
latter.
Shawn
^ permalink raw reply [flat|nested] 54+ messages in thread
* Re: [PATCH v6 0/2] ARM: imx25: print silicon revision at startup
@ 2023-08-06 3:23 ` Shawn Guo
0 siblings, 0 replies; 54+ messages in thread
From: Shawn Guo @ 2023-08-06 3:23 UTC (permalink / raw)
To: Martin Kaiser
Cc: Stephen Boyd, Arnd Bergmann, Abel Vesa, Fabio Estevam,
linux-arm-kernel, linux-clk, linux-kernel
On Wed, Aug 02, 2023 at 08:38:49PM +0200, Martin Kaiser wrote:
> Stephen Boyd (sboyd@kernel.org) wrote:
>
> > You need to Cc linux-imx@nxp.com on imx clk patches. I think Abel has
> > some filter that looks for linux-clk@vger and linux-imx.
>
> > Also, please don't send series replies to previous rounds. It buries the
> > patches deep in my MUA and my scripts don't work well to apply patches
> > when they're sent like that.
>
> > I presume that Abel will pick the patches up? Or do you want to land
> > them through Arnd's tree? Either way feel free to add my acked-by
>
> > Acked-by: Stephen Boyd <sboyd@kernel.org>
>
> Thanks for responding, Stephen.
>
> Ok, understood. I'll resend with Cc linux-imx@nxp.com and without the
> reply to previous versions.
>
> Arnd, are you ok with taking these patches through your tree as
> suggested by Stephen?
I prefer to have Abel apply the patches through clk tree rather than
arm-soc tree, unless there is a good reason for them to go via the
latter.
Shawn
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 54+ messages in thread
* Re: [PATCH v6 0/2] ARM: imx25: print silicon revision at startup
2023-08-06 3:23 ` Shawn Guo
@ 2023-08-07 14:38 ` Martin Kaiser
-1 siblings, 0 replies; 54+ messages in thread
From: Martin Kaiser @ 2023-08-07 14:38 UTC (permalink / raw)
To: Shawn Guo
Cc: Stephen Boyd, Arnd Bergmann, Abel Vesa, Fabio Estevam,
linux-arm-kernel, linux-clk, linux-kernel
Shawn Guo (shawnguo@kernel.org) wrote:
> I prefer to have Abel apply the patches through clk tree rather than
> arm-soc tree, unless there is a good reason for them to go via the
> latter.
ok with me. I'd be happy to get this sorted (one way or another) so that
Arnd can enable -Werror=missing-prototypes for 6.6.
Abel, could you pick up these patches?
Thanks,
Martin
^ permalink raw reply [flat|nested] 54+ messages in thread
* Re: [PATCH v6 0/2] ARM: imx25: print silicon revision at startup
@ 2023-08-07 14:38 ` Martin Kaiser
0 siblings, 0 replies; 54+ messages in thread
From: Martin Kaiser @ 2023-08-07 14:38 UTC (permalink / raw)
To: Shawn Guo
Cc: Stephen Boyd, Arnd Bergmann, Abel Vesa, Fabio Estevam,
linux-arm-kernel, linux-clk, linux-kernel
Shawn Guo (shawnguo@kernel.org) wrote:
> I prefer to have Abel apply the patches through clk tree rather than
> arm-soc tree, unless there is a good reason for them to go via the
> latter.
ok with me. I'd be happy to get this sorted (one way or another) so that
Arnd can enable -Werror=missing-prototypes for 6.6.
Abel, could you pick up these patches?
Thanks,
Martin
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 54+ messages in thread
end of thread, other threads:[~2023-08-07 14:39 UTC | newest]
Thread overview: 54+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-02 8:03 [PATCH 0/3] ARM: imx25: print silicon revision, support 1.2 Martin Kaiser
2022-06-02 8:03 ` Martin Kaiser
2022-06-02 8:03 ` [PATCH 1/3] ARM: imx25: support silicon revision 1.2 Martin Kaiser
2022-06-02 8:03 ` Martin Kaiser
2022-06-19 3:40 ` Shawn Guo
2022-06-19 3:40 ` Shawn Guo
2022-06-02 8:03 ` [PATCH 2/3] clk: imx25: print silicon revision during init Martin Kaiser
2022-06-02 8:03 ` Martin Kaiser
2022-06-02 8:03 ` [PATCH 3/3] clk: imx25: make __mx25_clocks_init return void Martin Kaiser
2022-06-02 8:03 ` Martin Kaiser
2022-06-23 7:51 ` [PATCH v2 0/2] ARM: imx25: print silicon revision at startup Martin Kaiser
2022-06-23 7:51 ` Martin Kaiser
2022-06-23 7:51 ` [PATCH v2 1/2] clk: imx25: print silicon revision during init Martin Kaiser
2022-06-23 7:51 ` Martin Kaiser
2022-06-23 7:51 ` [PATCH v2 2/2] clk: imx25: make __mx25_clocks_init return void Martin Kaiser
2022-06-23 7:51 ` Martin Kaiser
2022-07-24 17:47 ` [PATCH v3 0/2] ARM: imx25: print silicon revision at startup Martin Kaiser
2022-07-24 17:47 ` Martin Kaiser
2022-07-24 17:47 ` [PATCH v3 1/2] clk: imx25: print silicon revision during init Martin Kaiser
2022-07-24 17:47 ` Martin Kaiser
2022-07-25 10:53 ` Fabio Estevam
2022-07-25 10:53 ` Fabio Estevam
2022-07-24 17:47 ` [PATCH v3 2/2] clk: imx25: make __mx25_clocks_init return void Martin Kaiser
2022-07-24 17:47 ` Martin Kaiser
2022-07-25 10:54 ` Fabio Estevam
2022-07-25 10:54 ` Fabio Estevam
2022-08-15 19:07 ` [PATCH v4 0/2] ARM: imx25: print silicon revision at startup Martin Kaiser
2022-08-15 19:07 ` Martin Kaiser
2022-08-15 19:07 ` [PATCH v4 1/2] clk: imx25: print silicon revision during init Martin Kaiser
2022-08-15 19:07 ` Martin Kaiser
2022-08-15 19:07 ` [PATCH v4 2/2] clk: imx25: make __mx25_clocks_init return void Martin Kaiser
2022-08-15 19:07 ` Martin Kaiser
2023-05-17 15:39 ` [PATCH v5 0/2] ARM: imx25: print silicon revision at startup Martin Kaiser
2023-05-17 15:39 ` Martin Kaiser
2023-05-17 15:39 ` [PATCH v5 1/2] clk: imx25: print silicon revision during init Martin Kaiser
2023-05-17 15:39 ` Martin Kaiser
2023-05-17 15:39 ` [PATCH v5 2/2] clk: imx25: make __mx25_clocks_init return void Martin Kaiser
2023-05-17 15:39 ` Martin Kaiser
2023-05-17 18:21 ` [PATCH v5 0/2] ARM: imx25: print silicon revision at startup Arnd Bergmann
2023-05-17 18:21 ` Arnd Bergmann
2023-07-30 16:39 ` [PATCH v6 " Martin Kaiser
2023-07-30 16:39 ` Martin Kaiser
2023-07-30 16:39 ` [PATCH v6 1/2] clk: imx25: print silicon revision during init Martin Kaiser
2023-07-30 16:39 ` Martin Kaiser
2023-07-30 16:39 ` [PATCH v6 2/2] clk: imx25: make __mx25_clocks_init return void Martin Kaiser
2023-07-30 16:39 ` Martin Kaiser
2023-08-01 19:13 ` [PATCH v6 0/2] ARM: imx25: print silicon revision at startup Stephen Boyd
2023-08-01 19:13 ` Stephen Boyd
2023-08-02 18:38 ` Martin Kaiser
2023-08-02 18:38 ` Martin Kaiser
2023-08-06 3:23 ` Shawn Guo
2023-08-06 3:23 ` Shawn Guo
2023-08-07 14:38 ` Martin Kaiser
2023-08-07 14:38 ` Martin Kaiser
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.