All of lore.kernel.org
 help / color / mirror / Atom feed
From: Fabio Estevam <festevam@gmail.com>
To: Marcel Ziswiler <marcel@ziswiler.com>, Tom Rini <trini@konsulko.com>
Cc: U-Boot-Denx <u-boot@lists.denx.de>,
	Michael Walle <michael@walle.cc>,
	 "NXP i . MX U-Boot Team" <uboot-imx@nxp.com>,
	Jaehoon Chung <jh80.chung@samsung.com>,
	 Sean Anderson <sean.anderson@seco.com>,
	Marcel Ziswiler <marcel.ziswiler@toradex.com>,
	 Peng Fan <peng.fan@nxp.com>, Stefano Babic <sbabic@denx.de>
Subject: Re: [PATCH v1] mmc: fsl_esdhc_imx: fix watermark level in dma
Date: Wed, 2 Feb 2022 14:08:53 -0300	[thread overview]
Message-ID: <CAOMZO5BULMhr=Hsx=zpkmN=Ym4Q5xG9xAWkdEmFJSHZn2O2FBw@mail.gmail.com> (raw)
In-Reply-To: <CAOMZO5AGmsxsfQT7QrGYaGusPvBjm=gfE2T2O5+4yMNc1_GhJA@mail.gmail.com>

On Mon, Jan 31, 2022 at 10:44 PM Fabio Estevam <festevam@gmail.com> wrote:
>
> Hi Marcel,
>
> On Mon, Jan 31, 2022 at 7:08 PM Marcel Ziswiler <marcel@ziswiler.com> wrote:
> >
> > From: Marcel Ziswiler <marcel.ziswiler@toradex.com>
> >
> > Seems that we need the waterlevel setting not only for PIO mode as
> > without this at least the i.MX 8M Mini won't boot anymore when being
> > written by such a U-Boot. Corruption has also been observed both on
> > the i.MX 6 as well as i.MX 8M Mini when using ums on the eMMC. Fix
> > this by setting the watermark level again regardless of whether in
> > DMA or PIO mode.
> >
> > Fixes: 41c6a22fc296 ("mmc: fsl_esdhc_imx: simplify esdhc_setup_data()")
> > Signed-off-by: Marcel Ziswiler <marcel.ziswiler@toradex.com>
>
> This is probably the failure I saw on imx7 when I tried testing 'ums'.
>
> Reviewed-by: Fabio Estevam <festevam@gmail.com>

This indeed fixes the regression I was seeing with imx7s-warp:

Tested-by: Fabio Estevam <festevam@gmail.com>

  reply	other threads:[~2022-02-02 17:09 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20220131220855epcas1p1a3c5547afa644ae58e98bc7d7ff2baa5@epcas1p1.samsung.com>
2022-01-31 22:08 ` [PATCH v1] mmc: fsl_esdhc_imx: fix watermark level in dma Marcel Ziswiler
2022-02-01  1:44   ` Fabio Estevam
2022-02-02 17:08     ` Fabio Estevam [this message]
2022-02-08  1:32       ` Fabio Estevam
2022-02-08  2:15         ` Jaehoon Chung
2022-02-08 23:37   ` Jaehoon Chung

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAOMZO5BULMhr=Hsx=zpkmN=Ym4Q5xG9xAWkdEmFJSHZn2O2FBw@mail.gmail.com' \
    --to=festevam@gmail.com \
    --cc=jh80.chung@samsung.com \
    --cc=marcel.ziswiler@toradex.com \
    --cc=marcel@ziswiler.com \
    --cc=michael@walle.cc \
    --cc=peng.fan@nxp.com \
    --cc=sbabic@denx.de \
    --cc=sean.anderson@seco.com \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    --cc=uboot-imx@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.