* [PATCH] dt-bindings: mfd: mc13xxx: Add the unit address to sysled
@ 2017-12-01 21:51 Fabio Estevam
[not found] ` <1512165086-25512-1-git-send-email-festevam-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
0 siblings, 1 reply; 6+ messages in thread
From: Fabio Estevam @ 2017-12-01 21:51 UTC (permalink / raw)
To: lee.jones-QSEj5FYQhm4dnm+yROfE0A
Cc: robh+dt-DgEjT+Ai2ygdnm+yROfE0A,
devicetree-u79uwXL29TY76Z2rM5mHXA, Fabio Estevam
From: Fabio Estevam <fabio.estevam-3arQi8VN3Tc@public.gmane.org>
As the 'reg' property is mandatory in the subnodes, improve the
example by adding the unit address to the sysled node.
This prevents the following build warning with W=1:
Node /soc/aips@70000000/spba@70000000/ecspi@70010000/pmic@0/leds/sysled0 has a reg or ranges property, but no unit name
Signed-off-by: Fabio Estevam <fabio.estevam-3arQi8VN3Tc@public.gmane.org>
---
Documentation/devicetree/bindings/mfd/mc13xxx.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/mfd/mc13xxx.txt b/Documentation/devicetree/bindings/mfd/mc13xxx.txt
index ac235fe..8261ea7 100644
--- a/Documentation/devicetree/bindings/mfd/mc13xxx.txt
+++ b/Documentation/devicetree/bindings/mfd/mc13xxx.txt
@@ -130,7 +130,7 @@ ecspi@70010000 { /* ECSPI1 */
#size-cells = <0>;
led-control = <0x000 0x000 0x0e0 0x000>;
- sysled {
+ sysled@3 {
reg = <3>;
label = "system:red:live";
linux,default-trigger = "heartbeat";
--
2.7.4
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] dt-bindings: mfd: mc13xxx: Add the unit address to sysled
[not found] ` <1512165086-25512-1-git-send-email-festevam-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
@ 2017-12-04 9:07 ` Lee Jones
2017-12-04 9:09 ` Fabio Estevam
2017-12-04 21:53 ` Rob Herring
2017-12-15 10:50 ` Lee Jones
2 siblings, 1 reply; 6+ messages in thread
From: Lee Jones @ 2017-12-04 9:07 UTC (permalink / raw)
To: Fabio Estevam
Cc: robh+dt-DgEjT+Ai2ygdnm+yROfE0A,
devicetree-u79uwXL29TY76Z2rM5mHXA, Fabio Estevam
On Fri, 01 Dec 2017, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam-3arQi8VN3Tc@public.gmane.org>
>
> As the 'reg' property is mandatory in the subnodes, improve the
> example by adding the unit address to the sysled node.
>
> This prevents the following build warning with W=1:
>
> Node /soc/aips@70000000/spba@70000000/ecspi@70010000/pmic@0/leds/sysled0 has a reg or ranges property, but no unit name
>
> Signed-off-by: Fabio Estevam <fabio.estevam-3arQi8VN3Tc@public.gmane.org>
> ---
> Documentation/devicetree/bindings/mfd/mc13xxx.txt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Why do I have 2 identical patches in my inbox?
> diff --git a/Documentation/devicetree/bindings/mfd/mc13xxx.txt b/Documentation/devicetree/bindings/mfd/mc13xxx.txt
> index ac235fe..8261ea7 100644
> --- a/Documentation/devicetree/bindings/mfd/mc13xxx.txt
> +++ b/Documentation/devicetree/bindings/mfd/mc13xxx.txt
> @@ -130,7 +130,7 @@ ecspi@70010000 { /* ECSPI1 */
> #size-cells = <0>;
> led-control = <0x000 0x000 0x0e0 0x000>;
>
> - sysled {
> + sysled@3 {
> reg = <3>;
> label = "system:red:live";
> linux,default-trigger = "heartbeat";
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] dt-bindings: mfd: mc13xxx: Add the unit address to sysled
2017-12-04 9:07 ` Lee Jones
@ 2017-12-04 9:09 ` Fabio Estevam
0 siblings, 0 replies; 6+ messages in thread
From: Fabio Estevam @ 2017-12-04 9:09 UTC (permalink / raw)
To: Lee Jones
Cc: robh+dt-DgEjT+Ai2ygdnm+yROfE0A,
devicetree-u79uwXL29TY76Z2rM5mHXA, Fabio Estevam
On Mon, Dec 4, 2017 at 7:07 AM, Lee Jones <lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> wrote:
> On Fri, 01 Dec 2017, Fabio Estevam wrote:
>
>> From: Fabio Estevam <fabio.estevam-3arQi8VN3Tc@public.gmane.org>
>>
>> As the 'reg' property is mandatory in the subnodes, improve the
>> example by adding the unit address to the sysled node.
>>
>> This prevents the following build warning with W=1:
>>
>> Node /soc/aips@70000000/spba@70000000/ecspi@70010000/pmic@0/leds/sysled0 has a reg or ranges property, but no unit name
>>
>> Signed-off-by: Fabio Estevam <fabio.estevam-3arQi8VN3Tc@public.gmane.org>
>> ---
>> Documentation/devicetree/bindings/mfd/mc13xxx.txt | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Why do I have 2 identical patches in my inbox?
There was a typo in the mailing list address in the first one, sorry.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] dt-bindings: mfd: mc13xxx: Add the unit address to sysled
[not found] ` <1512165086-25512-1-git-send-email-festevam-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-12-04 9:07 ` Lee Jones
@ 2017-12-04 21:53 ` Rob Herring
2017-12-04 21:57 ` Fabio Estevam
2017-12-15 10:50 ` Lee Jones
2 siblings, 1 reply; 6+ messages in thread
From: Rob Herring @ 2017-12-04 21:53 UTC (permalink / raw)
To: Fabio Estevam
Cc: lee.jones-QSEj5FYQhm4dnm+yROfE0A,
devicetree-u79uwXL29TY76Z2rM5mHXA, Fabio Estevam
On Fri, Dec 01, 2017 at 07:51:26PM -0200, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam-3arQi8VN3Tc@public.gmane.org>
>
> As the 'reg' property is mandatory in the subnodes, improve the
> example by adding the unit address to the sysled node.
>
> This prevents the following build warning with W=1:
>
> Node /soc/aips@70000000/spba@70000000/ecspi@70010000/pmic@0/leds/sysled0 has a reg or ranges property, but no unit name
Even if the doc file could compile, looks like the name was sysled not
sysled0.
>
> Signed-off-by: Fabio Estevam <fabio.estevam-3arQi8VN3Tc@public.gmane.org>
> ---
> Documentation/devicetree/bindings/mfd/mc13xxx.txt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
In any case,
Reviewed-by: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] dt-bindings: mfd: mc13xxx: Add the unit address to sysled
2017-12-04 21:53 ` Rob Herring
@ 2017-12-04 21:57 ` Fabio Estevam
0 siblings, 0 replies; 6+ messages in thread
From: Fabio Estevam @ 2017-12-04 21:57 UTC (permalink / raw)
To: Rob Herring; +Cc: Lee Jones, devicetree-u79uwXL29TY76Z2rM5mHXA, Fabio Estevam
Hi Rob,
On Mon, Dec 4, 2017 at 7:53 PM, Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> wrote:
> On Fri, Dec 01, 2017 at 07:51:26PM -0200, Fabio Estevam wrote:
>> From: Fabio Estevam <fabio.estevam-3arQi8VN3Tc@public.gmane.org>
>>
>> As the 'reg' property is mandatory in the subnodes, improve the
>> example by adding the unit address to the sysled node.
>>
>> This prevents the following build warning with W=1:
>>
>> Node /soc/aips@70000000/spba@70000000/ecspi@70010000/pmic@0/leds/sysled0 has a reg or ranges property, but no unit name
>
> Even if the doc file could compile, looks like the name was sysled not
> sysled0.
The sysled0 name I got from arch/arm/boot/dts/imx51-zii-rdu1.dts,
where I fixed the real warning:
https://www.spinics.net/lists/arm-kernel/msg620322.html
>>
>> Signed-off-by: Fabio Estevam <fabio.estevam-3arQi8VN3Tc@public.gmane.org>
>> ---
>> Documentation/devicetree/bindings/mfd/mc13xxx.txt | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> In any case,
>
> Reviewed-by: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Thanks
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] dt-bindings: mfd: mc13xxx: Add the unit address to sysled
[not found] ` <1512165086-25512-1-git-send-email-festevam-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-12-04 9:07 ` Lee Jones
2017-12-04 21:53 ` Rob Herring
@ 2017-12-15 10:50 ` Lee Jones
2 siblings, 0 replies; 6+ messages in thread
From: Lee Jones @ 2017-12-15 10:50 UTC (permalink / raw)
To: Fabio Estevam
Cc: robh+dt-DgEjT+Ai2ygdnm+yROfE0A,
devicetree-u79uwXL29TY76Z2rM5mHXA, Fabio Estevam
On Fri, 01 Dec 2017, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam-3arQi8VN3Tc@public.gmane.org>
>
> As the 'reg' property is mandatory in the subnodes, improve the
> example by adding the unit address to the sysled node.
>
> This prevents the following build warning with W=1:
>
> Node /soc/aips@70000000/spba@70000000/ecspi@70010000/pmic@0/leds/sysled0 has a reg or ranges property, but no unit name
>
> Signed-off-by: Fabio Estevam <fabio.estevam-3arQi8VN3Tc@public.gmane.org>
> ---
> Documentation/devicetree/bindings/mfd/mc13xxx.txt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks.
--
Lee Jones
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-12-15 10:50 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-12-01 21:51 [PATCH] dt-bindings: mfd: mc13xxx: Add the unit address to sysled Fabio Estevam
[not found] ` <1512165086-25512-1-git-send-email-festevam-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-12-04 9:07 ` Lee Jones
2017-12-04 9:09 ` Fabio Estevam
2017-12-04 21:53 ` Rob Herring
2017-12-04 21:57 ` Fabio Estevam
2017-12-15 10:50 ` Lee Jones
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.