* [PATCH 1/2] nfc: st21nfca: Check for devm_kzalloc() failure
@ 2018-03-24 13:44 Fabio Estevam
2018-03-24 13:44 ` [PATCH 2/2] nfc: st21nfca: Remove unnecessary devm_kzalloc() cast Fabio Estevam
2018-04-23 11:50 ` [PATCH 1/2] nfc: st21nfca: Check for devm_kzalloc() failure Fabio Estevam
0 siblings, 2 replies; 4+ messages in thread
From: Fabio Estevam @ 2018-03-24 13:44 UTC (permalink / raw)
To: sameo; +Cc: linux-wireless, christophe.ricard, linux-nfc, Fabio Estevam
From: Fabio Estevam <fabio.estevam@nxp.com>
devm_kzalloc() may fail, so we should better check for error and
propagate the error in the case of allocation failure.
This avoids a potential NULL pointer dereference later on.
Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
---
drivers/nfc/st21nfca/se.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/nfc/st21nfca/se.c b/drivers/nfc/st21nfca/se.c
index 4bed9e84..fd967a3 100644
--- a/drivers/nfc/st21nfca/se.c
+++ b/drivers/nfc/st21nfca/se.c
@@ -328,6 +328,8 @@ int st21nfca_connectivity_event_received(struct nfc_hci_dev *hdev, u8 host,
transaction = (struct nfc_evt_transaction *)devm_kzalloc(dev,
skb->len - 2, GFP_KERNEL);
+ if (!transaction)
+ return -ENOMEM;
transaction->aid_len = skb->data[1];
memcpy(transaction->aid, &skb->data[2],
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 2/2] nfc: st21nfca: Remove unnecessary devm_kzalloc() cast
2018-03-24 13:44 [PATCH 1/2] nfc: st21nfca: Check for devm_kzalloc() failure Fabio Estevam
@ 2018-03-24 13:44 ` Fabio Estevam
2018-04-23 11:50 ` [PATCH 1/2] nfc: st21nfca: Check for devm_kzalloc() failure Fabio Estevam
1 sibling, 0 replies; 4+ messages in thread
From: Fabio Estevam @ 2018-03-24 13:44 UTC (permalink / raw)
To: sameo; +Cc: linux-wireless, christophe.ricard, linux-nfc, Fabio Estevam
From: Fabio Estevam <fabio.estevam@nxp.com>
There is no need to use cast for the returned value
from memory allocation functions, so remove the unnecessary cast.
Detected via Coccinelle script:
scripts/coccinelle/api/alloc/alloc_cast.cocci.
Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
---
drivers/nfc/st21nfca/se.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/nfc/st21nfca/se.c b/drivers/nfc/st21nfca/se.c
index fd967a3..5b63549 100644
--- a/drivers/nfc/st21nfca/se.c
+++ b/drivers/nfc/st21nfca/se.c
@@ -326,8 +326,7 @@ int st21nfca_connectivity_event_received(struct nfc_hci_dev *hdev, u8 host,
skb->data[0] != NFC_EVT_TRANSACTION_AID_TAG)
return -EPROTO;
- transaction = (struct nfc_evt_transaction *)devm_kzalloc(dev,
- skb->len - 2, GFP_KERNEL);
+ transaction = devm_kzalloc(dev, skb->len - 2, GFP_KERNEL);
if (!transaction)
return -ENOMEM;
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 1/2] nfc: st21nfca: Check for devm_kzalloc() failure
2018-03-24 13:44 [PATCH 1/2] nfc: st21nfca: Check for devm_kzalloc() failure Fabio Estevam
2018-03-24 13:44 ` [PATCH 2/2] nfc: st21nfca: Remove unnecessary devm_kzalloc() cast Fabio Estevam
@ 2018-04-23 11:50 ` Fabio Estevam
2018-06-04 4:26 ` Samuel Ortiz
1 sibling, 1 reply; 4+ messages in thread
From: Fabio Estevam @ 2018-04-23 11:50 UTC (permalink / raw)
To: Samuel Ortiz; +Cc: linux-wireless, Christophe Ricard, linux-nfc, Fabio Estevam
Hi Samuel,
Maybe this patch series got forgotten?
On Sat, Mar 24, 2018 at 10:44 AM, Fabio Estevam <festevam@gmail.com> wrote:
> From: Fabio Estevam <fabio.estevam@nxp.com>
>
> devm_kzalloc() may fail, so we should better check for error and
> propagate the error in the case of allocation failure.
>
> This avoids a potential NULL pointer dereference later on.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
> ---
> drivers/nfc/st21nfca/se.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/nfc/st21nfca/se.c b/drivers/nfc/st21nfca/se.c
> index 4bed9e84..fd967a3 100644
> --- a/drivers/nfc/st21nfca/se.c
> +++ b/drivers/nfc/st21nfca/se.c
> @@ -328,6 +328,8 @@ int st21nfca_connectivity_event_received(struct nfc_hci_dev *hdev, u8 host,
>
> transaction = (struct nfc_evt_transaction *)devm_kzalloc(dev,
> skb->len - 2, GFP_KERNEL);
> + if (!transaction)
> + return -ENOMEM;
>
> transaction->aid_len = skb->data[1];
> memcpy(transaction->aid, &skb->data[2],
> --
> 2.7.4
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/2] nfc: st21nfca: Check for devm_kzalloc() failure
2018-04-23 11:50 ` [PATCH 1/2] nfc: st21nfca: Check for devm_kzalloc() failure Fabio Estevam
@ 2018-06-04 4:26 ` Samuel Ortiz
0 siblings, 0 replies; 4+ messages in thread
From: Samuel Ortiz @ 2018-06-04 4:26 UTC (permalink / raw)
To: Fabio Estevam; +Cc: linux-wireless, Christophe Ricard, linux-nfc, Fabio Estevam
Hi Fabio,
On Mon, Apr 23, 2018 at 08:50:04AM -0300, Fabio Estevam wrote:
> Hi Samuel,
>
> Maybe this patch series got forgotten?
Both patches applied to nfc-next, sorry for the lag.
Cheers,
Samuel.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-06-04 4:26 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-03-24 13:44 [PATCH 1/2] nfc: st21nfca: Check for devm_kzalloc() failure Fabio Estevam
2018-03-24 13:44 ` [PATCH 2/2] nfc: st21nfca: Remove unnecessary devm_kzalloc() cast Fabio Estevam
2018-04-23 11:50 ` [PATCH 1/2] nfc: st21nfca: Check for devm_kzalloc() failure Fabio Estevam
2018-06-04 4:26 ` Samuel Ortiz
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.