All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] arm64: dts: imx8mq: Add eLCDIF controller
@ 2019-11-23 12:08 ` Guido Günther
  0 siblings, 0 replies; 6+ messages in thread
From: Guido Günther @ 2019-11-23 12:08 UTC (permalink / raw)
  To: Rob Herring, Mark Rutland, Shawn Guo, Sascha Hauer,
	Pengutronix Kernel Team, Fabio Estevam, NXP Linux Team,
	Lucas Stach, Anson Huang, Abel Vesa, Guido Günther,
	Andrey Smirnov, Carlo Caione, Angus Ainslie (Purism),
	devicetree, linux-arm-kernel, linux-kernel

Add a node for the eLCDIF controller, "disabled" by default.

Signed-off-by: Guido Günther <agx@sigxcpu.org>
---
With some minimal support on imx8mq we might as well add it to the DT

 arch/arm64/boot/dts/freescale/imx8mq.dtsi | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)

diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
index 7f9319452b58..00aa63bfd816 100644
--- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
@@ -448,6 +448,23 @@
 				fsl,sdma-ram-script-name = "imx/sdma/sdma-imx7d.bin";
 			};
 
+			lcdif: lcdif@30320000 {
+				compatible = "fsl,imx8mq-lcdif", "fsl,imx28-lcdif";
+				reg = <0x30320000 0x10000>;
+				interrupts = <GIC_SPI 5 IRQ_TYPE_LEVEL_HIGH>;
+				clocks = <&clk IMX8MQ_CLK_LCDIF_PIXEL>;
+				clock-names = "pix";
+				assigned-clocks = <&clk IMX8MQ_VIDEO_PLL1_REF_SEL>,
+						  <&clk IMX8MQ_VIDEO_PLL1_BYPASS>,
+						  <&clk IMX8MQ_CLK_LCDIF_PIXEL>,
+						  <&clk IMX8MQ_VIDEO_PLL1>;
+				assigned-clock-parents = <&clk IMX8MQ_CLK_25M>,
+						  <&clk IMX8MQ_VIDEO_PLL1>,
+						  <&clk IMX8MQ_VIDEO_PLL1_OUT>;
+				assigned-clock-rates = <0>, <0>, <0>, <594000000>;
+				status = "disabled";
+			};
+
 			iomuxc: iomuxc@30330000 {
 				compatible = "fsl,imx8mq-iomuxc";
 				reg = <0x30330000 0x10000>;
-- 
2.23.0


^ permalink raw reply related	[flat|nested] 6+ messages in thread
* [PATCH] arm64: dts: imx8mq: Add eLCDIF controller
@ 2019-11-23 12:08 ` Guido Günther
  0 siblings, 0 replies; 6+ messages in thread
From: Guido Günther @ 2019-11-23 12:08 UTC (permalink / raw)
  To: Rob Herring, Mark Rutland, Shawn Guo, Sascha Hauer,
	Pengutronix Kernel Team, Fabio Estevam, NXP Linux Team,
	Lucas Stach, Anson Huang, Abel Vesa, Guido Günther,
	Andrey Smirnov, Carlo Caione, Angus Ainslie (Purism),
	devicetree, linux-arm-kernel, linux-kernel

Add a node for the eLCDIF controller, "disabled" by default.

Signed-off-by: Guido Günther <agx@sigxcpu.org>
---
With some minimal support on imx8mq we might as well add it to the DT

 arch/arm64/boot/dts/freescale/imx8mq.dtsi | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)

diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
index 7f9319452b58..00aa63bfd816 100644
--- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
@@ -448,6 +448,23 @@
 				fsl,sdma-ram-script-name = "imx/sdma/sdma-imx7d.bin";
 			};
 
+			lcdif: lcdif@30320000 {
+				compatible = "fsl,imx8mq-lcdif", "fsl,imx28-lcdif";
+				reg = <0x30320000 0x10000>;
+				interrupts = <GIC_SPI 5 IRQ_TYPE_LEVEL_HIGH>;
+				clocks = <&clk IMX8MQ_CLK_LCDIF_PIXEL>;
+				clock-names = "pix";
+				assigned-clocks = <&clk IMX8MQ_VIDEO_PLL1_REF_SEL>,
+						  <&clk IMX8MQ_VIDEO_PLL1_BYPASS>,
+						  <&clk IMX8MQ_CLK_LCDIF_PIXEL>,
+						  <&clk IMX8MQ_VIDEO_PLL1>;
+				assigned-clock-parents = <&clk IMX8MQ_CLK_25M>,
+						  <&clk IMX8MQ_VIDEO_PLL1>,
+						  <&clk IMX8MQ_VIDEO_PLL1_OUT>;
+				assigned-clock-rates = <0>, <0>, <0>, <594000000>;
+				status = "disabled";
+			};
+
 			iomuxc: iomuxc@30330000 {
 				compatible = "fsl,imx8mq-iomuxc";
 				reg = <0x30330000 0x10000>;
-- 
2.23.0


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 6+ messages in thread
* Re: [PATCH] arm64: dts: imx8mq: Add eLCDIF controller
  2019-11-23 12:08 ` Guido Günther
@ 2019-11-23 12:25   ` Fabio Estevam
  -1 siblings, 0 replies; 6+ messages in thread
From: Fabio Estevam @ 2019-11-23 12:25 UTC (permalink / raw)
  To: Guido Günther
  Cc: Rob Herring, Mark Rutland, Shawn Guo, Sascha Hauer,
	Pengutronix Kernel Team, NXP Linux Team, Lucas Stach,
	Anson Huang, Abel Vesa, Andrey Smirnov, Carlo Caione,
	Angus Ainslie (Purism),
	open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
	moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
	linux-kernel

Hi Guido,

On Sat, Nov 23, 2019 at 9:09 AM Guido Günther <agx@sigxcpu.org> wrote:

> diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> index 7f9319452b58..00aa63bfd816 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> @@ -448,6 +448,23 @@
>                                 fsl,sdma-ram-script-name = "imx/sdma/sdma-imx7d.bin";
>                         };
>
> +                       lcdif: lcdif@30320000 {
> +                               compatible = "fsl,imx8mq-lcdif", "fsl,imx28-lcdif";

fsl,imx8mq-lcdif should also be documented.

Reviewed-by: Fabio Estevam <festevam@gmail.com>

Thanks

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] arm64: dts: imx8mq: Add eLCDIF controller
@ 2019-11-23 12:25   ` Fabio Estevam
  0 siblings, 0 replies; 6+ messages in thread
From: Fabio Estevam @ 2019-11-23 12:25 UTC (permalink / raw)
  To: Guido Günther
  Cc: Mark Rutland,
	open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
	Abel Vesa, Anson Huang, Carlo Caione, Andrey Smirnov,
	Sascha Hauer, Angus Ainslie (Purism),
	linux-kernel, Rob Herring, NXP Linux Team,
	Pengutronix Kernel Team, Shawn Guo,
	moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
	Lucas Stach

Hi Guido,

On Sat, Nov 23, 2019 at 9:09 AM Guido Günther <agx@sigxcpu.org> wrote:

> diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> index 7f9319452b58..00aa63bfd816 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> @@ -448,6 +448,23 @@
>                                 fsl,sdma-ram-script-name = "imx/sdma/sdma-imx7d.bin";
>                         };
>
> +                       lcdif: lcdif@30320000 {
> +                               compatible = "fsl,imx8mq-lcdif", "fsl,imx28-lcdif";

fsl,imx8mq-lcdif should also be documented.

Reviewed-by: Fabio Estevam <festevam@gmail.com>

Thanks

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] arm64: dts: imx8mq: Add eLCDIF controller
  2019-11-23 12:08 ` Guido Günther
@ 2019-11-23 17:09   ` Fabio Estevam
  -1 siblings, 0 replies; 6+ messages in thread
From: Fabio Estevam @ 2019-11-23 17:09 UTC (permalink / raw)
  To: Guido Günther
  Cc: Rob Herring, Mark Rutland, Shawn Guo, Sascha Hauer,
	Pengutronix Kernel Team, NXP Linux Team, Lucas Stach,
	Anson Huang, Abel Vesa, Andrey Smirnov, Carlo Caione,
	Angus Ainslie (Purism),
	open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
	moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
	linux-kernel

On Sat, Nov 23, 2019 at 9:09 AM Guido Günther <agx@sigxcpu.org> wrote:
>
> Add a node for the eLCDIF controller, "disabled" by default.
>
> Signed-off-by: Guido Günther <agx@sigxcpu.org>
> ---
> With some minimal support on imx8mq we might as well add it to the DT
>
>  arch/arm64/boot/dts/freescale/imx8mq.dtsi | 17 +++++++++++++++++
>  1 file changed, 17 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> index 7f9319452b58..00aa63bfd816 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> @@ -448,6 +448,23 @@
>                                 fsl,sdma-ram-script-name = "imx/sdma/sdma-imx7d.bin";
>                         };
>
> +                       lcdif: lcdif@30320000 {

Forgot to say that generic node names are preferred, so maybe:

lcdif: lcd-controller@30320000 {

instead?

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] arm64: dts: imx8mq: Add eLCDIF controller
@ 2019-11-23 17:09   ` Fabio Estevam
  0 siblings, 0 replies; 6+ messages in thread
From: Fabio Estevam @ 2019-11-23 17:09 UTC (permalink / raw)
  To: Guido Günther
  Cc: Mark Rutland,
	open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
	Abel Vesa, Anson Huang, Carlo Caione, Andrey Smirnov,
	Sascha Hauer, Angus Ainslie (Purism),
	linux-kernel, Rob Herring, NXP Linux Team,
	Pengutronix Kernel Team, Shawn Guo,
	moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
	Lucas Stach

On Sat, Nov 23, 2019 at 9:09 AM Guido Günther <agx@sigxcpu.org> wrote:
>
> Add a node for the eLCDIF controller, "disabled" by default.
>
> Signed-off-by: Guido Günther <agx@sigxcpu.org>
> ---
> With some minimal support on imx8mq we might as well add it to the DT
>
>  arch/arm64/boot/dts/freescale/imx8mq.dtsi | 17 +++++++++++++++++
>  1 file changed, 17 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> index 7f9319452b58..00aa63bfd816 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> @@ -448,6 +448,23 @@
>                                 fsl,sdma-ram-script-name = "imx/sdma/sdma-imx7d.bin";
>                         };
>
> +                       lcdif: lcdif@30320000 {

Forgot to say that generic node names are preferred, so maybe:

lcdif: lcd-controller@30320000 {

instead?

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-11-23 17:09 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-23 12:08 [PATCH] arm64: dts: imx8mq: Add eLCDIF controller Guido Günther
2019-11-23 12:08 ` Guido Günther
2019-11-23 12:25 ` Fabio Estevam
2019-11-23 12:25   ` Fabio Estevam
2019-11-23 17:09 ` Fabio Estevam
2019-11-23 17:09   ` Fabio Estevam

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.