* [patch 1/1] imx53-qsb: enable usb power
@ 2013-06-20 21:29 Arnaud Patard (Rtp)
2013-06-23 18:59 ` Sascha Hauer
` (2 more replies)
0 siblings, 3 replies; 8+ messages in thread
From: Arnaud Patard (Rtp) @ 2013-06-20 21:29 UTC (permalink / raw)
To: linux-arm-kernel
An embedded and charset-unspecified text was scrubbed...
Name: imx53-qsb-usb-power.patch
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20130620/749dd8d2/attachment.ksh>
^ permalink raw reply [flat|nested] 8+ messages in thread
* [patch 1/1] imx53-qsb: enable usb power
2013-06-20 21:29 [patch 1/1] imx53-qsb: enable usb power Arnaud Patard (Rtp)
@ 2013-06-23 18:59 ` Sascha Hauer
2013-06-24 7:29 ` Arnaud Patard (Rtp)
2013-06-24 23:52 ` Fabio Estevam
2013-07-25 12:42 ` Fabio Estevam
2 siblings, 1 reply; 8+ messages in thread
From: Sascha Hauer @ 2013-06-23 18:59 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, Jun 20, 2013 at 11:29:30PM +0200, Arnaud Patard wrote:
> Enable usb power pin by using a fixed regulator. With this and the usb clock
> patch is making usb working on my loco.
>
> Signed-off-by: Arnaud Patard <arnaud.patard@rtp-net.org>
> Index: linux-next/arch/arm/boot/dts/imx53-qsb.dts
> ===================================================================
> --- linux-next.orig/arch/arm/boot/dts/imx53-qsb.dts 2013-06-20 23:25:46.049428530 +0200
> +++ linux-next/arch/arm/boot/dts/imx53-qsb.dts 2013-06-20 23:26:34.293425920 +0200
> @@ -93,6 +93,15 @@
> regulator-max-microvolt = <3200000>;
> regulator-always-on;
> };
> +
> + reg_usbpwr: usbpwr {
> + compatible = "regulator-fixed";
> + regulator-name = "usbpwr";
> + regulator-min-microvolt = <5000000>;
> + regulator-max-microvolt = <5000000>;
> + gpio = <&gpio7 8 0>;
> + regulator-always-on;
> + };
Shouldn't this be provided to the chipidea driver as vbus?
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
^ permalink raw reply [flat|nested] 8+ messages in thread
* [patch 1/1] imx53-qsb: enable usb power
2013-06-23 18:59 ` Sascha Hauer
@ 2013-06-24 7:29 ` Arnaud Patard (Rtp)
0 siblings, 0 replies; 8+ messages in thread
From: Arnaud Patard (Rtp) @ 2013-06-24 7:29 UTC (permalink / raw)
To: linux-arm-kernel
Sascha Hauer <s.hauer@pengutronix.de> writes:
> On Thu, Jun 20, 2013 at 11:29:30PM +0200, Arnaud Patard wrote:
>> Enable usb power pin by using a fixed regulator. With this and the usb clock
>> patch is making usb working on my loco.
>>
>> Signed-off-by: Arnaud Patard <arnaud.patard@rtp-net.org>
>> Index: linux-next/arch/arm/boot/dts/imx53-qsb.dts
>> ===================================================================
>> --- linux-next.orig/arch/arm/boot/dts/imx53-qsb.dts 2013-06-20 23:25:46.049428530 +0200
>> +++ linux-next/arch/arm/boot/dts/imx53-qsb.dts 2013-06-20 23:26:34.293425920 +0200
>> @@ -93,6 +93,15 @@
>> regulator-max-microvolt = <3200000>;
>> regulator-always-on;
>> };
>> +
>> + reg_usbpwr: usbpwr {
>> + compatible = "regulator-fixed";
>> + regulator-name = "usbpwr";
>> + regulator-min-microvolt = <5000000>;
>> + regulator-max-microvolt = <5000000>;
>> + gpio = <&gpio7 8 0>;
>> + regulator-always-on;
>> + };
>
> Shouldn't this be provided to the chipidea driver as vbus?
I'm not sure about that. This gpio is controlling the usb power for the
2 usb ports while the vbus is more a port-basis thing.
Arnaud
^ permalink raw reply [flat|nested] 8+ messages in thread
* [patch 1/1] imx53-qsb: enable usb power
2013-06-20 21:29 [patch 1/1] imx53-qsb: enable usb power Arnaud Patard (Rtp)
2013-06-23 18:59 ` Sascha Hauer
@ 2013-06-24 23:52 ` Fabio Estevam
2013-06-25 1:40 ` Fabio Estevam
2013-07-25 12:42 ` Fabio Estevam
2 siblings, 1 reply; 8+ messages in thread
From: Fabio Estevam @ 2013-06-24 23:52 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, Jun 20, 2013 at 6:29 PM, Arnaud Patard
<arnaud.patard@rtp-net.org> wrote:
> Enable usb power pin by using a fixed regulator. With this and the usb clock
> patch is making usb working on my loco.
>
> Signed-off-by: Arnaud Patard <arnaud.patard@rtp-net.org>
Could you please test this against linux-next?
It does not work for me:
usbcore: registered new interface driver usb-storage
platform 53f80000.usb: Driver imx_usb requests probe deferral
platform 53f80200.usb: Driver imx_usb requests probe deferral
^ permalink raw reply [flat|nested] 8+ messages in thread
* [patch 1/1] imx53-qsb: enable usb power
2013-06-24 23:52 ` Fabio Estevam
@ 2013-06-25 1:40 ` Fabio Estevam
2013-06-25 17:08 ` Arnaud Patard (Rtp)
0 siblings, 1 reply; 8+ messages in thread
From: Fabio Estevam @ 2013-06-25 1:40 UTC (permalink / raw)
To: linux-arm-kernel
On Mon, Jun 24, 2013 at 8:52 PM, Fabio Estevam <festevam@gmail.com> wrote:
> On Thu, Jun 20, 2013 at 6:29 PM, Arnaud Patard
> <arnaud.patard@rtp-net.org> wrote:
>> Enable usb power pin by using a fixed regulator. With this and the usb clock
>> patch is making usb working on my loco.
>>
>> Signed-off-by: Arnaud Patard <arnaud.patard@rtp-net.org>
>
> Could you please test this against linux-next?
>
> It does not work for me:
>
> usbcore: registered new interface driver usb-storage
> platform 53f80000.usb: Driver imx_usb requests probe deferral
> platform 53f80200.usb: Driver imx_usb requests probe deferral
Ok, got it working now, but had to do two changes:
- Add a vbus-supply node for usbh1 as suggested by Sascha
- Select CONFIG_NOP_USB_XCEIV. Will send a patch to select it by default.
^ permalink raw reply [flat|nested] 8+ messages in thread
* [patch 1/1] imx53-qsb: enable usb power
2013-06-25 1:40 ` Fabio Estevam
@ 2013-06-25 17:08 ` Arnaud Patard (Rtp)
2013-06-25 17:12 ` Fabio Estevam
0 siblings, 1 reply; 8+ messages in thread
From: Arnaud Patard (Rtp) @ 2013-06-25 17:08 UTC (permalink / raw)
To: linux-arm-kernel
Fabio Estevam <festevam@gmail.com> writes:
> On Mon, Jun 24, 2013 at 8:52 PM, Fabio Estevam <festevam@gmail.com> wrote:
>> On Thu, Jun 20, 2013 at 6:29 PM, Arnaud Patard
>> <arnaud.patard@rtp-net.org> wrote:
>>> Enable usb power pin by using a fixed regulator. With this and the usb clock
>>> patch is making usb working on my loco.
>>>
>>> Signed-off-by: Arnaud Patard <arnaud.patard@rtp-net.org>
>>
>> Could you please test this against linux-next?
>>
>> It does not work for me:
>>
>> usbcore: registered new interface driver usb-storage
>> platform 53f80000.usb: Driver imx_usb requests probe deferral
>> platform 53f80200.usb: Driver imx_usb requests probe deferral
>
> Ok, got it working now, but had to do two changes:
>
> - Add a vbus-supply node for usbh1 as suggested by Sascha
How do you want to proceed ? send a patch on top of mine or send a new
patch containing my patch and this change ? ( I guess that the later
would be easier)
btw, now that it seems that some more stuff has been merged in chipidea
are in next, what about enabling the second port ?
Arnaud
^ permalink raw reply [flat|nested] 8+ messages in thread
* [patch 1/1] imx53-qsb: enable usb power
2013-06-25 17:08 ` Arnaud Patard (Rtp)
@ 2013-06-25 17:12 ` Fabio Estevam
0 siblings, 0 replies; 8+ messages in thread
From: Fabio Estevam @ 2013-06-25 17:12 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, Jun 25, 2013 at 2:08 PM, Arnaud Patard
<arnaud.patard@rtp-net.org> wrote:
> How do you want to proceed ? send a patch on top of mine or send a new
> patch containing my patch and this change ? ( I guess that the later
> would be easier)
It would be nice if you could send a v2 of your patch adding the
vbus_supply node.
>
> btw, now that it seems that some more stuff has been merged in chipidea
> are in next, what about enabling the second port ?
That would be nice as well, please send a patch for it if you have a chance.
^ permalink raw reply [flat|nested] 8+ messages in thread
* [patch 1/1] imx53-qsb: enable usb power
2013-06-20 21:29 [patch 1/1] imx53-qsb: enable usb power Arnaud Patard (Rtp)
2013-06-23 18:59 ` Sascha Hauer
2013-06-24 23:52 ` Fabio Estevam
@ 2013-07-25 12:42 ` Fabio Estevam
2 siblings, 0 replies; 8+ messages in thread
From: Fabio Estevam @ 2013-07-25 12:42 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, Jun 20, 2013 at 6:29 PM, Arnaud Patard
<arnaud.patard@rtp-net.org> wrote:
> Enable usb power pin by using a fixed regulator. With this and the usb clock
> patch is making usb working on my loco.
Which "usb clock patch" are you referring to?
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2013-07-25 12:42 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-06-20 21:29 [patch 1/1] imx53-qsb: enable usb power Arnaud Patard (Rtp)
2013-06-23 18:59 ` Sascha Hauer
2013-06-24 7:29 ` Arnaud Patard (Rtp)
2013-06-24 23:52 ` Fabio Estevam
2013-06-25 1:40 ` Fabio Estevam
2013-06-25 17:08 ` Arnaud Patard (Rtp)
2013-06-25 17:12 ` Fabio Estevam
2013-07-25 12:42 ` Fabio Estevam
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.