* [PATCH 2/3] ASoC: fsl_ssi: mark some registers precious
@ 2015-12-20 20:31 ` Maciej S. Szmigiero
0 siblings, 0 replies; 5+ messages in thread
From: Maciej S. Szmigiero @ 2015-12-20 20:31 UTC (permalink / raw)
To: alsa-devel
Cc: Xiubo Li, linux-kernel, Liam Girdwood, Timur Tabi, Nicolin Chen,
Mark Brown, Fabio Estevam, linuxppc-dev
Mark some registers precious since their
reads have side effects (like clearing flags).
Signed-off-by: Maciej S. Szmigiero <mail@maciej.szmigiero.name>
---
sound/soc/fsl/fsl_ssi.c | 16 ++++++++++++++++
1 file changed, 16 insertions(+)
diff --git a/sound/soc/fsl/fsl_ssi.c b/sound/soc/fsl/fsl_ssi.c
index cc22354d7758..40dfd8a36484 100644
--- a/sound/soc/fsl/fsl_ssi.c
+++ b/sound/soc/fsl/fsl_ssi.c
@@ -157,6 +157,21 @@ static bool fsl_ssi_volatile_reg(struct device *dev, unsigned int reg)
}
}
+static bool fsl_ssi_precious_reg(struct device *dev, unsigned int reg)
+{
+ switch (reg) {
+ case CCSR_SSI_SRX0:
+ case CCSR_SSI_SRX1:
+ case CCSR_SSI_SISR:
+ case CCSR_SSI_SACADD:
+ case CCSR_SSI_SACDAT:
+ case CCSR_SSI_SATAG:
+ return true;
+ default:
+ return false;
+ }
+}
+
static bool fsl_ssi_writeable_reg(struct device *dev, unsigned int reg)
{
switch (reg) {
@@ -179,6 +194,7 @@ static const struct regmap_config fsl_ssi_regconfig = {
.num_reg_defaults = ARRAY_SIZE(fsl_ssi_reg_defaults),
.readable_reg = fsl_ssi_readable_reg,
.volatile_reg = fsl_ssi_volatile_reg,
+ .precious_reg = fsl_ssi_precious_reg,
.writeable_reg = fsl_ssi_writeable_reg,
.cache_type = REGCACHE_RBTREE,
};
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH 2/3] ASoC: fsl_ssi: mark some registers precious
2015-12-20 20:31 ` Maciej S. Szmigiero
(?)
@ 2015-12-23 13:12 ` Fabio Estevam
-1 siblings, 0 replies; 5+ messages in thread
From: Fabio Estevam @ 2015-12-23 13:12 UTC (permalink / raw)
To: Maciej S. Szmigiero
Cc: alsa-devel, Timur Tabi, Nicolin Chen, Xiubo Li, Liam Girdwood,
Mark Brown, linuxppc-dev, linux-kernel
On Sun, Dec 20, 2015 at 6:31 PM, Maciej S. Szmigiero
<mail@maciej.szmigiero.name> wrote:
> Mark some registers precious since their
> reads have side effects (like clearing flags).
>
> Signed-off-by: Maciej S. Szmigiero <mail@maciej.szmigiero.name>
Reviewed-by: Fabio Estevam <fabio.estevam@nxp.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Applied "ASoC: fsl_ssi: mark some registers precious" to the asoc tree
2015-12-20 20:31 ` Maciej S. Szmigiero
(?)
(?)
@ 2016-01-10 12:22 ` Mark Brown
-1 siblings, 0 replies; 5+ messages in thread
From: Mark Brown @ 2016-01-10 12:22 UTC (permalink / raw)
To: Maciej S. Szmigiero, Mark Brown; +Cc: alsa-devel
The patch
ASoC: fsl_ssi: mark some registers precious
has been applied to the asoc tree at
git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
>From f51e3d5372b4bf80006cdc1694a7656aba7c9b58 Mon Sep 17 00:00:00 2001
From: "Maciej S. Szmigiero" <mail@maciej.szmigiero.name>
Date: Sun, 20 Dec 2015 21:31:48 +0100
Subject: [PATCH] ASoC: fsl_ssi: mark some registers precious
Mark some registers precious since their
reads have side effects (like clearing flags).
Signed-off-by: Maciej S. Szmigiero <mail@maciej.szmigiero.name>
Reviewed-by: Fabio Estevam <fabio.estevam@nxp.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
---
sound/soc/fsl/fsl_ssi.c | 16 ++++++++++++++++
1 file changed, 16 insertions(+)
diff --git a/sound/soc/fsl/fsl_ssi.c b/sound/soc/fsl/fsl_ssi.c
index cc22354d7758..40dfd8a36484 100644
--- a/sound/soc/fsl/fsl_ssi.c
+++ b/sound/soc/fsl/fsl_ssi.c
@@ -157,6 +157,21 @@ static bool fsl_ssi_volatile_reg(struct device *dev, unsigned int reg)
}
}
+static bool fsl_ssi_precious_reg(struct device *dev, unsigned int reg)
+{
+ switch (reg) {
+ case CCSR_SSI_SRX0:
+ case CCSR_SSI_SRX1:
+ case CCSR_SSI_SISR:
+ case CCSR_SSI_SACADD:
+ case CCSR_SSI_SACDAT:
+ case CCSR_SSI_SATAG:
+ return true;
+ default:
+ return false;
+ }
+}
+
static bool fsl_ssi_writeable_reg(struct device *dev, unsigned int reg)
{
switch (reg) {
@@ -179,6 +194,7 @@ static const struct regmap_config fsl_ssi_regconfig = {
.num_reg_defaults = ARRAY_SIZE(fsl_ssi_reg_defaults),
.readable_reg = fsl_ssi_readable_reg,
.volatile_reg = fsl_ssi_volatile_reg,
+ .precious_reg = fsl_ssi_precious_reg,
.writeable_reg = fsl_ssi_writeable_reg,
.cache_type = REGCACHE_RBTREE,
};
--
2.7.0.rc3
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH 2/3] ASoC: fsl_ssi: mark some registers precious
2015-12-20 20:31 ` Maciej S. Szmigiero
` (2 preceding siblings ...)
(?)
@ 2016-01-10 21:35 ` Timur Tabi
-1 siblings, 0 replies; 5+ messages in thread
From: Timur Tabi @ 2016-01-10 21:35 UTC (permalink / raw)
To: Maciej S. Szmigiero, alsa-devel
Cc: Nicolin Chen, Xiubo Li, Liam Girdwood, Mark Brown, linuxppc-dev,
linux-kernel, Fabio Estevam
Maciej S. Szmigiero wrote:
> Mark some registers precious since their
> reads have side effects (like clearing flags).
>
> Signed-off-by: Maciej S. Szmigiero<mail@maciej.szmigiero.name>
Acked-by: Timur Tabi <timur@tabi.org>
^ permalink raw reply [flat|nested] 5+ messages in thread