* [U-Boot] [PATCH] imx8mq_evk_defconfig: Move file system options to Kconfig
@ 2018-12-27 19:14 Fabio Estevam
2018-12-29 4:58 ` Peng Fan
0 siblings, 1 reply; 4+ messages in thread
From: Fabio Estevam @ 2018-12-27 19:14 UTC (permalink / raw)
To: u-boot
Chris Spencer reports that when enabling ext4 read support without
also enabling write support the following error is seen:
fs/fs.c:198:12: error: 'ext4_write_file' undeclared here (not in a
function); did you mean 'ext4_read_file'?
.write = ext4_write_file,
^~~~~~~~~~~~~~~
Fix this problem by moving these options to Kconfig.
Reported-by: Chris Spencer <spencercw@gmail.com>
Signed-off-by: Fabio Estevam <festevam@gmail.com>
---
configs/imx8mq_evk_defconfig | 5 +++++
include/configs/imx8mq_evk.h | 6 ------
2 files changed, 5 insertions(+), 6 deletions(-)
diff --git a/configs/imx8mq_evk_defconfig b/configs/imx8mq_evk_defconfig
index f216d46a8f..b473fcd61b 100644
--- a/configs/imx8mq_evk_defconfig
+++ b/configs/imx8mq_evk_defconfig
@@ -15,6 +15,11 @@ CONFIG_SPL_LOAD_FIT=y
CONFIG_SPL=y
CONFIG_SPL_BOARD_INIT=y
CONFIG_HUSH_PARSER=y
+CONFIG_DOS_PARTITION=y
+CONFIG_CMD_EXT2=y
+CONFIG_CMD_EXT4=y
+CONFIG_CMD_EXT4_WRITE=y
+CONFIG_CMD_FAT=
CONFIG_CMD_GPIO=y
CONFIG_CMD_I2C=y
CONFIG_CMD_CACHE=y
diff --git a/include/configs/imx8mq_evk.h b/include/configs/imx8mq_evk.h
index 35f81152f2..f0430224cb 100644
--- a/include/configs/imx8mq_evk.h
+++ b/include/configs/imx8mq_evk.h
@@ -226,12 +226,6 @@
#define CONFIG_SYS_FSL_USDHC_NUM 2
#define CONFIG_SYS_FSL_ESDHC_ADDR 0
-#define CONFIG_DOS_PARTITION
-#define CONFIG_CMD_EXT2
-#define CONFIG_CMD_EXT4
-#define CONFIG_CMD_EXT4_WRITE
-#define CONFIG_CMD_FAT
-
#define CONFIG_SUPPORT_EMMC_BOOT /* eMMC specific */
#define CONFIG_SYS_MMC_IMG_LOAD_PART 1
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [U-Boot] [PATCH] imx8mq_evk_defconfig: Move file system options to Kconfig
2018-12-27 19:14 [U-Boot] [PATCH] imx8mq_evk_defconfig: Move file system options to Kconfig Fabio Estevam
@ 2018-12-29 4:58 ` Peng Fan
2018-12-29 5:59 ` Offouga Joris
0 siblings, 1 reply; 4+ messages in thread
From: Peng Fan @ 2018-12-29 4:58 UTC (permalink / raw)
To: u-boot
> -----Original Message-----
> From: Fabio Estevam [mailto:festevam at gmail.com]
> Sent: 2018年12月28日 3:14
> To: sbabic at denx.de
> Cc: dl-uboot-imx <uboot-imx@nxp.com>; u-boot at lists.denx.de;
> spencercw at gmail.com; Fabio Estevam <festevam@gmail.com>
> Subject: [PATCH] imx8mq_evk_defconfig: Move file system options to Kconfig
>
> Chris Spencer reports that when enabling ext4 read support without also
> enabling write support the following error is seen:
>
> fs/fs.c:198:12: error: 'ext4_write_file' undeclared here (not in a function); did
> you mean 'ext4_read_file'?
> .write = ext4_write_file,
> ^~~~~~~~~~~~~~~
> Fix this problem by moving these options to Kconfig.
>
> Reported-by: Chris Spencer <spencercw@gmail.com>
> Signed-off-by: Fabio Estevam <festevam@gmail.com>
Acked-by: Peng Fan <peng.fan@nxp.com>
> ---
> configs/imx8mq_evk_defconfig | 5 +++++
> include/configs/imx8mq_evk.h | 6 ------
> 2 files changed, 5 insertions(+), 6 deletions(-)
>
> diff --git a/configs/imx8mq_evk_defconfig b/configs/imx8mq_evk_defconfig
> index f216d46a8f..b473fcd61b 100644
> --- a/configs/imx8mq_evk_defconfig
> +++ b/configs/imx8mq_evk_defconfig
> @@ -15,6 +15,11 @@ CONFIG_SPL_LOAD_FIT=y CONFIG_SPL=y
> CONFIG_SPL_BOARD_INIT=y CONFIG_HUSH_PARSER=y
> +CONFIG_DOS_PARTITION=y
> +CONFIG_CMD_EXT2=y
> +CONFIG_CMD_EXT4=y
> +CONFIG_CMD_EXT4_WRITE=y
> +CONFIG_CMD_FAT=
> CONFIG_CMD_GPIO=y
> CONFIG_CMD_I2C=y
> CONFIG_CMD_CACHE=y
> diff --git a/include/configs/imx8mq_evk.h b/include/configs/imx8mq_evk.h
> index 35f81152f2..f0430224cb 100644
> --- a/include/configs/imx8mq_evk.h
> +++ b/include/configs/imx8mq_evk.h
> @@ -226,12 +226,6 @@
> #define CONFIG_SYS_FSL_USDHC_NUM 2
> #define CONFIG_SYS_FSL_ESDHC_ADDR 0
>
> -#define CONFIG_DOS_PARTITION
> -#define CONFIG_CMD_EXT2
> -#define CONFIG_CMD_EXT4
> -#define CONFIG_CMD_EXT4_WRITE
> -#define CONFIG_CMD_FAT
> -
> #define CONFIG_SUPPORT_EMMC_BOOT /* eMMC specific */
> #define CONFIG_SYS_MMC_IMG_LOAD_PART 1
>
> --
> 2.17.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* [U-Boot] [PATCH] imx8mq_evk_defconfig: Move file system options to Kconfig
2018-12-29 4:58 ` Peng Fan
@ 2018-12-29 5:59 ` Offouga Joris
2018-12-29 12:03 ` Fabio Estevam
0 siblings, 1 reply; 4+ messages in thread
From: Offouga Joris @ 2018-12-29 5:59 UTC (permalink / raw)
To: u-boot
Hi Fabio,
Joris Offouga
Le 29 déc. 2018 à 05:58, Peng Fan <peng.fan@nxp.com> a écrit :
>> -----Original Message-----
>> From: Fabio Estevam [mailto:festevam at gmail.com]
>> Sent: 2018年12月28日 3:14
>> To: sbabic at denx.de
>> Cc: dl-uboot-imx <uboot-imx@nxp.com>; u-boot at lists.denx.de;
>> spencercw at gmail.com; Fabio Estevam <festevam@gmail.com>
>> Subject: [PATCH] imx8mq_evk_defconfig: Move file system options to Kconfig
>>
>> Chris Spencer reports that when enabling ext4 read support without also
>> enabling write support the following error is seen:
>>
>> fs/fs.c:198:12: error: 'ext4_write_file' undeclared here (not in a function); did
>> you mean 'ext4_read_file'?
>> .write = ext4_write_file,
>> ^~~~~~~~~~~~~~~
>> Fix this problem by moving these options to Kconfig.
>>
>> Reported-by: Chris Spencer <spencercw@gmail.com>
>> Signed-off-by: Fabio Estevam <festevam@gmail.com>
>
> Acked-by: Peng Fan <peng.fan@nxp.com>
>
>> ---
>> configs/imx8mq_evk_defconfig | 5 +++++
>> include/configs/imx8mq_evk.h | 6 ------
>> 2 files changed, 5 insertions(+), 6 deletions(-)
>>
>> diff --git a/configs/imx8mq_evk_defconfig b/configs/imx8mq_evk_defconfig
>> index f216d46a8f..b473fcd61b 100644
>> --- a/configs/imx8mq_evk_defconfig
>> +++ b/configs/imx8mq_evk_defconfig
>> @@ -15,6 +15,11 @@ CONFIG_SPL_LOAD_FIT=y CONFIG_SPL=y
>> CONFIG_SPL_BOARD_INIT=y CONFIG_HUSH_PARSER=y
>> +CONFIG_DOS_PARTITION=y
>> +CONFIG_CMD_EXT2=y
>> +CONFIG_CMD_EXT4=y
>> +CONFIG_CMD_EXT4_WRITE=y
>> +CONFIG_CMD_FAT=
You forgot "y" to this line, correct this in CONFIG_CMD_FAT=y
>> CONFIG_CMD_GPIO=y
>> CONFIG_CMD_I2C=y
>> CONFIG_CMD_CACHE=y
>> diff --git a/include/configs/imx8mq_evk.h b/include/configs/imx8mq_evk.h
>> index 35f81152f2..f0430224cb 100644
>> --- a/include/configs/imx8mq_evk.h
>> +++ b/include/configs/imx8mq_evk.h
>> @@ -226,12 +226,6 @@
>> #define CONFIG_SYS_FSL_USDHC_NUM 2
>> #define CONFIG_SYS_FSL_ESDHC_ADDR 0
>>
>> -#define CONFIG_DOS_PARTITION
>> -#define CONFIG_CMD_EXT2
>> -#define CONFIG_CMD_EXT4
>> -#define CONFIG_CMD_EXT4_WRITE
>> -#define CONFIG_CMD_FAT
>> -
>> #define CONFIG_SUPPORT_EMMC_BOOT /* eMMC specific */
>> #define CONFIG_SYS_MMC_IMG_LOAD_PART 1
>>
>> --
>> 2.17.1
>
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> https://lists.denx.de/listinfo/u-boot
^ permalink raw reply [flat|nested] 4+ messages in thread
* [U-Boot] [PATCH] imx8mq_evk_defconfig: Move file system options to Kconfig
2018-12-29 5:59 ` Offouga Joris
@ 2018-12-29 12:03 ` Fabio Estevam
0 siblings, 0 replies; 4+ messages in thread
From: Fabio Estevam @ 2018-12-29 12:03 UTC (permalink / raw)
To: u-boot
Hi Joris,
On Sat, Dec 29, 2018 at 3:59 AM Offouga Joris <offougajoris@gmail.com> wrote:
> You forgot "y" to this line, correct this in CONFIG_CMD_FAT=y
Thanks! I have just sent a corrected v2.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-12-29 12:03 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-12-27 19:14 [U-Boot] [PATCH] imx8mq_evk_defconfig: Move file system options to Kconfig Fabio Estevam
2018-12-29 4:58 ` Peng Fan
2018-12-29 5:59 ` Offouga Joris
2018-12-29 12:03 ` Fabio Estevam
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.