All of lore.kernel.org
 help / color / mirror / Atom feed
From: Fabio Estevam <festevam@gmail.com>
To: "Ariel D'Alessandro" <ariel.dalessandro@collabora.com>
Cc: U-Boot-Denx <u-boot@lists.denx.de>,
	dl-uboot-imx <uboot-imx@nxp.com>,  Adam Ford <aford173@gmail.com>,
	Andre Przywara <andre.przywara@arm.com>,
	 ZHIZHIKIN Andrey <andrey.zhizhikin@leica-geosystems.com>,
	 Christian Hewitt <christianshewitt@gmail.com>,
	Heiko Schocher <hs@denx.de>, Ilko Iliev <iliev@ronetix.at>,
	Jagan Teki <jagan@amarulasolutions.com>,
	Marcel Ziswiler <marcel.ziswiler@toradex.com>,
	 Neil Armstrong <narmstrong@baylibre.com>,
	Patrick Delaunay <patrick.delaunay@foss.st.com>,
	 Peter Robinson <pbrobinson@gmail.com>,
	Peng Fan <peng.fan@nxp.com>, Rick Chen <rick@andestech.com>,
	 Stefano Babic <sbabic@denx.de>,
	Sean Anderson <seanga2@gmail.com>, Simon Glass <sjg@chromium.org>,
	 Teresa Remmet <t.remmet@phytec.de>,
	Tim Harvey <tharvey@gateworks.com>,
	 Tom Rini <trini@konsulko.com>
Subject: Re: [PATCH v3 1/1] imx8mn_var_som: Add support for Variscite VAR-SOM-MX8M-NANO board
Date: Tue, 16 Nov 2021 08:37:06 -0300	[thread overview]
Message-ID: <CAOMZO5C1GNdyehhkEvM5Kcj5KcdPWp0-kDZKUN4vHLTkCRXRWw@mail.gmail.com> (raw)
In-Reply-To: <20211116035055.1194673-2-ariel.dalessandro@collabora.com>

Hi Ariel,

The patch looks good. Only some minor comments:

On Tue, Nov 16, 2021 at 12:51 AM Ariel D'Alessandro
<ariel.dalessandro@collabora.com> wrote:
>
> Add support for iMX8MN VAR-SOM-MX8M-NANO board. Enables support for:
>
> - 1GiB DDR4 RAM
> - 16 GiB eMMC
> - SD card
> - Gigabit ethernet
> - USBOTG1 peripheral - fastboot
>
> Signed-off-by: Ariel D'Alessandro <ariel.dalessandro@collabora.com>

It would be nice to have a README file so that the users can know how
to build and flash mainline
U-Boot in this board.

> +#define PHYS_SDRAM                     0x40000000
> +#define PHYS_SDRAM_SIZE                        SZ_1G /* 1GB DDR */
> +
> +#define CONFIG_BAUDRATE                        115200

This is the default. No need to be specified here.

> +#define CONFIG_MXC_UART_BASE           UART4_BASE_ADDR
> +
> +/* Monitor Command Prompt */
> +#define CONFIG_SYS_CBSIZE              SZ_2K
> +#define CONFIG_SYS_MAXARGS             64
> +#define CONFIG_SYS_BARGSIZE            CONFIG_SYS_CBSIZE
> +#define CONFIG_SYS_PBSIZE              (CONFIG_SYS_CBSIZE + \
> +                                        sizeof(CONFIG_SYS_PROMPT) + 16)
> +
> +/* USDHC */
> +#define CONFIG_FSL_USDHC

This should be placed in defconfig.

> +#define CONFIG_SYS_FSL_USDHC_NUM       2

This is not used. Please remove it.

  reply	other threads:[~2021-11-16 11:46 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-16  3:50 [PATCH v3 0/1] imx8mn_var_som: Add support for Variscite VAR-SOM-MX8M-NANO board Ariel D'Alessandro
2021-11-16  3:50 ` [PATCH v3 1/1] " Ariel D'Alessandro
2021-11-16 11:37   ` Fabio Estevam [this message]
2021-11-16 13:13     ` Tom Rini
2021-11-16 13:53       ` Ariel D'Alessandro
2021-11-16 14:07     ` Ariel D'Alessandro

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAOMZO5C1GNdyehhkEvM5Kcj5KcdPWp0-kDZKUN4vHLTkCRXRWw@mail.gmail.com \
    --to=festevam@gmail.com \
    --cc=aford173@gmail.com \
    --cc=andre.przywara@arm.com \
    --cc=andrey.zhizhikin@leica-geosystems.com \
    --cc=ariel.dalessandro@collabora.com \
    --cc=christianshewitt@gmail.com \
    --cc=hs@denx.de \
    --cc=iliev@ronetix.at \
    --cc=jagan@amarulasolutions.com \
    --cc=marcel.ziswiler@toradex.com \
    --cc=narmstrong@baylibre.com \
    --cc=patrick.delaunay@foss.st.com \
    --cc=pbrobinson@gmail.com \
    --cc=peng.fan@nxp.com \
    --cc=rick@andestech.com \
    --cc=sbabic@denx.de \
    --cc=seanga2@gmail.com \
    --cc=sjg@chromium.org \
    --cc=t.remmet@phytec.de \
    --cc=tharvey@gateworks.com \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    --cc=uboot-imx@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.