* [PATCH v2] dt-bindings: ifc: Fix the unit address format in the examples
@ 2018-03-10 17:06 Fabio Estevam
2018-03-12 7:39 ` Shawn Guo
2018-03-18 12:48 ` Rob Herring
0 siblings, 2 replies; 4+ messages in thread
From: Fabio Estevam @ 2018-03-10 17:06 UTC (permalink / raw)
To: shawnguo; +Cc: robh+dt, devicetree, Fabio Estevam
From: Fabio Estevam <fabio.estevam@nxp.com>
DTC warnings will be seen if these examples are used in a real dts file
due to a mismatch in the unit address notation.
Align the unit address notation to what is done in the real dts files
as per commit f81d7af79575 ("arm64: dts: fsl: fix ifc simple-bus unit
address format warnings")
Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
---
Hi,
Commit f81d7af79575 ("arm64: dts: fsl: fix ifc simple-bus unit address
format warnings") is present in Shawn Guo's tree.
Changes since v1:
- Add a 'ifc' prefix in the Subject
Documentation/devicetree/bindings/memory-controllers/fsl/ifc.txt | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/Documentation/devicetree/bindings/memory-controllers/fsl/ifc.txt b/Documentation/devicetree/bindings/memory-controllers/fsl/ifc.txt
index 89427b0..a4d4b6a 100644
--- a/Documentation/devicetree/bindings/memory-controllers/fsl/ifc.txt
+++ b/Documentation/devicetree/bindings/memory-controllers/fsl/ifc.txt
@@ -43,7 +43,7 @@ Example:
0x1 0x0 0x0 0xffa00000 0x00010000
0x3 0x0 0x0 0xffb00000 0x00020000>;
- flash@0,0 {
+ flash@0 {
#address-cells = <1>;
#size-cells = <1>;
compatible = "cfi-flash";
@@ -58,7 +58,7 @@ Example:
};
};
- flash@1,0 {
+ flash@100000000 {
#address-cells = <1>;
#size-cells = <1>;
compatible = "fsl,ifc-nand";
@@ -73,7 +73,7 @@ Example:
};
};
- cpld@3,0 {
+ cpld@@300000000 {
#address-cells = <1>;
#size-cells = <1>;
compatible = "fsl,p1010rdb-cpld";
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v2] dt-bindings: ifc: Fix the unit address format in the examples
2018-03-10 17:06 [PATCH v2] dt-bindings: ifc: Fix the unit address format in the examples Fabio Estevam
@ 2018-03-12 7:39 ` Shawn Guo
2018-03-18 12:48 ` Rob Herring
1 sibling, 0 replies; 4+ messages in thread
From: Shawn Guo @ 2018-03-12 7:39 UTC (permalink / raw)
To: Fabio Estevam; +Cc: robh+dt, devicetree, Fabio Estevam
On Sat, Mar 10, 2018 at 02:06:21PM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@nxp.com>
>
> DTC warnings will be seen if these examples are used in a real dts file
> due to a mismatch in the unit address notation.
>
> Align the unit address notation to what is done in the real dts files
> as per commit f81d7af79575 ("arm64: dts: fsl: fix ifc simple-bus unit
> address format warnings")
>
> Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] dt-bindings: ifc: Fix the unit address format in the examples
2018-03-10 17:06 [PATCH v2] dt-bindings: ifc: Fix the unit address format in the examples Fabio Estevam
2018-03-12 7:39 ` Shawn Guo
@ 2018-03-18 12:48 ` Rob Herring
2018-03-18 14:03 ` Fabio Estevam
1 sibling, 1 reply; 4+ messages in thread
From: Rob Herring @ 2018-03-18 12:48 UTC (permalink / raw)
To: Fabio Estevam; +Cc: shawnguo, devicetree, Fabio Estevam
On Sat, Mar 10, 2018 at 02:06:21PM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@nxp.com>
>
> DTC warnings will be seen if these examples are used in a real dts file
> due to a mismatch in the unit address notation.
>
> Align the unit address notation to what is done in the real dts files
> as per commit f81d7af79575 ("arm64: dts: fsl: fix ifc simple-bus unit
> address format warnings")
>
> Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
> ---
> Hi,
>
> Commit f81d7af79575 ("arm64: dts: fsl: fix ifc simple-bus unit address
> format warnings") is present in Shawn Guo's tree.
This "fix" is wrong. Memory controllers with chip selects should have
the chip select in the unit-address. The correct fix here is you should drop
"simple-bus".
Rob
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] dt-bindings: ifc: Fix the unit address format in the examples
2018-03-18 12:48 ` Rob Herring
@ 2018-03-18 14:03 ` Fabio Estevam
0 siblings, 0 replies; 4+ messages in thread
From: Fabio Estevam @ 2018-03-18 14:03 UTC (permalink / raw)
To: Rob Herring
Cc: Shawn Guo,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
Fabio Estevam
Hi Rob,
On Sun, Mar 18, 2018 at 9:48 AM, Rob Herring <robh@kernel.org> wrote:
> This "fix" is wrong. Memory controllers with chip selects should have
> the chip select in the unit-address. The correct fix here is you should drop
> "simple-bus".
Thanks. I will revert the change and will drop "simple-bus" as suggested.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-03-18 14:03 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-03-10 17:06 [PATCH v2] dt-bindings: ifc: Fix the unit address format in the examples Fabio Estevam
2018-03-12 7:39 ` Shawn Guo
2018-03-18 12:48 ` Rob Herring
2018-03-18 14:03 ` Fabio Estevam
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.