All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ARM: imx: limit errata selection to Cortex-A9 based designs
@ 2020-02-02 19:30 ` Stefan Agner
  0 siblings, 0 replies; 6+ messages in thread
From: Stefan Agner @ 2020-02-02 19:30 UTC (permalink / raw)
  To: shawnguo, s.hauer
  Cc: stefan, linux, kernel, festevam, linux-imx, arnd, Anson.Huang,
	linux-arm-kernel, linux-kernel, Stefan Agner

From: Stefan Agner <stefan.agner@toradex.com>

The two erratas 754322 and 775420 are Cortex-A9 specific. Only
select the erratas for SoC which use a Cortex-A9.

Signed-off-by: Stefan Agner <stefan@agner.ch>
---
 arch/arm/mach-imx/Kconfig | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/arch/arm/mach-imx/Kconfig b/arch/arm/mach-imx/Kconfig
index 95584ee02b55..e7d7b90e2cf8 100644
--- a/arch/arm/mach-imx/Kconfig
+++ b/arch/arm/mach-imx/Kconfig
@@ -471,8 +471,6 @@ config	SOC_IMX53
 config SOC_IMX6
 	bool
 	select ARM_CPU_SUSPEND if (PM || CPU_IDLE)
-	select ARM_ERRATA_754322
-	select ARM_ERRATA_775420
 	select ARM_GIC
 	select HAVE_IMX_ANATOP
 	select HAVE_IMX_GPC
@@ -484,6 +482,8 @@ config SOC_IMX6
 config SOC_IMX6Q
 	bool "i.MX6 Quad/DualLite support"
 	select ARM_ERRATA_764369 if SMP
+	select ARM_ERRATA_754322
+	select ARM_ERRATA_775420
 	select HAVE_ARM_SCU if SMP
 	select HAVE_ARM_TWD
 	select PINCTRL_IMX6Q
@@ -494,6 +494,8 @@ config SOC_IMX6Q
 
 config SOC_IMX6SL
 	bool "i.MX6 SoloLite support"
+	select ARM_ERRATA_754322
+	select ARM_ERRATA_775420
 	select PINCTRL_IMX6SL
 	select SOC_IMX6
 
@@ -502,6 +504,8 @@ config SOC_IMX6SL
 
 config SOC_IMX6SLL
 	bool "i.MX6 SoloLiteLite support"
+	select ARM_ERRATA_754322
+	select ARM_ERRATA_775420
 	select PINCTRL_IMX6SLL
 	select SOC_IMX6
 
@@ -510,6 +514,8 @@ config SOC_IMX6SLL
 
 config SOC_IMX6SX
 	bool "i.MX6 SoloX support"
+	select ARM_ERRATA_754322
+	select ARM_ERRATA_775420
 	select PINCTRL_IMX6SX
 	select SOC_IMX6
 
-- 
2.25.0


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH] ARM: imx: limit errata selection to Cortex-A9 based designs
@ 2020-02-02 19:30 ` Stefan Agner
  0 siblings, 0 replies; 6+ messages in thread
From: Stefan Agner @ 2020-02-02 19:30 UTC (permalink / raw)
  To: shawnguo, s.hauer
  Cc: Anson.Huang, arnd, Stefan Agner, linux, stefan, linux-kernel,
	linux-imx, kernel, festevam, linux-arm-kernel

From: Stefan Agner <stefan.agner@toradex.com>

The two erratas 754322 and 775420 are Cortex-A9 specific. Only
select the erratas for SoC which use a Cortex-A9.

Signed-off-by: Stefan Agner <stefan@agner.ch>
---
 arch/arm/mach-imx/Kconfig | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/arch/arm/mach-imx/Kconfig b/arch/arm/mach-imx/Kconfig
index 95584ee02b55..e7d7b90e2cf8 100644
--- a/arch/arm/mach-imx/Kconfig
+++ b/arch/arm/mach-imx/Kconfig
@@ -471,8 +471,6 @@ config	SOC_IMX53
 config SOC_IMX6
 	bool
 	select ARM_CPU_SUSPEND if (PM || CPU_IDLE)
-	select ARM_ERRATA_754322
-	select ARM_ERRATA_775420
 	select ARM_GIC
 	select HAVE_IMX_ANATOP
 	select HAVE_IMX_GPC
@@ -484,6 +482,8 @@ config SOC_IMX6
 config SOC_IMX6Q
 	bool "i.MX6 Quad/DualLite support"
 	select ARM_ERRATA_764369 if SMP
+	select ARM_ERRATA_754322
+	select ARM_ERRATA_775420
 	select HAVE_ARM_SCU if SMP
 	select HAVE_ARM_TWD
 	select PINCTRL_IMX6Q
@@ -494,6 +494,8 @@ config SOC_IMX6Q
 
 config SOC_IMX6SL
 	bool "i.MX6 SoloLite support"
+	select ARM_ERRATA_754322
+	select ARM_ERRATA_775420
 	select PINCTRL_IMX6SL
 	select SOC_IMX6
 
@@ -502,6 +504,8 @@ config SOC_IMX6SL
 
 config SOC_IMX6SLL
 	bool "i.MX6 SoloLiteLite support"
+	select ARM_ERRATA_754322
+	select ARM_ERRATA_775420
 	select PINCTRL_IMX6SLL
 	select SOC_IMX6
 
@@ -510,6 +514,8 @@ config SOC_IMX6SLL
 
 config SOC_IMX6SX
 	bool "i.MX6 SoloX support"
+	select ARM_ERRATA_754322
+	select ARM_ERRATA_775420
 	select PINCTRL_IMX6SX
 	select SOC_IMX6
 
-- 
2.25.0


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH] ARM: imx: limit errata selection to Cortex-A9 based designs
  2020-02-02 19:30 ` Stefan Agner
@ 2020-02-03 14:11   ` Oleksandr Suvorov
  -1 siblings, 0 replies; 6+ messages in thread
From: Oleksandr Suvorov @ 2020-02-03 14:11 UTC (permalink / raw)
  To: Stefan Agner
  Cc: Shawn Guo, Sascha Hauer, linux, Pengutronix Kernel Team,
	Fabio Estevam, NXP Linux Team, Arnd Bergmann, Anson.Huang,
	linux-arm-kernel, linux-kernel, Stefan Agner

On Sun, Feb 2, 2020 at 9:31 PM Stefan Agner <stefan@agner.ch> wrote:
>
> From: Stefan Agner <stefan.agner@toradex.com>
>
> The two erratas 754322 and 775420 are Cortex-A9 specific. Only
> select the erratas for SoC which use a Cortex-A9.
>
> Signed-off-by: Stefan Agner <stefan@agner.ch>

Reviewed-by: Oleksandr Suvorov <oleksandr.suvorov@toradex.com>

> ---
>  arch/arm/mach-imx/Kconfig | 10 ++++++++--
>  1 file changed, 8 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/mach-imx/Kconfig b/arch/arm/mach-imx/Kconfig
> index 95584ee02b55..e7d7b90e2cf8 100644
> --- a/arch/arm/mach-imx/Kconfig
> +++ b/arch/arm/mach-imx/Kconfig
> @@ -471,8 +471,6 @@ config      SOC_IMX53
>  config SOC_IMX6
>         bool
>         select ARM_CPU_SUSPEND if (PM || CPU_IDLE)
> -       select ARM_ERRATA_754322
> -       select ARM_ERRATA_775420
>         select ARM_GIC
>         select HAVE_IMX_ANATOP
>         select HAVE_IMX_GPC
> @@ -484,6 +482,8 @@ config SOC_IMX6
>  config SOC_IMX6Q
>         bool "i.MX6 Quad/DualLite support"
>         select ARM_ERRATA_764369 if SMP
> +       select ARM_ERRATA_754322
> +       select ARM_ERRATA_775420
>         select HAVE_ARM_SCU if SMP
>         select HAVE_ARM_TWD
>         select PINCTRL_IMX6Q
> @@ -494,6 +494,8 @@ config SOC_IMX6Q
>
>  config SOC_IMX6SL
>         bool "i.MX6 SoloLite support"
> +       select ARM_ERRATA_754322
> +       select ARM_ERRATA_775420
>         select PINCTRL_IMX6SL
>         select SOC_IMX6
>
> @@ -502,6 +504,8 @@ config SOC_IMX6SL
>
>  config SOC_IMX6SLL
>         bool "i.MX6 SoloLiteLite support"
> +       select ARM_ERRATA_754322
> +       select ARM_ERRATA_775420
>         select PINCTRL_IMX6SLL
>         select SOC_IMX6
>
> @@ -510,6 +514,8 @@ config SOC_IMX6SLL
>
>  config SOC_IMX6SX
>         bool "i.MX6 SoloX support"
> +       select ARM_ERRATA_754322
> +       select ARM_ERRATA_775420
>         select PINCTRL_IMX6SX
>         select SOC_IMX6
>
> --
> 2.25.0
>

-- 
Best regards
Oleksandr Suvorov

Toradex AG
Altsagenstrasse 5 | 6048 Horw/Luzern | Switzerland | T: +41 41 500
4800 (main line)

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] ARM: imx: limit errata selection to Cortex-A9 based designs
@ 2020-02-03 14:11   ` Oleksandr Suvorov
  0 siblings, 0 replies; 6+ messages in thread
From: Oleksandr Suvorov @ 2020-02-03 14:11 UTC (permalink / raw)
  To: Stefan Agner
  Cc: Anson.Huang, Arnd Bergmann, Stefan Agner, Shawn Guo,
	Sascha Hauer, linux, linux-kernel, NXP Linux Team,
	Pengutronix Kernel Team, Fabio Estevam, linux-arm-kernel

On Sun, Feb 2, 2020 at 9:31 PM Stefan Agner <stefan@agner.ch> wrote:
>
> From: Stefan Agner <stefan.agner@toradex.com>
>
> The two erratas 754322 and 775420 are Cortex-A9 specific. Only
> select the erratas for SoC which use a Cortex-A9.
>
> Signed-off-by: Stefan Agner <stefan@agner.ch>

Reviewed-by: Oleksandr Suvorov <oleksandr.suvorov@toradex.com>

> ---
>  arch/arm/mach-imx/Kconfig | 10 ++++++++--
>  1 file changed, 8 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/mach-imx/Kconfig b/arch/arm/mach-imx/Kconfig
> index 95584ee02b55..e7d7b90e2cf8 100644
> --- a/arch/arm/mach-imx/Kconfig
> +++ b/arch/arm/mach-imx/Kconfig
> @@ -471,8 +471,6 @@ config      SOC_IMX53
>  config SOC_IMX6
>         bool
>         select ARM_CPU_SUSPEND if (PM || CPU_IDLE)
> -       select ARM_ERRATA_754322
> -       select ARM_ERRATA_775420
>         select ARM_GIC
>         select HAVE_IMX_ANATOP
>         select HAVE_IMX_GPC
> @@ -484,6 +482,8 @@ config SOC_IMX6
>  config SOC_IMX6Q
>         bool "i.MX6 Quad/DualLite support"
>         select ARM_ERRATA_764369 if SMP
> +       select ARM_ERRATA_754322
> +       select ARM_ERRATA_775420
>         select HAVE_ARM_SCU if SMP
>         select HAVE_ARM_TWD
>         select PINCTRL_IMX6Q
> @@ -494,6 +494,8 @@ config SOC_IMX6Q
>
>  config SOC_IMX6SL
>         bool "i.MX6 SoloLite support"
> +       select ARM_ERRATA_754322
> +       select ARM_ERRATA_775420
>         select PINCTRL_IMX6SL
>         select SOC_IMX6
>
> @@ -502,6 +504,8 @@ config SOC_IMX6SL
>
>  config SOC_IMX6SLL
>         bool "i.MX6 SoloLiteLite support"
> +       select ARM_ERRATA_754322
> +       select ARM_ERRATA_775420
>         select PINCTRL_IMX6SLL
>         select SOC_IMX6
>
> @@ -510,6 +514,8 @@ config SOC_IMX6SLL
>
>  config SOC_IMX6SX
>         bool "i.MX6 SoloX support"
> +       select ARM_ERRATA_754322
> +       select ARM_ERRATA_775420
>         select PINCTRL_IMX6SX
>         select SOC_IMX6
>
> --
> 2.25.0
>

-- 
Best regards
Oleksandr Suvorov

Toradex AG
Altsagenstrasse 5 | 6048 Horw/Luzern | Switzerland | T: +41 41 500
4800 (main line)

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] ARM: imx: limit errata selection to Cortex-A9 based designs
  2020-02-02 19:30 ` Stefan Agner
@ 2020-02-03 14:22   ` Fabio Estevam
  -1 siblings, 0 replies; 6+ messages in thread
From: Fabio Estevam @ 2020-02-03 14:22 UTC (permalink / raw)
  To: Stefan Agner
  Cc: Shawn Guo, Sascha Hauer, Russell King - ARM Linux, Sascha Hauer,
	NXP Linux Team, Arnd Bergmann, Yongcai Huang,
	moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
	linux-kernel, Stefan Agner

Hi Stefan,

On Sun, Feb 2, 2020 at 4:30 PM Stefan Agner <stefan@agner.ch> wrote:
>
> From: Stefan Agner <stefan.agner@toradex.com>
>
> The two erratas 754322 and 775420 are Cortex-A9 specific. Only
> select the erratas for SoC which use a Cortex-A9.

Change looks good.

It is not clear from the commit log, which SoC selects the errata
incorrectly though.

I would mention that i.MX6UL is based on Cortex-A7 and hence should
not select them.

Otherwise, only by looking at this patch context and commit log, we
cannot notice the problem.

Reviewed-by: Fabio Estevam <festevam@gmail.com>

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] ARM: imx: limit errata selection to Cortex-A9 based designs
@ 2020-02-03 14:22   ` Fabio Estevam
  0 siblings, 0 replies; 6+ messages in thread
From: Fabio Estevam @ 2020-02-03 14:22 UTC (permalink / raw)
  To: Stefan Agner
  Cc: Yongcai Huang, Arnd Bergmann, Stefan Agner, Sascha Hauer,
	Russell King - ARM Linux, linux-kernel, NXP Linux Team,
	Sascha Hauer, Shawn Guo,
	moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE

Hi Stefan,

On Sun, Feb 2, 2020 at 4:30 PM Stefan Agner <stefan@agner.ch> wrote:
>
> From: Stefan Agner <stefan.agner@toradex.com>
>
> The two erratas 754322 and 775420 are Cortex-A9 specific. Only
> select the erratas for SoC which use a Cortex-A9.

Change looks good.

It is not clear from the commit log, which SoC selects the errata
incorrectly though.

I would mention that i.MX6UL is based on Cortex-A7 and hence should
not select them.

Otherwise, only by looking at this patch context and commit log, we
cannot notice the problem.

Reviewed-by: Fabio Estevam <festevam@gmail.com>

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2020-02-03 14:23 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-02 19:30 [PATCH] ARM: imx: limit errata selection to Cortex-A9 based designs Stefan Agner
2020-02-02 19:30 ` Stefan Agner
2020-02-03 14:11 ` Oleksandr Suvorov
2020-02-03 14:11   ` Oleksandr Suvorov
2020-02-03 14:22 ` Fabio Estevam
2020-02-03 14:22   ` Fabio Estevam

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.