All of lore.kernel.org
 help / color / mirror / Atom feed
From: Fabio Estevam <festevam@gmail.com>
To: Peter Seiderer <ps.report@gmx.net>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	Russell King <linux@arm.linux.org.uk>,
	Pawel Moll <pawel.moll@arm.com>,
	Ian Campbell <ijc+devicetree@hellion.org.uk>,
	Rob Herring <robh+dt@kernel.org>,
	Sascha Hauer <kernel@pengutronix.de>,
	Kumar Gala <galak@codeaurora.org>,
	Shawn Guo <shawn.guo@linaro.org>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v1] ARM: dts: nitrogen6x: add CAN support
Date: Wed, 20 May 2015 19:26:18 -0300	[thread overview]
Message-ID: <CAOMZO5Cazk3TGSF1c4pt0WhY2stmJzHWfTyySnf_NyHxaAfgDA@mail.gmail.com> (raw)
In-Reply-To: <1432158569-4415-1-git-send-email-ps.report@gmx.net>

On Wed, May 20, 2015 at 6:49 PM, Peter Seiderer <ps.report@gmx.net> wrote:

> +               pinctrl_can1_1: can1grp-1 {
> +                       fsl,pins = <
> +                               MX6QDL_PAD_KEY_COL2__FLEXCAN1_TX 0x80000000
> +                               MX6QDL_PAD_KEY_ROW2__FLEXCAN1_RX 0x80000000

Better not to pass 0x80000000. Use the real PAD settings instead.

WARNING: multiple messages have this Message-ID (diff)
From: festevam@gmail.com (Fabio Estevam)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v1] ARM: dts: nitrogen6x: add CAN support
Date: Wed, 20 May 2015 19:26:18 -0300	[thread overview]
Message-ID: <CAOMZO5Cazk3TGSF1c4pt0WhY2stmJzHWfTyySnf_NyHxaAfgDA@mail.gmail.com> (raw)
In-Reply-To: <1432158569-4415-1-git-send-email-ps.report@gmx.net>

On Wed, May 20, 2015 at 6:49 PM, Peter Seiderer <ps.report@gmx.net> wrote:

> +               pinctrl_can1_1: can1grp-1 {
> +                       fsl,pins = <
> +                               MX6QDL_PAD_KEY_COL2__FLEXCAN1_TX 0x80000000
> +                               MX6QDL_PAD_KEY_ROW2__FLEXCAN1_RX 0x80000000

Better not to pass 0x80000000. Use the real PAD settings instead.

  reply	other threads:[~2015-05-20 22:26 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-20 21:49 [PATCH v1] ARM: dts: nitrogen6x: add CAN support Peter Seiderer
2015-05-20 21:49 ` Peter Seiderer
2015-05-20 22:26 ` Fabio Estevam [this message]
2015-05-20 22:26   ` Fabio Estevam
2015-05-20 22:26   ` Fabio Estevam
2015-05-21  6:51   ` Aw: " Peter Seiderer
2015-05-21  6:51     ` Peter Seiderer
2015-05-21  6:51     ` Peter Seiderer
2015-05-21  1:33 ` Shawn Guo
2015-05-21  1:33   ` Shawn Guo
2015-05-21  1:33   ` Shawn Guo
2015-05-21  6:56   ` Aw: " Peter Seiderer
2015-05-21  6:56     ` Peter Seiderer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAOMZO5Cazk3TGSF1c4pt0WhY2stmJzHWfTyySnf_NyHxaAfgDA@mail.gmail.com \
    --to=festevam@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=galak@codeaurora.org \
    --cc=ijc+devicetree@hellion.org.uk \
    --cc=kernel@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=mark.rutland@arm.com \
    --cc=pawel.moll@arm.com \
    --cc=ps.report@gmx.net \
    --cc=robh+dt@kernel.org \
    --cc=shawn.guo@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.