All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH V2] ARM: dts: imx6sll-evk: make pfuze100 sw4 always on
@ 2018-06-26  1:01 ` Anson Huang
  0 siblings, 0 replies; 5+ messages in thread
From: Anson Huang @ 2018-06-26  1:01 UTC (permalink / raw)
  To: shawnguo, s.hauer, kernel, fabio.estevam, robh+dt, mark.rutland
  Cc: Linux-imx, linux-arm-kernel, devicetree, linux-kernel

On i.MX6SLL EVK board, PFuze100's SW4 is supplying
LPDDR3, it needs to be always on. This patch fixes
Linux kernel boot up hang caused by commit
(5fe156f regulator: pfuze100: add enable/disable for switch),
because SW4 is turned off unexpectedly:

[    1.693613] cfg80211: failed to load regulatory.db
[    1.700063] SW4: disabling
[    1.703973] SWBST: disabling

Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
---
changes since V1:
	improve commit message by adding info of which commit introduces this issue.
 arch/arm/boot/dts/imx6sll-evk.dts | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm/boot/dts/imx6sll-evk.dts b/arch/arm/boot/dts/imx6sll-evk.dts
index 4684ac4..2217c40 100644
--- a/arch/arm/boot/dts/imx6sll-evk.dts
+++ b/arch/arm/boot/dts/imx6sll-evk.dts
@@ -142,6 +142,7 @@
 			sw4_reg: sw4 {
 				regulator-min-microvolt = <800000>;
 				regulator-max-microvolt = <3300000>;
+				regulator-always-on;
 			};
 
 			swbst_reg: swbst {
-- 
2.7.4


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [PATCH V2] ARM: dts: imx6sll-evk: make pfuze100 sw4 always on
@ 2018-06-26  1:01 ` Anson Huang
  0 siblings, 0 replies; 5+ messages in thread
From: Anson Huang @ 2018-06-26  1:01 UTC (permalink / raw)
  To: linux-arm-kernel

On i.MX6SLL EVK board, PFuze100's SW4 is supplying
LPDDR3, it needs to be always on. This patch fixes
Linux kernel boot up hang caused by commit
(5fe156f regulator: pfuze100: add enable/disable for switch),
because SW4 is turned off unexpectedly:

[    1.693613] cfg80211: failed to load regulatory.db
[    1.700063] SW4: disabling
[    1.703973] SWBST: disabling

Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
---
changes since V1:
	improve commit message by adding info of which commit introduces this issue.
 arch/arm/boot/dts/imx6sll-evk.dts | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm/boot/dts/imx6sll-evk.dts b/arch/arm/boot/dts/imx6sll-evk.dts
index 4684ac4..2217c40 100644
--- a/arch/arm/boot/dts/imx6sll-evk.dts
+++ b/arch/arm/boot/dts/imx6sll-evk.dts
@@ -142,6 +142,7 @@
 			sw4_reg: sw4 {
 				regulator-min-microvolt = <800000>;
 				regulator-max-microvolt = <3300000>;
+				regulator-always-on;
 			};
 
 			swbst_reg: swbst {
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH V2] ARM: dts: imx6sll-evk: make pfuze100 sw4 always on
  2018-06-26  1:01 ` Anson Huang
  (?)
@ 2018-06-27  1:19   ` Fabio Estevam
  -1 siblings, 0 replies; 5+ messages in thread
From: Fabio Estevam @ 2018-06-27  1:19 UTC (permalink / raw)
  To: Anson Huang
  Cc: Shawn Guo, Sascha Hauer, Sascha Hauer, Fabio Estevam,
	Rob Herring, Mark Rutland, NXP Linux Team,
	moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
	open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
	linux-kernel

Hi Anson,

On Mon, Jun 25, 2018 at 10:01 PM, Anson Huang <Anson.Huang@nxp.com> wrote:
> On i.MX6SLL EVK board, PFuze100's SW4 is supplying
> LPDDR3, it needs to be always on. This patch fixes
> Linux kernel boot up hang caused by commit
> (5fe156f regulator: pfuze100: add enable/disable for switch),
> because SW4 is turned off unexpectedly:

Nit: The proper way to reference a commit is:

commit 5fe156f1cab4 ("regulator: pfuze100: add enable/disable for switch")

12 char for the commit ID and the commit name inside (" ").

> [    1.693613] cfg80211: failed to load regulatory.db
> [    1.700063] SW4: disabling
> [    1.703973] SWBST: disabling

Probably worth adding the Fixes tag so that it can fix the boot
regression in 4.18-rc:

Fixes: 5fe156f1cab4 ("regulator: pfuze100: add enable/disable for switch")

> Signed-off-by: Anson Huang <Anson.Huang@nxp.com>

Reviewed-by: Fabio Estevam <fabio.estevam@nxp.com>

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH V2] ARM: dts: imx6sll-evk: make pfuze100 sw4 always on
@ 2018-06-27  1:19   ` Fabio Estevam
  0 siblings, 0 replies; 5+ messages in thread
From: Fabio Estevam @ 2018-06-27  1:19 UTC (permalink / raw)
  To: Anson Huang
  Cc: Shawn Guo, Sascha Hauer, Sascha Hauer, Fabio Estevam,
	Rob Herring, Mark Rutland, NXP Linux Team,
	moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
	open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
	linux-kernel

Hi Anson,

On Mon, Jun 25, 2018 at 10:01 PM, Anson Huang <Anson.Huang@nxp.com> wrote:
> On i.MX6SLL EVK board, PFuze100's SW4 is supplying
> LPDDR3, it needs to be always on. This patch fixes
> Linux kernel boot up hang caused by commit
> (5fe156f regulator: pfuze100: add enable/disable for switch),
> because SW4 is turned off unexpectedly:

Nit: The proper way to reference a commit is:

commit 5fe156f1cab4 ("regulator: pfuze100: add enable/disable for switch")

12 char for the commit ID and the commit name inside (" ").

> [    1.693613] cfg80211: failed to load regulatory.db
> [    1.700063] SW4: disabling
> [    1.703973] SWBST: disabling

Probably worth adding the Fixes tag so that it can fix the boot
regression in 4.18-rc:

Fixes: 5fe156f1cab4 ("regulator: pfuze100: add enable/disable for switch")

> Signed-off-by: Anson Huang <Anson.Huang@nxp.com>

Reviewed-by: Fabio Estevam <fabio.estevam@nxp.com>

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH V2] ARM: dts: imx6sll-evk: make pfuze100 sw4 always on
@ 2018-06-27  1:19   ` Fabio Estevam
  0 siblings, 0 replies; 5+ messages in thread
From: Fabio Estevam @ 2018-06-27  1:19 UTC (permalink / raw)
  To: linux-arm-kernel

Hi Anson,

On Mon, Jun 25, 2018 at 10:01 PM, Anson Huang <Anson.Huang@nxp.com> wrote:
> On i.MX6SLL EVK board, PFuze100's SW4 is supplying
> LPDDR3, it needs to be always on. This patch fixes
> Linux kernel boot up hang caused by commit
> (5fe156f regulator: pfuze100: add enable/disable for switch),
> because SW4 is turned off unexpectedly:

Nit: The proper way to reference a commit is:

commit 5fe156f1cab4 ("regulator: pfuze100: add enable/disable for switch")

12 char for the commit ID and the commit name inside (" ").

> [    1.693613] cfg80211: failed to load regulatory.db
> [    1.700063] SW4: disabling
> [    1.703973] SWBST: disabling

Probably worth adding the Fixes tag so that it can fix the boot
regression in 4.18-rc:

Fixes: 5fe156f1cab4 ("regulator: pfuze100: add enable/disable for switch")

> Signed-off-by: Anson Huang <Anson.Huang@nxp.com>

Reviewed-by: Fabio Estevam <fabio.estevam@nxp.com>

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2018-06-27  1:20 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-06-26  1:01 [PATCH V2] ARM: dts: imx6sll-evk: make pfuze100 sw4 always on Anson Huang
2018-06-26  1:01 ` Anson Huang
2018-06-27  1:19 ` Fabio Estevam
2018-06-27  1:19   ` Fabio Estevam
2018-06-27  1:19   ` Fabio Estevam

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.