All of lore.kernel.org
 help / color / mirror / Atom feed
From: Fabio Estevam <festevam@gmail.com>
To: abhinavk@codeaurora.org
Cc: Rob Clark <robdclark@gmail.com>,
	DRI mailing list <dri-devel@lists.freedesktop.org>,
	 "open list:DRM DRIVER FOR MSM ADRENO GPU"
	<freedreno@lists.freedesktop.org>,
	 Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
	stable <stable@vger.kernel.org>
Subject: Re: [Freedreno] [PATCH] drm/msm: Do not run snapshot on non-DPU devices
Date: Thu, 16 Sep 2021 13:24:25 -0300	[thread overview]
Message-ID: <CAOMZO5CgFFmKmKF0C_1okmu7N24=udevT3LE=0bRoZqUeDQSWg@mail.gmail.com> (raw)
In-Reply-To: <5409ccef7ee4359d070eed3acd955590@codeaurora.org>

Hi Abhinav,

On Thu, Sep 16, 2021 at 1:15 PM <abhinavk@codeaurora.org> wrote:
>
> Hi Fabio
>
> Thanks for confirming.
>
> Although I have no issues with your change, I am curious why even msm is
> probing and/or binding.
> Your device tree should not be having any mdp/dpu nodes then.

The i.MX53 does have the following GPU node:

compatible = "amd,imageon-200.0", "amd,imageon";

That's why it probes the msm driver.

However, i.MX53 does not have any of the Qualcomm display controllers.

It uses the i.MX IPU display controller instead.

Hope that clarifies.

Please reply with a Reviewed-by if you are happy with my fix.

Thanks

  reply	other threads:[~2021-09-16 16:24 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-14 17:48 [PATCH] drm/msm: Do not run snapshot on non-DPU devices Fabio Estevam
2021-09-16  2:22 ` [Freedreno] " abhinavk
2021-09-16 11:42   ` Fabio Estevam
2021-09-16 11:42     ` Fabio Estevam
2021-09-16 16:15     ` abhinavk
2021-09-16 16:15       ` abhinavk
2021-09-16 16:24       ` Fabio Estevam [this message]
2021-09-16 16:24         ` Fabio Estevam
2021-09-16 16:37         ` abhinavk
2021-09-16 16:37           ` abhinavk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAOMZO5CgFFmKmKF0C_1okmu7N24=udevT3LE=0bRoZqUeDQSWg@mail.gmail.com' \
    --to=festevam@gmail.com \
    --cc=abhinavk@codeaurora.org \
    --cc=dmitry.baryshkov@linaro.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=freedreno@lists.freedesktop.org \
    --cc=robdclark@gmail.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.