All of lore.kernel.org
 help / color / mirror / Atom feed
From: Fabio Estevam <festevam-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Russell King <rmk+kernel-I+IVW8TIWO2tmTQ+vhA3Yw@public.gmane.org>
Cc: Shawn Guo <shawnguo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	Jon Nettleton
	<jon.nettleton-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	Sascha Hauer <kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>,
	Fabio Estevam <fabio.estevam-3arQi8VN3Tc@public.gmane.org>,
	Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
	"linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org"
	<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>,
	"devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH 09/13] ARM: dts: imx6qdl-hummingboard: add SD card regulator
Date: Mon, 27 Nov 2017 18:11:10 -0200	[thread overview]
Message-ID: <CAOMZO5Ch5y-PJWTkwuV9HhasErqx+88wK-B+AtMKtCW3oj0ctg@mail.gmail.com> (raw)
In-Reply-To: <E1eJMeI-0002rP-Rt-eh5Bv4kxaXIk46pC+1QYvQNdhmdF6hFW@public.gmane.org>

On Mon, Nov 27, 2017 at 2:52 PM, Russell King
<rmk+kernel-I+IVW8TIWO2tmTQ+vhA3Yw@public.gmane.org> wrote:

> +       v_sd: regulator-v-sd {
> +               compatible = "regulator-fixed";
> +               gpio = <&gpio4 30 GPIO_ACTIVE_HIGH>;

It seems this should be GPIO_ACTIVE_LOW instead because
'enable-active-high' is not passed here.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: festevam@gmail.com (Fabio Estevam)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 09/13] ARM: dts: imx6qdl-hummingboard: add SD card regulator
Date: Mon, 27 Nov 2017 18:11:10 -0200	[thread overview]
Message-ID: <CAOMZO5Ch5y-PJWTkwuV9HhasErqx+88wK-B+AtMKtCW3oj0ctg@mail.gmail.com> (raw)
In-Reply-To: <E1eJMeI-0002rP-Rt@rmk-PC.armlinux.org.uk>

On Mon, Nov 27, 2017 at 2:52 PM, Russell King
<rmk+kernel@armlinux.org.uk> wrote:

> +       v_sd: regulator-v-sd {
> +               compatible = "regulator-fixed";
> +               gpio = <&gpio4 30 GPIO_ACTIVE_HIGH>;

It seems this should be GPIO_ACTIVE_LOW instead because
'enable-active-high' is not passed here.

  parent reply	other threads:[~2017-11-27 20:11 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-27 16:51 [PATCH 00/13] SolidRun Hummingboard DT updates Russell King - ARM Linux
2017-11-27 16:51 ` Russell King - ARM Linux
     [not found] ` <20171127165134.GH31757-l+eeeJia6m9URfEZ8mYm6t73F7V6hmMc@public.gmane.org>
2017-11-27 16:52   ` [PATCH 01/13] ARM: dts: imx6qdl: SolidRun: remove redundant regulators node Russell King
2017-11-27 16:52     ` Russell King
     [not found]     ` <E1eJMdd-0002qR-Or-eh5Bv4kxaXIk46pC+1QYvQNdhmdF6hFW@public.gmane.org>
2017-11-27 20:15       ` Fabio Estevam
2017-11-27 20:15         ` Fabio Estevam
     [not found]         ` <CAOMZO5B9GW26+3EfutnH4meUec3qq09Q6OBYHTtdvWG+DavJwg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-11-27 23:14           ` Russell King - ARM Linux
2017-11-27 23:14             ` Russell King - ARM Linux
     [not found]             ` <20171127231406.GQ31757-l+eeeJia6m9URfEZ8mYm6t73F7V6hmMc@public.gmane.org>
2017-11-27 23:55               ` Fabio Estevam
2017-11-27 23:55                 ` Fabio Estevam
2017-11-27 16:52   ` [PATCH 02/13] ARM: dts: imx6qdl: SolidRun: move AR8035 into microsom Russell King
2017-11-27 16:52     ` Russell King
     [not found]     ` <E1eJMdi-0002qY-Ta-eh5Bv4kxaXIk46pC+1QYvQNdhmdF6hFW@public.gmane.org>
2017-11-27 20:12       ` Fabio Estevam
2017-11-27 20:12         ` Fabio Estevam
     [not found]         ` <CAOMZO5C+z2nFv0pFz5XDY-DGtj2YvhU_kNh1H8mdq6GOUqc_Mg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-11-27 23:13           ` Russell King - ARM Linux
2017-11-27 23:13             ` Russell King - ARM Linux
2017-11-27 16:52   ` [PATCH 03/13] ARM: dts: imx6qdl: SolidRun: move microsom includes into .dts Russell King
2017-11-27 16:52     ` Russell King
2017-11-28  4:46     ` Jon Nettleton
2017-11-28 10:45       ` Russell King - ARM Linux
2017-11-28 10:45         ` Russell King - ARM Linux
2017-11-27 16:52   ` [PATCH 04/13] ARM: dts: imx6qdl-microsom: split out Broadcom Wi-Fi support Russell King
2017-11-27 16:52     ` Russell King
2017-11-27 16:52   ` [PATCH 05/13] ARM: dts: imx6qdl-microsom-brcm: rename sdio clock Russell King
2017-11-27 16:52     ` Russell King
2017-11-27 16:52   ` [PATCH 06/13] ARM: dts: imx6qdl-microsom: add 3.3V vcc regulator Russell King
2017-11-27 16:52     ` Russell King
2017-11-27 16:52   ` [PATCH 07/13] ARM: dts: imx6qdl-microsom: add support for TI Wi-Fi Russell King
2017-11-27 16:52     ` Russell King
2017-11-27 16:52   ` [PATCH 08/13] ARM: dts: ixm6qdl-microsom: add support for eMMC Russell King
2017-11-27 16:52     ` Russell King
2017-11-27 16:52   ` [PATCH 09/13] ARM: dts: imx6qdl-hummingboard: add SD card regulator Russell King
2017-11-27 16:52     ` Russell King
     [not found]     ` <E1eJMeI-0002rP-Rt-eh5Bv4kxaXIk46pC+1QYvQNdhmdF6hFW@public.gmane.org>
2017-11-27 20:11       ` Fabio Estevam [this message]
2017-11-27 20:11         ` Fabio Estevam
2017-11-27 16:52   ` [PATCH 10/13] ARM: dts: imx6qdl-hummingboard: rename regulators to match schematic Russell King
2017-11-27 16:52     ` Russell King
2017-11-27 16:53   ` [PATCH 11/13] ARM: dts: imx6qdl-hummingboard: fix node names Russell King
2017-11-27 16:53     ` Russell King
2017-11-27 16:53   ` [PATCH 12/13] ARM: dts: imx6qdl-cubox-i: rename regulators to match schematic Russell King
2017-11-27 16:53     ` Russell King
2017-11-27 16:53   ` [PATCH 13/13] ARM: dts: imx6qdl-cubox-i: fix node names Russell King
2017-11-27 16:53     ` Russell King
2017-11-27 20:18   ` [PATCH 00/13] SolidRun Hummingboard DT updates Fabio Estevam
2017-11-27 20:18     ` Fabio Estevam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAOMZO5Ch5y-PJWTkwuV9HhasErqx+88wK-B+AtMKtCW3oj0ctg@mail.gmail.com \
    --to=festevam-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
    --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=fabio.estevam-3arQi8VN3Tc@public.gmane.org \
    --cc=jon.nettleton-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \
    --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
    --cc=rmk+kernel-I+IVW8TIWO2tmTQ+vhA3Yw@public.gmane.org \
    --cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=shawnguo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.