All of lore.kernel.org
 help / color / mirror / Atom feed
* [U-Boot] arm: mxs: No arch specific invalidate_icache_all available!
@ 2017-04-24 11:03 Stefan Wahren
  2017-04-24 23:12 ` Fabio Estevam
  0 siblings, 1 reply; 6+ messages in thread
From: Stefan Wahren @ 2017-04-24 11:03 UTC (permalink / raw)
  To: u-boot

Hi,

i tried to port our Duckbill (based on NXP i.MX28 SoC) to U-Boot
v2017.03 [1]. The startup works fine, except of this warning:

No arch specific invalidate_icache_all available!

I didn't found a MXS specific implementation of invalidate_icache_all().

Did i miss something? Shouldn't be the other MXS boards also affected?

[1] - https://github.com/lategoodbye/u-boot/tree/v2017.03-duckbill

^ permalink raw reply	[flat|nested] 6+ messages in thread
* [U-Boot] arm: mxs: No arch specific invalidate_icache_all available!
  2017-04-24 11:03 [U-Boot] arm: mxs: No arch specific invalidate_icache_all available! Stefan Wahren
@ 2017-04-24 23:12 ` Fabio Estevam
  2017-04-29  7:21   ` Michael Heimpold
  0 siblings, 1 reply; 6+ messages in thread
From: Fabio Estevam @ 2017-04-24 23:12 UTC (permalink / raw)
  To: u-boot

Hi Stefan,

On Mon, Apr 24, 2017 at 8:03 AM, Stefan Wahren <stefan.wahren@i2se.com> wrote:
> Hi,
>
> i tried to port our Duckbill (based on NXP i.MX28 SoC) to U-Boot
> v2017.03 [1]. The startup works fine, except of this warning:
>
> No arch specific invalidate_icache_all available!
>
> I didn't found a MXS specific implementation of invalidate_icache_all().
>
> Did i miss something? Shouldn't be the other MXS boards also affected?
>
> [1] - https://github.com/lategoodbye/u-boot/tree/v2017.03-duckbill

Looks like ARM926 needs a invalidate_icache_all available() implementation.

Regards,

Fabio Estevam

^ permalink raw reply	[flat|nested] 6+ messages in thread
* [U-Boot] arm: mxs: No arch specific invalidate_icache_all available!
  2017-04-24 23:12 ` Fabio Estevam
@ 2017-04-29  7:21   ` Michael Heimpold
  2017-05-03  0:56     ` Fabio Estevam
  0 siblings, 1 reply; 6+ messages in thread
From: Michael Heimpold @ 2017-04-29  7:21 UTC (permalink / raw)
  To: u-boot

Hi,

Am Montag, 24. April 2017, 20:12:55 CEST schrieb Fabio Estevam:
> Hi Stefan,
> 
> On Mon, Apr 24, 2017 at 8:03 AM, Stefan Wahren <stefan.wahren@i2se.com> 
wrote:
> > Hi,
> > 
> > i tried to port our Duckbill (based on NXP i.MX28 SoC) to U-Boot
> > v2017.03 [1]. The startup works fine, except of this warning:
> > 
> > No arch specific invalidate_icache_all available!
> > 
> > I didn't found a MXS specific implementation of invalidate_icache_all().
> > 
> > Did i miss something? Shouldn't be the other MXS boards also affected?
> > 
> > [1] - https://github.com/lategoodbye/u-boot/tree/v2017.03-duckbill
> 
> Looks like ARM926 needs a invalidate_icache_all available() implementation.
> 

we could move the implementation in arch/arm/mach-at91/arm926ejs/cache.c
to a more generic place and re-use it.

However, the warning is only generated because lib/efi_loader/efi_runtime.c
calls invalidate_icache_all from efi_runtime_relocate. This is because
CONFIG_EFI_LOADER is set.

I don't know if somebody using the EFI stuff for other MXS-based boards.
For our Duckbill, I would simply force
# CONFIG_EFI_LOADER is not set
via config.

Regards,
Michael

^ permalink raw reply	[flat|nested] 6+ messages in thread
* [U-Boot] arm: mxs: No arch specific invalidate_icache_all available!
  2017-04-29  7:21   ` Michael Heimpold
@ 2017-05-03  0:56     ` Fabio Estevam
  2017-05-03  7:19       ` Michael Heimpold
  0 siblings, 1 reply; 6+ messages in thread
From: Fabio Estevam @ 2017-05-03  0:56 UTC (permalink / raw)
  To: u-boot

Hi Michael,

On Sat, Apr 29, 2017 at 4:21 AM, Michael Heimpold <mhei@heimpold.de> wrote:

> we could move the implementation in arch/arm/mach-at91/arm926ejs/cache.c
> to a more generic place and re-use it.
>
> However, the warning is only generated because lib/efi_loader/efi_runtime.c
> calls invalidate_icache_all from efi_runtime_relocate. This is because
> CONFIG_EFI_LOADER is set.
>
> I don't know if somebody using the EFI stuff for other MXS-based boards.
> For our Duckbill, I would simply force
> # CONFIG_EFI_LOADER is not set
> via config.

Not sure why CONFIG_EFI_LOADER is always selected for ARM.

What about doing this?

diff --git a/lib/efi_loader/Kconfig b/lib/efi_loader/Kconfig
index d2b6327..a2ea9c0 100644
--- a/lib/efi_loader/Kconfig
+++ b/lib/efi_loader/Kconfig
@@ -1,6 +1,6 @@
 config EFI_LOADER
        bool "Support running EFI Applications in U-Boot"
-       depends on (ARM || X86) && OF_LIBFDT
+       depends on X86 && OF_LIBFDT
        default y
        help
          Select this option if you want to run EFI applications (like grub2)

^ permalink raw reply related	[flat|nested] 6+ messages in thread
* [U-Boot] arm: mxs: No arch specific invalidate_icache_all available!
  2017-05-03  0:56     ` Fabio Estevam
@ 2017-05-03  7:19       ` Michael Heimpold
  2017-05-03 13:29         ` Fabio Estevam
  0 siblings, 1 reply; 6+ messages in thread
From: Michael Heimpold @ 2017-05-03  7:19 UTC (permalink / raw)
  To: u-boot

Hi Fabio,


Am 03.05.2017 um 02:56 schrieb Fabio Estevam:
> Hi Michael,
>
> On Sat, Apr 29, 2017 at 4:21 AM, Michael Heimpold <mhei@heimpold.de> wrote:
>
>> we could move the implementation in arch/arm/mach-at91/arm926ejs/cache.c
>> to a more generic place and re-use it.
>>
>> However, the warning is only generated because lib/efi_loader/efi_runtime.c
>> calls invalidate_icache_all from efi_runtime_relocate. This is because
>> CONFIG_EFI_LOADER is set.
>>
>> I don't know if somebody using the EFI stuff for other MXS-based boards.
>> For our Duckbill, I would simply force
>> # CONFIG_EFI_LOADER is not set
>> via config.
> Not sure why CONFIG_EFI_LOADER is always selected for ARM.
>
> What about doing this?
>
> diff --git a/lib/efi_loader/Kconfig b/lib/efi_loader/Kconfig
> index d2b6327..a2ea9c0 100644
> --- a/lib/efi_loader/Kconfig
> +++ b/lib/efi_loader/Kconfig
> @@ -1,6 +1,6 @@
>   config EFI_LOADER
>          bool "Support running EFI Applications in U-Boot"
> -       depends on (ARM || X86) && OF_LIBFDT
> +       depends on X86 && OF_LIBFDT
>          default y
>          help
>            Select this option if you want to run EFI applications (like grub2)

I don't think this is a good idea since this limits EFI support for x86 only?
Maybe we should just adjust the default value for MXS-based boards,
something like
default y if !ARCH_MXS
but at the moment there seems to be no such config symbol. I'm not sure which approach
is less painful, adding such a config symbol or just moving around the existing
invalidate_icache_all function and have some functionality in mxs based boards which is
usually not needed there.
Ideally we would do both, i.e. fine-tune the config stuff and clean up common code...


Mit freundlichen Grüßen / Kind regards
Michael Heimpold
-- 
Software Engineer

I2SE GmbH                           Tel: +49 (0) 341 355667-00
Friedrich-Ebert-Str. 61             Fax: +49 (0) 341 355667-02
04109 Leipzig
Germany
Web: http://www.i2se.com/           Mail: info at i2se.com
VAT No.: DE 811528334
Amtsgericht Leipzig HRB 23784
Geschäftsführer/CEO: Carsten Ziermann

*** Diese E-Mail ist allein für den bezeichneten Adressaten bestimmt. Sie kann rechtlich vertrauliche Informationen enthalten. Wenn Sie diese E-Mail irrtümlich erhalten haben, informieren Sie bitte unverzüglich den Absender per E-Mail und löschen Sie diese E-Mail von Ihrem Computer, ohne Kopien anzufertigen.
Vielen Dank. ***

*** This email is for the exclusive use of the addressee. It may contain legally privileged information. If you have received this message in error, please notify the sender by email immediately and delete the message from your computer without making any copies.
Thank you. ***

^ permalink raw reply	[flat|nested] 6+ messages in thread
* [U-Boot] arm: mxs: No arch specific invalidate_icache_all available!
  2017-05-03  7:19       ` Michael Heimpold
@ 2017-05-03 13:29         ` Fabio Estevam
  0 siblings, 0 replies; 6+ messages in thread
From: Fabio Estevam @ 2017-05-03 13:29 UTC (permalink / raw)
  To: u-boot

On Wed, May 3, 2017 at 4:19 AM, Michael Heimpold
<michael.heimpold@i2se.com> wrote:

> I don't think this is a good idea since this limits EFI support for x86
> only?
> Maybe we should just adjust the default value for MXS-based boards,
> something like
> default y if !ARCH_MXS

Or what about this one instead?

diff --git a/lib/efi_loader/Kconfig b/lib/efi_loader/Kconfig
index d2b6327..bf191af 100644
--- a/lib/efi_loader/Kconfig
+++ b/lib/efi_loader/Kconfig
@@ -1,7 +1,6 @@
 config EFI_LOADER
        bool "Support running EFI Applications in U-Boot"
        depends on (ARM || X86) && OF_LIBFDT
-       default y
        help
          Select this option if you want to run EFI applications (like grub2)
          on top of U-Boot. If this option is enabled, U-Boot will expose EFI

^ permalink raw reply related	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-05-03 13:29 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-04-24 11:03 [U-Boot] arm: mxs: No arch specific invalidate_icache_all available! Stefan Wahren
2017-04-24 23:12 ` Fabio Estevam
2017-04-29  7:21   ` Michael Heimpold
2017-05-03  0:56     ` Fabio Estevam
2017-05-03  7:19       ` Michael Heimpold
2017-05-03 13:29         ` Fabio Estevam

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.