* Re: [PATCH] ASoC: sgtl5000: fix powerup/down of micbias-voltage
@ 2018-01-12 12:35 ` Fischer, Christian
0 siblings, 0 replies; 7+ messages in thread
From: Fischer, Christian @ 2018-01-12 12:35 UTC (permalink / raw)
To: Mark Brown
Cc: alsa-devel, lgirdwood, perex, tiwai, richard.leitner,
fabio.estevam, bhumirks, linux-kernel
Hi Mark,
> Has your board connected the bias to the microphone widget it defines?
> Unless your board says that the bias is in use on a given board it won't be enabled.
Thanks for this tip!
The problem is that the machine-driver mxs-sgtl5000 don't support audio-routing.
I've prepared a patch that will be submitted this noon.
Regards,
Christian
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] ASoC: sgtl5000: fix powerup/down of micbias-voltage
@ 2018-01-12 12:35 ` Fischer, Christian
0 siblings, 0 replies; 7+ messages in thread
From: Fischer, Christian @ 2018-01-12 12:35 UTC (permalink / raw)
To: Mark Brown
Cc: alsa-devel, linux-kernel, tiwai, lgirdwood, fabio.estevam,
bhumirks, richard.leitner
Hi Mark,
> Has your board connected the bias to the microphone widget it defines?
> Unless your board says that the bias is in use on a given board it won't be enabled.
Thanks for this tip!
The problem is that the machine-driver mxs-sgtl5000 don't support audio-routing.
I've prepared a patch that will be submitted this noon.
Regards,
Christian
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [alsa-devel] [PATCH] ASoC: sgtl5000: fix powerup/down of micbias-voltage
2018-01-12 12:35 ` Fischer, Christian
@ 2018-01-13 0:05 ` Fabio Estevam
-1 siblings, 0 replies; 7+ messages in thread
From: Fabio Estevam @ 2018-01-13 0:05 UTC (permalink / raw)
To: Fischer, Christian
Cc: Mark Brown, alsa-devel, linux-kernel, tiwai, lgirdwood,
fabio.estevam, bhumirks, richard.leitner
Hi Christian,
On Fri, Jan 12, 2018 at 10:35 AM, Fischer, Christian
<fischerc@swissphone.de> wrote:
> Thanks for this tip!
> The problem is that the machine-driver mxs-sgtl5000 don't support audio-routing.
> I've prepared a patch that will be submitted this noon.
What about using simple audio card binding in your device tree instead?
You could pass the simple-audio-card,routing property as described in
Documentation/devicetree/bindings/sound/simple-card.txt
A dts where sgtl5000 is used with simple audio card is
arch/arm/boot/dts/imx7s-warp.dts.
This one does not use simple-audio-card,routing, but at least it gives
you a reference.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] ASoC: sgtl5000: fix powerup/down of micbias-voltage
@ 2018-01-13 0:05 ` Fabio Estevam
0 siblings, 0 replies; 7+ messages in thread
From: Fabio Estevam @ 2018-01-13 0:05 UTC (permalink / raw)
To: Fischer, Christian
Cc: alsa-devel, tiwai, lgirdwood, linux-kernel, Mark Brown,
fabio.estevam, bhumirks, richard.leitner
Hi Christian,
On Fri, Jan 12, 2018 at 10:35 AM, Fischer, Christian
<fischerc@swissphone.de> wrote:
> Thanks for this tip!
> The problem is that the machine-driver mxs-sgtl5000 don't support audio-routing.
> I've prepared a patch that will be submitted this noon.
What about using simple audio card binding in your device tree instead?
You could pass the simple-audio-card,routing property as described in
Documentation/devicetree/bindings/sound/simple-card.txt
A dts where sgtl5000 is used with simple audio card is
arch/arm/boot/dts/imx7s-warp.dts.
This one does not use simple-audio-card,routing, but at least it gives
you a reference.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [alsa-devel] [PATCH] ASoC: sgtl5000: fix powerup/down of micbias-voltage
2018-01-13 0:05 ` Fabio Estevam
(?)
@ 2018-01-13 0:10 ` Fabio Estevam
2018-01-13 9:50 ` Fischer, Christian
-1 siblings, 1 reply; 7+ messages in thread
From: Fabio Estevam @ 2018-01-13 0:10 UTC (permalink / raw)
To: Fischer, Christian
Cc: Mark Brown, alsa-devel, linux-kernel, tiwai, lgirdwood,
fabio.estevam, bhumirks, richard.leitner
On Fri, Jan 12, 2018 at 10:05 PM, Fabio Estevam <festevam@gmail.com> wrote:
> What about using simple audio card binding in your device tree instead?
>
> You could pass the simple-audio-card,routing property as described in
> Documentation/devicetree/bindings/sound/simple-card.txt
>
> A dts where sgtl5000 is used with simple audio card is
> arch/arm/boot/dts/imx7s-warp.dts.
>
> This one does not use simple-audio-card,routing, but at least it gives
> you a reference.
This one uses sgtl5000 with simple-audio-card,routing:
arch/arm/boot/dts/imx6ul-tx6ul.dtsi
Hope it helps.
^ permalink raw reply [flat|nested] 7+ messages in thread
* AW: [alsa-devel] [PATCH] ASoC: sgtl5000: fix powerup/down of micbias-voltage
2018-01-13 0:10 ` [alsa-devel] " Fabio Estevam
@ 2018-01-13 9:50 ` Fischer, Christian
0 siblings, 0 replies; 7+ messages in thread
From: Fischer, Christian @ 2018-01-13 9:50 UTC (permalink / raw)
To: Fabio Estevam
Cc: Mark Brown, alsa-devel, linux-kernel, tiwai, lgirdwood,
fabio.estevam, bhumirks, richard.leitner
>> What about using simple audio card binding in your device tree instead?
>>
>> You could pass the simple-audio-card,routing property as described in
>> Documentation/devicetree/bindings/sound/simple-card.txt
>>
>> A dts where sgtl5000 is used with simple audio card is
>> arch/arm/boot/dts/imx7s-warp.dts.
>>
>> This one does not use simple-audio-card,routing, but at least it gives
>> you a reference.
>
> This one uses sgtl5000 with simple-audio-card,routing:
> arch/arm/boot/dts/imx6ul-tx6ul.dtsi
>
> Hope it helps.
Hello Fabio,
you are right, a simple-audio-card would work too! Thanks!
I also applied a patch for mxs-sgtl5000 machine-driver that adds audio-routing support:
http://mailman.alsa-project.org/pipermail/alsa-devel/2018-January/130666.html
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] ASoC: sgtl5000: fix powerup/down of micbias-voltage
@ 2018-01-13 9:50 ` Fischer, Christian
0 siblings, 0 replies; 7+ messages in thread
From: Fischer, Christian @ 2018-01-13 9:50 UTC (permalink / raw)
To: Fabio Estevam
Cc: alsa-devel, tiwai, lgirdwood, linux-kernel, Mark Brown,
fabio.estevam, bhumirks, richard.leitner
>> What about using simple audio card binding in your device tree instead?
>>
>> You could pass the simple-audio-card,routing property as described in
>> Documentation/devicetree/bindings/sound/simple-card.txt
>>
>> A dts where sgtl5000 is used with simple audio card is
>> arch/arm/boot/dts/imx7s-warp.dts.
>>
>> This one does not use simple-audio-card,routing, but at least it gives
>> you a reference.
>
> This one uses sgtl5000 with simple-audio-card,routing:
> arch/arm/boot/dts/imx6ul-tx6ul.dtsi
>
> Hope it helps.
Hello Fabio,
you are right, a simple-audio-card would work too! Thanks!
I also applied a patch for mxs-sgtl5000 machine-driver that adds audio-routing support:
http://mailman.alsa-project.org/pipermail/alsa-devel/2018-January/130666.html
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2018-01-13 9:51 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-01-12 12:35 [PATCH] ASoC: sgtl5000: fix powerup/down of micbias-voltage Fischer, Christian
2018-01-12 12:35 ` Fischer, Christian
2018-01-13 0:05 ` [alsa-devel] " Fabio Estevam
2018-01-13 0:05 ` Fabio Estevam
2018-01-13 0:10 ` [alsa-devel] " Fabio Estevam
2018-01-13 9:50 ` AW: " Fischer, Christian
2018-01-13 9:50 ` Fischer, Christian
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.