[PATCH] arm: imx: parse-container: add some missing end of line

[PATCH] arm: imx: parse-container: add some missing end of line

[Clément Péron]

Some printf() have strings that doesn't terminate with end of line
and make the output hard to read.

Signed-off-by: Clément Péron <peron.clem@gmail.com>
---
 arch/arm/mach-imx/parse-container.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm/mach-imx/parse-container.c b/arch/arm/mach-imx/parse-container.c
index 039a4c7303..a4214d5376 100644
--- a/arch/arm/mach-imx/parse-container.c
+++ b/arch/arm/mach-imx/parse-container.c
@@ -142,12 +142,12 @@ static int read_auth_container(struct spl_image_info *spl_image,
 		return -EIO;
 
 	if (container->tag != 0x87 && container->version != 0x0) {
-		printf("Wrong container header");
+		printf("Wrong container header\n");
 		return -ENOENT;
 	}
 
 	if (!container->num_images) {
-		printf("Wrong container, no image found");
+		printf("Wrong container, no image found\n");
 		return -ENOENT;
 	}
 
-- 
2.32.0

Re: [PATCH] arm: imx: parse-container: add some missing end of line

[Fabio Estevam]

Hi Clément,

On Wed, Mar 30, 2022 at 8:49 AM Clément Péron <peron.clem@gmail.com> wrote:
>
> Some printf() have strings that doesn't terminate with end of line
> and make the output hard to read.
>
> Signed-off-by: Clément Péron <peron.clem@gmail.com>

Thanks for the patch:

Reviewed-by: Fabio Estevam <festevam@denx.de>

Re: [PATCH] arm: imx: parse-container: add some missing end of line

[Peng Fan (OSS)]

On 2022/3/30 19:49, Clément Péron wrote:
> Some printf() have strings that doesn't terminate with end of line
> and make the output hard to read.
> 
> Signed-off-by: Clément Péron <peron.clem@gmail.com>

Reviewed-by: Peng Fan <peng.fan@nxp.com>

> ---
>   arch/arm/mach-imx/parse-container.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/mach-imx/parse-container.c b/arch/arm/mach-imx/parse-container.c
> index 039a4c7303..a4214d5376 100644
> --- a/arch/arm/mach-imx/parse-container.c
> +++ b/arch/arm/mach-imx/parse-container.c
> @@ -142,12 +142,12 @@ static int read_auth_container(struct spl_image_info *spl_image,
>   		return -EIO;
>   
>   	if (container->tag != 0x87 && container->version != 0x0) {
> -		printf("Wrong container header");
> +		printf("Wrong container header\n");
>   		return -ENOENT;
>   	}
>   
>   	if (!container->num_images) {
> -		printf("Wrong container, no image found");
> +		printf("Wrong container, no image found\n");
>   		return -ENOENT;
>   	}
>   
> 

[PATCH] arm: imx: parse-container: add some missing end of line

[sbabic]

> Some printf() have strings that doesn't terminate with end of line
> and make the output hard to read.
> Signed-off-by: Clément Péron <peron.clem@gmail.com>
> Reviewed-by: Fabio Estevam <festevam@denx.de>
> Reviewed-by: Peng Fan <peng.fan@nxp.com>
Applied to u-boot-imx, master, thanks !

Best regards,
Stefano Babic

-- 
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic@denx.de
=====================================================================