[PATCH] imx6: Remove unneeded CONFIG_DM_MDIO

[PATCH] imx6: Remove unneeded CONFIG_DM_MDIO

[Fabio Estevam]

As explained in the CONFIG_DM_MDIO text inside drivers/net/Kconfig:

"Useful in particular for systems that support
DM_ETH and have a stand-alone MDIO hardware block shared by multiple
Ethernet interfaces."
 
i.MX6 has a single FEC instance, so there is no need to select
CONFIG_DM_MDIO.

Remove it from the i.MX6 defconfig files.

Signed-off-by: Fabio Estevam <festevam@gmail.com>
---
 configs/apalis_imx6_defconfig  | 1 -
 configs/colibri_imx6_defconfig | 1 -
 configs/dh_imx6_defconfig      | 1 -
 configs/mx6sabreauto_defconfig | 1 -
 configs/mx6sabresd_defconfig   | 1 -
 5 files changed, 5 deletions(-)

diff --git a/configs/apalis_imx6_defconfig b/configs/apalis_imx6_defconfig
index 34d939a0e9..e162f0a5e8 100644
--- a/configs/apalis_imx6_defconfig
+++ b/configs/apalis_imx6_defconfig
@@ -74,7 +74,6 @@ CONFIG_PHYLIB=y
 CONFIG_PHY_MICREL=y
 CONFIG_PHY_MICREL_KSZ90X1=y
 CONFIG_DM_ETH=y
-CONFIG_DM_MDIO=y
 CONFIG_FEC_MXC=y
 CONFIG_MII=y
 CONFIG_PINCTRL=y
diff --git a/configs/colibri_imx6_defconfig b/configs/colibri_imx6_defconfig
index 11cd1da26e..ffa773b581 100644
--- a/configs/colibri_imx6_defconfig
+++ b/configs/colibri_imx6_defconfig
@@ -73,7 +73,6 @@ CONFIG_PHYLIB=y
 CONFIG_PHY_MICREL=y
 CONFIG_PHY_MICREL_KSZ8XXX=y
 CONFIG_DM_ETH=y
-CONFIG_DM_MDIO=y
 CONFIG_FEC_MXC=y
 CONFIG_MII=y
 CONFIG_PINCTRL=y
diff --git a/configs/dh_imx6_defconfig b/configs/dh_imx6_defconfig
index d91ff77a4a..e643ade2e6 100644
--- a/configs/dh_imx6_defconfig
+++ b/configs/dh_imx6_defconfig
@@ -77,7 +77,6 @@ CONFIG_PHYLIB=y
 CONFIG_PHY_MICREL=y
 CONFIG_PHY_MICREL_KSZ90X1=y
 CONFIG_DM_ETH=y
-CONFIG_DM_MDIO=y
 CONFIG_FEC_MXC=y
 CONFIG_MII=y
 CONFIG_PINCTRL=y
diff --git a/configs/mx6sabreauto_defconfig b/configs/mx6sabreauto_defconfig
index 56fe307e63..106c967652 100644
--- a/configs/mx6sabreauto_defconfig
+++ b/configs/mx6sabreauto_defconfig
@@ -76,7 +76,6 @@ CONFIG_SPI_FLASH_STMICRO=y
 CONFIG_PHYLIB=y
 CONFIG_PHY_ATHEROS=y
 CONFIG_DM_ETH=y
-CONFIG_DM_MDIO=y
 CONFIG_FEC_MXC=y
 CONFIG_RGMII=y
 CONFIG_MII=y
diff --git a/configs/mx6sabresd_defconfig b/configs/mx6sabresd_defconfig
index 24bc8630f1..f88c629fbf 100644
--- a/configs/mx6sabresd_defconfig
+++ b/configs/mx6sabresd_defconfig
@@ -83,7 +83,6 @@ CONFIG_SPI_FLASH_STMICRO=y
 CONFIG_PHYLIB=y
 CONFIG_PHY_ATHEROS=y
 CONFIG_DM_ETH=y
-CONFIG_DM_MDIO=y
 CONFIG_FEC_MXC=y
 CONFIG_RGMII=y
 CONFIG_MII=y
-- 
2.17.1

[PATCH] imx6: Remove unneeded CONFIG_DM_MDIO

[Stefano Babic]

Hi Fabio,

On 13.07.20 16:59, Fabio Estevam wrote:
> As explained in the CONFIG_DM_MDIO text inside drivers/net/Kconfig:
> 
> "Useful in particular for systems that support
> DM_ETH and have a stand-alone MDIO hardware block shared by multiple
> Ethernet interfaces."
>  
> i.MX6 has a single FEC instance, so there is no need to select
> CONFIG_DM_MDIO.
> 
> Remove it from the i.MX6 defconfig files.
> 

This has a side-effect because it breaks mx6memcal. I propose to let
this in and to fix mx6memcal as follows:


diff --git a/configs/mx6memcal_defconfig b/configs/mx6memcal_defconfig
index 57e44a14ba..01a0fff6e0 100644
--- a/configs/mx6memcal_defconfig
+++ b/configs/mx6memcal_defconfig
@@ -39,6 +39,7 @@ CONFIG_SYS_MEMTEST_END=0x20000000
 CONFIG_CMD_CACHE=y
 CONFIG_SYS_RELOC_GD_ENV_ADDR=y
 # CONFIG_NET is not set
+CONFIG_DM=y
 # CONFIG_MMC is not set
 CONFIG_FSL_USDHC=y
 CONFIG_USB=y
@@ -47,4 +48,5 @@ CONFIG_USB_GADGET_MANUFACTURER="FSL"
 CONFIG_USB_GADGET_VENDOR_NUM=0x0525
 CONFIG_USB_GADGET_PRODUCT_NUM=0xa4a5
 CONFIG_CI_UDC=y
-CONFIG_REGEX=y
+CONFIG_OF_LIBFDT=y
+# CONFIG_EFI_LOADER is not set

(I will send afterwards a proper patch).

What do you think ?

Stefano

> Signed-off-by: Fabio Estevam <festevam@gmail.com>
> ---
>  configs/apalis_imx6_defconfig  | 1 -
>  configs/colibri_imx6_defconfig | 1 -
>  configs/dh_imx6_defconfig      | 1 -
>  configs/mx6sabreauto_defconfig | 1 -
>  configs/mx6sabresd_defconfig   | 1 -
>  5 files changed, 5 deletions(-)
> 
> diff --git a/configs/apalis_imx6_defconfig b/configs/apalis_imx6_defconfig
> index 34d939a0e9..e162f0a5e8 100644
> --- a/configs/apalis_imx6_defconfig
> +++ b/configs/apalis_imx6_defconfig
> @@ -74,7 +74,6 @@ CONFIG_PHYLIB=y
>  CONFIG_PHY_MICREL=y
>  CONFIG_PHY_MICREL_KSZ90X1=y
>  CONFIG_DM_ETH=y
> -CONFIG_DM_MDIO=y
>  CONFIG_FEC_MXC=y
>  CONFIG_MII=y
>  CONFIG_PINCTRL=y
> diff --git a/configs/colibri_imx6_defconfig b/configs/colibri_imx6_defconfig
> index 11cd1da26e..ffa773b581 100644
> --- a/configs/colibri_imx6_defconfig
> +++ b/configs/colibri_imx6_defconfig
> @@ -73,7 +73,6 @@ CONFIG_PHYLIB=y
>  CONFIG_PHY_MICREL=y
>  CONFIG_PHY_MICREL_KSZ8XXX=y
>  CONFIG_DM_ETH=y
> -CONFIG_DM_MDIO=y
>  CONFIG_FEC_MXC=y
>  CONFIG_MII=y
>  CONFIG_PINCTRL=y
> diff --git a/configs/dh_imx6_defconfig b/configs/dh_imx6_defconfig
> index d91ff77a4a..e643ade2e6 100644
> --- a/configs/dh_imx6_defconfig
> +++ b/configs/dh_imx6_defconfig
> @@ -77,7 +77,6 @@ CONFIG_PHYLIB=y
>  CONFIG_PHY_MICREL=y
>  CONFIG_PHY_MICREL_KSZ90X1=y
>  CONFIG_DM_ETH=y
> -CONFIG_DM_MDIO=y
>  CONFIG_FEC_MXC=y
>  CONFIG_MII=y
>  CONFIG_PINCTRL=y
> diff --git a/configs/mx6sabreauto_defconfig b/configs/mx6sabreauto_defconfig
> index 56fe307e63..106c967652 100644
> --- a/configs/mx6sabreauto_defconfig
> +++ b/configs/mx6sabreauto_defconfig
> @@ -76,7 +76,6 @@ CONFIG_SPI_FLASH_STMICRO=y
>  CONFIG_PHYLIB=y
>  CONFIG_PHY_ATHEROS=y
>  CONFIG_DM_ETH=y
> -CONFIG_DM_MDIO=y
>  CONFIG_FEC_MXC=y
>  CONFIG_RGMII=y
>  CONFIG_MII=y
> diff --git a/configs/mx6sabresd_defconfig b/configs/mx6sabresd_defconfig
> index 24bc8630f1..f88c629fbf 100644
> --- a/configs/mx6sabresd_defconfig
> +++ b/configs/mx6sabresd_defconfig
> @@ -83,7 +83,6 @@ CONFIG_SPI_FLASH_STMICRO=y
>  CONFIG_PHYLIB=y
>  CONFIG_PHY_ATHEROS=y
>  CONFIG_DM_ETH=y
> -CONFIG_DM_MDIO=y
>  CONFIG_FEC_MXC=y
>  CONFIG_RGMII=y
>  CONFIG_MII=y
> 


-- 
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================

[PATCH] imx6: Remove unneeded CONFIG_DM_MDIO

[Fabio Estevam]

Hi Stefano,

On Thu, Jul 16, 2020 at 9:05 AM Stefano Babic <sbabic@denx.de> wrote:

> This has a side-effect because it breaks mx6memcal. I propose to let
> this in and to fix mx6memcal as follows:

I was not able to reproduce the build break on mx6memcal_defconfig here.

Just applied the patch against U-Boot master and mx6memcal_defconfig built fine.

Could you please share the build error log?

This patch does not touch mx6memcal, so not sure how it breaks it.

Thanks

[PATCH] imx6: Remove unneeded CONFIG_DM_MDIO

[Stefano Babic]

On 16.07.20 14:18, Fabio Estevam wrote:
> Hi Stefano,
> 
> On Thu, Jul 16, 2020 at 9:05 AM Stefano Babic <sbabic@denx.de> wrote:
> 
>> This has a side-effect because it breaks mx6memcal. I propose to let
>> this in and to fix mx6memcal as follows:
> 
> I was not able to reproduce the build break on mx6memcal_defconfig here.
> 
> Just applied the patch against U-Boot master and mx6memcal_defconfig built fine.
> 
> Could you please share the build error log?
> 
> This patch does not touch mx6memcal, so not sure how it breaks it.

Right - it looks like that CONFIG_DM is removed at all from mx6memcal,
removing an implicit OF_LIBFDT.

https://travis-ci.org/github/sbabic/u-boot-imx/jobs/708667322

Stefano

-- 
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================

[PATCH] imx6: Remove unneeded CONFIG_DM_MDIO

[Fabio Estevam]

Hi Stefano,

On Thu, Jul 16, 2020 at 9:26 AM Stefano Babic <sbabic@denx.de> wrote:

> Right - it looks like that CONFIG_DM is removed at all from mx6memcal,
> removing an implicit OF_LIBFDT.
>
> https://travis-ci.org/github/sbabic/u-boot-imx/jobs/708667322

I think your proposed patch makes sense.

I have compared the .config file generated from mx6memcal_defconfig
before and after my patch and they are identical.

Thanks

[PATCH] imx6: Remove unneeded CONFIG_DM_MDIO

[Stefano Babic]

On 16.07.20 15:03, Fabio Estevam wrote:
> Hi Stefano,
> 
> On Thu, Jul 16, 2020 at 9:26 AM Stefano Babic <sbabic@denx.de> wrote:
> 
>> Right - it looks like that CONFIG_DM is removed at all from mx6memcal,
>> removing an implicit OF_LIBFDT.
>>
>> https://travis-ci.org/github/sbabic/u-boot-imx/jobs/708667322
> 
> I think your proposed patch makes sense.
> 
> I have compared the .config file generated from mx6memcal_defconfig
> before and after my patch and they are identical.

I do not think the issue is caused by your patch - it is like a side
effect and implicitely some CONFIG_ are turned off for memcal.

I send a formal patch.

Regards,
Stefano



-- 
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================

[PATCH] imx6: Remove unneeded CONFIG_DM_MDIO

[sbabic at denx.de]

> As explained in the CONFIG_DM_MDIO text inside drivers/net/Kconfig:
> "Useful in particular for systems that support
> DM_ETH and have a stand-alone MDIO hardware block shared by multiple
> Ethernet interfaces."
>  
> i.MX6 has a single FEC instance, so there is no need to select
> CONFIG_DM_MDIO.
> Remove it from the i.MX6 defconfig files.
> Signed-off-by: Fabio Estevam <festevam@gmail.com>
Applied to u-boot-imx, master, thanks !

Best regards,
Stefano Babic

-- 
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================