All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ARM: dts: imx7d-nitrogen7: Fix the description of the Wifi clock
@ 2018-11-30  1:47 Fabio Estevam
  2018-12-02 19:09 ` Gary Bisson
  0 siblings, 1 reply; 4+ messages in thread
From: Fabio Estevam @ 2018-11-30  1:47 UTC (permalink / raw)
  To: shawnguo; +Cc: gary.bisson, Fabio Estevam, linux-arm-kernel, troy.kisky

According to bindings/regulator/fixed-regulator.txt the 'clocks' and
'clock-names' properties are not valid ones.

In order to turn on the Wifi clock the correct location for describing
the CLKO2 clock is via a mmc-pwrseq handle, so do it accordingly.

Fixes: 56354959cfec ("ARM: dts: imx: add Boundary Devices Nitrogen7 board")
Signed-off-by: Fabio Estevam <festevam@gmail.com>
Acked-by: Troy Kisky <troy.kisky@boundarydevices.com>
---
 arch/arm/boot/dts/imx7d-nitrogen7.dts | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/arch/arm/boot/dts/imx7d-nitrogen7.dts b/arch/arm/boot/dts/imx7d-nitrogen7.dts
index 4fb7e84..9ba9084 100644
--- a/arch/arm/boot/dts/imx7d-nitrogen7.dts
+++ b/arch/arm/boot/dts/imx7d-nitrogen7.dts
@@ -87,13 +87,17 @@
 		compatible = "regulator-fixed";
 		regulator-min-microvolt = <3300000>;
 		regulator-max-microvolt = <3300000>;
-		clocks = <&clks IMX7D_CLKO2_ROOT_DIV>;
-		clock-names = "slow";
 		regulator-name = "reg_wlan";
 		startup-delay-us = <70000>;
 		gpio = <&gpio4 21 GPIO_ACTIVE_HIGH>;
 		enable-active-high;
 	};
+
+	usdhc2_pwrseq: usdhc2_pwrseq {
+		compatible = "mmc-pwrseq-simple";
+		clocks = <&clks IMX7D_CLKO2_ROOT_DIV>;
+		clock-names = "slow";
+	};
 };
 
 &adc1 {
@@ -376,6 +380,7 @@
 	bus-width = <4>;
 	non-removable;
 	vmmc-supply = <&reg_wlan>;
+	mmc-pwrseq = <&usdhc2_pwrseq>;
 	cap-power-off-card;
 	keep-power-in-suspend;
 	status = "okay";
-- 
2.7.4


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 4+ messages in thread
* Re: [PATCH] ARM: dts: imx7d-nitrogen7: Fix the description of the Wifi clock
  2018-11-30  1:47 [PATCH] ARM: dts: imx7d-nitrogen7: Fix the description of the Wifi clock Fabio Estevam
@ 2018-12-02 19:09 ` Gary Bisson
  2018-12-02 20:42   ` Fabio Estevam
  0 siblings, 1 reply; 4+ messages in thread
From: Gary Bisson @ 2018-12-02 19:09 UTC (permalink / raw)
  To: Fabio Estevam; +Cc: Shawn Guo, linux-arm-kernel, Troy Kisky

Hi,

On Fri, Nov 30, 2018 at 2:48 AM Fabio Estevam <festevam@gmail.com> wrote:
>
> According to bindings/regulator/fixed-regulator.txt the 'clocks' and
> 'clock-names' properties are not valid ones.
>
> In order to turn on the Wifi clock the correct location for describing
> the CLKO2 clock is via a mmc-pwrseq handle, so do it accordingly.
>
> Fixes: 56354959cfec ("ARM: dts: imx: add Boundary Devices Nitrogen7 board")
> Signed-off-by: Fabio Estevam <festevam@gmail.com>
> Acked-by: Troy Kisky <troy.kisky@boundarydevices.com>
> ---
>  arch/arm/boot/dts/imx7d-nitrogen7.dts | 9 +++++++--
>  1 file changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/imx7d-nitrogen7.dts b/arch/arm/boot/dts/imx7d-nitrogen7.dts
> index 4fb7e84..9ba9084 100644
> --- a/arch/arm/boot/dts/imx7d-nitrogen7.dts
> +++ b/arch/arm/boot/dts/imx7d-nitrogen7.dts
> @@ -87,13 +87,17 @@
>                 compatible = "regulator-fixed";
>                 regulator-min-microvolt = <3300000>;
>                 regulator-max-microvolt = <3300000>;
> -               clocks = <&clks IMX7D_CLKO2_ROOT_DIV>;
> -               clock-names = "slow";
>                 regulator-name = "reg_wlan";
>                 startup-delay-us = <70000>;
>                 gpio = <&gpio4 21 GPIO_ACTIVE_HIGH>;
>                 enable-active-high;
>         };

Actually the whole regulator should be changed into a pwrseq as it is
really a WL_EN signal.

> +
> +       usdhc2_pwrseq: usdhc2_pwrseq {
> +               compatible = "mmc-pwrseq-simple";
> +               clocks = <&clks IMX7D_CLKO2_ROOT_DIV>;
> +               clock-names = "slow";

Shouldn't the name be "ext_clock"?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/mmc/core/pwrseq_simple.c#n121

Regards,
Gary

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH] ARM: dts: imx7d-nitrogen7: Fix the description of the Wifi clock
  2018-12-02 19:09 ` Gary Bisson
@ 2018-12-02 20:42   ` Fabio Estevam
  2018-12-05  4:10     ` Shawn Guo
  0 siblings, 1 reply; 4+ messages in thread
From: Fabio Estevam @ 2018-12-02 20:42 UTC (permalink / raw)
  To: Gary Bisson
  Cc: Shawn Guo,
	moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
	Troy Kisky

Hi Gary,

On Sun, Dec 2, 2018 at 5:09 PM Gary Bisson
<gary.bisson@boundarydevices.com> wrote:

> Actually the whole regulator should be changed into a pwrseq as it is
> really a WL_EN signal.

Documentation/devicetree/bindings/mmc/mmc-pwrseq-simple.txt only lists
a 'reset-gpios' entry, so it seems this should stays as regulator.

> > +
> > +       usdhc2_pwrseq: usdhc2_pwrseq {
> > +               compatible = "mmc-pwrseq-simple";
> > +               clocks = <&clks IMX7D_CLKO2_ROOT_DIV>;
> > +               clock-names = "slow";
>
> Shouldn't the name be "ext_clock"?

Yes, you are correct.

If you agree that we should keep the regulator as is, then I can send a v2.

Thanks

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH] ARM: dts: imx7d-nitrogen7: Fix the description of the Wifi clock
  2018-12-02 20:42   ` Fabio Estevam
@ 2018-12-05  4:10     ` Shawn Guo
  0 siblings, 0 replies; 4+ messages in thread
From: Shawn Guo @ 2018-12-05  4:10 UTC (permalink / raw)
  To: Fabio Estevam
  Cc: Gary Bisson,
	moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
	Troy Kisky

On Sun, Dec 02, 2018 at 06:42:08PM -0200, Fabio Estevam wrote:
> Hi Gary,
> 
> On Sun, Dec 2, 2018 at 5:09 PM Gary Bisson
> <gary.bisson@boundarydevices.com> wrote:
> 
> > Actually the whole regulator should be changed into a pwrseq as it is
> > really a WL_EN signal.
> 
> Documentation/devicetree/bindings/mmc/mmc-pwrseq-simple.txt only lists
> a 'reset-gpios' entry, so it seems this should stays as regulator.
> 
> > > +
> > > +       usdhc2_pwrseq: usdhc2_pwrseq {
> > > +               compatible = "mmc-pwrseq-simple";
> > > +               clocks = <&clks IMX7D_CLKO2_ROOT_DIV>;
> > > +               clock-names = "slow";
> >
> > Shouldn't the name be "ext_clock"?
> 
> Yes, you are correct.
> 
> If you agree that we should keep the regulator as is, then I can send a v2.

Okay, dropped RFC patch and waiting for new version.

Shawn

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-12-05  4:11 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-11-30  1:47 [PATCH] ARM: dts: imx7d-nitrogen7: Fix the description of the Wifi clock Fabio Estevam
2018-12-02 19:09 ` Gary Bisson
2018-12-02 20:42   ` Fabio Estevam
2018-12-05  4:10     ` Shawn Guo

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.