All of lore.kernel.org
 help / color / mirror / Atom feed
From: Fabio Estevam <festevam@gmail.com>
To: Marek Vasut <marex@denx.de>
Cc: "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE"
	<linux-arm-kernel@lists.infradead.org>,
	Shawn Guo <shawnguo@kernel.org>,
	 NXP Linux Team <linux-imx@nxp.com>
Subject: Re: [PATCH] ARM: dts: imx: Fix USB host power regulator polarity on M53Menlo
Date: Sun, 5 Sep 2021 09:00:46 -0300	[thread overview]
Message-ID: <CAOMZO5DEqLLt29UOsB1TH6N15ufH4+qb7WuJJaW6HED61Q4Nzw@mail.gmail.com> (raw)
In-Reply-To: <92d00e82-737b-7380-00aa-fb49656ff8e7@denx.de>

Hi Marek,

On Sat, Sep 4, 2021 at 11:57 PM Marek Vasut <marex@denx.de> wrote:

> No, the GPIO flags are ignored by gpiolib-of and the signal is active
> low. That's why there is that zero, no flags, and no enable-active-high
> property.

Yes, correct. The GPIO flag is ignored by "regulator-fixed".

As you removed the 'enable-active-high' property, you turned the
regulator to active low as needed.

This is correct.

gpio = <&gpio1 2 0> is the same as gpio = <&gpio1 2 GPIO_ACTIVE_HIGH>

I just suggested gpio = <&gpio1 2 GPIO_ACTIVE_LOW> to make it clearer
what is the real polarity.

The GPIO flag is ignored, I know. No issues if you want to keep it as
gpio = <&gpio1 2 0>.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2021-09-05 12:03 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-05  0:01 [PATCH] ARM: dts: imx: Fix USB host power regulator polarity on M53Menlo Marek Vasut
2021-09-05  0:49 ` Fabio Estevam
2021-09-05  2:57   ` Marek Vasut
2021-09-05 12:00     ` Fabio Estevam [this message]
2021-09-05 14:35       ` Marek Vasut
2021-09-05 13:03 ` Fabio Estevam
2021-09-22  8:14 ` Shawn Guo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAOMZO5DEqLLt29UOsB1TH6N15ufH4+qb7WuJJaW6HED61Q4Nzw@mail.gmail.com \
    --to=festevam@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-imx@nxp.com \
    --cc=marex@denx.de \
    --cc=shawnguo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.