All of lore.kernel.org
 help / color / mirror / Atom feed
From: Fabio Estevam <festevam@gmail.com>
To: Marek Vasut <marex@denx.de>
Cc: "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE"
	<linux-arm-kernel@lists.infradead.org>,
	Shawn Guo <shawnguo@kernel.org>,
	 NXP Linux Team <linux-imx@nxp.com>
Subject: Re: [PATCH] ARM: dts: imx: Fix USB host power regulator polarity on M53Menlo
Date: Sat, 4 Sep 2021 21:49:14 -0300	[thread overview]
Message-ID: <CAOMZO5DsSUdM8v6L6v+t-EAuKYfTHWx6F+gqbEVpAtQL8bb4iA@mail.gmail.com> (raw)
In-Reply-To: <20210905000137.95438-1-marex@denx.de>

Hi Marek,

On Sat, Sep 4, 2021 at 9:01 PM Marek Vasut <marex@denx.de> wrote:
>
> The MIC2025 switch input signal nEN is active low, describe it as such
> in the DT. The previous change to this regulator polarity was incorrectly
> influenced by broken quirks in gpiolib-of.c, which is now long fixed. So
> fix this regulator polarity setting here once and for all.
>
> Fixes: 3c3601cd6a6d3 ("ARM: dts: imx53: Update USB configuration on M53Menlo")
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Shawn Guo <shawnguo@kernel.org>
> Cc: Fabio Estevam <festevam@gmail.com>
> Cc: NXP Linux Team <linux-imx@nxp.com>
> ---
>  arch/arm/boot/dts/imx53-m53menlo.dts | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/imx53-m53menlo.dts b/arch/arm/boot/dts/imx53-m53menlo.dts
> index 48adcfd32cea9..4f88e96d81ddb 100644
> --- a/arch/arm/boot/dts/imx53-m53menlo.dts
> +++ b/arch/arm/boot/dts/imx53-m53menlo.dts
> @@ -77,8 +77,7 @@ reg_usbh1_vbus: regulator-usbh1-vbus {
>                 regulator-name = "vbus";
>                 regulator-min-microvolt = <5000000>;
>                 regulator-max-microvolt = <5000000>;
> -               gpio = <&gpio1 2 GPIO_ACTIVE_HIGH>;
> -               enable-active-high;
> +               gpio = <&gpio1 2 0>;

Don't you mean: gpio = <&gpio1 2 GPIO_ACTIVE_LOW> here?

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2021-09-05  0:50 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-05  0:01 [PATCH] ARM: dts: imx: Fix USB host power regulator polarity on M53Menlo Marek Vasut
2021-09-05  0:49 ` Fabio Estevam [this message]
2021-09-05  2:57   ` Marek Vasut
2021-09-05 12:00     ` Fabio Estevam
2021-09-05 14:35       ` Marek Vasut
2021-09-05 13:03 ` Fabio Estevam
2021-09-22  8:14 ` Shawn Guo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAOMZO5DsSUdM8v6L6v+t-EAuKYfTHWx6F+gqbEVpAtQL8bb4iA@mail.gmail.com \
    --to=festevam@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-imx@nxp.com \
    --cc=marex@denx.de \
    --cc=shawnguo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.