All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v2] ARM: dts: imx6qdl-wandboard: enable USB OTG
@ 2017-07-23 16:49 ` Alexander Kurz
  0 siblings, 0 replies; 6+ messages in thread
From: Alexander Kurz @ 2017-07-23 16:49 UTC (permalink / raw)
  To: Fabio Estevam; +Cc: devicetree, Alexander Kurz, linux-arm-kernel

Enable USB OTG (dual-role) on the Wandboard.
Note, that the USB_OTG_VBUS current is quite limited due to a 22R resistor
in the power line. Hence, the overcurrent signal of 1A will never be
triggered on this board.

Signed-off-by: Alexander Kurz <akurz@blala.de>
---
 arch/arm/boot/dts/imx6qdl-wandboard.dtsi | 19 ++++++++++++++++++-
 1 file changed, 18 insertions(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/imx6qdl-wandboard.dtsi b/arch/arm/boot/dts/imx6qdl-wandboard.dtsi
index b4fa7f1..f1abde8 100644
--- a/arch/arm/boot/dts/imx6qdl-wandboard.dtsi
+++ b/arch/arm/boot/dts/imx6qdl-wandboard.dtsi
@@ -34,6 +34,16 @@
 			regulator-max-microvolt = <3300000>;
 			regulator-always-on;
 		};
+
+		reg_usb_otg_vbus: usb_otg_vbus {
+			compatible = "regulator-fixed";
+			regulator-name = "usb_otg_vbus";
+			regulator-min-microvolt = <5000000>;
+			regulator-max-microvolt = <5000000>;
+			pinctrl-names = "default";
+			pinctrl-0 = <&pinctrl_usbotgvbus>;
+			gpio = <&gpio3 22 GPIO_ACTIVE_LOW>;
+		};
 	};
 
 	sound {
@@ -170,6 +180,12 @@
 			>;
 		};
 
+		pinctrl_usbotgvbus: usbotgvbusgrp {
+			fsl,pins = <
+				MX6QDL_PAD_EIM_D22__GPIO3_IO22		0x130b0
+			>;
+		};
+
 		pinctrl_usdhc1: usdhc1grp {
 			fsl,pins = <
 				MX6QDL_PAD_SD1_CMD__SD1_CMD		0x17059
@@ -244,10 +260,11 @@
 };
 
 &usbotg {
+	vbus-supply = <&reg_usb_otg_vbus>;
 	pinctrl-names = "default";
 	pinctrl-0 = <&pinctrl_usbotg>;
 	disable-over-current;
-	dr_mode = "peripheral";
+	dr_mode = "otg";
 	status = "okay";
 };
 
-- 
2.1.4

^ permalink raw reply related	[flat|nested] 6+ messages in thread
* [PATCH v2] ARM: dts: imx6qdl-wandboard: enable USB OTG
@ 2017-07-23 16:49 ` Alexander Kurz
  0 siblings, 0 replies; 6+ messages in thread
From: Alexander Kurz @ 2017-07-23 16:49 UTC (permalink / raw)
  To: linux-arm-kernel

Enable USB OTG (dual-role) on the Wandboard.
Note, that the USB_OTG_VBUS current is quite limited due to a 22R resistor
in the power line. Hence, the overcurrent signal of 1A will never be
triggered on this board.

Signed-off-by: Alexander Kurz <akurz@blala.de>
---
 arch/arm/boot/dts/imx6qdl-wandboard.dtsi | 19 ++++++++++++++++++-
 1 file changed, 18 insertions(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/imx6qdl-wandboard.dtsi b/arch/arm/boot/dts/imx6qdl-wandboard.dtsi
index b4fa7f1..f1abde8 100644
--- a/arch/arm/boot/dts/imx6qdl-wandboard.dtsi
+++ b/arch/arm/boot/dts/imx6qdl-wandboard.dtsi
@@ -34,6 +34,16 @@
 			regulator-max-microvolt = <3300000>;
 			regulator-always-on;
 		};
+
+		reg_usb_otg_vbus: usb_otg_vbus {
+			compatible = "regulator-fixed";
+			regulator-name = "usb_otg_vbus";
+			regulator-min-microvolt = <5000000>;
+			regulator-max-microvolt = <5000000>;
+			pinctrl-names = "default";
+			pinctrl-0 = <&pinctrl_usbotgvbus>;
+			gpio = <&gpio3 22 GPIO_ACTIVE_LOW>;
+		};
 	};
 
 	sound {
@@ -170,6 +180,12 @@
 			>;
 		};
 
+		pinctrl_usbotgvbus: usbotgvbusgrp {
+			fsl,pins = <
+				MX6QDL_PAD_EIM_D22__GPIO3_IO22		0x130b0
+			>;
+		};
+
 		pinctrl_usdhc1: usdhc1grp {
 			fsl,pins = <
 				MX6QDL_PAD_SD1_CMD__SD1_CMD		0x17059
@@ -244,10 +260,11 @@
 };
 
 &usbotg {
+	vbus-supply = <&reg_usb_otg_vbus>;
 	pinctrl-names = "default";
 	pinctrl-0 = <&pinctrl_usbotg>;
 	disable-over-current;
-	dr_mode = "peripheral";
+	dr_mode = "otg";
 	status = "okay";
 };
 
-- 
2.1.4

^ permalink raw reply related	[flat|nested] 6+ messages in thread
* Re: [PATCH v2] ARM: dts: imx6qdl-wandboard: enable USB OTG
  2017-07-23 16:49 ` Alexander Kurz
@ 2017-07-23 20:29     ` Fabio Estevam
  -1 siblings, 0 replies; 6+ messages in thread
From: Fabio Estevam @ 2017-07-23 20:29 UTC (permalink / raw)
  To: Alexander Kurz, Shawn Guo
  Cc: Fabio Estevam, devicetree-u79uwXL29TY76Z2rM5mHXA,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r

[Adding Shawn]

On Sun, Jul 23, 2017 at 1:49 PM, Alexander Kurz <akurz-3EoFODjbY6Q@public.gmane.org> wrote:
> Enable USB OTG (dual-role) on the Wandboard.
> Note, that the USB_OTG_VBUS current is quite limited due to a 22R resistor
> in the power line. Hence, the overcurrent signal of 1A will never be
> triggered on this board.
>
> Signed-off-by: Alexander Kurz <akurz-3EoFODjbY6Q@public.gmane.org>

Reviewed-by: Fabio Estevam <fabio.estevam-3arQi8VN3Tc@public.gmane.org>

> ---
>  arch/arm/boot/dts/imx6qdl-wandboard.dtsi | 19 ++++++++++++++++++-
>  1 file changed, 18 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/imx6qdl-wandboard.dtsi b/arch/arm/boot/dts/imx6qdl-wandboard.dtsi
> index b4fa7f1..f1abde8 100644
> --- a/arch/arm/boot/dts/imx6qdl-wandboard.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl-wandboard.dtsi
> @@ -34,6 +34,16 @@
>                         regulator-max-microvolt = <3300000>;
>                         regulator-always-on;
>                 };
> +
> +               reg_usb_otg_vbus: usb_otg_vbus {
> +                       compatible = "regulator-fixed";
> +                       regulator-name = "usb_otg_vbus";
> +                       regulator-min-microvolt = <5000000>;
> +                       regulator-max-microvolt = <5000000>;
> +                       pinctrl-names = "default";
> +                       pinctrl-0 = <&pinctrl_usbotgvbus>;
> +                       gpio = <&gpio3 22 GPIO_ACTIVE_LOW>;
> +               };
>         };
>
>         sound {
> @@ -170,6 +180,12 @@
>                         >;
>                 };
>
> +               pinctrl_usbotgvbus: usbotgvbusgrp {
> +                       fsl,pins = <
> +                               MX6QDL_PAD_EIM_D22__GPIO3_IO22          0x130b0
> +                       >;
> +               };
> +
>                 pinctrl_usdhc1: usdhc1grp {
>                         fsl,pins = <
>                                 MX6QDL_PAD_SD1_CMD__SD1_CMD             0x17059
> @@ -244,10 +260,11 @@
>  };
>
>  &usbotg {
> +       vbus-supply = <&reg_usb_otg_vbus>;
>         pinctrl-names = "default";
>         pinctrl-0 = <&pinctrl_usbotg>;
>         disable-over-current;
> -       dr_mode = "peripheral";
> +       dr_mode = "otg";
>         status = "okay";
>  };
>
> --
> 2.1.4
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 6+ messages in thread
* [PATCH v2] ARM: dts: imx6qdl-wandboard: enable USB OTG
@ 2017-07-23 20:29     ` Fabio Estevam
  0 siblings, 0 replies; 6+ messages in thread
From: Fabio Estevam @ 2017-07-23 20:29 UTC (permalink / raw)
  To: linux-arm-kernel

[Adding Shawn]

On Sun, Jul 23, 2017 at 1:49 PM, Alexander Kurz <akurz@blala.de> wrote:
> Enable USB OTG (dual-role) on the Wandboard.
> Note, that the USB_OTG_VBUS current is quite limited due to a 22R resistor
> in the power line. Hence, the overcurrent signal of 1A will never be
> triggered on this board.
>
> Signed-off-by: Alexander Kurz <akurz@blala.de>

Reviewed-by: Fabio Estevam <fabio.estevam@nxp.com>

> ---
>  arch/arm/boot/dts/imx6qdl-wandboard.dtsi | 19 ++++++++++++++++++-
>  1 file changed, 18 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/imx6qdl-wandboard.dtsi b/arch/arm/boot/dts/imx6qdl-wandboard.dtsi
> index b4fa7f1..f1abde8 100644
> --- a/arch/arm/boot/dts/imx6qdl-wandboard.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl-wandboard.dtsi
> @@ -34,6 +34,16 @@
>                         regulator-max-microvolt = <3300000>;
>                         regulator-always-on;
>                 };
> +
> +               reg_usb_otg_vbus: usb_otg_vbus {
> +                       compatible = "regulator-fixed";
> +                       regulator-name = "usb_otg_vbus";
> +                       regulator-min-microvolt = <5000000>;
> +                       regulator-max-microvolt = <5000000>;
> +                       pinctrl-names = "default";
> +                       pinctrl-0 = <&pinctrl_usbotgvbus>;
> +                       gpio = <&gpio3 22 GPIO_ACTIVE_LOW>;
> +               };
>         };
>
>         sound {
> @@ -170,6 +180,12 @@
>                         >;
>                 };
>
> +               pinctrl_usbotgvbus: usbotgvbusgrp {
> +                       fsl,pins = <
> +                               MX6QDL_PAD_EIM_D22__GPIO3_IO22          0x130b0
> +                       >;
> +               };
> +
>                 pinctrl_usdhc1: usdhc1grp {
>                         fsl,pins = <
>                                 MX6QDL_PAD_SD1_CMD__SD1_CMD             0x17059
> @@ -244,10 +260,11 @@
>  };
>
>  &usbotg {
> +       vbus-supply = <&reg_usb_otg_vbus>;
>         pinctrl-names = "default";
>         pinctrl-0 = <&pinctrl_usbotg>;
>         disable-over-current;
> -       dr_mode = "peripheral";
> +       dr_mode = "otg";
>         status = "okay";
>  };
>
> --
> 2.1.4
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH v2] ARM: dts: imx6qdl-wandboard: enable USB OTG
  2017-07-23 16:49 ` Alexander Kurz
@ 2017-07-26  2:36     ` Shawn Guo
  -1 siblings, 0 replies; 6+ messages in thread
From: Shawn Guo @ 2017-07-26  2:36 UTC (permalink / raw)
  To: Alexander Kurz
  Cc: Fabio Estevam, devicetree-u79uwXL29TY76Z2rM5mHXA,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r

On Sun, Jul 23, 2017 at 06:49:12PM +0200, Alexander Kurz wrote:
> Enable USB OTG (dual-role) on the Wandboard.
> Note, that the USB_OTG_VBUS current is quite limited due to a 22R resistor
> in the power line. Hence, the overcurrent signal of 1A will never be
> triggered on this board.
> 
> Signed-off-by: Alexander Kurz <akurz-3EoFODjbY6Q@public.gmane.org>
> ---

When sending a version, it's helpful to have a change log here.

>  arch/arm/boot/dts/imx6qdl-wandboard.dtsi | 19 ++++++++++++++++++-
>  1 file changed, 18 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/imx6qdl-wandboard.dtsi b/arch/arm/boot/dts/imx6qdl-wandboard.dtsi
> index b4fa7f1..f1abde8 100644
> --- a/arch/arm/boot/dts/imx6qdl-wandboard.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl-wandboard.dtsi
> @@ -34,6 +34,16 @@
>  			regulator-max-microvolt = <3300000>;
>  			regulator-always-on;
>  		};
> +
> +		reg_usb_otg_vbus: usb_otg_vbus {

You are trying to add a fixed regulator under regulators bus node
without sticking to the existing convention.  I understand that it's
now preferred to put fixed regulator node directly under root node, but
mixing two styles is not good either.

I suggest you order a patch to remove regulators bus node and name node
like below:

	reg_xxx: regulator-xxx {
		...
	};

And then add your changes on top of that.

Shawn

> +			compatible = "regulator-fixed";
> +			regulator-name = "usb_otg_vbus";
> +			regulator-min-microvolt = <5000000>;
> +			regulator-max-microvolt = <5000000>;
> +			pinctrl-names = "default";
> +			pinctrl-0 = <&pinctrl_usbotgvbus>;
> +			gpio = <&gpio3 22 GPIO_ACTIVE_LOW>;
> +		};
>  	};
>  
>  	sound {
> @@ -170,6 +180,12 @@
>  			>;
>  		};
>  
> +		pinctrl_usbotgvbus: usbotgvbusgrp {
> +			fsl,pins = <
> +				MX6QDL_PAD_EIM_D22__GPIO3_IO22		0x130b0
> +			>;
> +		};
> +
>  		pinctrl_usdhc1: usdhc1grp {
>  			fsl,pins = <
>  				MX6QDL_PAD_SD1_CMD__SD1_CMD		0x17059
> @@ -244,10 +260,11 @@
>  };
>  
>  &usbotg {
> +	vbus-supply = <&reg_usb_otg_vbus>;
>  	pinctrl-names = "default";
>  	pinctrl-0 = <&pinctrl_usbotg>;
>  	disable-over-current;
> -	dr_mode = "peripheral";
> +	dr_mode = "otg";
>  	status = "okay";
>  };
>  
> -- 
> 2.1.4
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 6+ messages in thread
* [PATCH v2] ARM: dts: imx6qdl-wandboard: enable USB OTG
@ 2017-07-26  2:36     ` Shawn Guo
  0 siblings, 0 replies; 6+ messages in thread
From: Shawn Guo @ 2017-07-26  2:36 UTC (permalink / raw)
  To: linux-arm-kernel

On Sun, Jul 23, 2017 at 06:49:12PM +0200, Alexander Kurz wrote:
> Enable USB OTG (dual-role) on the Wandboard.
> Note, that the USB_OTG_VBUS current is quite limited due to a 22R resistor
> in the power line. Hence, the overcurrent signal of 1A will never be
> triggered on this board.
> 
> Signed-off-by: Alexander Kurz <akurz@blala.de>
> ---

When sending a version, it's helpful to have a change log here.

>  arch/arm/boot/dts/imx6qdl-wandboard.dtsi | 19 ++++++++++++++++++-
>  1 file changed, 18 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/imx6qdl-wandboard.dtsi b/arch/arm/boot/dts/imx6qdl-wandboard.dtsi
> index b4fa7f1..f1abde8 100644
> --- a/arch/arm/boot/dts/imx6qdl-wandboard.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl-wandboard.dtsi
> @@ -34,6 +34,16 @@
>  			regulator-max-microvolt = <3300000>;
>  			regulator-always-on;
>  		};
> +
> +		reg_usb_otg_vbus: usb_otg_vbus {

You are trying to add a fixed regulator under regulators bus node
without sticking to the existing convention.  I understand that it's
now preferred to put fixed regulator node directly under root node, but
mixing two styles is not good either.

I suggest you order a patch to remove regulators bus node and name node
like below:

	reg_xxx: regulator-xxx {
		...
	};

And then add your changes on top of that.

Shawn

> +			compatible = "regulator-fixed";
> +			regulator-name = "usb_otg_vbus";
> +			regulator-min-microvolt = <5000000>;
> +			regulator-max-microvolt = <5000000>;
> +			pinctrl-names = "default";
> +			pinctrl-0 = <&pinctrl_usbotgvbus>;
> +			gpio = <&gpio3 22 GPIO_ACTIVE_LOW>;
> +		};
>  	};
>  
>  	sound {
> @@ -170,6 +180,12 @@
>  			>;
>  		};
>  
> +		pinctrl_usbotgvbus: usbotgvbusgrp {
> +			fsl,pins = <
> +				MX6QDL_PAD_EIM_D22__GPIO3_IO22		0x130b0
> +			>;
> +		};
> +
>  		pinctrl_usdhc1: usdhc1grp {
>  			fsl,pins = <
>  				MX6QDL_PAD_SD1_CMD__SD1_CMD		0x17059
> @@ -244,10 +260,11 @@
>  };
>  
>  &usbotg {
> +	vbus-supply = <&reg_usb_otg_vbus>;
>  	pinctrl-names = "default";
>  	pinctrl-0 = <&pinctrl_usbotg>;
>  	disable-over-current;
> -	dr_mode = "peripheral";
> +	dr_mode = "otg";
>  	status = "okay";
>  };
>  
> -- 
> 2.1.4
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-07-26  2:36 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-07-23 16:49 [PATCH v2] ARM: dts: imx6qdl-wandboard: enable USB OTG Alexander Kurz
2017-07-23 16:49 ` Alexander Kurz
     [not found] ` <1500828552-16237-1-git-send-email-akurz-3EoFODjbY6Q@public.gmane.org>
2017-07-23 20:29   ` Fabio Estevam
2017-07-23 20:29     ` Fabio Estevam
2017-07-26  2:36   ` Shawn Guo
2017-07-26  2:36     ` Shawn Guo

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.