[Buildroot] [PATCH v2] uboot-tools: bump to version 2017.09

[Buildroot] [PATCH v2] uboot-tools: bump to version 2017.09

[Fabio Estevam]

The 'env' target has been renamed to 'envtools' so change it
accordingly.

Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
---
Changes since v1:
- Take the 'env' target rename into account

 package/uboot-tools/uboot-tools.hash | 2 +-
 package/uboot-tools/uboot-tools.mk   | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/package/uboot-tools/uboot-tools.hash b/package/uboot-tools/uboot-tools.hash
index 3ba8e34..82efc79 100644
--- a/package/uboot-tools/uboot-tools.hash
+++ b/package/uboot-tools/uboot-tools.hash
@@ -1,2 +1,2 @@
 # Locally computed:
-sha256  5374bfdc8acb9a38c025371b1ff20f45e7533668e84e685d0df5d9e7c0e4feff  u-boot-2017.07.tar.bz2
+sha256  b2d15f2cf5f72e706025cde73d67247c6da8cd35f7e10891eefe7d9095089744  u-boot-2017.09.tar.bz2
diff --git a/package/uboot-tools/uboot-tools.mk b/package/uboot-tools/uboot-tools.mk
index 4f39f4a..c936575 100644
--- a/package/uboot-tools/uboot-tools.mk
+++ b/package/uboot-tools/uboot-tools.mk
@@ -4,7 +4,7 @@
 #
 ################################################################################
 
-UBOOT_TOOLS_VERSION = 2017.07
+UBOOT_TOOLS_VERSION = 2017.09
 UBOOT_TOOLS_SOURCE = u-boot-$(UBOOT_TOOLS_VERSION).tar.bz2
 UBOOT_TOOLS_SITE = ftp://ftp.denx.de/pub/u-boot
 UBOOT_TOOLS_LICENSE = GPL-2.0+
@@ -35,7 +35,7 @@ define UBOOT_TOOLS_BUILD_CMDS
 	$(TARGET_MAKE_ENV) $(MAKE) -C $(@D) $(UBOOT_TOOLS_MAKE_OPTS) \
 		CROSS_BUILD_TOOLS=y tools-only
 	$(TARGET_MAKE_ENV) $(MAKE) -C $(@D) $(UBOOT_TOOLS_MAKE_OPTS) \
-		env no-dot-config-targets=env
+		envtools no-dot-config-targets=envtools
 endef
 
 ifeq ($(BR2_PACKAGE_UBOOT_TOOLS_MKIMAGE),y)
-- 
2.7.4

[Buildroot] [PATCH v2] uboot-tools: bump to version 2017.09

[Matthew Weber]

Fabio,

On Wed, Nov 1, 2017 at 1:53 PM, Fabio Estevam <fabio.estevam@nxp.com> wrote:

Would you mind testing this patchset against this bump?  I believe the
patches will need rework if this series is applied first.
https://patchwork.ozlabs.org/patch/833049/

Matt

[Buildroot] [PATCH v2] uboot-tools: bump to version 2017.09

[Fabio Estevam]

Hi Matthew,

On Wed, Nov 1, 2017 at 5:22 PM, Matthew Weber
<matthew.weber@rockwellcollins.com> wrote:
> Fabio,
>
> On Wed, Nov 1, 2017 at 1:53 PM, Fabio Estevam <fabio.estevam@nxp.com> wrote:
>
> Would you mind testing this patchset against this bump?  I believe the
> patches will need rework if this series is applied first.
> https://patchwork.ozlabs.org/patch/833049/

I applied your patch and u-boot tools still built fine.

[Buildroot] [PATCH v2] uboot-tools: bump to version 2017.09

[Jan Kundrát]

On st?eda 1. listopadu 2017 19:53:18 CET, Fabio Estevam wrote:
> The 'env' target has been renamed to 'envtools' so change it
> accordingly.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
> ---
> Changes since v1:
> - Take the 'env' target rename into account
>
>  package/uboot-tools/uboot-tools.hash | 2 +-
>  package/uboot-tools/uboot-tools.mk   | 4 ++--
>  2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/package/uboot-tools/uboot-tools.hash 
> b/package/uboot-tools/uboot-tools.hash
> index 3ba8e34..82efc79 100644
> --- a/package/uboot-tools/uboot-tools.hash
> +++ b/package/uboot-tools/uboot-tools.hash
> @@ -1,2 +1,2 @@
>  # Locally computed:
> -sha256  
> 5374bfdc8acb9a38c025371b1ff20f45e7533668e84e685d0df5d9e7c0e4feff 
>  u-boot-2017.07.tar.bz2
> +sha256  
> b2d15f2cf5f72e706025cde73d67247c6da8cd35f7e10891eefe7d9095089744 
>  u-boot-2017.09.tar.bz2
> diff --git a/package/uboot-tools/uboot-tools.mk 
> b/package/uboot-tools/uboot-tools.mk
> index 4f39f4a..c936575 100644
> --- a/package/uboot-tools/uboot-tools.mk
> +++ b/package/uboot-tools/uboot-tools.mk
> @@ -4,7 +4,7 @@
>  #
>  
> ################################################################################
>  
> -UBOOT_TOOLS_VERSION = 2017.07
> +UBOOT_TOOLS_VERSION = 2017.09
>  UBOOT_TOOLS_SOURCE = u-boot-$(UBOOT_TOOLS_VERSION).tar.bz2
>  UBOOT_TOOLS_SITE = ftp://ftp.denx.de/pub/u-boot
>  UBOOT_TOOLS_LICENSE = GPL-2.0+
> @@ -35,7 +35,7 @@ define UBOOT_TOOLS_BUILD_CMDS
>  	$(TARGET_MAKE_ENV) $(MAKE) -C $(@D) $(UBOOT_TOOLS_MAKE_OPTS) \
>  		CROSS_BUILD_TOOLS=y tools-only
>  	$(TARGET_MAKE_ENV) $(MAKE) -C $(@D) $(UBOOT_TOOLS_MAKE_OPTS) \
> -		env no-dot-config-targets=env
> +		envtools no-dot-config-targets=envtools
>  endef
>  
>  ifeq ($(BR2_PACKAGE_UBOOT_TOOLS_MKIMAGE),y)

Thanks, this is similar to a local hack that I've been using. The build 
produces what I am expecting in the target image.

Tested-by: Jan Kundr?t <jan.kundrat@cesnet.cz>
Reviewed-by: Jan Kundr?t <jan.kundrat@cesnet.cz>

[Buildroot] [PATCH v2] uboot-tools: bump to version 2017.09

[Thomas Petazzoni]

Hello,

On Wed, 1 Nov 2017 16:53:18 -0200, Fabio Estevam wrote:
> The 'env' target has been renamed to 'envtools' so change it
> accordingly.
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
> ---
> Changes since v1:
> - Take the 'env' target rename into account

Applied to master, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[Buildroot] [PATCH v2] uboot-tools: bump to version 2017.09

[Thomas Petazzoni]

Hello,

On Wed, 1 Nov 2017 16:53:18 -0200, Fabio Estevam wrote:
> The 'env' target has been renamed to 'envtools' so change it
> accordingly.
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
> ---
> Changes since v1:
> - Take the 'env' target rename into account

I'm not sure if it's this version bump, or Matthew Weber's patch about
pylibfdt, but we're seeing new build failures with host-uboot-tools:

  http://autobuild.buildroot.net/?reason=host-uboot-tools-2017.09

Could one of you have a look?

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[Buildroot] [PATCH v2] uboot-tools: bump to version 2017.09

[Matthew Weber]

Thomas, Fabio

On Fri, Nov 3, 2017 at 7:50 AM, Thomas Petazzoni
<thomas.petazzoni@free-electrons.com> wrote:
>
> Hello,
>
> On Wed, 1 Nov 2017 16:53:18 -0200, Fabio Estevam wrote:
> > The 'env' target has been renamed to 'envtools' so change it
> > accordingly.
> >
> > Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
> > ---
> > Changes since v1:
> > - Take the 'env' target rename into account
>
> I'm not sure if it's this version bump, or Matthew Weber's patch about
> pylibfdt, but we're seeing new build failures with host-uboot-tools:
>
>   http://autobuild.buildroot.net/?reason=host-uboot-tools-2017.09
>
> Could one of you have a look?
>

Sure

[Buildroot] [PATCH v2] uboot-tools: bump to version 2017.09

[Jan Kundrát]

On p?tek 3. listopadu 2017 13:50:56 CET, Thomas Petazzoni wrote:
> I'm not sure if it's this version bump, or Matthew Weber's patch about
> pylibfdt, but we're seeing new build failures with host-uboot-tools:
>
>   http://autobuild.buildroot.net/?reason=host-uboot-tools-2017.09
>
> Could one of you have a look?

Hi,
I believe that this is caused by a change to host-dtc in commit 
b8c3e941731ddfc3728045142aa9081adeeeaee2. Since this commit, host-dtc has 
started installing its own libfdt into host/include/libfdt*. U-Boot uses 
#include directives in form of <system/ones>, not "user/ones", so it finds 
a copy of libfdt provided by dtc, not its own modified version. I sent a 
quick and dirty patch which fixes this earlier today:

http://lists.busybox.net/pipermail/buildroot/2017-November/206092.html

With kind regards,
Jan

[Buildroot] [PATCH v2] uboot-tools: bump to version 2017.09

[Matthew Weber]

Jan,

On Fri, Nov 3, 2017 at 8:15 AM, Jan Kundr?t <jan.kundrat@cesnet.cz> wrote:
> On p?tek 3. listopadu 2017 13:50:56 CET, Thomas Petazzoni wrote:
>>
>> I'm not sure if it's this version bump, or Matthew Weber's patch about
>> pylibfdt, but we're seeing new build failures with host-uboot-tools:
>>
>>   http://autobuild.buildroot.net/?reason=host-uboot-tools-2017.09
>>
>> Could one of you have a look?
>
>
> Hi,
> I believe that this is caused by a change to host-dtc in commit
> b8c3e941731ddfc3728045142aa9081adeeeaee2. Since this commit, host-dtc has
> started installing its own libfdt into host/include/libfdt*. U-Boot uses
> #include directives in form of <system/ones>, not "user/ones", so it finds a
> copy of libfdt provided by dtc, not its own modified version. I sent a quick
> and dirty patch which fixes this earlier today:
>
> http://lists.busybox.net/pipermail/buildroot/2017-November/206092.html
>

Tested that patch and it resolves a rebuild without error on my end.
Agree, unsure how we'd want to fix that one, upstream is a mess right
now with anything tool/*fdt related...

Matt

[Buildroot] [PATCH v2] uboot-tools: bump to version 2017.09

[Guo Ren]

Hi Jan,

On Fri, Nov 03, 2017 at 02:15:18PM +0100, Jan Kundr?t wrote:
> On p?tek 3. listopadu 2017 13:50:56 CET, Thomas Petazzoni wrote:
> >I'm not sure if it's this version bump, or Matthew Weber's patch about
> >pylibfdt, but we're seeing new build failures with host-uboot-tools:
> >
> >  http://autobuild.buildroot.net/?reason=host-uboot-tools-2017.09
> >
> >Could one of you have a look?
> 
> Hi,
> I believe that this is caused by a change to host-dtc in commit
> b8c3e941731ddfc3728045142aa9081adeeeaee2. Since this commit, host-dtc has
> started installing its own libfdt into host/include/libfdt*. U-Boot uses
> #include directives in form of <system/ones>, not "user/ones", so it finds a
> copy of libfdt provided by dtc, not its own modified version. I sent a quick
> and dirty patch which fixes this earlier today:
> 
> http://lists.busybox.net/pipermail/buildroot/2017-November/206092.html

Tested your patch on my machine and I could build host-uboot-tools and
host-qemu together without error.

Best Regards
 Guo Ren

[Buildroot] [PATCH v2] uboot-tools: bump to version 2017.09

[Matthew Weber]

Jan,

On Fri, Nov 3, 2017 at 8:15 AM, Jan Kundr?t <jan.kundrat@cesnet.cz> wrote:
> On p?tek 3. listopadu 2017 13:50:56 CET, Thomas Petazzoni wrote:
>>
>> I'm not sure if it's this version bump, or Matthew Weber's patch about
>> pylibfdt, but we're seeing new build failures with host-uboot-tools:
>>
>>   http://autobuild.buildroot.net/?reason=host-uboot-tools-2017.09
>>
>> Could one of you have a look?
>
>
> Hi,
> I believe that this is caused by a change to host-dtc in commit
> b8c3e941731ddfc3728045142aa9081adeeeaee2. Since this commit, host-dtc has
> started installing its own libfdt into host/include/libfdt*. U-Boot uses
> #include directives in form of <system/ones>, not "user/ones", so it finds a
> copy of libfdt provided by dtc, not its own modified version. I sent a quick
> and dirty patch which fixes this earlier today:
>
> http://lists.busybox.net/pipermail/buildroot/2017-November/206092.html
>

Based on Jan's submission and Arnout's feedback

https://patchwork.ozlabs.org/patch/834861/
https://patchwork.ozlabs.org/patch/834862/

Matt