* SoC/Codecs/SGTL5000 - Non working MIC_BIAS Voltage settings
@ 2015-06-12 16:13 gianluca
2015-06-17 7:20 ` gianluca
2015-09-30 19:32 ` Applied "ASoC: sgtl5000: fix wrong register MIC_BIAS_VOLTAGE setup on probe" to the asoc tree Mark Brown
0 siblings, 2 replies; 6+ messages in thread
From: gianluca @ 2015-06-12 16:13 UTC (permalink / raw)
To: Zeng Zhaoming; +Cc: Fabio.Estevam, alsa-devel
[-- Attachment #1: Type: text/plain, Size: 352 bytes --]
Hello,
in attachment there is a small patch to ensure the correct register
value for MIC BIAS Voltage.
Best regards
--
Eurek s.r.l. |
Electronic Engineering | http://www.eurek.it
via Celletta 8/B, 40026 Imola, Italy | Phone: +39-(0)542-609120
p.iva 00690621206 - c.f. 04020030377 | Fax: +39-(0)542-609212
[-- Attachment #2: sgtl5000.patch --]
[-- Type: text/x-patch, Size: 600 bytes --]
diff -Nru linux-4.0.5.orig/sound/soc/codecs/sgtl5000.c linux-4.0.5/sound/soc/codecs/sgtl5000.c
--- linux-4.0.5.orig/sound/soc/codecs/sgtl5000.c 2015-06-06 17:21:22.000000000 +0200
+++ linux-4.0.5/sound/soc/codecs/sgtl5000.c 2015-06-12 18:09:38.363381087 +0200
@@ -1339,8 +1339,8 @@
sgtl5000->micbias_resistor << SGTL5000_BIAS_R_SHIFT);
snd_soc_update_bits(codec, SGTL5000_CHIP_MIC_CTRL,
- SGTL5000_BIAS_R_MASK,
- sgtl5000->micbias_voltage << SGTL5000_BIAS_R_SHIFT);
+ SGTL5000_BIAS_VOLT_MASK,
+ sgtl5000->micbias_voltage << SGTL5000_BIAS_VOLT_SHIFT);
/*
* disable DAP
* TODO:
[-- Attachment #3: Type: text/plain, Size: 0 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: SoC/Codecs/SGTL5000 - Non working MIC_BIAS Voltage settings
2015-06-12 16:13 SoC/Codecs/SGTL5000 - Non working MIC_BIAS Voltage settings gianluca
@ 2015-06-17 7:20 ` gianluca
2015-06-17 7:32 ` Michael Trimarchi
2015-06-17 13:00 ` Fabio Estevam
2015-09-30 19:32 ` Applied "ASoC: sgtl5000: fix wrong register MIC_BIAS_VOLTAGE setup on probe" to the asoc tree Mark Brown
1 sibling, 2 replies; 6+ messages in thread
From: gianluca @ 2015-06-17 7:20 UTC (permalink / raw)
To: alsa-devel; +Cc: Fabio.Estevam, Zeng Zhaoming
Hello,
I didn't receive any feedback about this posting...
On 06/12/2015 06:13 PM, gianluca wrote:
> Hello,
> in attachment there is a small patch to ensure the correct register
> value for MIC BIAS Voltage.
diff -Nru linux-4.0.5.orig/sound/soc/codecs/sgtl5000.c
linux-4.0.5/sound/soc/codecs/sgtl5000.c
--- linux-4.0.5.orig/sound/soc/codecs/sgtl5000.c 2015-06-06
17:21:22.000000000 +0200
+++ linux-4.0.5/sound/soc/codecs/sgtl5000.c 2015-06-12
18:09:38.363381087 +0200
@@ -1339,8 +1339,8 @@
sgtl5000->micbias_resistor << SGTL5000_BIAS_R_SHIFT);
snd_soc_update_bits(codec, SGTL5000_CHIP_MIC_CTRL,
- SGTL5000_BIAS_R_MASK,
- sgtl5000->micbias_voltage << SGTL5000_BIAS_R_SHIFT);
+ SGTL5000_BIAS_VOLT_MASK,
+ sgtl5000->micbias_voltage << SGTL5000_BIAS_VOLT_SHIFT);
/*
* disable DAP
* TODO:
--
Eurek s.r.l. |
Electronic Engineering | http://www.eurek.it
via Celletta 8/B, 40026 Imola, Italy | Phone: +39-(0)542-609120
p.iva 00690621206 - c.f. 04020030377 | Fax: +39-(0)542-609212
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: SoC/Codecs/SGTL5000 - Non working MIC_BIAS Voltage settings
2015-06-17 7:20 ` gianluca
@ 2015-06-17 7:32 ` Michael Trimarchi
2015-06-17 13:00 ` Fabio Estevam
1 sibling, 0 replies; 6+ messages in thread
From: Michael Trimarchi @ 2015-06-17 7:32 UTC (permalink / raw)
To: gianluca; +Cc: Fabio.Estevam, alsa-devel, Zeng Zhaoming
Hi Gianluca
On Wed, Jun 17, 2015 at 8:20 AM, gianluca
<gianlucarenzi@eurekelettronica.it> wrote:
> Hello,
> I didn't receive any feedback about this posting...
>
> On 06/12/2015 06:13 PM, gianluca wrote:
>>
>> Hello,
>> in attachment there is a small patch to ensure the correct register
>> value for MIC BIAS Voltage.
>
>
> diff -Nru linux-4.0.5.orig/sound/soc/codecs/sgtl5000.c
> linux-4.0.5/sound/soc/codecs/sgtl5000.c
> --- linux-4.0.5.orig/sound/soc/codecs/sgtl5000.c 2015-06-06
> 17:21:22.000000000 +0200
> +++ linux-4.0.5/sound/soc/codecs/sgtl5000.c 2015-06-12
> 18:09:38.363381087 +0200
> @@ -1339,8 +1339,8 @@
> sgtl5000->micbias_resistor <<
> SGTL5000_BIAS_R_SHIFT);
>
> snd_soc_update_bits(codec, SGTL5000_CHIP_MIC_CTRL,
> - SGTL5000_BIAS_R_MASK,
> - sgtl5000->micbias_voltage << SGTL5000_BIAS_R_SHIFT);
> + SGTL5000_BIAS_VOLT_MASK,
> + sgtl5000->micbias_voltage <<
> SGTL5000_BIAS_VOLT_SHIFT);
> /*
According to what I see look fine. Fabio will comment on it. You
should adjust the subject like:
ASoC: sgtl5000: <description here>
Michael
> * disable DAP
> * TODO:
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: SoC/Codecs/SGTL5000 - Non working MIC_BIAS Voltage settings
2015-06-17 7:20 ` gianluca
2015-06-17 7:32 ` Michael Trimarchi
@ 2015-06-17 13:00 ` Fabio Estevam
2015-06-17 14:08 ` Michael Trimarchi
1 sibling, 1 reply; 6+ messages in thread
From: Fabio Estevam @ 2015-06-17 13:00 UTC (permalink / raw)
To: gianluca; +Cc: Fabio.Estevam, alsa-devel, Zeng Zhaoming
Hi Gianluca,
On Wed, Jun 17, 2015 at 4:20 AM, gianluca
<gianlucarenzi@eurekelettronica.it> wrote:
> Hello,
> I didn't receive any feedback about this posting...
Thanks for your patch.
Please don't post patches as attachments. Better send them with 'git
send-email'.
Documentation/SubmittingPatches has the information you need.
You also need to provide a commit log, proper Subject and your Signed-off-by.
Then Cc the maintainer: ./scripts/get_maintainer.pl <yourpatch> can
help you listing the appropriate folks.
Regards,
Fabio Estevam
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: SoC/Codecs/SGTL5000 - Non working MIC_BIAS Voltage settings
2015-06-17 13:00 ` Fabio Estevam
@ 2015-06-17 14:08 ` Michael Trimarchi
0 siblings, 0 replies; 6+ messages in thread
From: Michael Trimarchi @ 2015-06-17 14:08 UTC (permalink / raw)
To: Fabio Estevam; +Cc: Fabio.Estevam, alsa-devel, gianluca, Zeng Zhaoming
Hi
On Jun 17, 2015 3:03 PM, "Fabio Estevam" <festevam@gmail.com> wrote:
>
> Hi Gianluca,
>
> On Wed, Jun 17, 2015 at 4:20 AM, gianluca
> <gianlucarenzi@eurekelettronica.it> wrote:
> > Hello,
> > I didn't receive any feedback about this posting...
>
> Thanks for your patch.
>
> Please don't post patches as attachments. Better send them with 'git
> send-email'.
> Documentation/SubmittingPatches has the information you need.
>
> You also need to provide a commit log, proper Subject and your
Signed-off-by.
>
> Then Cc the maintainer: ./scripts/get_maintainer.pl <yourpatch> can
> help you listing the appropriate folks.
>
Already inform him about rule ;)
He should send up a new one
Michael
> Regards,
>
> Fabio Estevam
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@alsa-project.org
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Applied "ASoC: sgtl5000: fix wrong register MIC_BIAS_VOLTAGE setup on probe" to the asoc tree
2015-06-12 16:13 SoC/Codecs/SGTL5000 - Non working MIC_BIAS Voltage settings gianluca
2015-06-17 7:20 ` gianluca
@ 2015-09-30 19:32 ` Mark Brown
1 sibling, 0 replies; 6+ messages in thread
From: Mark Brown @ 2015-09-30 19:32 UTC (permalink / raw)
To: Gianluca Renzi, Mark Brown, stable; +Cc: alsa-devel
The patch
ASoC: sgtl5000: fix wrong register MIC_BIAS_VOLTAGE setup on probe
has been applied to the asoc tree at
git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
>From e256da84a04ea31c3c215997c847609af224e8f4 Mon Sep 17 00:00:00 2001
From: Gianluca Renzi <gianlucarenzi@eurekelettronica.it>
Date: Fri, 25 Sep 2015 21:33:41 +0200
Subject: [PATCH] ASoC: sgtl5000: fix wrong register MIC_BIAS_VOLTAGE setup on
probe
Signed-off-by: Gianluca Renzi <gianlucarenzi@eurekelettronica.it>
Signed-off-by: Mark Brown <broonie@kernel.org>
Cc: stable@vger.kernel.org
---
sound/soc/codecs/sgtl5000.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/sound/soc/codecs/sgtl5000.c b/sound/soc/codecs/sgtl5000.c
index 6e7843e..f540f82 100644
--- a/sound/soc/codecs/sgtl5000.c
+++ b/sound/soc/codecs/sgtl5000.c
@@ -1376,8 +1376,8 @@ static int sgtl5000_probe(struct snd_soc_codec *codec)
sgtl5000->micbias_resistor << SGTL5000_BIAS_R_SHIFT);
snd_soc_update_bits(codec, SGTL5000_CHIP_MIC_CTRL,
- SGTL5000_BIAS_R_MASK,
- sgtl5000->micbias_voltage << SGTL5000_BIAS_R_SHIFT);
+ SGTL5000_BIAS_VOLT_MASK,
+ sgtl5000->micbias_voltage << SGTL5000_BIAS_VOLT_SHIFT);
/*
* disable DAP
* TODO:
--
2.5.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
end of thread, other threads:[~2015-09-30 19:32 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-06-12 16:13 SoC/Codecs/SGTL5000 - Non working MIC_BIAS Voltage settings gianluca
2015-06-17 7:20 ` gianluca
2015-06-17 7:32 ` Michael Trimarchi
2015-06-17 13:00 ` Fabio Estevam
2015-06-17 14:08 ` Michael Trimarchi
2015-09-30 19:32 ` Applied "ASoC: sgtl5000: fix wrong register MIC_BIAS_VOLTAGE setup on probe" to the asoc tree Mark Brown
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.