All of lore.kernel.org
 help / color / mirror / Atom feed
From: Fabio Estevam <festevam@gmail.com>
To: Dong Aisheng <aisheng.dong@nxp.com>
Cc: Martin Kaiser <martin@kaiser.cx>, Shawn Guo <shawnguo@kernel.org>,
	Stefan Agner <stefan@agner.ch>,
	Sascha Hauer <kernel@pengutronix.de>,
	Linus Walleij <linus.walleij@linaro.org>,
	"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	Leonard Crestez <leonard.crestez@nxp.com>
Subject: Re: [PATCH] pinctrl: imx: make sure that maps are fully initialized
Date: Mon, 12 Nov 2018 13:09:26 -0200	[thread overview]
Message-ID: <CAOMZO5DbuuVr7JVpK+DCsE4G=tksTg6CRrCGwyaNO55WDuyRzw@mail.gmail.com> (raw)
In-Reply-To: <AM0PR04MB4211FE365D78EDEB0003D74380C10@AM0PR04MB4211.eurprd04.prod.outlook.com>

Hi Dong,

On Mon, Nov 12, 2018 at 1:04 PM A.s. Dong <aisheng.dong@nxp.com> wrote:

> Thanks for reporting this issue.
> The original code intended to save 3 common lines for both SCU and MMIO pads,
> but it did change the code logic a bit which resulted in a regression specificly
> for NO_PAD_CTL cases used on a few legacy boards. (NO_PAD_CTL is deprecated
> for new boards dts).

Just a clarification: NO_PAD_CTL is not deprecated.

It is not recommended for new dts as we should not rely on the
bootloader pinctrl settings.

> As you both had a patch, i'm not sure who i'm going to expect for a updated one,
> so I would send it my own with both of your tags.

Yes, please send a patch putting a Reported-by tag from Martin and a
Suggested-by tag from Leonard.

Thanks

      reply	other threads:[~2018-11-12 15:09 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-10 17:37 [PATCH] pinctrl: imx: make sure that maps are fully initialized Martin Kaiser
2018-11-10 17:49 ` Fabio Estevam
2018-11-11 22:37 ` Leonard Crestez
2018-11-12 15:37   ` Martin Kaiser
2018-11-12 15:04 ` A.s. Dong
2018-11-12 15:09   ` Fabio Estevam [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAOMZO5DbuuVr7JVpK+DCsE4G=tksTg6CRrCGwyaNO55WDuyRzw@mail.gmail.com' \
    --to=festevam@gmail.com \
    --cc=aisheng.dong@nxp.com \
    --cc=kernel@pengutronix.de \
    --cc=leonard.crestez@nxp.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=martin@kaiser.cx \
    --cc=shawnguo@kernel.org \
    --cc=stefan@agner.ch \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.