[PATCH] tty: serial: fsl_lpuart: fix the wrong mapbase value

[PATCH] tty: serial: fsl_lpuart: fix the wrong mapbase value

[Sherry Sun]

From: Andy Duan <fugang.duan@nxp.com>

Register offset needs to be applied on mapbase also.
dma_tx/rx_request use the physical address of UARTDATA.
Register offset is currently only applied to membase (the
corresponding virtual addr) but not on mapbase.

Reviewed-by: Leonard Crestez <leonard.crestez@nxp.com>
Acked-by: Fugang Duan <fugang.duan@nxp.com>
Signed-off-by: Adriana Reus <adriana.reus@nxp.com>
Signed-off-by: Sherry Sun <sherry.sun@nxp.com>
---
 drivers/tty/serial/fsl_lpuart.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/tty/serial/fsl_lpuart.c b/drivers/tty/serial/fsl_lpuart.c
index f0e5da77ed6d..460e428b7592 100644
--- a/drivers/tty/serial/fsl_lpuart.c
+++ b/drivers/tty/serial/fsl_lpuart.c
@@ -2611,7 +2611,7 @@ static int lpuart_probe(struct platform_device *pdev)
 		return PTR_ERR(sport->port.membase);
 
 	sport->port.membase += sdata->reg_off;
-	sport->port.mapbase = res->start;
+	sport->port.mapbase = res->start + sdata->reg_off;
 	sport->port.dev = &pdev->dev;
 	sport->port.type = PORT_LPUART;
 	sport->devtype = sdata->devtype;
-- 
2.17.1

Re: [PATCH] tty: serial: fsl_lpuart: fix the wrong mapbase value

[Greg KH]

On Tue, Aug 17, 2021 at 02:30:58PM +0800, Sherry Sun wrote:
> From: Andy Duan <fugang.duan@nxp.com>
> 
> Register offset needs to be applied on mapbase also.
> dma_tx/rx_request use the physical address of UARTDATA.
> Register offset is currently only applied to membase (the
> corresponding virtual addr) but not on mapbase.
> 
> Reviewed-by: Leonard Crestez <leonard.crestez@nxp.com>
> Acked-by: Fugang Duan <fugang.duan@nxp.com>
> Signed-off-by: Adriana Reus <adriana.reus@nxp.com>
> Signed-off-by: Sherry Sun <sherry.sun@nxp.com>
> ---

Why is there no signed-off-by from the author?

Please fix up.

thanks,

greg k-h

RE: [PATCH] tty: serial: fsl_lpuart: fix the wrong mapbase value

[Sherry Sun]

Hi Greg,

> -----Original Message-----
> From: Greg KH <gregkh@linuxfoundation.org>
> Sent: 2021年8月18日 22:05
> To: Sherry Sun <sherry.sun@nxp.com>
> Cc: jirislaby@kernel.org; linux-serial@vger.kernel.org; linux-
> kernel@vger.kernel.org; dl-linux-imx <linux-imx@nxp.com>
> Subject: Re: [PATCH] tty: serial: fsl_lpuart: fix the wrong mapbase value
> 
> On Tue, Aug 17, 2021 at 02:30:58PM +0800, Sherry Sun wrote:
> > From: Andy Duan <fugang.duan@nxp.com>
> >
> > Register offset needs to be applied on mapbase also.
> > dma_tx/rx_request use the physical address of UARTDATA.
> > Register offset is currently only applied to membase (the
> > corresponding virtual addr) but not on mapbase.
> >
> > Reviewed-by: Leonard Crestez <leonard.crestez@nxp.com>
> > Acked-by: Fugang Duan <fugang.duan@nxp.com>
> > Signed-off-by: Adriana Reus <adriana.reus@nxp.com>
> > Signed-off-by: Sherry Sun <sherry.sun@nxp.com>
> > ---
> 
> Why is there no signed-off-by from the author?
> 
> Please fix up.

Sure, will add it in V2, thanks!

> 
> thanks,
> 
> greg k-h

Re: [PATCH] tty: serial: fsl_lpuart: fix the wrong mapbase value

[Fabio Estevam]

Hi Sherry,

On Tue, Aug 17, 2021 at 3:32 AM Sherry Sun <sherry.sun@nxp.com> wrote:
>
> From: Andy Duan <fugang.duan@nxp.com>
>
> Register offset needs to be applied on mapbase also.
> dma_tx/rx_request use the physical address of UARTDATA.
> Register offset is currently only applied to membase (the
> corresponding virtual addr) but not on mapbase.
>
> Reviewed-by: Leonard Crestez <leonard.crestez@nxp.com>
> Acked-by: Fugang Duan <fugang.duan@nxp.com>
> Signed-off-by: Adriana Reus <adriana.reus@nxp.com>
> Signed-off-by: Sherry Sun <sherry.sun@nxp.com>

You probably should add a Fixes tag.

RE: [PATCH] tty: serial: fsl_lpuart: fix the wrong mapbase value

[Sherry Sun]

Hi Fabio,

> -----Original Message-----
> From: Fabio Estevam <festevam@gmail.com>
> Sent: 2021年8月19日 9:55
> To: Sherry Sun <sherry.sun@nxp.com>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>; Jiri Slaby
> <jirislaby@kernel.org>; linux-serial@vger.kernel.org; linux-kernel <linux-
> kernel@vger.kernel.org>; dl-linux-imx <linux-imx@nxp.com>
> Subject: Re: [PATCH] tty: serial: fsl_lpuart: fix the wrong mapbase value
> 
> Hi Sherry,
> 
> On Tue, Aug 17, 2021 at 3:32 AM Sherry Sun <sherry.sun@nxp.com> wrote:
> >
> > From: Andy Duan <fugang.duan@nxp.com>
> >
> > Register offset needs to be applied on mapbase also.
> > dma_tx/rx_request use the physical address of UARTDATA.
> > Register offset is currently only applied to membase (the
> > corresponding virtual addr) but not on mapbase.
> >
> > Reviewed-by: Leonard Crestez <leonard.crestez@nxp.com>
> > Acked-by: Fugang Duan <fugang.duan@nxp.com>
> > Signed-off-by: Adriana Reus <adriana.reus@nxp.com>
> > Signed-off-by: Sherry Sun <sherry.sun@nxp.com>
> 
> You probably should add a Fixes tag.

That's reasonable, I will add it. Thanks!

Best regards
Sherry