* [PATCH 0/5] use setup_timer() helper function.
@ 2017-09-22 10:58 Allen Pais
2017-09-22 10:58 ` [PATCH 1/5] net: nfc: hci: use setup_timer() helper Allen Pais
` (5 more replies)
0 siblings, 6 replies; 11+ messages in thread
From: Allen Pais @ 2017-09-22 10:58 UTC (permalink / raw)
To: netdev; +Cc: davem, sameo, Allen Pais
This series uses setup_timer() helper function. The series
addresses the files under net/*.
Allen Pais (5):
net: nfc: hci: use setup_timer() helper.
net: nfc: hci: llc_shdlc: use setup_timer() helper.
net: af_packet: use setup_timer() helper.
net: nfc: core: use setup_timer() helper.
net: nfc: llcp_core: use setup_timer() helper.
net/nfc/core.c | 5 ++---
net/nfc/hci/core.c | 5 ++---
net/nfc/hci/llc_shdlc.c | 15 ++++++---------
net/nfc/llcp_core.c | 10 ++++------
net/packet/af_packet.c | 4 +---
5 files changed, 15 insertions(+), 24 deletions(-)
--
2.7.4
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH 1/5] net: nfc: hci: use setup_timer() helper.
2017-09-22 10:58 [PATCH 0/5] use setup_timer() helper function Allen Pais
@ 2017-09-22 10:58 ` Allen Pais
2017-09-22 10:58 ` [PATCH 2/5] net: nfc: hci: llc_shdlc: " Allen Pais
` (4 subsequent siblings)
5 siblings, 0 replies; 11+ messages in thread
From: Allen Pais @ 2017-09-22 10:58 UTC (permalink / raw)
To: netdev; +Cc: davem, sameo, Allen Pais
Use setup_timer function instead of initializing timer with the
function and data fields.
Signed-off-by: Allen Pais <allen.lkml@gmail.com>
---
net/nfc/hci/core.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/net/nfc/hci/core.c b/net/nfc/hci/core.c
index b740fef..a8a6e78 100644
--- a/net/nfc/hci/core.c
+++ b/net/nfc/hci/core.c
@@ -1004,9 +1004,8 @@ int nfc_hci_register_device(struct nfc_hci_dev *hdev)
INIT_WORK(&hdev->msg_tx_work, nfc_hci_msg_tx_work);
- init_timer(&hdev->cmd_timer);
- hdev->cmd_timer.data = (unsigned long)hdev;
- hdev->cmd_timer.function = nfc_hci_cmd_timeout;
+ setup_timer(&hdev->cmd_timer, nfc_hci_cmd_timeout,
+ (unsigned long)hdev);
skb_queue_head_init(&hdev->rx_hcp_frags);
--
2.7.4
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH 2/5] net: nfc: hci: llc_shdlc: use setup_timer() helper.
2017-09-22 10:58 [PATCH 0/5] use setup_timer() helper function Allen Pais
2017-09-22 10:58 ` [PATCH 1/5] net: nfc: hci: use setup_timer() helper Allen Pais
@ 2017-09-22 10:58 ` Allen Pais
2017-09-22 10:58 ` [PATCH 3/5] net: af_packet: " Allen Pais
` (3 subsequent siblings)
5 siblings, 0 replies; 11+ messages in thread
From: Allen Pais @ 2017-09-22 10:58 UTC (permalink / raw)
To: netdev; +Cc: davem, sameo, Allen Pais
Use setup_timer function instead of initializing timer with the
function and data fields.
Signed-off-by: Allen Pais <allen.lkml@gmail.com>
---
net/nfc/hci/llc_shdlc.c | 15 ++++++---------
1 file changed, 6 insertions(+), 9 deletions(-)
diff --git a/net/nfc/hci/llc_shdlc.c b/net/nfc/hci/llc_shdlc.c
index 17e59a0..58df37e 100644
--- a/net/nfc/hci/llc_shdlc.c
+++ b/net/nfc/hci/llc_shdlc.c
@@ -763,17 +763,14 @@ static void *llc_shdlc_init(struct nfc_hci_dev *hdev, xmit_to_drv_t xmit_to_drv,
mutex_init(&shdlc->state_mutex);
shdlc->state = SHDLC_DISCONNECTED;
- init_timer(&shdlc->connect_timer);
- shdlc->connect_timer.data = (unsigned long)shdlc;
- shdlc->connect_timer.function = llc_shdlc_connect_timeout;
+ setup_timer(&shdlc->connect_timer, llc_shdlc_connect_timeout,
+ (unsigned long)shdlc);
- init_timer(&shdlc->t1_timer);
- shdlc->t1_timer.data = (unsigned long)shdlc;
- shdlc->t1_timer.function = llc_shdlc_t1_timeout;
+ setup_timer(&shdlc->t1_timer, llc_shdlc_t1_timeout,
+ (unsigned long)shdlc);
- init_timer(&shdlc->t2_timer);
- shdlc->t2_timer.data = (unsigned long)shdlc;
- shdlc->t2_timer.function = llc_shdlc_t2_timeout;
+ setup_timer(&shdlc->t2_timer, llc_shdlc_t2_timeout,
+ (unsigned long)shdlc);
shdlc->w = SHDLC_MAX_WINDOW;
shdlc->srej_support = SHDLC_SREJ_SUPPORT;
--
2.7.4
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH 3/5] net: af_packet: use setup_timer() helper.
2017-09-22 10:58 [PATCH 0/5] use setup_timer() helper function Allen Pais
2017-09-22 10:58 ` [PATCH 1/5] net: nfc: hci: use setup_timer() helper Allen Pais
2017-09-22 10:58 ` [PATCH 2/5] net: nfc: hci: llc_shdlc: " Allen Pais
@ 2017-09-22 10:58 ` Allen Pais
2017-09-22 10:58 ` [PATCH 4/5] net: nfc: core: " Allen Pais
` (2 subsequent siblings)
5 siblings, 0 replies; 11+ messages in thread
From: Allen Pais @ 2017-09-22 10:58 UTC (permalink / raw)
To: netdev; +Cc: davem, sameo, Allen Pais
Use setup_timer function instead of initializing timer with the
function and data fields.
Signed-off-by: Allen Pais <allen.lkml@gmail.com>
---
net/packet/af_packet.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/net/packet/af_packet.c b/net/packet/af_packet.c
index c261729..1d3e3ce 100644
--- a/net/packet/af_packet.c
+++ b/net/packet/af_packet.c
@@ -544,9 +544,7 @@ static void prb_init_blk_timer(struct packet_sock *po,
struct tpacket_kbdq_core *pkc,
void (*func) (unsigned long))
{
- init_timer(&pkc->retire_blk_timer);
- pkc->retire_blk_timer.data = (long)po;
- pkc->retire_blk_timer.function = func;
+ setup_timer(&pkc->retire_blk_timer, func, (long)po);
pkc->retire_blk_timer.expires = jiffies;
}
--
2.7.4
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH 4/5] net: nfc: core: use setup_timer() helper.
2017-09-22 10:58 [PATCH 0/5] use setup_timer() helper function Allen Pais
` (2 preceding siblings ...)
2017-09-22 10:58 ` [PATCH 3/5] net: af_packet: " Allen Pais
@ 2017-09-22 10:58 ` Allen Pais
2017-09-22 10:58 ` [PATCH 5/5] net: nfc: llcp_core: " Allen Pais
2017-09-23 1:22 ` [PATCH 0/5] use setup_timer() helper function David Miller
5 siblings, 0 replies; 11+ messages in thread
From: Allen Pais @ 2017-09-22 10:58 UTC (permalink / raw)
To: netdev; +Cc: davem, sameo, Allen Pais
Use setup_timer function instead of initializing timer with the
function and data fields.
Signed-off-by: Allen Pais <allen.lkml@gmail.com>
---
net/nfc/core.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/net/nfc/core.c b/net/nfc/core.c
index 5cf33df..e5e23c2 100644
--- a/net/nfc/core.c
+++ b/net/nfc/core.c
@@ -1094,9 +1094,8 @@ struct nfc_dev *nfc_allocate_device(struct nfc_ops *ops,
dev->targets_generation = 1;
if (ops->check_presence) {
- init_timer(&dev->check_pres_timer);
- dev->check_pres_timer.data = (unsigned long)dev;
- dev->check_pres_timer.function = nfc_check_pres_timeout;
+ setup_timer(&dev->check_pres_timer, nfc_check_pres_timeout,
+ (unsigned long)dev);
INIT_WORK(&dev->check_pres_work, nfc_check_pres_work);
}
--
2.7.4
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH 5/5] net: nfc: llcp_core: use setup_timer() helper.
2017-09-22 10:58 [PATCH 0/5] use setup_timer() helper function Allen Pais
` (3 preceding siblings ...)
2017-09-22 10:58 ` [PATCH 4/5] net: nfc: core: " Allen Pais
@ 2017-09-22 10:58 ` Allen Pais
2017-09-23 1:22 ` [PATCH 0/5] use setup_timer() helper function David Miller
5 siblings, 0 replies; 11+ messages in thread
From: Allen Pais @ 2017-09-22 10:58 UTC (permalink / raw)
To: netdev; +Cc: davem, sameo, Allen Pais
Use setup_timer function instead of initializing timer with the
function and data fields.
Signed-off-by: Allen Pais <allen.lkml@gmail.com>
---
net/nfc/llcp_core.c | 10 ++++------
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/net/nfc/llcp_core.c b/net/nfc/llcp_core.c
index 02eef5c..7988185 100644
--- a/net/nfc/llcp_core.c
+++ b/net/nfc/llcp_core.c
@@ -1573,9 +1573,8 @@ int nfc_llcp_register_device(struct nfc_dev *ndev)
INIT_LIST_HEAD(&local->list);
kref_init(&local->ref);
mutex_init(&local->sdp_lock);
- init_timer(&local->link_timer);
- local->link_timer.data = (unsigned long) local;
- local->link_timer.function = nfc_llcp_symm_timer;
+ setup_timer(&local->link_timer, nfc_llcp_symm_timer,
+ (unsigned long)local);
skb_queue_head_init(&local->tx_queue);
INIT_WORK(&local->tx_work, nfc_llcp_tx_work);
@@ -1601,9 +1600,8 @@ int nfc_llcp_register_device(struct nfc_dev *ndev)
mutex_init(&local->sdreq_lock);
INIT_HLIST_HEAD(&local->pending_sdreqs);
- init_timer(&local->sdreq_timer);
- local->sdreq_timer.data = (unsigned long) local;
- local->sdreq_timer.function = nfc_llcp_sdreq_timer;
+ setup_timer(&local->sdreq_timer, nfc_llcp_sdreq_timer,
+ (unsigned long)local);
INIT_WORK(&local->sdreq_timeout_work, nfc_llcp_sdreq_timeout_work);
list_add(&local->list, &llcp_devices);
--
2.7.4
^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [PATCH 0/5] use setup_timer() helper function.
2017-09-22 10:58 [PATCH 0/5] use setup_timer() helper function Allen Pais
` (4 preceding siblings ...)
2017-09-22 10:58 ` [PATCH 5/5] net: nfc: llcp_core: " Allen Pais
@ 2017-09-23 1:22 ` David Miller
2017-09-25 7:30 ` Allen
5 siblings, 1 reply; 11+ messages in thread
From: David Miller @ 2017-09-23 1:22 UTC (permalink / raw)
To: allen.lkml; +Cc: netdev, sameo
From: Allen Pais <allen.lkml@gmail.com>
Date: Fri, 22 Sep 2017 16:28:17 +0530
> This series uses setup_timer() helper function. The series
> addresses the files under net/*.
There was a recent change to the nfc code in net-next which causes
your patches to not apply.
Please repsin against net-next, thanks.
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 0/5] use setup_timer() helper function.
2017-09-23 1:22 ` [PATCH 0/5] use setup_timer() helper function David Miller
@ 2017-09-25 7:30 ` Allen
0 siblings, 0 replies; 11+ messages in thread
From: Allen @ 2017-09-25 7:30 UTC (permalink / raw)
To: David Miller; +Cc: netdev, sameo
>
> There was a recent change to the nfc code in net-next which causes
> your patches to not apply.
>
> Please repsin against net-next, thanks.
Sent out V2.
Thanks.
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH 0/5] use setup_timer() helper function.
@ 2017-09-22 11:16 Allen Pais
0 siblings, 0 replies; 11+ messages in thread
From: Allen Pais @ 2017-09-22 11:16 UTC (permalink / raw)
To: linux-kernel; +Cc: ed.cashin, Allen Pais
This series uses setup_timer() helper function. The series
addresses the files under drivers/block/*.
Allen Pais (5):
block: amiflop: use setup_timer() helper.
block: aoe: use setup_timer() helper.
block: aoe: use setup_timer() helper.
block: umem: use setup_timer() helper.
block: DAC960: use setup_timer() helper.
drivers/block/DAC960.c | 5 ++---
drivers/block/amiflop.c | 16 ++++------------
drivers/block/aoe/aoedev.c | 4 +---
drivers/block/aoe/aoemain.c | 4 +---
drivers/block/umem.c | 3 +--
5 files changed, 9 insertions(+), 23 deletions(-)
--
2.7.4
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH 0/5] use setup_timer() helper function.
@ 2017-09-22 10:08 ` Allen Pais
0 siblings, 0 replies; 11+ messages in thread
From: Allen Pais @ 2017-09-22 10:20 UTC (permalink / raw)
To: linux-scsi; +Cc: nab, target-devel, Allen Pais
This series uses setup_timer() helper function. The series
addresses the files under drivers/target/iscsi/*.
Allen Pais (5):
iscsi-target: use setup_timer() helper.
iscsi-target: use setup_timer() helper.
iscsi-target: use setup_timer() helper.
iscsi-target: use setup_timer() helper.
iscsi-target: use setup_timer() helper.
drivers/target/iscsi/iscsi_target_erl0.c | 5 ++---
drivers/target/iscsi/iscsi_target_erl1.c | 5 ++---
drivers/target/iscsi/iscsi_target_login.c | 5 ++---
drivers/target/iscsi/iscsi_target_nego.c | 5 ++---
drivers/target/iscsi/iscsi_target_util.c | 5 ++---
5 files changed, 10 insertions(+), 15 deletions(-)
--
2.7.4
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH 0/5] use setup_timer() helper function.
@ 2017-09-22 10:08 ` Allen Pais
0 siblings, 0 replies; 11+ messages in thread
From: Allen Pais @ 2017-09-22 10:08 UTC (permalink / raw)
To: linux-scsi; +Cc: nab, target-devel, Allen Pais
This series uses setup_timer() helper function. The series
addresses the files under drivers/target/iscsi/*.
Allen Pais (5):
iscsi-target: use setup_timer() helper.
iscsi-target: use setup_timer() helper.
iscsi-target: use setup_timer() helper.
iscsi-target: use setup_timer() helper.
iscsi-target: use setup_timer() helper.
drivers/target/iscsi/iscsi_target_erl0.c | 5 ++---
drivers/target/iscsi/iscsi_target_erl1.c | 5 ++---
drivers/target/iscsi/iscsi_target_login.c | 5 ++---
drivers/target/iscsi/iscsi_target_nego.c | 5 ++---
drivers/target/iscsi/iscsi_target_util.c | 5 ++---
5 files changed, 10 insertions(+), 15 deletions(-)
--
2.7.4
^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2017-09-25 7:30 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-09-22 10:58 [PATCH 0/5] use setup_timer() helper function Allen Pais
2017-09-22 10:58 ` [PATCH 1/5] net: nfc: hci: use setup_timer() helper Allen Pais
2017-09-22 10:58 ` [PATCH 2/5] net: nfc: hci: llc_shdlc: " Allen Pais
2017-09-22 10:58 ` [PATCH 3/5] net: af_packet: " Allen Pais
2017-09-22 10:58 ` [PATCH 4/5] net: nfc: core: " Allen Pais
2017-09-22 10:58 ` [PATCH 5/5] net: nfc: llcp_core: " Allen Pais
2017-09-23 1:22 ` [PATCH 0/5] use setup_timer() helper function David Miller
2017-09-25 7:30 ` Allen
-- strict thread matches above, loose matches on Subject: below --
2017-09-22 11:16 Allen Pais
2017-09-22 10:20 Allen Pais
2017-09-22 10:08 ` Allen Pais
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.