All of lore.kernel.org
 help / color / mirror / Atom feed
From: Laszlo Papp <lpapp@kde.org>
To: Mark Brown <broonie@kernel.org>
Cc: Lee Jones <lee.jones@linaro.org>,
	Linus Walleij <linus.walleij@linaro.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Krzysztof Kozlowski <k.kozlowski@samsung.com>,
	Sachin Kamat <sachin.kamat@linaro.org>,
	Jean Delvare <jdelvare@suse.de>,
	Guenter Roeck <linux@roeck-us.net>
Subject: Re: [PATCH v6] mfd: MAX6650/6651 support
Date: Fri, 14 Feb 2014 09:02:20 +0000	[thread overview]
Message-ID: <CAOMwXhNd69KMDcBLjfiw16T3bWWki-Dvxbz+zhgNe6OESnVaSw@mail.gmail.com> (raw)
In-Reply-To: <20140212175018.GJ28112@sirena.org.uk>

On Wed, Feb 12, 2014 at 5:50 PM, Mark Brown <broonie@kernel.org> wrote:
> On Wed, Feb 12, 2014 at 04:02:40AM +0000, Laszlo Papp wrote:
>
>> +const struct regmap_config max665x_regmap_config = {
>> +     .reg_bits = 5,
>> +};
>
> This would normally be static too, and I'd *really* expect to see a
> val_bits set here.  I'm a bit surprised this works without one.

Makes sense, thanks. Shall I also set the .max_register or any other
mandatory variables in here?

>> +     mutex_init(&max665x->iolock);
>
> What is this needed for?

It was done for consistency with the other mfd drivers (maxim), e.g.
8997 or 8998 as the closest resemblence in this family. Would you
prefer me removing this mutex locker?

  parent reply	other threads:[~2014-02-14  9:02 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-12  4:02 [PATCH v6] mfd: MAX6650/6651 support Laszlo Papp
2014-02-12  4:42 ` Sachin Kamat
2014-02-12  7:06   ` Laszlo Papp
2014-02-12  8:32     ` Lee Jones
2014-02-12  9:34       ` Laszlo Papp
2014-02-12 17:50 ` Mark Brown
2014-02-13  8:23   ` Lee Jones
2014-02-13  9:14     ` Laszlo Papp
2014-02-13 10:26       ` Mark Brown
2014-02-13 10:34       ` Laszlo Papp
2014-02-14  9:02   ` Laszlo Papp [this message]
2014-02-14 10:19     ` Lee Jones
2014-02-14 10:59       ` Laszlo Papp
2014-02-14 20:57     ` Mark Brown
2014-02-17  8:55       ` Laszlo Papp

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAOMwXhNd69KMDcBLjfiw16T3bWWki-Dvxbz+zhgNe6OESnVaSw@mail.gmail.com \
    --to=lpapp@kde.org \
    --cc=broonie@kernel.org \
    --cc=jdelvare@suse.de \
    --cc=k.kozlowski@samsung.com \
    --cc=lee.jones@linaro.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=sachin.kamat@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.