From: Laszlo Papp <lpapp@kde.org>
To: Lee Jones <lee.jones@linaro.org>
Cc: Mark Brown <broonie@kernel.org>,
Linus Walleij <linus.walleij@linaro.org>,
LKML <linux-kernel@vger.kernel.org>,
Krzysztof Kozlowski <k.kozlowski@samsung.com>,
Sachin Kamat <sachin.kamat@linaro.org>,
Jean Delvare <jdelvare@suse.de>,
Guenter Roeck <linux@roeck-us.net>
Subject: Re: [PATCH v6] mfd: MAX6650/6651 support
Date: Thu, 13 Feb 2014 10:34:31 +0000 [thread overview]
Message-ID: <CAOMwXhPtw-ZZZtTax_oK6kwDMbC0e8BetVH1vvo8+8O53pbeGw@mail.gmail.com> (raw)
In-Reply-To: <CAOMwXhPsQPvPn+kmBXyGq3WqsGhxTR2w1YjTzNbTyrEyxVHWxQ@mail.gmail.com>
On Thu, Feb 13, 2014 at 9:14 AM, Laszlo Papp <lpapp@kde.org> wrote:
> On Thu, Feb 13, 2014 at 8:23 AM, Lee Jones <lee.jones@linaro.org> wrote:
>> Laszlo,
>>
>>> > +const struct regmap_config max665x_regmap_config = {
>>> > + .reg_bits = 5,
>>> > +};
>>>
>>> This would normally be static too, and I'd *really* expect to see a
>>> val_bits set here. I'm a bit surprised this works without one.
>>
>> Mark (privately) mentioned to me that this patch can't possibly work
>> given the current Regmap configuration.
>
> Strange because I have tested the change, although not for days and
> weeks. What exactly cannot possible work?
Hmm, yes, as it seems, I have not actually tested the patch set
_after_ all the modifications. I deemed some of them trivial enough,
but apparently I was wrong. In this case, sending trivial updates will
slow down, but I guess that is the way to follow. Well, I apologize.
next prev parent reply other threads:[~2014-02-13 10:34 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-12 4:02 [PATCH v6] mfd: MAX6650/6651 support Laszlo Papp
2014-02-12 4:42 ` Sachin Kamat
2014-02-12 7:06 ` Laszlo Papp
2014-02-12 8:32 ` Lee Jones
2014-02-12 9:34 ` Laszlo Papp
2014-02-12 17:50 ` Mark Brown
2014-02-13 8:23 ` Lee Jones
2014-02-13 9:14 ` Laszlo Papp
2014-02-13 10:26 ` Mark Brown
2014-02-13 10:34 ` Laszlo Papp [this message]
2014-02-14 9:02 ` Laszlo Papp
2014-02-14 10:19 ` Lee Jones
2014-02-14 10:59 ` Laszlo Papp
2014-02-14 20:57 ` Mark Brown
2014-02-17 8:55 ` Laszlo Papp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAOMwXhPtw-ZZZtTax_oK6kwDMbC0e8BetVH1vvo8+8O53pbeGw@mail.gmail.com \
--to=lpapp@kde.org \
--cc=broonie@kernel.org \
--cc=jdelvare@suse.de \
--cc=k.kozlowski@samsung.com \
--cc=lee.jones@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=sachin.kamat@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.