From: Amir Goldstein <amir73il@gmail.com>
To: Jan Kara <jack@suse.cz>
Cc: Eric Paris <eparis@redhat.com>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>
Subject: Re: [RFC][PATCH 0/4] fsnotify: pass single mark to handle_event()
Date: Wed, 4 Jan 2017 12:45:41 +0200 [thread overview]
Message-ID: <CAOQ4uxj1UdNJuEOQYpFcAU9KrNFHjTdjhcJSZo1thu5EB6MKfg@mail.gmail.com> (raw)
In-Reply-To: <20170104103958.GN3780@quack2.suse.cz>
On Wed, Jan 4, 2017 at 12:39 PM, Jan Kara <jack@suse.cz> wrote:
> On Wed 04-01-17 11:57:04, Amir Goldstein wrote:
...
>> Yes, I am aware of those testcases.
>> I find LTP quite heavy to build, so I though I would spin a dedicated
>> testsuite that will contain your testcases, but will also include
>> infrastructure for stress testing and profiling.
>> Keeping track of performance regressions is clearly a major aspect
>> of maintaining fsnotify.
>
> Yeah, I don't build full LTP, just testcases in those two directories.
LTP seems to have this massive build system around it.
So just to give me a head start, do you use any custom build scripts
to build just those testcases? or simple make inside their directory
will do the trick (it didn't seem so simple from first look).
> The
> advantage of LTP is that quite a few people run it so you get a decent test
> coverage on different systems (and I've got reports from people running LTP
> about regressions in fsnotify code). So I'd prefer to have the functional
> tests in LTP if reasonably feasible.
Sure. That's makes a lot of sense.
> But with respect to performance
> testing or some crazy stress tests which take long to execute I can definitely
> see space for a dedicated test suite.
>
> Honza
> --
> Jan Kara <jack@suse.com>
> SUSE Labs, CR
next prev parent reply other threads:[~2017-01-04 10:45 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-27 19:32 [RFC][PATCH 0/4] fsnotify: pass single mark to handle_event() Amir Goldstein
2016-12-27 19:32 ` [RFC][PATCH 1/4] fsnotify: process inode/vfsmount marks independently Amir Goldstein
2016-12-27 19:32 ` [RFC][PATCH 2/4] fsnotify: helper to update marks ignored_mask Amir Goldstein
2016-12-27 19:32 ` [RFC][PATCH 3/4] fsnotify: return FSNOTIFY_DROPPED when handle_event() dropped event Amir Goldstein
2016-12-27 19:32 ` [RFC][PATCH 4/4] fsnotify: pass single mark to handle_event() Amir Goldstein
2017-01-04 8:28 ` [RFC][PATCH 0/4] " Jan Kara
2017-01-04 9:57 ` Amir Goldstein
2017-01-04 10:39 ` Jan Kara
2017-01-04 10:45 ` Amir Goldstein [this message]
2017-01-04 11:47 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAOQ4uxj1UdNJuEOQYpFcAU9KrNFHjTdjhcJSZo1thu5EB6MKfg@mail.gmail.com \
--to=amir73il@gmail.com \
--cc=eparis@redhat.com \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.